From nobody Mon May 25 05:12:55 2026 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4F37B3093D8 for ; Mon, 18 May 2026 12:50:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779108605; cv=none; b=Y8h39XQt/wp6/HWF3MRQFnHMi2m/v6jEzaTuw3UTFa2rMWvQQ/yJmbwNES8gx6POLwOyih3PG5U2JXgK9HfDYnKmuKxYC7SO9WnRpvHU3yf/NohK7DZFqpm3dhy6bAgW/D1dHDGGTj9wKbNCek3Of1DAELF5CQTEM7VG8qg/fIw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779108605; c=relaxed/simple; bh=hnhjwsGDmLy5hoDXIQt5+VDD6x50FSd8ahg1XH5JUCU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=E052SSSDTZycVbfdrqGmvC73UX6xR2IuD4L6gsUWf808uICgot/Ng6CUbR779sAsTUzS2ywbQfCJOH/0J5AMpNeF8XLskaXpcPR0r+vkPP64sdgIwgtYJ8v/yCM98vEYSH4+ZxyYdm0i4oUqjoEspaB/aUo2dy81eJyF9xWfOGc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hnvsPi1I; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hnvsPi1I" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-2bdeed4f717so4050985ad.0 for ; Mon, 18 May 2026 05:50:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779108604; x=1779713404; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=+kR1uWbklt4iMogl7XGhEDFycrnSG5eLMhDf2zVjKyM=; b=hnvsPi1IPhV154Z+jw1nQDRs+/UMlYhYvV1HU5y781I0d4cDwE/p80Qwowuvq8dSDX v+K9gka5/bGb1YJUTwkeDuseLiXtlLMuP+umTphX5gIIG88Q5osJkVC2ZKPt2m7Fwq4J mtFQbBxDeuuAwOzMbs3BF+5ARBn8Qlzqd8ze2ZQYs7vbuw36NLNtPoea5PBtRDX4ru68 QlEAmetKVpdswyzss7mQEMo6rryYk1M9CsKw42P4uyP54mUSDnf/0WsB1/rtn7bnvYWi KCpR0OHdhF0sum3uC3XMdojmjykK/3gpiOxQYCNFLkrqkcXnRbDh2+rkjT16Rbdu+83/ 1h1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779108604; x=1779713404; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+kR1uWbklt4iMogl7XGhEDFycrnSG5eLMhDf2zVjKyM=; b=cSbvqZj8BZQunOVvHqBmDhzv8NfdGx9qh07JRf3FzZ3eYD30Au/fdnre9zraDuNJI7 lBoa/DSp/k1HN6WcO8G7l2TBbRkAdUpQl+6St5eb0xdVGuK/Oj4h7HbVRMy3hqbpAar9 aPCNEHNmaxvSt0/edYd9zQb+2ilE9Xz+WnXL52vN5PE5G7hAs6chI3pHjqfreebt2YAF Ist4NbthaUb33tBaKju7oQF52s1rseUKewqf9KGBheHxZuUPtCraAK/bhZGgDcev4uKS u83I6LRiMqrnz8uO+a8Fq4C4tmD+5YFloK7EL7GTFMQwIsOuPH+KU6b/ZD5gEl7esNVa lyAQ== X-Forwarded-Encrypted: i=1; AFNElJ/osbq2Ufkiqe6XxwYqvxiR2FBFuZOdXoVXvXM+VSjQ/NOvTeXxpU4buFUFwz8uYG59f6+nkZZiIuAmgXo=@vger.kernel.org X-Gm-Message-State: AOJu0YynlGKHNYTCxIisFx2B6qgoINbh4qcHg3pgc9JRB9wj6noXAuG3 6M3xcVTtBaFkuPMZ+MJPyc9OvKggXq60WfUAzIJXYJOW6Y5qSO8nPwUv X-Gm-Gg: Acq92OEIePPBebsamURbm/9u315ar5X4pwACN+wfSw+mhfGsrtZj3GByROzrz+dbBVF wBCysHjUf8IYk1NOncFp0HzMFwo7LJ2rOz3ggiEsi8rRQTkhFBzaUWOPYK0GYCQbSohB0q8gOzi I8e70/mCgyN0m1Ndesrww4IR5ZRjdZXXAWyxHkZNjrNR+zR4Lc3RUxb3IuPqRiFYf+zfKjLZYjN 6bV5VxBfnl7IcszY3N60okFh60U+RI0AGeVahwu6fcd6EIqYL+Fl/lq85l6fY/ju/i2sKXcCVDe BK+wJzT/UJDI3P8T24xY0E493qJ6tyS530BlsQqtWjGH1uZ34c3q7sqIkjIJobTc4iMRmsh977x tazf8DqHIYGM7RIQ+4IkcXGdIGp0McDqVVja5H8GQJKrIUVz84rH2353RrCS9V2hWj05DmYWjrD umcPbkJQ== X-Received: by 2002:a17:903:2ecf:b0:2ba:b643:1f81 with SMTP id d9443c01a7336-2bd7e84407dmr159020445ad.15.1779108603610; Mon, 18 May 2026 05:50:03 -0700 (PDT) Received: from lgs.. ([2001:250:5800:1000::f280]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2bd5cfe4935sm156159725ad.42.2026.05.18.05.49.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 May 2026 05:50:02 -0700 (PDT) From: Guangshuo Li To: Jean-Christophe Trotin , Mauro Carvalho Chehab , Yannick Fertre , Peter Griffin , Hans Verkuil , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Guangshuo Li Subject: [PATCH] media: sti: hva: avoid double free on video register failure Date: Mon, 18 May 2026 20:47:18 +0800 Message-ID: <20260518124718.996943-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" hva_register_device() allocates a video_device with video_device_alloc() and releases it from the err_vdev_release error path if video_register_device() fails. This can double free the video_device when __video_register_device() reaches device_register() and that call fails: video_register_device() -> __video_register_device() -> device_register() fails -> put_device(&vdev->dev) -> v4l2_device_release() -> vdev->release(vdev) -> video_device_release(vdev) hva_register_device() -> err_vdev_release -> video_device_release(vdev) Use video_device_release_empty() while registering the device so that registration failure paths do not free vdev through vdev->release(). hva_register_device() then releases vdev exactly once from err_vdev_release. Restore video_device_release() after successful registration so the registered device keeps its normal lifetime handling. This issue was found by a static analysis tool I am developing. Fixes: 57b2c0628b60 ("[media] st-hva: multi-format video encoder V4L2 drive= r") Signed-off-by: Guangshuo Li --- drivers/media/platform/st/sti/hva/hva-v4l2.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/st/sti/hva/hva-v4l2.c b/drivers/media/p= latform/st/sti/hva/hva-v4l2.c index 645e4f155dd0..4e93a7d4b245 100644 --- a/drivers/media/platform/st/sti/hva/hva-v4l2.c +++ b/drivers/media/platform/st/sti/hva/hva-v4l2.c @@ -1305,7 +1305,7 @@ static int hva_register_device(struct hva_dev *hva) =20 vdev->fops =3D &hva_fops; vdev->ioctl_ops =3D &hva_ioctl_ops; - vdev->release =3D video_device_release; + vdev->release =3D video_device_release_empty; vdev->lock =3D &hva->lock; vdev->vfl_dir =3D VFL_DIR_M2M; vdev->device_caps =3D V4L2_CAP_STREAMING | V4L2_CAP_VIDEO_M2M; @@ -1319,6 +1319,7 @@ static int hva_register_device(struct hva_dev *hva) HVA_PREFIX); goto err_vdev_release; } + vdev->release =3D video_device_release; =20 hva->vdev =3D vdev; video_set_drvdata(vdev, hva); --=20 2.43.0