From nobody Mon May 25 05:12:50 2026 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EBD23273F9 for ; Mon, 18 May 2026 12:44:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779108269; cv=none; b=p69ND/MnIZlKjlu6kOGwOir4+O673aO5noptPzHi4H9ZkBjFBAm09eFD1EzScn5KTb92fzWLfVzzD0QRB+ljR+g2UN7BvnKhW4GuaTOYkftlokJgDTZvVRj/wzcCH8Y2XKM1CcgciiRd54lwheUmzYIYTTtY+mXPFJF1FCtpFHk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779108269; c=relaxed/simple; bh=1EiBwiLFVmD62ZUt5qrK0A1DphQB/3QwVGEMyqIVdQE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=p2SoGdkAKdpyP0OTNsVvEdbTaoa3LHV/LDQ+67ERm/lkdE4IYJU2Yci/KWT3Z73g6hyBMhZKDoN1jOYrcyYJqUTR2eW9IKFHRtwAq/XGvmWR9iKvRWyinW/sv0jXiAvBO2V8Av3sEhExEHyXTKCBP0a4N8T92TK4wvZ4nqiYWes= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dlgt4tNu; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dlgt4tNu" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-2ba0fc8b1f0so13643065ad.3 for ; Mon, 18 May 2026 05:44:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779108267; x=1779713067; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=D0xfFcN/bl2TM7C9TR6nPSQpgcgZrLujYdk8LlfWRiM=; b=dlgt4tNutcOi4uJGwnkjOP1YZyqGpVYoeIptsvBXl8kygMQilh1e/3vzKdvONCAOSc Lz6UD/RTKdaVy83h+XepjqD1MABJ/dO/LTTqSxH86bhjonZm4NwlwzdbO03+IxL3cg4O Ps1E9pweQzXDxEGpMyZD59PmkXFO+pbrRD1hQhsaVcHqlfj/Z0bED0mpudZN7/ovlu5X SVre7Ys8E0N8va4Uz7M/1x1XDAz1gWDCF7z9BwNeuvCCkRXCxlfBCT79CEA8F4NzCY63 D7qd4izP1PpihCazpqNjKnatIKBevfg+ELz/2FW4sOOIAjSN/6zb1ZY1bOQcLO64JSyf SYJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779108267; x=1779713067; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=D0xfFcN/bl2TM7C9TR6nPSQpgcgZrLujYdk8LlfWRiM=; b=qpGc2m+vhaBGdCL2EtepllSnegrhaxfcujv4EDkvQk1ux1PLlKkeIceBcCZhkVs8Q+ IN4KGejppKyO/Zr8hugEimypPPEpLL5NkhlhRsNcMzOSVB+KV+ozHsuMmtrqH6XZDfvS v0v0flfcIBCWqfMahr/YugGwZeaoR8+57YlQ7udO9mju0/PRTDyxegJOA7AOA0TB+FuT q0tl4106UZ6tZcXXxHtsEfkGu3ctu6OmNGimJYwXkAeIcmmEsNtUIYbkSQiVvxVpEbct cMsxGT5yA6x66WFUbH1LwmSC3OwO7bsWSQeRy/YjATt7UTO4PYH0+mFmG6urBGfEvdF5 vEnQ== X-Forwarded-Encrypted: i=1; AFNElJ9HBDqSMocL1m9aeAI4U67x3O/soLmZ7y6ahd+i+AWox79Tz4x6/MKCcB/+ez8iORvrExOGSwT/HsZ9nSY=@vger.kernel.org X-Gm-Message-State: AOJu0YwJHUDn5fFtA0Un73ICQ+Ub4bzJkdyFUx4DLWNF2X6+bo4TKnjq 8bSrz/ClwOTADTdIl3gF7/ZuiINt8QykDEMeS4mxvXazFtTka0Ia9wCA X-Gm-Gg: Acq92OEXtcNp2gBNStf9NoSXuvuji7WyDDN7OubWmX8MglUxXI6j4EdCqSFfoe/0/uh bXFUL84m7YAabHSv8zlqixL4mv0VYvoxZmdhhvfEEZc7Ou8zbhPBf3L+1Dn1OFZbBuzvpuMwjwd wDZHw0hzezeFPixzjO7uhXIpDZzLksnyIp+/O0EFKdaRhk8ZR0P9kwMKE6MtxvStGQSGvfuJ7d1 NGE9X2WSXVCAe+aSnL70ZepJ9G0gvHARqvkELO6mYNIlWx4sSM+UmWMntVBzk89OIdFhDZX1wad 1ZLgl65J1wp20PCBVsk0ji84CAmapG3JPRFZZ9VnEQwZS22ymmEh0cmoJXp1rMqvIC/+W6OWDzW W8sDd25Pd8653y8gvpLB3r5cnmihw3LFdAuJ2Bx2dxJEVDLef8LCkovOgOyOR0MjbLGoGhM9GJ3 Irp/yIAsYjDVurYBi6l+gpQoc+L6S1OHQ= X-Received: by 2002:a17:903:13c8:b0:2bd:8395:feca with SMTP id d9443c01a7336-2bd839605e4mr151517625ad.23.1779108267198; Mon, 18 May 2026 05:44:27 -0700 (PDT) Received: from lgs.. ([101.76.249.46]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2bd5c2631basm145857285ad.34.2026.05.18.05.44.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 May 2026 05:44:26 -0700 (PDT) From: Guangshuo Li To: Hugues Fruchet , Mauro Carvalho Chehab , Peter Griffin , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Guangshuo Li Subject: [PATCH] media: sti: delta: avoid double free on video register failure Date: Mon, 18 May 2026 20:43:58 +0800 Message-ID: <20260518124358.995482-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" delta_register_device() allocates a video_device with video_device_alloc() and releases it from the err_vdev_release error path if video_register_device() fails. This can double free the video_device when __video_register_device() reaches device_register() and that call fails: video_register_device() -> __video_register_device() -> device_register() fails -> put_device(&vdev->dev) -> v4l2_device_release() -> vdev->release(vdev) -> video_device_release(vdev) delta_register_device() -> err_vdev_release -> video_device_release(vdev) Use video_device_release_empty() while registering the device so that registration failure paths do not free vdev through vdev->release(). delta_register_device() then releases vdev exactly once from err_vdev_release. Restore video_device_release() after successful registration so the registered device keeps its normal lifetime handling. This issue was found by a static analysis tool I am developing. Fixes: f386509e4959 ("[media] st-delta: STiH4xx multi-format video decoder = v4l2 driver") Signed-off-by: Guangshuo Li --- drivers/media/platform/st/sti/delta/delta-v4l2.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/st/sti/delta/delta-v4l2.c b/drivers/med= ia/platform/st/sti/delta/delta-v4l2.c index 7dd27de37b78..0c6ac4bdaa9d 100644 --- a/drivers/media/platform/st/sti/delta/delta-v4l2.c +++ b/drivers/media/platform/st/sti/delta/delta-v4l2.c @@ -1767,7 +1767,7 @@ static int delta_register_device(struct delta_dev *de= lta) =20 vdev->fops =3D &delta_fops; vdev->ioctl_ops =3D &delta_ioctl_ops; - vdev->release =3D video_device_release; + vdev->release =3D video_device_release_empty; vdev->lock =3D &delta->lock; vdev->vfl_dir =3D VFL_DIR_M2M; vdev->device_caps =3D V4L2_CAP_STREAMING | V4L2_CAP_VIDEO_M2M; @@ -1781,6 +1781,7 @@ static int delta_register_device(struct delta_dev *de= lta) DELTA_PREFIX); goto err_vdev_release; } + vdev->release =3D video_device_release; =20 delta->vdev =3D vdev; video_set_drvdata(vdev, delta); --=20 2.43.0