From nobody Mon May 25 05:13:49 2026 Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB3D13FB7C2 for ; Mon, 18 May 2026 12:08:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779106126; cv=none; b=L+gvoHW7ry1fFe2DsfHY4hfoY3lbUUEjfgC+aVi1h8Ni6czm9MMEzxVTW9KfG787D+jiUAvmnCOZz5zv2RmhUD9vLaizrbHvDDO+RRP2kiGl7dDTxPLdQCNzYQCldxgSHLMpgd7EZ0s3RxgLl6qoOEYA4ZhFmgl4hLhoAtlCW4s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779106126; c=relaxed/simple; bh=zlGH5jEAEssmNm/OKOrVqj0vtMiAu/0ivcXixYxnHWo=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=CEW3ISw+ZSj2eev0um5DxsN0KSgPqf9lKkhrgxAZ+H5W33KVqpQHhEuAuyyu+W87KuIh24U93A/Nbvw9WuaBQw7n/iUhTajrJFUjQttwXCPZEGHBRrwBqiFtz9SS2ak4g09VHqrGHcLfS/lJoIAPOxNEiW1N7wBt8MBl1xjsr2U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=j5X3u8h5; arc=none smtp.client-ip=209.85.210.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="j5X3u8h5" Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-836ebdeb969so901974b3a.3 for ; Mon, 18 May 2026 05:08:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779106119; x=1779710919; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=i6DawpBpNprrDJmZUeejuEEC3bbIORGgrCvdJmH0V7A=; b=j5X3u8h5Jn0GHe6ldftes6NB1yZxDSBt4V/YZcj7XUD8tx3PLlBaH4prsD9BfOjKvU PMDcdAzGPdTe6bMGX+LAjA2ITXxkMl4Pw9X9Y4ytEfGhpVDMlE7cBA5yKcDKOIjXAeek 7TSk9Xy+VdBCTn1oCCUp3YMU4BJV2mRGbn2EdQ9W0ssDosNlJpDkUJCbOaN9qjoJsqbt BGNx26UioBYIeYBEiDlscNnWeZwBhLAdPGZ6dbfBWfrrqG1ZN56ylDE2wjSgbCi/K3gS hyuxBF6k4di22pAFxp3lFsLt9QQ3NxXX/EnSU6SDtK7G6dwSzBCAPCSrh2GqY4Nk+FNe tyPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779106119; x=1779710919; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=i6DawpBpNprrDJmZUeejuEEC3bbIORGgrCvdJmH0V7A=; b=i1cuUKEhnwbzwP9R+ksK4hqvRmzS+s7NIAWWMrzPEz0MSgiDiHsvlxpSNwh7mp55HV /MNpFZ2w5Xy5Erv5cXQOSDI0XyA3/ulKjEs0FjIDcTDbBOiqzHQZwNKP9GHkg+WP3sj/ PAxp+JEP5O937UCqicyaMImaNFVYPU+R8TMOrSGfjiUgPF5md4b7iRN8aZ4awvXUiPwa 4KUYMtrZ6BOa8IgIqRMU9d8mSgR58CM/6EQrmVoGRk6CHE1Wn3UY/ScMzAVZxDI1FeKK UKL/tXtifdx5Ia3etSkB4ZOdGZyyf3IhC9vCQyqZNBP+vwGVicX2JwclSHv2WUdT7o0K Y5XQ== X-Forwarded-Encrypted: i=1; AFNElJ8opIBcELPm6MnJaVOxtVndqQDAiIJVYdNvz/7r4P8Hxp5Ptwar7mNU0yNAu/LQQal7sWkWdMqsRHkJZd4=@vger.kernel.org X-Gm-Message-State: AOJu0YxgqqX7XMrVE9IvNOYYIUpsENOS7qg9D7OJgySNgSMUgqU/+opF q0SnqtxG+CrUIhhhehvQiACLH3Z438rJJimiWGb5ftyjOA39CyMheGyKHXnAvesF7ik= X-Gm-Gg: Acq92OHTB0xaeCA4LvNCNU4NEBFvfH8crwz/8ktCqi74Tsr0wLUvNyGGHhKA95R2JXy 9F88JNZ/+ObvT02bPnPMYohSaYCZDz3FRfrrq/3IwKwy26RnJPT/XNy4bpEL7OKxk+OzqprvO7m 5XcAMhnGJZhGjlW8v8Lj+u3rj7CkxSpw9FEpM1yNxRsnHKd7tPh3DkF3pt+u41IQxJO8wzVO85O T+bCV0yHqmsPI2VwmDh/Y7NjOTv+GVYsBK6jf0n+H8MP0UGrRQoqLh2uoxKI80oXxWMXD1H4ADj 8vfs6nf2TwQkxMUJt+UmhXNnEjyiETAkQN4M+oUlA0110sjf3HiIo8bH2TX71Ii3QEYT86JF/n4 eEoxbSqTraPBbB6QPv76qLpgr8EW8uKRkjmUDn2t6yFcYWvIA7Ss69E4aQv3gK2WoanWvm2gsXs Hw8OC/qyxB4Y4bfg== X-Received: by 2002:a05:6a00:1911:b0:82c:9f7e:518c with SMTP id d2e1a72fcca58-83f33cf10c7mr15241822b3a.25.1779106119153; Mon, 18 May 2026 05:08:39 -0700 (PDT) Received: from lgs.. ([101.36.107.181]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-83f19664712sm14666966b3a.12.2026.05.18.05.08.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 May 2026 05:08:38 -0700 (PDT) From: Guangshuo Li To: Devarsh Thakkar , Mauro Carvalho Chehab , Nicolas Dufresne , Haoxiang Li , Hans Verkuil , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Guangshuo Li Subject: [PATCH] media: imagination: e5010: avoid double free on video register failure Date: Mon, 18 May 2026 20:08:24 +0800 Message-ID: <20260518120824.993116-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" e5010_probe() allocates a video_device with video_device_alloc() and releases it from the fail_after_video_device_alloc error path if video_register_device() fails. This can double free the video_device when __video_register_device() reaches device_register() and that call fails: video_register_device() -> __video_register_device() -> device_register() fails -> put_device(&vdev->dev) -> v4l2_device_release() -> vdev->release(vdev) -> video_device_release(vdev) e5010_probe() -> fail_after_video_device_alloc -> video_device_release(e5010->vdev) Use video_device_release_empty() while registering the device so that registration failure paths do not free e5010->vdev through vdev->release(). e5010_probe() then releases e5010->vdev exactly once from fail_after_video_device_alloc. Restore video_device_release() after successful registration so the registered device keeps its normal lifetime handling. This issue was found by a static analysis tool I am developing. Fixes: 609ba05b9484 ("media: imagination: fix a potential memory leak in e5= 010_probe()") Signed-off-by: Guangshuo Li --- drivers/media/platform/imagination/e5010-jpeg-enc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/imagination/e5010-jpeg-enc.c b/drivers/= media/platform/imagination/e5010-jpeg-enc.c index 42ad9ee3993b..7f4076d3bca8 100644 --- a/drivers/media/platform/imagination/e5010-jpeg-enc.c +++ b/drivers/media/platform/imagination/e5010-jpeg-enc.c @@ -1045,7 +1045,7 @@ static int e5010_probe(struct platform_device *pdev) e5010->vdev->fops =3D &e5010_fops; e5010->vdev->ioctl_ops =3D &e5010_ioctl_ops; e5010->vdev->minor =3D -1; - e5010->vdev->release =3D video_device_release; + e5010->vdev->release =3D video_device_release_empty; e5010->vdev->vfl_dir =3D VFL_DIR_M2M; e5010->vdev->device_caps =3D V4L2_CAP_VIDEO_M2M_MPLANE | V4L2_CAP_STREAMI= NG; e5010->vdev->v4l2_dev =3D &e5010->v4l2_dev; @@ -1106,6 +1106,7 @@ static int e5010_probe(struct platform_device *pdev) dev_err_probe(dev, ret, "failed to register video device\n"); goto fail_after_video_register_device; } + e5010->vdev->release =3D video_device_release; =20 v4l2_info(&e5010->v4l2_dev, "Device registered as /dev/video%d\n", e5010->vdev->num); --=20 2.43.0