From nobody Mon May 25 05:13:49 2026 Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4AA5A3FCB18 for ; Mon, 18 May 2026 12:01:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779105666; cv=none; b=Me1jtMzIMmawqn5+LSYB/xng1EFPNc101BIei5Uj8n7MKu9OjFg0LwyjEBaNo1gnJvXR+8vd4n/ayzlI+09KZpU5lAMctteCh1pU6SGqM6inmyH8ziTWAp5nSjGQ1k6fhB/pL47ip9Pa70LsRDgxdCL/sDN51pEXyKUqFRDH3lw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779105666; c=relaxed/simple; bh=0c1Mrkb7+bhzeKC2Ct5caXkVbPMxmWDkewexcMtIHhY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=D7v7ShW/HuLOAfIfwo9BtlL9U5W2FQYywKDl1Ke3wXpkfbsqIdlcB7bCQsFPto2R8OneefRIvIuimmB8FP1ix+zYoZLvWQ4sDMTGyIZ8rTHNPbyXFJJXd3Px0HlZxmLuRHcXENsb6JWs8jtbX6q1+vDG6eNgd6elMtjSyUslhOE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=P9SjxPzt; arc=none smtp.client-ip=209.85.210.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="P9SjxPzt" Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-82fbf5d4dc2so1539659b3a.1 for ; Mon, 18 May 2026 05:01:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779105664; x=1779710464; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=KJEUMZmKl6FVu1xLyRkkbFa1bO93jpDXLl37QYwaEqs=; b=P9SjxPztAwHs9/O/9DDvc0cyrSvie4JJljx17+4zjaZzbuWDQerKyYYQQ2DLppYWz+ GT1fJUCq8tyyWb2JcNIdo/frSuTFJ2S1lQ+7y2Pxk//JxrNh/fdd27AMHw98ZriUYu7h wC6ZpuDLvA25DG8KWhpn9gsciRrxd84wIY61MOEyGX2MUzapc4r2d6hEuZ9bnNXxuE+d 1OP6lvt7RVVQFGJ715C2FTScs9ycQI2YBwLIeIu6O7AfqyyBgsP2hxHkejxG0IYNNYFx DHb1eIfu1EscdyfrDKZdZLFc77d9YfFJpHQTMYwJl+tod4PNNcE7A6SjHo1xY79+PtqN Ni5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779105664; x=1779710464; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=KJEUMZmKl6FVu1xLyRkkbFa1bO93jpDXLl37QYwaEqs=; b=DOXU+rqolA2EfyTZCXwqjuQbt/pcfD5FbDxT/KI15Rr+udhtdK483btK+89SfiaCkA 3s/QEdsaM+HYy5JmYVA6CIQHw8tC1DExElr8AZNMFdhWpG0vkwr9eALbvcZygnwgWHhu ofiWfSiTGIvm+ImNamBAtmlkVjvC0pB8rAggIwuuQaVY16zJNuFSrEl/z35P6U1MTbvM BIsgNgnScVup0zwbBcpG+OXgYSWMBDBDPrP2+F+9qktvdKSRYKhgTD+sQR63iPCnwge7 XanZimmNM93nQx0LnYX5E8F0lwuRWgteJJtrd2hvZ0lGqtl1MHRyl/G6npcOTtvoNVWS Ai3g== X-Forwarded-Encrypted: i=1; AFNElJ9694msqHWOD+GkLrj13GtpbG4CDfW7fo9neqvSGexqqMgPTAIrt1k94inTKt2w5zckJLH/MmAJIQGElmo=@vger.kernel.org X-Gm-Message-State: AOJu0YwH8q4zbdck52UM+T7onEjt6HoTNsVsn01vUEdptRT9616feXub /u40KIwNzUN4yYdBfvv2xAgqO9t1IUvcQvECVKeMDPdgYrYFx+doKQCS X-Gm-Gg: Acq92OHo+ZjWsnO3Cd9juQLl2yY/rG3XsIhq8yChonGk21YgzzfB9rZQ+UOWhBZtkep hOAVjXmQgnIefT+8XJj5gMok7/0wZY0fvLGRQKUVh9jQOiBFlmFrfNe/mK7O42WbnVgWL1M4hpp uEl+B3f0vOCCk+/2Z9s2wfy66imG1jxFQq4j0sMtrJgx6MafPpcCTunBQfufLTjrNmk9Zt4reZ6 DNGy9wNh14UlhXOd80dfVdd/QDj/lamJofcpWKCBI7gy2c3lO1hjUyzGMhMJW/IFTQSpKoSbTKl RLVCmue5CmWMxzGQFOjO85Ydymjz3CuL9xlW2nqEEQjN1GAuZ2VMH4ANEoBxdoCwWA15IoMNCrF rGU34JEAYJNGmGgqG0sCQsHcBd/cTPnP2KqTP15UBsr7SO7gnTEtEI47DyPGgEYbuxBqW1utjj2 oLBZ8dZ6s6AkS+8MY1 X-Received: by 2002:a05:6a00:4193:b0:82f:a6bf:bee7 with SMTP id d2e1a72fcca58-83f33d0d040mr15225051b3a.49.1779105663542; Mon, 18 May 2026 05:01:03 -0700 (PDT) Received: from lgs.. ([2001:250:5800:1000::f280]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-83f19f61e5dsm15030434b3a.51.2026.05.18.05.01.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 May 2026 05:01:03 -0700 (PDT) From: Guangshuo Li To: Ming Qian , Zhou Peng , Mauro Carvalho Chehab , Shijie Qin , Hans Verkuil , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Guangshuo Li Subject: [PATCH] media: amphion: avoid double free on video register failure Date: Mon, 18 May 2026 19:58:13 +0800 Message-ID: <20260518115813.992075-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" vpu_add_func() allocates a video_device with video_device_alloc() and releases it if video_register_device() fails. This can double free the video_device when __video_register_device() reaches device_register() and that call fails: video_register_device() -> __video_register_device() -> device_register() fails -> put_device(&vdev->dev) -> v4l2_device_release() -> vdev->release(vdev) -> video_device_release(vdev) vpu_add_func() -> video_device_release(vfd) Use video_device_release_empty() while registering the device so that registration failure paths do not free vfd through vdev->release(). vpu_add_func() then releases vfd exactly once on failure. Restore video_device_release() after successful registration so the registered device keeps its normal lifetime handling. This issue was found by a static analysis tool I am developing. Fixes: 3cd084519c6f ("media: amphion: add vpu v4l2 m2m support") Signed-off-by: Guangshuo Li --- drivers/media/platform/amphion/vpu_v4l2.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/amphion/vpu_v4l2.c b/drivers/media/plat= form/amphion/vpu_v4l2.c index 64fc88d89ccc..8a89e48ae467 100644 --- a/drivers/media/platform/amphion/vpu_v4l2.c +++ b/drivers/media/platform/amphion/vpu_v4l2.c @@ -832,7 +832,7 @@ int vpu_add_func(struct vpu_dev *vpu, struct vpu_func *= func) dev_err(vpu->dev, "alloc vpu decoder video device fail\n"); return -ENOMEM; } - vfd->release =3D video_device_release; + vfd->release =3D video_device_release_empty; vfd->vfl_dir =3D VFL_DIR_M2M; vfd->v4l2_dev =3D &vpu->v4l2_dev; vfd->device_caps =3D V4L2_CAP_VIDEO_M2M_MPLANE | V4L2_CAP_STREAMING; @@ -853,6 +853,8 @@ int vpu_add_func(struct vpu_dev *vpu, struct vpu_func *= func) v4l2_m2m_release(func->m2m_dev); return ret; } + + vfd->release =3D video_device_release; func->vfd =3D vfd; =20 ret =3D v4l2_m2m_register_media_controller(func->m2m_dev, func->vfd, func= ->function); --=20 2.43.0