From nobody Mon May 25 05:12:55 2026 Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DCBCF3F6C35 for ; Mon, 18 May 2026 11:52:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779105154; cv=none; b=ROhSLnT4ZhDj9PcgSClggBX1p5j3ur3wwDKOj584uSED+EsJz39GSVSaad8lSD8e4VlH08GpuDgOAJ2joBaVxxqlj/E3eNrlcEIJWzYEK1zVpsZY7G4YP/5w4JAUSPnygoYYyFzEavplB5D+PbAdaUobb3XrCg0fy68APjL4oG8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779105154; c=relaxed/simple; bh=H+Tyls76daA3eGlvfJPN03V8C3U5uw1XgqZPCavatgY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=dtgZXBElJnrv7D/PpfVWukb4NUUuLJAr+gnNbcs75kAV61MiIMy3Ve16bKABkieBtGc+1vt0ccZCtZqfemoEbXsuSogIaL31eACqwbsvfI9pHLogfXcUwmwK0yvWEFHWBFkp8dN1Y6cv86s9KUAsdVXgy+VNYPiQ+nh6XTE/+EU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Uh9rDT5W; arc=none smtp.client-ip=209.85.216.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Uh9rDT5W" Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-3684a6f3b0bso1300440a91.1 for ; Mon, 18 May 2026 04:52:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779105152; x=1779709952; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=lcjglP+1RAddnRhcnzDODhk3aYczqj8l0Dmk1F3SgoM=; b=Uh9rDT5WfWYlR8MjKmn2CfnFREyhQugP5OwqkhYNctGuCdaQhH2cKPaHWYGgaHRhue pCD6BQko3kVFOR7CGPjVuZpC7iVrYeC0iOqlxeTEx1bi+nee+EYEWD6tcuFuhzBUckQu Xpe5frNjMsvkXzwMPlMWAb8b5ONqGbtmnmW5lN6YpqBDU41cK5ZtBYPb9hobgr7mhaOx dfpGUthvyi2TMYHLuPOHxvhbMLUFws30Z7J+CzaFq1XvB1LL4WnspC446zm5WNEH9HfB Bh3N7NLTLYT3XolHBqIkHBpoEIqXrzoQ+K/MJRBXhp13Y8YPl+38lSZh2SfJTqxDzgUE cssQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779105152; x=1779709952; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=lcjglP+1RAddnRhcnzDODhk3aYczqj8l0Dmk1F3SgoM=; b=hDuikHLKEUYePdqFLIZbWGrS35nctTlPCanXXRX20HEpFhQBG6ods5KRnZDuEJgY71 0GTqPkKccjT5DGKznD1hdSSFqjqATVBGYn8npwmWyPtpzcSIebLrfPyVlUqsZ0leNslo wCbj38o47uge5R0dYWTqbmhxN2o/hBN7KTrDX7yaA9s1OWWnLiC1bv2smdMpBpdJ1f90 +Teok2FuZr+8dQxzxNmjvs6rseMStLFkYGeupttE1Iw968Z0gHTa9d6GMlSW/znWX4CV yv4rGmpf6gyVJslHQt1m454aDScqic8itH9wPvWKvvHl+xLeqru/b2KsThIYCWPpfinn HdrA== X-Forwarded-Encrypted: i=1; AFNElJ8C4gJAHblBX/8XA9SunU/7vTajsrNYOyY3NfOOzbkswW6zYK6umc5dqITZBt1Gs3x83+J0UqwPNIIrOg8=@vger.kernel.org X-Gm-Message-State: AOJu0YxtWUkSWYXmid3dOQ2cSdFoRFa3+ik+Ofe5BXshZA7CJA5eAJeW KW039LUHiGrNMuDMuCOB/rlBOCjTERpC1wxMKU07Y5kj7FZ5gmQ99fg6 X-Gm-Gg: Acq92OEZge0uj/7n4Nb82bwiAA2dwclby3Tu7MS5QRs+DRkR3oX5jy6UUGtpju8eR/x wi6mzENnLpElnqZuWSv3fssBbaFRSCEqs9YdtyM9hedG7waSBY/5rTalPDH2A6O8TzNZp66++WB ZK6A9IrSZwMcsKHG27ggWDRmNXRf2WmzwluLmf0w0ADkKKiwcmTdU2tx7dv+9mOzsbzjkc2sdvh ES5op7j0Kp5E+DOyNiUTuk9lD6b4r69be1tMCDqQK/sO6FbDZcx07c6AjuniUVKQwf52f6x4S5Q 7cU1oVWotJTpNDzp0K7XDLMNl6Iy8BAwmXxvEWpHzn55k2Xc5t7RApJIa8f6heposHkukRIJFn4 kIzbYsH2vGtYbbbkHgBawz0HAWi48ABqhdzDfMViGN3wZTRujGKll8H2VtQ1R7K7OMlTVEKKme/ jVdBy41z1x1VOeb8/qnPKh X-Received: by 2002:a17:90b:5708:b0:365:8fd4:925c with SMTP id 98e67ed59e1d1-3695149986amr10611417a91.8.1779105152199; Mon, 18 May 2026 04:52:32 -0700 (PDT) Received: from lgs.. ([101.76.249.46]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3695157c3cfsm11047195a91.5.2026.05.18.04.52.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 May 2026 04:52:31 -0700 (PDT) From: Guangshuo Li To: Andrzej Pietrasiewicz , Jacek Anaszewski , Sylwester Nawrocki , Mauro Carvalho Chehab , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Guangshuo Li Subject: [PATCH] media: s5p-jpeg: avoid double free on video register failure Date: Mon, 18 May 2026 19:52:19 +0800 Message-ID: <20260518115219.990820-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" s5p_jpeg_probe() allocates encoder and decoder video_devices with video_device_alloc() and releases them if video_register_device() fails. This can double free the video_device when __video_register_device() reaches device_register() and that call fails: video_register_device() -> __video_register_device() -> device_register() fails -> put_device(&vdev->dev) -> v4l2_device_release() -> vdev->release(vdev) -> video_device_release(vdev) s5p_jpeg_probe() -> video_device_release(jpeg->vfd_encoder) The same issue exists for jpeg->vfd_decoder. Use video_device_release_empty() while registering the devices so that registration failure paths do not free them through vdev->release(). s5p_jpeg_probe() then releases the failed video_device exactly once. Restore video_device_release() after successful registration so the registered devices keep their normal lifetime handling. This issue was found by a static analysis tool I am developing. Fixes: 7a1d4e7c064c ("[media] s5p-jpeg: Eliminate double kfree()") Signed-off-by: Guangshuo Li --- drivers/media/platform/samsung/s5p-jpeg/jpeg-core.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/samsung/s5p-jpeg/jpeg-core.c b/drivers/= media/platform/samsung/s5p-jpeg/jpeg-core.c index fdc9d7e0be66..046ad555c5fc 100644 --- a/drivers/media/platform/samsung/s5p-jpeg/jpeg-core.c +++ b/drivers/media/platform/samsung/s5p-jpeg/jpeg-core.c @@ -2915,7 +2915,7 @@ static int s5p_jpeg_probe(struct platform_device *pde= v) jpeg->vfd_encoder->fops =3D &s5p_jpeg_fops; jpeg->vfd_encoder->ioctl_ops =3D &s5p_jpeg_ioctl_ops; jpeg->vfd_encoder->minor =3D -1; - jpeg->vfd_encoder->release =3D video_device_release; + jpeg->vfd_encoder->release =3D video_device_release_empty; jpeg->vfd_encoder->lock =3D &jpeg->lock; jpeg->vfd_encoder->v4l2_dev =3D &jpeg->v4l2_dev; jpeg->vfd_encoder->vfl_dir =3D VFL_DIR_M2M; @@ -2927,6 +2927,7 @@ static int s5p_jpeg_probe(struct platform_device *pde= v) video_device_release(jpeg->vfd_encoder); goto m2m_init_rollback; } + jpeg->vfd_encoder->release =3D video_device_release; =20 video_set_drvdata(jpeg->vfd_encoder, jpeg); v4l2_info(&jpeg->v4l2_dev, @@ -2945,7 +2946,7 @@ static int s5p_jpeg_probe(struct platform_device *pde= v) jpeg->vfd_decoder->fops =3D &s5p_jpeg_fops; jpeg->vfd_decoder->ioctl_ops =3D &s5p_jpeg_ioctl_ops; jpeg->vfd_decoder->minor =3D -1; - jpeg->vfd_decoder->release =3D video_device_release; + jpeg->vfd_decoder->release =3D video_device_release_empty; jpeg->vfd_decoder->lock =3D &jpeg->lock; jpeg->vfd_decoder->v4l2_dev =3D &jpeg->v4l2_dev; jpeg->vfd_decoder->vfl_dir =3D VFL_DIR_M2M; @@ -2957,6 +2958,7 @@ static int s5p_jpeg_probe(struct platform_device *pde= v) video_device_release(jpeg->vfd_decoder); goto enc_vdev_register_rollback; } + jpeg->vfd_decoder->release =3D video_device_release; =20 video_set_drvdata(jpeg->vfd_decoder, jpeg); v4l2_info(&jpeg->v4l2_dev, --=20 2.43.0