From nobody Mon May 25 05:12:05 2026 Received: from mail-lj1-f178.google.com (mail-lj1-f178.google.com [209.85.208.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 541DA3F23D3 for ; Mon, 18 May 2026 11:00:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779102051; cv=none; b=E8A+V5ESdh962+aJmPZOtHSagLj1ChdBd08iwrWNhTqVFepcwPSFt+T+K4B8NW9HnpDzUp7drwpz2TrKhdk/va4jYhoW14w7fX0SGkyaP+r2K0jWaxc2booDNy73iFmqdFMkGxs5S16UbqAyXqm60EkG+o8OTquDbRB4Do23zSo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779102051; c=relaxed/simple; bh=MSyEDhlSoU8Puzubbj6qEaJ+2TU2CVDNruRtvJm6Lis=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=NJflwwHvjuqRQtIqoTVxxVqEgucaeNZn5Sbc5V9iMb7100oMmlvozHxlQgQOri5kNFISAh+3oukKJxmPw/UiOlR61omtBEnmxdBdCbzRCqf+avXcFgcalU4BigYwEVdyxLeirZYqD/88wUKTuGdfVWLRgKS2Ft1JiLE9L8C4cDc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dUBF7MHc; arc=none smtp.client-ip=209.85.208.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dUBF7MHc" Received: by mail-lj1-f178.google.com with SMTP id 38308e7fff4ca-393a44854d2so20349731fa.3 for ; Mon, 18 May 2026 04:00:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779102042; x=1779706842; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xskhRMwYt31YiznnIqsP+p3rukkWTePKX8/4DT9Rytk=; b=dUBF7MHcAPVERjG94lZstniKLwoLdsmRDmMIiYpQqD42Xfy8Da47uNiFD0IFMM44fN a+bW4lm50Ku1+ZDvhnJG96Wf+ZMI/ibK2u3B+RpnejKoBm8t1B4CYwuVUeiYr+sAfS3K 74hnPd14YFsPTCtfaCgIn1Hpn3xT9alqsL/D04l/ZObx+gfvq5YLOLQPBJQk+TH410/J PqbHv5HnPSTECsaIKHOtspNzJF+yXa0VKMY2GLw8h0ar67gKEGG8lx8KFCkEStAU7gtN lrqEqdD7pDUuMqYixSMr+S+ae1U756aB5SJCWWf5dcENE8ZN4OXDq7MBw+3hRO7QoWQ8 5izw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779102042; x=1779706842; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=xskhRMwYt31YiznnIqsP+p3rukkWTePKX8/4DT9Rytk=; b=Ak8ClJo6CUfNDa2S24jJx3xl6wDyWrjSrmkLMaFmpp/58hv+mSJj2Z6XIQIUBlQvuY SnygDtugSEyN89mgwmpkKVhPtXztoUCExomUtrLTeGh/ckU2bahl+Y3JeAP+FW3t3r3X Zvl6RuIBkkMpt14wpVRvvV7r9xZN+fDIvlWVbDlFvSPBHZfseTT7zh9ZVnpcPvzyj0xp L5k3YD/944iZtBLm2UBpO7n1zDnvw9g/tATJAcgq/u9aQUIisRSwjP6l0govB6kySoa6 NlGjK9hgiylOiQJg7ll2mx8rXhurlTQ3hbRgHxAc2tiAkk1IQjQSQdUBDCA3Fg+p7yyK UbYA== X-Forwarded-Encrypted: i=1; AFNElJ+Rf1KSmTMInD3y3twMmjnGlQJWGeSZ3JCLBNBeT5RJg8n9BlZaeyFCAxLiE73Ur3r4eJwvjPnDMt+YM1k=@vger.kernel.org X-Gm-Message-State: AOJu0YxJNvhCQENFLXUQYV/B/bgqg+aB69EsH99MfdgHSJAFopnJYuVF nUwaP3fD2kNWe1AOocyLUovMGPkIieYMxXKR004vl29q6Zo67VZFm3p1 X-Gm-Gg: Acq92OFaagQzVFVQdZjFcXrvGIxzLSgpYWMUfcG0sd3Ejpx3zKazkN/ccM7+OL1jKD7 x4mxqXYW2jcCcV8SmAkz45JQJFigKrmK+bAz9AWsHz7SsfIA+7jA/n7+QEDk2mZh1s30tN3Kbcz 8r759aJTQPETJptdWMOCZ+TcMwu5gq2YGLq25jnn4BRloNtcZwa97fPPH4xZlrry7I3tBjBBUwE eHcY/E00ncig4Saro7xeeGAhGjv5D1Zd8/NNUS9rvBYIaxUyVS/9o5SR4u9W1c+UqOo8vL6tONO z4grpEx7mT0+C6/CFTPOmhpVqVVnA2qc46FTx8DDhl8zO7glakdfa/OFNfcMxsCu1lkGiJAQeTT 8xZje3pZm1RjzEF+a6bXMuJqSSpTO8ZpBnihG1fmlIrXp/gqiYvfc367ZV+GOSxW86epnap1hBV zp38rbuuvGflvbJPqZX2tZbvKFcnIOi+uqDgg= X-Received: by 2002:a05:6512:2301:b0:5a8:f8b3:6c8 with SMTP id 2adb3069b0e04-5aa0e7714ccmr4197260e87.37.1779102041544; Mon, 18 May 2026 04:00:41 -0700 (PDT) Received: from NB-6746.. ([188.243.183.222]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a9164bc462sm3239263e87.45.2026.05.18.04.00.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 May 2026 04:00:41 -0700 (PDT) From: Artem Shimko To: andriy.shevchenko@intel.com, adrian.hunter@intel.com, ulfh@kernel.org, p.zabel@pengutronix.de Cc: Artem Shimko , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/3] mmc: sdhci-of-dwcmshc: improve delay handling with fsleep() Date: Mon, 18 May 2026 14:00:31 +0300 Message-ID: <20260518110034.142587-2-a.shimko.dev@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260518110034.142587-1-a.shimko.dev@gmail.com> References: <20260518110034.142587-1-a.shimko.dev@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The driver currently uses udelay() for short delays, which performs busy-waiting and may not be optimal even for very short durations. While udelay() is appropriate for atomic context, these specific delays occur in non-atomic contexts where sleeping is allowed. Replace udelay(1) with fsleep(1) in dwcmshc_rk3568_set_clock() and rk35xx_sdhci_reset(). The fsleep() function automatically selects the optimal delay mechanism based on the requested duration - for delays <=3D 10 microseconds it will use udelay() internally, but provides better flexibility for future adjustments and makes the code more consistent with kernel best practices. No functional change is intended. Signed-off-by: Artem Shimko --- drivers/mmc/host/sdhci-of-dwcmshc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/host/sdhci-of-dwcmshc.c b/drivers/mmc/host/sdhci-o= f-dwcmshc.c index 0b2158a7e409..8c3ca47c8060 100644 --- a/drivers/mmc/host/sdhci-of-dwcmshc.c +++ b/drivers/mmc/host/sdhci-of-dwcmshc.c @@ -816,7 +816,7 @@ static void dwcmshc_rk3568_set_clock(struct sdhci_host = *host, unsigned int clock =20 /* Reset DLL */ sdhci_writel(host, BIT(1), DWCMSHC_EMMC_DLL_CTRL); - udelay(1); + fsleep(1); sdhci_writel(host, 0x0, DWCMSHC_EMMC_DLL_CTRL); =20 /* @@ -895,7 +895,7 @@ static void rk35xx_sdhci_reset(struct sdhci_host *host,= u8 mask) =20 if (mask & SDHCI_RESET_ALL && priv->reset) { reset_control_assert(priv->reset); - udelay(1); + fsleep(1); reset_control_deassert(priv->reset); } =20 --=20 2.43.0 From nobody Mon May 25 05:12:05 2026 Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com [209.85.167.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 033393F23D7 for ; Mon, 18 May 2026 11:00:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779102054; cv=none; b=R6F+q5/y/mwqyT8/vMTdDxqerjfK0QETPJZdueinYOzDggKqGRkNN7JmeKHlJl00AX+ac0f2obnbj31NwmYb+KAPTK/hXRIgYAClwvR1DAWNy1FhlVdoc4BQbjqFCUfcTgc8CprgwHfZ+/tTD+/5Bzhi+MZzAP2j4y/8UovtmTo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779102054; c=relaxed/simple; bh=CG4sNB/X7mYFR/iyKu3Bu+fMMI6VKefBNED4rCak/hM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=PRK+WT4tG7HEpVzC3uKoupo/iOqR9WLK4xHjNnFkBEV3wLBU8uaVBJBQAAk7Wn53dxEt8J85v8YmueVkRLIFHV+XBz68TEWWaxUk2SnzHO0j/3IlC4oQ+zaiwub9LXeN0IYdM7i/Kz8jwWUOL+t2OJ3gcABGBIMIXcpgzn5lElI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=p161nVdn; arc=none smtp.client-ip=209.85.167.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="p161nVdn" Received: by mail-lf1-f47.google.com with SMTP id 2adb3069b0e04-5a746f9c092so3543991e87.1 for ; Mon, 18 May 2026 04:00:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779102045; x=1779706845; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=JvJX+slfx57snLGLCMB+OXIo54ykizFHdlL5Gp1Pnl4=; b=p161nVdnKqubVEVkuQbgIW5UM4PmIMDVRQdDChT8RvMlDAsHqyStl+b4w+H+2TIPhG MuVaMlVx6H+wglDlGnbwjx7kWS18hp+ehuv4jfrFhzu4sMCxiJf2aKeDs2YjmHyPDyQV F7d9TtXiETrMRU0hQKR0jHQKh8HhMulxiPwzCPtEGYg/kOe3EWyAL/oEXQdMnCM+bneH O5srq2x0WZZmTdhL1PgdUxQH6Hg0Y5ST6i5Eacn8gF1Xx1Qg0pWSeY6ktEEVly8V3kE1 VrN1GNp4XCG6s5/2FqVau/dGldeKzVtyET7+Ks0rfMODaXkGkRVqjioz5MY4pn8W3g/a JzIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779102045; x=1779706845; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=JvJX+slfx57snLGLCMB+OXIo54ykizFHdlL5Gp1Pnl4=; b=JpXrcHvNwwKUD2WVs92uTO23mivwDYUoppOyFq7hewf2CdR91boOPiW8QMWK7ZOX4Z OHahPc3Bah3qoYzsNXRlgAAoxBIGMM6a45+J47d0SyyAATllJnCrYiXM5usdGeACc35y zkeRe93GYyCKHZsH1dJqTFsaxHeEmYgXDtLWUJoVTsXotAOMEbRsiFYq7eCMz986jGpx qZy5MgjK5PiGJJ3DTUnljs8E4HLy2xaMfEmrNoGXPxIre4Y0Im5VDDsA4Rt4W4udun8S tz7xB/AoeGZbWz7nX05/BD5sKKrwwi+zhxVN67Ra5wGRssDGFZ4UbMuM9jYB+WQvEmMx Gz4A== X-Forwarded-Encrypted: i=1; AFNElJ/MRU/eLX5QT1aVoax+Kkfycb/oRettc+F6ldMPyidANNo9yw+D6WMmHrFs8KaprgHy8Uk3s4fio2r3Jc8=@vger.kernel.org X-Gm-Message-State: AOJu0Yz4O1hOa76TIbF1gpcHgIM04WgsySzjuMSEupVcPhWwVVi8q7Tw APwulqyr/KwOLZOnMUAk8YDe09Z/ppOJRoFJAIbuf4z1Kn/RRVA2Iivpvjiajg== X-Gm-Gg: Acq92OHPU11ddBZJlguQO5/tj4aQUwqCxxeJqnTdSDvliita523uOiDiQs6cP1gKtE8 ORyWqPcE6/f/Wn+n+K6q/tlMxtuR6wBt0sMzoocSTuNkON2ICHrHf6PecXW93ArJAcPaNbUn4WK wNeJrkJYm2Ia7JL8cqNV21uFtlUjgtIxeAGaygC6g0bwRxtOnihgQnH7ngvoHXv4uoYvy0uKxrh DVwM92tScCSVFw1c0WLz/GgSWifSyJKCgUNv9o/b7kf8ocgkp2yWsPnhXtmTzFh7WVbYZYr+mAE M3MX4KVRxaXa1eTyg9GuzMvtNsO9JwPakpL0LylfnPSSuvupEEQf6w2/2yq1t10Y5nL8OewVtVa JElTr2jSdUt+kxG9U6dFyCpICYlMAy1E78W9BHfRSoolzankBwq9EUfTZGm9kbCr3miR5pee3xO 7Q2ifndvp5ZA+dDBpaCntahppZ X-Received: by 2002:a05:6512:114f:b0:5a4:175a:f821 with SMTP id 2adb3069b0e04-5aa0e09d0a6mr3470924e87.17.1779102043360; Mon, 18 May 2026 04:00:43 -0700 (PDT) Received: from NB-6746.. ([188.243.183.222]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a9164bc462sm3239263e87.45.2026.05.18.04.00.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 May 2026 04:00:43 -0700 (PDT) From: Artem Shimko To: andriy.shevchenko@intel.com, adrian.hunter@intel.com, ulfh@kernel.org, p.zabel@pengutronix.de Cc: Artem Shimko , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/3] mmc: sdhci-of-dwcmshc: remove redundant IS_ERR() check Date: Mon, 18 May 2026 14:00:32 +0300 Message-ID: <20260518110034.142587-3-a.shimko.dev@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260518110034.142587-1-a.shimko.dev@gmail.com> References: <20260518110034.142587-1-a.shimko.dev@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The clk_disable_unprepare() function has internal protection against ERR_PTR and NULL pointers (IS_ERR_OR_NULL). Remove the redundant IS_ERR() check for bus_clk in dwcmshc_suspend() and in the error path of dwcmshc_resume() to simplify the code. Note that the clk_prepare_enable() call in dwcmshc_resume() must retain its IS_ERR() check because clk_prepare() only handles NULL pointers, not ERR_PTR. No functional change intended. Signed-off-by: Artem Shimko Acked-by: Adrian Hunter --- drivers/mmc/host/sdhci-of-dwcmshc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/host/sdhci-of-dwcmshc.c b/drivers/mmc/host/sdhci-o= f-dwcmshc.c index 8c3ca47c8060..29bb46783ee5 100644 --- a/drivers/mmc/host/sdhci-of-dwcmshc.c +++ b/drivers/mmc/host/sdhci-of-dwcmshc.c @@ -2564,8 +2564,7 @@ static int dwcmshc_suspend(struct device *dev) return ret; =20 clk_disable_unprepare(pltfm_host->clk); - if (!IS_ERR(priv->bus_clk)) - clk_disable_unprepare(priv->bus_clk); + clk_disable_unprepare(priv->bus_clk); =20 clk_bulk_disable_unprepare(priv->num_other_clks, priv->other_clks); =20 @@ -2608,8 +2607,7 @@ static int dwcmshc_resume(struct device *dev) disable_other_clks: clk_bulk_disable_unprepare(priv->num_other_clks, priv->other_clks); disable_bus_clk: - if (!IS_ERR(priv->bus_clk)) - clk_disable_unprepare(priv->bus_clk); + clk_disable_unprepare(priv->bus_clk); disable_clk: clk_disable_unprepare(pltfm_host->clk); return ret; --=20 2.43.0 From nobody Mon May 25 05:12:05 2026 Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com [209.85.167.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3B4F33F0A87 for ; Mon, 18 May 2026 11:00:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779102054; cv=none; b=mNcE3Ruz5M2Zolff2Ifc/2Mq3xTmY1SpJByFqYI8WFZYbiG5EFfRTmazWU0ZjhUpzLfTMSWPGnwgZZ/pjXBa6iK2zMis2ia88e3Ocu0EcrGnyR9G7Ln1LwaaZO5VaWsoumbHBKZE02F31WxCYCXbkE5aHvm3eKxLdcu8Gk8v/mE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779102054; c=relaxed/simple; bh=vjcxSjLNhxaVag18gaVizf2BPlU5CIRtAWRHBJWIrkw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=bXUuVO6/O51amFhIBsGoRdcZmdHB5+PDcCPaUUudHnUIs2gL2vxVtRBc5ZnOjSH5N1bcgKu6p+GYqOSDtsRdVabkm1GPDRFxniz/BNhCLoZi86BQtmVBekYxra26jUCmA4HgM86NuTeztGS8FHFe/i78SRa7boCfl54Z7JEdDps= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Kzd7BFic; arc=none smtp.client-ip=209.85.167.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Kzd7BFic" Received: by mail-lf1-f47.google.com with SMTP id 2adb3069b0e04-5a85b30dd54so2245093e87.2 for ; Mon, 18 May 2026 04:00:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779102046; x=1779706846; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=vnmrA8CV6GUqaooh5wLr8Nhglv5SXozFN3O1CcZvuCU=; b=Kzd7BFiccAIr5ZJJX9Se3KCsTDW0+uWvt4LKRvDShDdezra7F8ZzHZ8I5LLh8ufGcM 53+f/8epQPzISBPnuIjL80DgUVvPJJnGFCfkFvlvIXIwVOLtgZn7Jt0auuJhU8PxKpGI vC8sst/J2BGu7/bRoHwWR7AXYrr4ta4TOgRXdPPygRzRnZtq+7QxSRjnVgNs3dqoLihE 4G2K3Ki2P0TPMZf1iv6N6JcpQR2JaWyEz3vC790S87mbxcKWw+0anVzDSp8e/fqjyqaj +TmAtDnQ/YvDWM7YN0J9v/1kD+p4io9n2YHRLeF+xjW4LPClxngXdTD9I+CuSfcRZWFI DXSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779102046; x=1779706846; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=vnmrA8CV6GUqaooh5wLr8Nhglv5SXozFN3O1CcZvuCU=; b=YUQMA9losRg7VYvbf+f6hq5x+ag9eU5icIXneQpHmv/s+i8VEiMyhyMbYfa+/VlhY0 yXVcebmDnw4IXf0LqAylE+oqfc24FA1g8TJ9OvNN035vsDfAzEdvaiE5Ah/J2POUvDNH YuWTjwsKqQq2HTJ2lNwxdk/9DHmzPJvXqOOYG00zWDEYnQji7aUHEoeC7iissPc+1otv 8zNAxlcYE/JgDAAS3Q+/ba61ytvRXdCni8M2O0VtdzGBAb8C2gS6wieHo++IeOgxd2hQ A4p009U16TaU+Y2WfBxT9fT4pPdtE6UQVoXgQ1x/hRTNgCnYu8x3OT2UJHozZ2yW4Vdf LQPg== X-Forwarded-Encrypted: i=1; AFNElJ/lcZIamnWj+6bFGM+fBZn6eHLyjQh7+iAHpntGcpKJSh8T5gNYP+kFqjGuRDX3sgWSwlEvELonICSNF5g=@vger.kernel.org X-Gm-Message-State: AOJu0YwUogAF1nIojSc0fhTtmx6GRV2pSKjru1gwXvVfRviYgwPgBpkL t04QV6V58hIBC3DDzt1rJNj8P9kQFtNzLBqt8pjVrHFQcxnX0cBFp925 X-Gm-Gg: Acq92OHM+yTQ56WSYkO0yqmYq3dG0RuC7ETC/lgdEaGYp336BdGaMxHb7zmDRU9Eo2O z9a3aj7akXgkAvBlmChPfJMx0+k0uMYG71hij9xOfSNE7Y6AFXxEfRKJ5Dqzc9xmoisLL2RCKvy GQTBGTFc/WjKT94ICVxZtGo+olC0tYPS+P95f3FnU0Ocj8GfZk57trWr26rjhSOeJgGW1H03n+T kq+jTDZ98OQbgukfDH3oGlWfCO/kavmrigUYhaTgc6a17/ZmkR3pmLGomxk9svfAPj9kuvATF9x XAtCgBoYxbVTDQEQCysCFJSBdu2oROxpkaCwTJ/2v6pdwBRkCgnSm/+nxi9lDUWVbApf3WdzdB1 q184kQba4dNXk1uihdBvMdoQpkPryq5t6y7XfxnY+t1WS8k0bruFxnkk0xFleR98/RYUbYavBYK kOnU2eMK9VfSWpgAREn24Pa9tp X-Received: by 2002:a05:6512:3b9b:b0:5a8:950f:e92e with SMTP id 2adb3069b0e04-5aa0e73059dmr6146690e87.23.1779102045422; Mon, 18 May 2026 04:00:45 -0700 (PDT) Received: from NB-6746.. ([188.243.183.222]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a9164bc462sm3239263e87.45.2026.05.18.04.00.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 May 2026 04:00:44 -0700 (PDT) From: Artem Shimko To: andriy.shevchenko@intel.com, adrian.hunter@intel.com, ulfh@kernel.org, p.zabel@pengutronix.de Cc: Artem Shimko , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/3] mmc: sdhci-of-dwcmshc: use dev_err_probe() to simplify error paths Date: Mon, 18 May 2026 14:00:33 +0300 Message-ID: <20260518110034.142587-4-a.shimko.dev@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260518110034.142587-1-a.shimko.dev@gmail.com> References: <20260518110034.142587-1-a.shimko.dev@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace common pattern of dev_err() + return with dev_err_probe() in probe functions and their callees. This macro provides standardized error message format with symbolic error names and adds deferred probe debugging information. The conversion makes the code more compact and ensures consistent error logging across all initialization paths. Signed-off-by: Artem Shimko --- drivers/mmc/host/sdhci-of-dwcmshc.c | 31 +++++++++++------------------ 1 file changed, 12 insertions(+), 19 deletions(-) diff --git a/drivers/mmc/host/sdhci-of-dwcmshc.c b/drivers/mmc/host/sdhci-o= f-dwcmshc.c index 29bb46783ee5..ccd5f4d6fec0 100644 --- a/drivers/mmc/host/sdhci-of-dwcmshc.c +++ b/drivers/mmc/host/sdhci-of-dwcmshc.c @@ -917,11 +917,9 @@ static int dwcmshc_rk35xx_init(struct device *dev, str= uct sdhci_host *host, return -ENOMEM; =20 priv->reset =3D devm_reset_control_array_get_optional_exclusive(mmc_dev(h= ost->mmc)); - if (IS_ERR(priv->reset)) { - err =3D PTR_ERR(priv->reset); - dev_err(mmc_dev(host->mmc), "failed to get reset control %d\n", err); - return err; - } + if (IS_ERR(priv->reset)) + return dev_err_probe(mmc_dev(host->mmc), PTR_ERR(priv->reset), + "failed to get reset control\n"); =20 err =3D dwcmshc_get_enable_other_clks(mmc_dev(host->mmc), dwc_priv, ARRAY_SIZE(clk_ids), clk_ids); @@ -1781,10 +1779,8 @@ static int eic7700_init(struct device *dev, struct s= dhci_host *host, struct dwcm dwc_priv->priv =3D priv; =20 ret =3D sdhci_eic7700_reset_init(dev, dwc_priv->priv); - if (ret) { - dev_err(dev, "failed to reset\n"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, "failed to reset\n"); =20 ret =3D dwcmshc_get_enable_other_clks(mmc_dev(host->mmc), dwc_priv, ARRAY_SIZE(clk_ids), clk_ids); @@ -1792,16 +1788,14 @@ static int eic7700_init(struct device *dev, struct = sdhci_host *host, struct dwcm return ret; =20 ret =3D of_parse_phandle_with_fixed_args(dev->of_node, "eswin,hsp-sp-csr"= , 2, 0, &args); - if (ret) { - dev_err(dev, "Fail to parse 'eswin,hsp-sp-csr' phandle (%d)\n", ret); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, "Fail to parse 'eswin,hsp-sp-csr' phandle= \n"); =20 hsp_regmap =3D syscon_node_to_regmap(args.np); if (IS_ERR(hsp_regmap)) { - dev_err(dev, "Failed to get regmap for 'eswin,hsp-sp-csr'\n"); of_node_put(args.np); - return PTR_ERR(hsp_regmap); + return dev_err_probe(dev, PTR_ERR(hsp_regmap), + "Failed to get regmap for 'eswin,hsp-sp-csr'\n"); } hsp_int_status =3D args.args[0]; hsp_pwr_ctrl =3D args.args[1]; @@ -2408,10 +2402,9 @@ static int dwcmshc_probe(struct platform_device *pde= v) u32 extra, caps; =20 pltfm_data =3D device_get_match_data(&pdev->dev); - if (!pltfm_data) { - dev_err(&pdev->dev, "Error: No device match data found\n"); - return -ENODEV; - } + if (!pltfm_data) + return dev_err_probe(&pdev->dev, -ENODEV, + "Error: No device match data found\n"); =20 host =3D sdhci_pltfm_init(pdev, &pltfm_data->pdata, sizeof(struct dwcmshc_priv)); --=20 2.43.0