From nobody Mon May 25 05:13:58 2026 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DA31E319871 for ; Mon, 18 May 2026 10:58:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779101898; cv=none; b=IvbXae72ej+v8GNK/PGHZzOSMYfAy3FeHoKSrq9dEFR2ll9qj2Ck/EqK5GgesQt8MI7tOa0U/3/AtZzfnROISD6JVs/L7kOtakFCdMscRu+I8zraB9fax7HszmWfrhShcAIJ2B9piCgNhwyBSVQw5eUPbLbBgjvxEOKIJCoIS9c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779101898; c=relaxed/simple; bh=O9YNQzI1HHIKBIBkzsKm32RBLUqeyNJY3cFZr5m9atE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=VkF22ZfBPRdm2G/oWFn4vr2dP+XnzFCjBywHRgIQvT27Nofv+exfHYeBh1QVU+LUnNiQeFYn0hd+FDyjYKCzWuj99zrUv2U3kXMwH4WsSChZwFo/N+O++nocu2VP5cB85ICLFFJUeRENLl9FHg5VuY3UkswPFvJmdUPQViPyTR8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MTFjmCJ/; arc=none smtp.client-ip=209.85.210.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MTFjmCJ/" Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-839dc688d6cso785002b3a.2 for ; Mon, 18 May 2026 03:58:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779101890; x=1779706690; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=2bedMT/1wLJU6lQZbrg2nG4yNZCN3FiqAaO+Q+eV5ME=; b=MTFjmCJ/8qpHXrmlMsZG0zxmJiaNApJthbgELgKyeGFNuphiV5oHL4GhlDzuQZi6De QrSUDQ5LM1bXGHrAU8kfeDW8JYaBigDMEhrljIYoJFhnqlKOYmrd7k4tDLdYCd+MIr1M USAn3zHhtACtx4TdUXquMHXjtWtCUx0cDM8Mp0gZVfNin3IwhDTIMhBjIS53SPXDm3qV IkhLcZTvjEopiXOjNNQWZMzbKMrbSIEXR696AjEv5JqsULcn2zrxnyNG7DBJA3/Upxs+ bXo8oEpu9KO82YeGhARrprAkaziMLdMdO+qQUYkSn5KhIiFUiDpRwqonF/YOMQ3kkIKA Gs7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779101890; x=1779706690; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=2bedMT/1wLJU6lQZbrg2nG4yNZCN3FiqAaO+Q+eV5ME=; b=suBdumtv67oVwNxXxlPi7UvpVKeOJDmrz9AFn7dXmxHd+7aGEic0cxeNQDCfZPLbV9 vZffOal+v/WH5AXbmKMcWItVJbCxCKpYDjXnQRC2wcWrAnpLDToaEXFb6aMEvwy0EXgW tRevXvg5WHuan7wsHXqjtLfnN8N4eASN6au1c7c9/g4hN7IVrEGYu+v0yT81NiW20AJc 1HNAWM5XbIO7ZO9yj1Ew7ijzWKJhNxRtGJqyai00tOdCKCjGm1D+7K18eMFvD/33C1T7 E9O5abRcA0ghMyDGzt6XrdFbFg/bU/NmTrbel+mVczRHliQdRt0YrcuIECRgPUWHlHwW F26Q== X-Forwarded-Encrypted: i=1; AFNElJ+5tawKRiQt8IBaBQ3S0HxG2Of+V97OkcRrD4k4ogGZGyfq55QBa/uTGjVeOxLEjGk9unbBnvFccbGuQvM=@vger.kernel.org X-Gm-Message-State: AOJu0YzC99f3thfX5vZ/eznr9KZ/RXjQHblSxL6S+XbZ2Kf29Z1/WiDw bV6X7LW7Q80vh1/AzuM4WFyrDfbK0Yi6auOSQIf+dG9THz0C5iKUQlGj X-Gm-Gg: Acq92OFtO4wudyzZpdwUdPDX2gMk/O+Q97gs/NKcl6CTCZohEf29qiqfE3z9+PuRYna agXld1QF6/hh+0cD6/zNfJH2QM566V6+HWg0eDYD4UFuLR1J2N7/fLXsk54XPnUCD0P09+857V/ XrDeoku2Xd4Z0fo2wEi5k/AP3ojjq5NOvCEI/EGkbtaRHdPEk2MlOO80cfiRCQuFxgXq7cJLFYL zoLrMSzaU7e7YSwe5WO2GPuuPApPtucYxOJgMtrj4wHxTb9rdN2nzam4EFIDny18S2fdYCUSDvN tN5kdTYXEF7P1kjpc7a0Pu2PHY7z0PMrlskyKBJaVQQR+G29yer1PQTBP+JBeoYVhqg3C3Mtg/q eN/pYJVKHSz3aKuoLwhQOIJDB/9naqFpenTYd1ISXUP/EyP7HGjpILyi9i0HUXdHP8f2AtryBnf PUy+Js3WfVOik9+A== X-Received: by 2002:a05:6a00:4403:b0:834:e882:3280 with SMTP id d2e1a72fcca58-83f33cef68amr14145948b3a.31.1779101890282; Mon, 18 May 2026 03:58:10 -0700 (PDT) Received: from lgs.. ([101.36.109.157]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-83f196818efsm17201275b3a.16.2026.05.18.03.58.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 May 2026 03:58:09 -0700 (PDT) From: Guangshuo Li To: Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , "Bryan O'Donoghue" , Mauro Carvalho Chehab , Hans Verkuil , Stefan Schmidt , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Guangshuo Li Subject: [PATCH] media: qcom: iris: avoid double free on video register failure Date: Mon, 18 May 2026 18:57:55 +0800 Message-ID: <20260518105755.988961-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" iris_register_video_device() allocates a video_device with video_device_alloc() and releases it from the err_vdev_release error path if video_register_device() fails. This can double free the video_device when __video_register_device() reaches device_register() and that call fails: video_register_device() -> __video_register_device() -> device_register() fails -> put_device(&vdev->dev) -> v4l2_device_release() -> vdev->release(vdev) -> video_device_release(vdev) iris_register_video_device() -> err_vdev_release -> video_device_release(vdev) Use video_device_release_empty() while registering the device so that registration failure paths do not free vdev through vdev->release(). iris_register_video_device() then releases vdev exactly once from err_vdev_release. Restore video_device_release() after successful registration so the registered device keeps its normal lifetime handling. Clear the cached decoder or encoder video_device pointer on failure since it is assigned before video_register_device(). This issue was found by a static analysis tool I am developing. Fixes: 38506cb7e8d2 ("media: iris: add platform driver for iris video devic= e") Signed-off-by: Guangshuo Li --- drivers/media/platform/qcom/iris/iris_probe.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/qcom/iris/iris_probe.c b/drivers/media/= platform/qcom/iris/iris_probe.c index ddaacda523ec..0d259f9b22a1 100644 --- a/drivers/media/platform/qcom/iris/iris_probe.c +++ b/drivers/media/platform/qcom/iris/iris_probe.c @@ -151,7 +151,7 @@ static int iris_register_video_device(struct iris_core = *core, enum domain_type t if (!vdev) return -ENOMEM; =20 - vdev->release =3D video_device_release; + vdev->release =3D video_device_release_empty; vdev->fops =3D core->iris_v4l2_file_ops; vdev->vfl_dir =3D VFL_DIR_M2M; vdev->v4l2_dev =3D &core->v4l2_dev; @@ -174,11 +174,17 @@ static int iris_register_video_device(struct iris_cor= e *core, enum domain_type t if (ret) goto err_vdev_release; =20 + vdev->release =3D video_device_release; video_set_drvdata(vdev, core); =20 return 0; =20 err_vdev_release: + if (core->vdev_dec =3D=3D vdev) + core->vdev_dec =3D NULL; + if (core->vdev_enc =3D=3D vdev) + core->vdev_enc =3D NULL; + video_device_release(vdev); =20 return ret; --=20 2.43.0