From nobody Mon May 25 05:13:13 2026 Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B2B63EF658 for ; Mon, 18 May 2026 10:52:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779101529; cv=none; b=AxUz0cCo8tDAjJNN0rTQci4q85FvE4smV+zCGpLtndOADVQIlbor5fmEvztEe13/rlVlnlo4j3g+XEXf5MOvSUJOJs9euheDnWQdZoFAX8DEUcnb6CTSbTRz1ZebVdRm/4cXcQK+dp89CECui95k5JXQt0LHswCmpwGadtBVifU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779101529; c=relaxed/simple; bh=wiCVYdzE63JDD7QEHWLD40kMkCELvj4ARCz6e0vEqCU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=sTl6oRzo5sfL8fHjyyGyo6OEoHrhvnfMU9O8TG1tE6x7wgryc6snDKC1hli/RCKzsZAGpBylEa1h4RYYJw/RIPqO8YU5b5ETgNPvxTQv8vlWsEvE0uaIO1Ot/vMQeIL3ickcud9fmmPv7EMkVSI3a6fBEZB/Ecm3efEmN8wAkbo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QYAd2c6q; arc=none smtp.client-ip=209.85.216.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QYAd2c6q" Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-366330b6751so1725779a91.1 for ; Mon, 18 May 2026 03:52:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779101520; x=1779706320; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=CC1BbEYhycnz0G2b2hJ8BLdN9a+o6lZEO3GOpDZkkew=; b=QYAd2c6qqc3vrYNc632CCGCOs+11zPR4RzHIZ1DCbDl0LlT0nM5Lh6pNZ3WCyv/Zwp KRcikq5YMleGN/JimG38hyZvqZS5TYPM2V6JT3I1ruaFKF0EVsBbfQlIHIKybdouZVn2 hSWttiWnjO0ydWt/h3Mh745vqdKXdvogNl/s07D0+gJeCPUmEDudRNpHQwf+8wz+VE7Q vB5rhtm7v6kjzdyBjj/OkHAlTsKzCNccA0E/Zi++5CPiFhmI1BJFq1cTdwiAdABvPDFL vH94VxrArbpmgwoQBNbRGBQuehoH7RC0kSCMprr+EoLafM0WfiZao6u+FlDj0AuWLH7L Jdbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779101520; x=1779706320; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=CC1BbEYhycnz0G2b2hJ8BLdN9a+o6lZEO3GOpDZkkew=; b=oS4nZD5hJZXr6E61KlnHwuGmGGuHJ9zW3f+uy9o/FJNQvc4wMSzQ/vlwvbgjfyq4vn 6NVKKKODYFrDBhLu5niHP4OkfOH//caTh5gigfBgkEyOO+2iKbq3nC+Qd1zs8dGPXRj1 Bv1J77g7uB7fRh4yZekb0qPd0iOlpiv8oV4fP73AhSzXoxJXp5aXFWL/EVV3UP72Yded dYAQqCnEY+wHi7GHxIkUtQoX6J664TsNpTzxXQLEUxD1fQHLhEMV5mbg1IABoYNs/HNW MR9SyUQRo5C7eJuIUwS1kTnXFjU195xNRoNbnTOjuqaJD55tQwF8Kti7r6et7muU2jUv VlrQ== X-Forwarded-Encrypted: i=1; AFNElJ9OIpuP4yGyHZKXeF7UQhyFt/VfjKD73Vtqqw71C7zhrcd4XIm7mQBO2W08O83Mnc5TOuBQqEVjTqcUE9A=@vger.kernel.org X-Gm-Message-State: AOJu0YzYgo26jPxEH6T0mZO25QqN54LB+rQ8ogQsz6XAC6N/ieGeN7A7 eWF/0qAuKgo4U8yQ5LK9XfyNIQIRYIcaefSFW574G/tbvenraZDBLoah X-Gm-Gg: Acq92OFZQrCz/yArPFsLc6HI0ut8DQ7BFfiNB+RJyd+8WWINpGN4kQYNiHkQ3FDLgYG CABKUcXvDp+HO1Hw47gVGsAQRebwi4x0m/K4GbA0knna7/ocYCcIn/w4rGGEyvUj8ri9gJh0c87 sFn3Oj/I2RwQn8fWLZ2MLWEYEmD08I/koljoInLBTK2nOG5AKTINAD1gCuVWkhaJmia4IScWBKd 0JCJskF83tQ9lTwbRTA14GWO+gCFOtOm+vLNtsRmgbkZyw6hLk16IgNwYkg3pvBJey5UupwAwy7 LPIl43XhkLyiqQ1+VXAlKTVHGaGdBNsTYUAt1OfYCJmYvHkoCpqsuRTnxVScfDkoqF/1cdmJsTs Leg/8IbARckAxBV+NIsOBuRptiVZ6k7l7sqcBs27ZA4l7OJ9jUk90yNfoNfPRtAWRa6VwOgaIWy Q99UniZ+KMvrg9BH9CakvkR+E= X-Received: by 2002:a17:903:2284:b0:2b2:4bf9:1766 with SMTP id d9443c01a7336-2bd7e949015mr170263595ad.33.1779101519779; Mon, 18 May 2026 03:51:59 -0700 (PDT) Received: from lgs.. ([36.255.223.70]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2bd5bd5fb0csm135509825ad.17.2026.05.18.03.51.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 May 2026 03:51:59 -0700 (PDT) From: Guangshuo Li To: Fabrizio Castro , Mauro Carvalho Chehab , Geert Uytterhoeven , Magnus Damm , Hans Verkuil , Ramesh Shanmugasundaram , linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Guangshuo Li Subject: [PATCH] media: rcar_drif: avoid double free on video register failure Date: Mon, 18 May 2026 18:51:43 +0800 Message-ID: <20260518105143.988148-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" rcar_drif_sdr_register() allocates a video_device with video_device_alloc() and releases it if video_register_device() fails. This can double free the video_device when __video_register_device() reaches device_register() and that call fails: video_register_device() -> __video_register_device() -> device_register() fails -> put_device(&vdev->dev) -> v4l2_device_release() -> vdev->release(vdev) -> video_device_release(vdev) rcar_drif_sdr_register() -> video_device_release(sdr->vdev) Use video_device_release_empty() while registering the device so that registration failure paths do not free sdr->vdev through vdev->release(). rcar_drif_sdr_register() then releases sdr->vdev exactly once on failure. Restore video_device_release() after successful registration so the registered device keeps its normal lifetime handling. This issue was found by a static analysis tool I am developing. Fixes: 7625ee981af1 ("[media] media: platform: rcar_drif: Add DRIF support") Signed-off-by: Guangshuo Li --- drivers/media/platform/renesas/rcar_drif.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/renesas/rcar_drif.c b/drivers/media/pla= tform/renesas/rcar_drif.c index 0844934f7aa6..19c5c2823176 100644 --- a/drivers/media/platform/renesas/rcar_drif.c +++ b/drivers/media/platform/renesas/rcar_drif.c @@ -1066,7 +1066,7 @@ static int rcar_drif_sdr_register(struct rcar_drif_sd= r *sdr) snprintf(sdr->vdev->name, sizeof(sdr->vdev->name), "R-Car DRIF"); sdr->vdev->fops =3D &rcar_drif_fops; sdr->vdev->ioctl_ops =3D &rcar_drif_ioctl_ops; - sdr->vdev->release =3D video_device_release; + sdr->vdev->release =3D video_device_release_empty; sdr->vdev->lock =3D &sdr->v4l2_mutex; sdr->vdev->queue =3D &sdr->vb_queue; sdr->vdev->ctrl_handler =3D &sdr->ctrl_hdl; @@ -1082,6 +1082,7 @@ static int rcar_drif_sdr_register(struct rcar_drif_sd= r *sdr) sdr->vdev =3D NULL; dev_err(sdr->dev, "failed video_register_device (%d)\n", ret); } + sdr->vdev->release =3D video_device_release; =20 return ret; } --=20 2.43.0