From nobody Mon May 25 05:12:54 2026 Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ACB7E3ED131 for ; Mon, 18 May 2026 10:33:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779100451; cv=none; b=Fri91QZobqX42yabJvrldozP/6eiYcguFCjp199DjKGgs/oLxBKM+nsl4bj8JEpaDb3N5aHF2NmsLBjVcvnkOx6xYi8KcIkUZyd09Vw+0ASpSECU7MeH4VOQ6WD1hYL+9yR0uVsO5IdtqtGNqAzKBpiPcv/rTLHRrMTkHtSm2IU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779100451; c=relaxed/simple; bh=2LL/FLItPCn44dnp2ycwM3wTq608SyGansKwrSme9pI=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=tDJOPTJ4xHNPOlQ5Q9aD1R2oAU78uBerliNdHsdPLqzXHphAAKbMCc/umS1Vw7KWRafzwQ4iYd4pnxbMNBvKt7e1piUjUauNYo9mijMaMA8oco1wajjd3/KtxNVLX1tPehLtCccatswYgucQutPL98I8bvpHTyduYsbVz3U17e0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=a8Rozc+f; arc=none smtp.client-ip=209.85.210.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="a8Rozc+f" Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-8353c9f24d2so919166b3a.3 for ; Mon, 18 May 2026 03:33:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779100431; x=1779705231; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=WS9Y2/caebVCglEjYJZNbQVr+9NHlmJ0JSaocEMxTMA=; b=a8Rozc+fTjMrcXNNoeQlYGGh9Fag76PCKrr38yQklb4DMEaaS6DxkIC0cwkhN5Kxfz 7AC68YMTu9d8Do1qBlddtIJRGDgEJ6BSNnKhmUIF6aZs7n9C5jhywnhuwfUAGQrOD6LH qVMSSMy1J2ZWIdYuZpuhzDZgPPex0ksrBmZ+dZKW1UIPiQ25WeAJSyhYcTdFhjBkUpYA aGU2HEudl04pnlKzmmLLBVoiR6sxBIJGvos+16lPHm21mZ6K2ejueokzFLyep+VBvrgU zoCrXL9s5YPXcSATxPHt69iyv8PgEC8BY1EKMOZoyLczM1ol2yf7/InuoDG0RZ2NAE/G 5JqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779100431; x=1779705231; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=WS9Y2/caebVCglEjYJZNbQVr+9NHlmJ0JSaocEMxTMA=; b=KF20cQ1ZKHcUC/yUTYh11N0KmcusrW/4//pj4iuQ6tnCI7Gz7yeh0lg6ZYPfg1lUbW /UyRaktQfXqEPMpgz+48HbuL2UI3z6mIahHhnuQWJPSKLHpSZm2Qz7UAU2hx/qAT1T/6 8O1OiTWOEv/9noz+sNxFMrHA/fkIZd6O5QgsWbKX12UvWjQ8bNX3F8v9NPdieuqYup0H JKvhNmvP5qh5NTOnWx+jd8W8LS6lGHBSTbywDZ0fpFcRVGZ8fnjlz1uOXtkMQ/LOTAvu T+rMzvec0/4+SXKfqmjqSzGQUWLOocxNz3tNLD+lkkw4C4FbBwo9sw9YZTQu3quzpcUk m9dQ== X-Forwarded-Encrypted: i=1; AFNElJ9jyfTcpS6LbiRzxDRRyUr6LQm6sg2affFaL8hBya/42t1gtNJXpWP86oVLIE+d0vGE1Xbp9uni2SmXurg=@vger.kernel.org X-Gm-Message-State: AOJu0YzwOsC/4Rf3sWz0S54D+/4vqvcVO8eByxS9upQGRiJaeRv4GXR9 lNeIKl6u3oSxG3CKcHsih0XcA05uPUHIyNdpxx1s2TM4zI2Uo7UruGKL X-Gm-Gg: Acq92OHR7WzCqAupJqI2y7cxy+AZ+vZ7DbRFGtIAuiiAuGrg9fv+JZcM93PRwb2wMdc QVJK8o2m9VpxKDByRqT27bdd94TXgfzqopyPPIBLP1GzraqJoL5KnpXhppZWK4jd2yFiLHZOM8V nplCz8e/z4+f30OvPjT2pnUIHFlPwm3Cr0x3Oiq5VKXscwSBO+zLVfhQfPcpggQInzn1vsWR9HF vZlvq1N1DUGUEzseiwC5AqnbWjTDXywqdROvlL1c0OOfzrwpfWjM+aFsWZaeCHZ3fCFDfd7uZ8z tsAbqbap7KU+5L84jptjJS75qzNu3bRniKkw0xeNGeiiOb4PRoX77rfxVWkWe2pBgOqqqMQhFuf NaDF1517kjN5xQ1p6BfWHTI+9qGFBIMQBgRtW2ZAR6fUUfduMzdLEC5fcwVOnwVR5iXFiiZR37O DIpvoELs2vtKNdNg== X-Received: by 2002:a05:6a00:4484:b0:829:8cfb:df45 with SMTP id d2e1a72fcca58-83f33c99b07mr14532309b3a.15.1779100431117; Mon, 18 May 2026 03:33:51 -0700 (PDT) Received: from lgs.. ([101.36.109.157]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-83f19794e6esm13161323b3a.25.2026.05.18.03.33.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 May 2026 03:33:50 -0700 (PDT) From: Guangshuo Li To: Mauro Carvalho Chehab , Guangshuo Li , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] media: saa7134: avoid double free on empress register failure Date: Mon, 18 May 2026 18:33:24 +0800 Message-ID: <20260518103324.985796-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" empress_init() allocates a video_device with video_device_alloc() and releases it if video_register_device() fails. This can double free the video_device when __video_register_device() reaches device_register() and that call fails: video_register_device() -> __video_register_device() -> device_register() fails -> put_device(&vdev->dev) -> v4l2_device_release() -> vdev->release(vdev) -> video_device_release(vdev) empress_init() -> video_device_release(dev->empress_dev) Use video_device_release_empty() while registering the device so that registration failure paths do not free dev->empress_dev through vdev->release(). empress_init() then releases dev->empress_dev exactly once on failure. Restore video_device_release() after successful registration so the registered device keeps its normal lifetime handling. This issue was found by a static analysis tool I am developing. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Signed-off-by: Guangshuo Li --- drivers/media/pci/saa7134/saa7134-empress.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/media/pci/saa7134/saa7134-empress.c b/drivers/media/pc= i/saa7134/saa7134-empress.c index 8c4f70e4177d..884c6418401a 100644 --- a/drivers/media/pci/saa7134/saa7134-empress.c +++ b/drivers/media/pci/saa7134/saa7134-empress.c @@ -250,7 +250,7 @@ static int empress_init(struct saa7134_dev *dev) return -ENOMEM; *(dev->empress_dev) =3D saa7134_empress_template; dev->empress_dev->v4l2_dev =3D &dev->v4l2_dev; - dev->empress_dev->release =3D video_device_release; + dev->empress_dev->release =3D video_device_release_empty; dev->empress_dev->lock =3D &dev->lock; snprintf(dev->empress_dev->name, sizeof(dev->empress_dev->name), "%s empress (%s)", dev->name, @@ -305,6 +305,8 @@ static int empress_init(struct saa7134_dev *dev) dev->empress_dev =3D NULL; return err; } + + dev->empress_dev->release =3D video_device_release; pr_info("%s: registered device %s [mpeg]\n", dev->name, video_device_node_name(dev->empress_dev)); =20 --=20 2.43.0