From nobody Mon May 25 05:13:48 2026 Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 06AB5317176 for ; Mon, 18 May 2026 10:18:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779099528; cv=none; b=eFjv1yEu1SrsxkYKgHnhmHMp+6vj35SzgoD2FkA31IDD9MFAzxf/aCaOy+/7tu+Bmx+v2EphmLzvmPgLrhAJ2+klDm468oz+fEYvnReI9niSMqzbqNp2gHMAbiAXrVWqGaBUOhvQKDSI7A/oKwjlOWccegTUeiqU70CXkC8yS3w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779099528; c=relaxed/simple; bh=ewm1kbv1+N3Kat0ubmv2J5bMALXxYISRWam1ypvHch0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=vD+TX0ToxibDXIrgZIfY4xNNIJGq1pL0eLMDmUH4OKyd58cG28osX/VVc6tuNhPCY17CCeMJEPcYkoac36vgdn9UAUzWPmKSxbIuzOApW/zUbauddJflDEVrViJMkh2wvBnHZpizvw13eYBElCqFvkGkUX0Trf1xrVsXCBBRePI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=U3LdmwwE; arc=none smtp.client-ip=209.85.215.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="U3LdmwwE" Received: by mail-pg1-f180.google.com with SMTP id 41be03b00d2f7-c8021c8c42fso745848a12.3 for ; Mon, 18 May 2026 03:18:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779099526; x=1779704326; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=pYuvKfaVNXKjK+yXrIC0/A95KOQQQb/+OdhM2DmllfM=; b=U3LdmwwErEvJcL+uUvueUgi8TdHgMNn7S7WJ9z31ktQpDeglxF4F8TrOd9Fj0M/aAc gJk7kXRvh3Cn8ynM9bBYN8g5DqRm+RN8SZVoUlTZ/L2Z99nwhqil2jkmMcaKFRBSvi8l Pr0wtTgF62sEaC7CsmR+uOZK6GR28kXHvvQsGkURL4exs9trxHgdMgg8NgYpTggaWT/j HMAUXlZtuiR5K0akuj1DxwXiNaCTllx+eGmpDLrr6ojoA8ABL3wz/F5wqb7CT6eEHcEZ Ppy0cUV4DXbejr0naww11Kss8JTKWHpvDvzs+1Ky9/Jxe7WK44MBJ7e42IGohtci9ee6 /idg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779099526; x=1779704326; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=pYuvKfaVNXKjK+yXrIC0/A95KOQQQb/+OdhM2DmllfM=; b=AItWYOiK3JwO/URFRd/5yq87TP8fB6lw0cZo39p9+Vsbhgi9SIUzW2VjEFHpT2QBHY /6labFcPUvsHsUjM0pgg15vkPPqGNz35Ut00WcHWaGEmqzNrQFGc/TylyM8+h+bB7dsY 0kuMqxGTbU72D4wv/2oJmDL5OXKaTYQEWECdGjnaJt38GtKJDg/Z3DTrnwqzEjHdpHFX dxf/xjsYWbXi1W/SaGAl8SG2SSN6lIAUChFh1W7cGgPkD0X8eViDDjPEyKML2uAU2XSl iGp8qUvmpQGOMytfvnF/j/TCSGGaoclTSGZgH4cMWxyEPDm6XjRSy+z/u7gR3yEW3OtD ap+Q== X-Forwarded-Encrypted: i=1; AFNElJ/gEd1+jGKc/xUD2CMLbyBeoqxBhBdDJA02YoUDFN7h+uYQ2KqQnI7B4fl2fPEvr3+J2zyc5xOdyf7hQb4=@vger.kernel.org X-Gm-Message-State: AOJu0YwJteE4yDlnpYC8WGFrHnxQpyTOa4wPUSwrdQnKNJ72YiPydqIp xMtNV1T27E1/kUutGJY8h1UW4I3/KA2OZL9EGUxUkGpEsKX+6IMQHmFVAlwttAvFbtw= X-Gm-Gg: Acq92OEjXJMpWvNX0CKRiGYShjmls29Y3f7tNpW6gKTbNe+LeFJ9IdgJF6YB7lnSxCe fix01ZTBuPuSQuCjWKzhYEBm21AvIL1GrfsHo2m1OamwvwGcaoqmbVBNg5Qg2/GW5d7r/u5bzKT oILUyiIv8ACbooGnFhWcVlFYhdNbinCUNpO8wo+L/RoAQtj7etrb42L0BZNKIs9bhOAvdJzXsAX bDYlWQ6ts6hz3YwUYTDzacg+2e8W2ACipnDtAM9uM493sn8DQSnONce3JYAmbk1V8GBT11k80Yw q7dHbt2BuuleYG1+mJ/UJleATW4DXXAHqZwCDegF56d77KtyJUVKudul4MjxB+8g8yQyG7j0IgJ qytblY3KX0zZwWUYHV2j2bCPaPNcuX1f8p6wJHUhLb/aZAgY/xY3bT+U6bAYkq4n48yQSsUCJ8q BAW5HnaVflxkls3Oe5LXPr1Sgv2U2FUzlcJQ== X-Received: by 2002:a17:903:984:b0:2b0:6e4a:32d0 with SMTP id d9443c01a7336-2bd7e97951dmr161511895ad.35.1779099526312; Mon, 18 May 2026 03:18:46 -0700 (PDT) Received: from lgs.. ([152.32.251.59]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2bd5d2360e8sm153584155ad.82.2026.05.18.03.18.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 May 2026 03:18:45 -0700 (PDT) From: Guangshuo Li To: Ezequiel Garcia , Mauro Carvalho Chehab , Miaoqian Lin , Hans Verkuil , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Guangshuo Li Subject: [PATCH] media: tw686x: avoid double free on video register failure Date: Mon, 18 May 2026 18:17:09 +0800 Message-ID: <20260518101709.984270-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" tw686x_video_init() allocates a video_device with video_device_alloc() and releases it if video_register_device() fails. This can double free the video_device when __video_register_device() reaches device_register() and that call fails: video_register_device() -> __video_register_device() -> device_register() fails -> put_device(&vdev->dev) -> v4l2_device_release() -> vdev->release(vdev) -> video_device_release(vdev) tw686x_video_init() -> video_device_release(vdev) Use video_device_release_empty() while registering the device so that registration failure paths do not free vdev through vdev->release(). tw686x_video_init() then releases vdev exactly once on failure. Restore video_device_release() after successful registration so the registered device keeps its normal lifetime handling. Clear vc->device after releasing the failed video_device, since the common error path tears down already initialized channels. This issue was found by a static analysis tool I am developing. Fixes: e0b212ec9d81 ("media: tw686x: Fix memory leak in tw686x_video_init") Signed-off-by: Guangshuo Li --- drivers/media/pci/tw686x/tw686x-video.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/media/pci/tw686x/tw686x-video.c b/drivers/media/pci/tw= 686x/tw686x-video.c index 785dd797d921..7d121dba4f79 100644 --- a/drivers/media/pci/tw686x/tw686x-video.c +++ b/drivers/media/pci/tw686x/tw686x-video.c @@ -1266,7 +1266,7 @@ int tw686x_video_init(struct tw686x_dev *dev) snprintf(vdev->name, sizeof(vdev->name), "%s video", dev->name); vdev->fops =3D &tw686x_video_fops; vdev->ioctl_ops =3D &tw686x_video_ioctl_ops; - vdev->release =3D video_device_release; + vdev->release =3D video_device_release_empty; vdev->v4l2_dev =3D &dev->v4l2_dev; vdev->queue =3D &vc->vidq; vdev->tvnorms =3D V4L2_STD_525_60 | V4L2_STD_625_50; @@ -1281,8 +1281,11 @@ int tw686x_video_init(struct tw686x_dev *dev) err =3D video_register_device(vdev, VFL_TYPE_VIDEO, -1); if (err < 0) { video_device_release(vdev); + vc->device =3D NULL; goto error; } + + vdev->release =3D video_device_release; vc->num =3D vdev->num; } =20 --=20 2.43.0