From nobody Mon May 25 05:55:53 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C7A183E558C for ; Mon, 18 May 2026 09:23:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779096237; cv=none; b=q2lEasfKHuudIEqbTrtdVkjabsAw3kGJb2fOY3JUwl3XfpNZ3HBGGvw552iA0YAO15OUyST277XIzvr1gBB0AH58wh37ftVW1Dcdsx0gsYkydAnh0bd3fCxDHQxjZgzu920t6pVw+cHEDGzcDn3w/1mIf/UQQyMnetF4sbqHcpg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779096237; c=relaxed/simple; bh=OartzHtMjkwbtY495zYmORd7DntitjwDcZpmsbrjb5E=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=tlUmHfi/sYdG867Uny9swZUJxvdqdk/18qkZFuGacsBBJvxeetFzq69YOROHSisUSwc46vqjJaxzpVbUfrii74HyW4n0COvG4TeYz2vmuE4vIhje+JRibxu2IPx/uH5l0fyqS0j5Gj5M5YXPhwgttsMgyTlb0JR+oMAxNG58h3Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=F7y/Hyto; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=JMF5LlhD; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="F7y/Hyto"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="JMF5LlhD" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64I8QTLa3269301 for ; Mon, 18 May 2026 09:23:55 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=DEneedWpQwB +o3i2G+K+xijFiG8S93MO38MV8xEuYUA=; b=F7y/HytoopXeqf5NpwhfH8SiEDQ uhfuFuR5R8nHi8N3My7WO9PtB3ZLG14U0/ev2OspTDneEm+CqjbmrcuJKmKcVAJZ 6iXprYaEDim8a503zvvZ0n78Yj6Ns4zlpHEKJYbtRAVIUiwMx3eNMEPBAmoC1RGj f0A/ym+whJzDgdptUqgOwN5i8g9KZBrgr7jqWgBB3GEgco0KSRPzV40ANobwTvip wsYNdUhqyGfzpQas7NAT/t8VY0heQSSyeLyRjbtslQbgLg7xK+goqGYUI8AFyqkj teZzy2TEOX+4KwDHbZu1rB0xVnmhxLqupncmGlyG0RWwFK4o/QVgvFKavlg== Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e6h0g5p5r-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 18 May 2026 09:23:54 +0000 (GMT) Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-8bc5ab12bb5so73209936d6.3 for ; Mon, 18 May 2026 02:23:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779096234; x=1779701034; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=DEneedWpQwB+o3i2G+K+xijFiG8S93MO38MV8xEuYUA=; b=JMF5LlhDp/XPYRbbf6GVldA3ysC9wy9ZdiGUairy2o9F6tHdOketLEZZMrLZrZNtfM 2OdcwdQ3AxeHx4poCD7M7XvOX9EZ4SlxT0skc/1F5XE2Cc3lVlkZ3EGsWkU0ZWPrkp3I RLBFxrjA6byHTioigtN7svruD/4/RErI/7nJj4soKCQFd/+tVHEmPyZntXKXK/b+HO4J 5oBgjuPYw2AZZInNseN2kQhy2DYZPZZUy8xbTb+jirWIiKjKw/6KXUud5acVuGc2kAqT 6saK2jZCfSRHAqImyrcTLTFcC3fRc0UKYc6dWJEoAD/uFwB4PKmqwXmxfRhkLwBmkZOq 7LXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779096234; x=1779701034; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=DEneedWpQwB+o3i2G+K+xijFiG8S93MO38MV8xEuYUA=; b=aCQoz+LUqaRhVYAqyFv8q0CiZ4AD1HxeeBCc4iila/FkxWv1LclB7CA7RV3bp6XWsR i5J1xfR7L+4qHeOqLZSvP5kcVdhUTETlVpsT6owwW+hBZVwd6I/A7wYioYBNIHykvFtl 6sAAHj1UKkol3rCdBe8rkj+dsHUWougMdtod+ouk1iofTt4nqDeX6g+kMop5tn8DNhQY RBAXIgYKDMLF5jtcJBcBuEOIpI5OXGg28B36m/3YPdFaMMjFmfdTzUDE5OME36Mw7XT9 dAfQBfsW4lpBk7UNr42m928KjC8QVAm4cVDWCN3iilG6/gMKPsEdjuVomnVaPpF5v1G9 BX2A== X-Forwarded-Encrypted: i=1; AFNElJ+bF2XSYldz8YSjbIQQO7L2r/X2pnn3use+Fl2zShzuIj2t+zFTO1aWdDzI2irhETfHGP+hgZwuF/5hNfI=@vger.kernel.org X-Gm-Message-State: AOJu0Yws9g9qTIu9WWltk6cyeHpnbcik1PgAs8/lCrLC86iXC0607zHg ynak0DX9FihEUUpsys276oRgkt77GoE3OgeYZ97XWmZHRu1yfb1qA4ZrC8lYxhhOpivw+AczYpI 3hUAkexngQzs5piMwSYE0yHbQGfVGErdyKKLUlth0LsZu/DccH4FABabjOSVuQrrtisBf7JWVtD I= X-Gm-Gg: Acq92OFb7OUPIOngX4RnO97LtPiNTYRpRhxEtfeTx2cI3jXQjbI36IdTEev8dxD1Sl3 dOsA9b9XZ2s/HgiF8nCLVkoktniZnXMfuL95+ecLonQ34586uuRvVFYfWHv4O946yJyoKMY2l/n ooAUHapmSA2kPzM9mY7Av29OiHyxFuPDIBxtrTcpIu8vQzjSmLmEKTCf2+3DWwJDcq7fMvmvO1/ cJqZpE+BqsFT4B01O1jBMZBXzJWtiESTLQnDT1XSSHu8VhnoIPjaCFWqUXvJdkk0Ir6JTGHybEC TA124NizAkFCwmYIvUOSSMSNMDKCNTg5vDuasGT0WQO7VIlTSpDm1wv8wmqTB9dbkJ2uS225Duf Sbdi+A/hxKyUM0cVV2PRrnSYX1X4KafuSxZIBlRB5dV/E1RNsLKf9Lc8= X-Received: by 2002:a05:622a:1f96:b0:50f:ccdd:13f1 with SMTP id d75a77b69052e-5165a03f078mr203841211cf.16.1779096233786; Mon, 18 May 2026 02:23:53 -0700 (PDT) X-Received: by 2002:a05:622a:1f96:b0:50f:ccdd:13f1 with SMTP id d75a77b69052e-5165a03f078mr203840921cf.16.1779096233343; Mon, 18 May 2026 02:23:53 -0700 (PDT) Received: from localhost.localdomain ([5.133.47.210]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45da0fe0fecsm33265900f8f.26.2026.05.18.02.23.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 May 2026 02:23:52 -0700 (PDT) From: Srinivas Kandagatla To: broonie@kernel.org Cc: jens.glathe@oldschoolsolutions.biz, linux-sound@vger.kernel.org, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, val@packett.cool, mailingradian@gmail.com, Srinivas Kandagatla , Stable@vger.kernel.org Subject: [PATCH 1/5] ASoC: qcom: q6asm-dai: do not set stream state in event and trigger callbacks Date: Mon, 18 May 2026 09:23:43 +0000 Message-ID: <20260518092347.3446946-2-srinivas.kandagatla@oss.qualcomm.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260518092347.3446946-1-srinivas.kandagatla@oss.qualcomm.com> References: <20260518092347.3446946-1-srinivas.kandagatla@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTE4MDA5MCBTYWx0ZWRfX/GAyrkMLCWRy gdHyj1+l3jY1spwe/JYKGlmnN2l92T2sOEqGcfSw9h8lJn4PIBEVCtT5mltyCXYvF75tSQJBoPh 9S0m5TuhB4XfIToIEE/3ARiTb1/+shKDMjxDhsO9CvRZdhZwzwWMQ4O57MI+6ynQtdlLqWgSQEw 6nfBEXl/Skq8/Z9fRv9nyGwuW5B4NPf2OyP+hxAxPSeZZlOwKVeI0ow/iSrInu2q6kr6KlipjlS QX0xjuTR/IfPuWIub8MwglfC3E7BrmwCP7TigWpFDnsz9hHhxEHeu9YWZK+7oKA4/bbDClQB8Z3 1EgJJVas4/kRyB5AQLL05imX4W8Uw22eT6HoHV6Kx8WR16H9s8kBXOC+9+S3ttk1O/9IU6SC6jC 3ZFnj5NK5+1N0He+Gf+96bxEZ2VTf7ZvBIlQlUQaB/8kl2e9zsAaqZZnKvbbnDvBkz5GypbsWHN dSSvJubBxDyVPqBAyug== X-Authority-Analysis: v=2.4 cv=W7gIkxWk c=1 sm=1 tr=0 ts=6a0adaaa cx=c_pps a=wEM5vcRIz55oU/E2lInRtA==:117 a=ZsC4DHZuhs/kKio7QBcDoQ==:17 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=TpFDhmux8Oo1qIo2-XoA:9 a=OIgjcC2v60KrkQgK7BGD:22 X-Proofpoint-GUID: RuKvE8WjVjyhEhlLllL6C8oW2Gn0UCB_ X-Proofpoint-ORIG-GUID: RuKvE8WjVjyhEhlLllL6C8oW2Gn0UCB_ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-18_02,2026-05-15_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 bulkscore=0 malwarescore=0 impostorscore=0 adultscore=0 phishscore=0 clxscore=1015 spamscore=0 lowpriorityscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605180090 Content-Type: text/plain; charset="utf-8" The q6asm-dai stream state is used by prepare() to decide whether an existing stream setup needs to be closed before opening/configuring a new one. Updating the state from trigger or asynchronous DSP callbacks can make that state stale or incorrect relative to the actual setup lifetime. In particular, setting Q6ASM_STREAM_STOPPED on STOP or EOS completion can make prepare() believe there is no active setup to close, which can result in opening/configuring the same stream more than once. Keep stream state updates tied to prepare(), where the stream is actually closed and reopened, and stop changing it from trigger and EOS callbacks. Fixes: bfbb12dfa144 ("ASoC: qcom: q6asm-dai: perform correct state check be= fore closing") Cc: Closes: https://lore.kernel.org/all/afS7rTHdc9TyIeLx@rdacayan/ Signed-off-by: Srinivas Kandagatla --- sound/soc/qcom/qdsp6/q6asm-dai.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/sound/soc/qcom/qdsp6/q6asm-dai.c b/sound/soc/qcom/qdsp6/q6asm-= dai.c index 4f8f7db6c3d3..56f0d8913904 100644 --- a/sound/soc/qcom/qdsp6/q6asm-dai.c +++ b/sound/soc/qcom/qdsp6/q6asm-dai.c @@ -186,7 +186,6 @@ static void event_handler(uint32_t opcode, uint32_t tok= en, case ASM_CLIENT_EVENT_CMD_RUN_DONE: break; case ASM_CLIENT_EVENT_CMD_EOS_DONE: - prtd->state =3D Q6ASM_STREAM_STOPPED; break; case ASM_CLIENT_EVENT_DATA_WRITE_DONE: { snd_pcm_period_elapsed(substream); @@ -341,7 +340,6 @@ static int q6asm_dai_trigger(struct snd_soc_component *= component, 0, 0, 0); break; case SNDRV_PCM_TRIGGER_STOP: - prtd->state =3D Q6ASM_STREAM_STOPPED; ret =3D q6asm_cmd_nowait(prtd->audio_client, prtd->stream_id, CMD_EOS); break; @@ -555,8 +553,6 @@ static void compress_event_handler(uint32_t opcode, uin= t32_t token, snd_compr_drain_notify(prtd->cstream); prtd->notify_on_drain =3D false; =20 - } else { - prtd->state =3D Q6ASM_STREAM_STOPPED; } break; =20 @@ -1014,7 +1010,6 @@ static int q6asm_dai_compr_trigger(struct snd_soc_com= ponent *component, 0, 0, 0); break; case SNDRV_PCM_TRIGGER_STOP: - prtd->state =3D Q6ASM_STREAM_STOPPED; ret =3D q6asm_cmd_nowait(prtd->audio_client, prtd->stream_id, CMD_EOS); break; --=20 2.47.3 From nobody Mon May 25 05:55:53 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DCED6377558 for ; Mon, 18 May 2026 09:23:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779096240; cv=none; b=KfwFH232P+tDyXTXOhnLJTp6aMkKzOBhbLFVePHfZ17HCDQ1b1ZrNg065QcGxJ1iCX2ptj7ETOUCGYG3zQTUsixmuYJW0ZY7w5axxZdbxr86r2wCuXKVj5EdApzsiGNL+eUNJ8ySyxdVNn392b1ehWLFrT1/G2uFR75uYJvdb6w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779096240; c=relaxed/simple; bh=RCs85gMYZ1p9MuIk2+VubwPsJIHZd4Qgpqt8dbtEJpo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=s+gwEbzaB7kDHCSzn4e6+mv0HSrTim7KZqVxld79o4CT5MnVWBdsiHEOHG3+VW7dpafdrfEJKsP1uvvRqRHDxeFe2yLPADV4gYxUoqNi2hNsGTfFbuKi4PunEI3+u6fmTJUX5xKquku0CE7tCqaOvjD9BJes0tqIsrHMzLC6x8o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=MnyhI2N1; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=WCwEXlTO; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="MnyhI2N1"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="WCwEXlTO" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64I4shSC3779377 for ; Mon, 18 May 2026 09:23:55 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=s/uuIZd9tj7 QhjDlqlxXE48EZqcvyagv3QTAGMpzuIA=; b=MnyhI2N1cFnaVI0OIWEJRYbrl5D vyg/05SnXAb9BXCaEZ/Up0ZBwfOkn/Xyb5ZzMkOmA563fVpJYRhqiyQFi+RM9G7I hqpM0GsoV0I4kyE/ZeEhjZRx6caUFUNyezoqRLaGAxrTjQoOAVkc2dhH6aY8Fjzd admrMs0awSJRoqrL9AbqPRzq4WiDM54dRr1avmikdvycZh9RZ9GH5muvVBF4q4Uk fW3UPcmmGH/DbwNLH6Y4Dn+Jw4fcXtPCfeRsnGp6YXudRkrEB+gb09cxUHmQPiRd dZ+nyUntNteX5VFCCNIwRqYZyQPIBnRCJc+M2aQwWD4PPifVqf24C2SWglw== Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e6h0qdqnd-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 18 May 2026 09:23:55 +0000 (GMT) Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-8ba8a1f3dd7so24272606d6.3 for ; Mon, 18 May 2026 02:23:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779096235; x=1779701035; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=s/uuIZd9tj7QhjDlqlxXE48EZqcvyagv3QTAGMpzuIA=; b=WCwEXlTOb0GMmX22or4eV0qY7WjjxdAARTUPwJXFgQJEXTfAv1UzUKJElfuJpJgyg/ ZfR2QMKdtdedUrZC8NMPHy5lpCY+l0dcvB79ayop6dIP+v5aZeET+mIDGiDFNrxzhVCV /M5/U9vrZrg3v01awoZRXRaklvECOlCzsO+aKwatZmeF4qHbpXcpWiTmV+Vfya3fiQcF nxsKKqnVpc03m3A0lwMsx9YhyugrsPKtXuJ9MW3M2iicY5+KESp5msj9PnkCpFfQHROg TxN9HMzUoJ5731bdyzVK0R1CQypSJwfNnM7WK546/ofMas9LGCpF0rlg4Kr4QiS87nmr U3lA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779096235; x=1779701035; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=s/uuIZd9tj7QhjDlqlxXE48EZqcvyagv3QTAGMpzuIA=; b=AlDvOeiCUi3elcrPjDuKy97T8QWtw6bYkiSTRbzg4ErdUZyZWBt0cSCvVskZxAC4pf YW+c5D94bYHeBrm5iTTU7c6dajFk58NDiJjiyCXKNXiXSlfsPKn4a8QsqBFe1qWpKQjl U/NbIQKjRg2YGhe2BnC9Mq2x1SIAqnFs0FjqzM9wookw5t0GQrHP/KE6oKOrxTSINaLl ppekmyifOU8W4TFgyvqvvWEMzRv1a9TFnQuigHz+aHo+Eo5rL/lvXZVEd17RvjI7IJxV O453l91LTh6pngNIW9ItWpyxo0cFabbWC3BKsMJQrW3EGVJbVtemXgLk3+zb9l0wrDLn mNnQ== X-Forwarded-Encrypted: i=1; AFNElJ9Jscj2lc7Pa/1a79Mzjy4TMIPN119MQLDjllCs8KNQ/Duki4i2EMwZt3nErBJ4dA9MAYpzNC0McJEJBsg=@vger.kernel.org X-Gm-Message-State: AOJu0Yz22dGKlHvtITao4lMSC9QmZRFaVZ7hXONDy20Lgat7Y0qDTYdQ +cnWcSALshqiEHgaiD9oIhyGY1uvNyYGvC0xbsZWtYC8z04JxE2+CdJRCDr39NtrQXtJ/IVA0xz qx82vv/Ykja+02VpUZ/fZVTbtpRBhwlWmz/NzMNkhZPNzTjmK0n+AGnhUJuIXWyEcRq4= X-Gm-Gg: Acq92OGXDhvXpnF79RWslFZYN9gCn/qE0t3KobRnRHlXeY4HrRYxT3s/gagXdUl/ezp AauN4CglH5Vhwc7r+7FSW0fAhb/dtNp67cesEK2XcHM69J0uArDuVEQZ/IK4fwvoWDaWxOuNIJg iDUSVOFeuvuMd50SrXfqT7EaKAOl5q9E+N5IMDZBbiMY8k1/NvFl3V9Qt/uweWk4/BAn6gl2Vks QzNXOrxEdTkV+1FmFAEm2RZnbQBd29wqM6Z8EJ5Fwo6EshF7gltZvMxwCsw+RCFAqpxSuI1+BQU IHql/aluz2DnKxFLQB52CyGGyr54ohBXKjeVXJJM91ufhepN+z+gS5cRoI9X5ce4eRp9ff6b1xq 22ZTgFywQpSq8TTGXkYMyLS9Ems0kIA3Qv8KsvkF9V9WoTrnkARbqxTo= X-Received: by 2002:a05:622a:2514:b0:509:39b5:a97f with SMTP id d75a77b69052e-5165a0a37a6mr197721001cf.29.1779096235062; Mon, 18 May 2026 02:23:55 -0700 (PDT) X-Received: by 2002:a05:622a:2514:b0:509:39b5:a97f with SMTP id d75a77b69052e-5165a0a37a6mr197720721cf.29.1779096234552; Mon, 18 May 2026 02:23:54 -0700 (PDT) Received: from localhost.localdomain ([5.133.47.210]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45da0fe0fecsm33265900f8f.26.2026.05.18.02.23.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 May 2026 02:23:53 -0700 (PDT) From: Srinivas Kandagatla To: broonie@kernel.org Cc: jens.glathe@oldschoolsolutions.biz, linux-sound@vger.kernel.org, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, val@packett.cool, mailingradian@gmail.com, Srinivas Kandagatla , Stable@vger.kernel.org Subject: [PATCH 2/5] ASoC: qcom: q6asm-dai: close stream only when running Date: Mon, 18 May 2026 09:23:44 +0000 Message-ID: <20260518092347.3446946-3-srinivas.kandagatla@oss.qualcomm.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260518092347.3446946-1-srinivas.kandagatla@oss.qualcomm.com> References: <20260518092347.3446946-1-srinivas.kandagatla@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-ORIG-GUID: P8Mg8ppNgX4YBUQR6YijjMY8on6wM48c X-Proofpoint-GUID: P8Mg8ppNgX4YBUQR6YijjMY8on6wM48c X-Authority-Analysis: v=2.4 cv=fIMJG5ae c=1 sm=1 tr=0 ts=6a0adaab cx=c_pps a=7E5Bxpl4vBhpaufnMqZlrw==:117 a=ZsC4DHZuhs/kKio7QBcDoQ==:17 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=KnWeaZq26ommGgBC8l4A:9 a=pJ04lnu7RYOZP9TFuWaZ:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTE4MDA5MCBTYWx0ZWRfXzChT8muOkieS Be8DtFYuZSTX1/2Tzh/BC6myV17eEuyTuuxKhxFGWr7XO6iE+BQYCXyG59TudHO9+MEwRs96gdI MT7pkidvKDAiHiyQl7M/9e62lKdzhZThTN0LtT7k+2DIdIimkNdD9r4mCaIbE6uufTSop1muQFV mytN4TXO8TUIrYLKjbQVv8Vc0nSEZmRnQ3M1h7NKAypawj/I9mPI4JUlnDRYhLOC4Gxsd5wcx3o a/MZBzvog2nEfPRkGLZy/fm3VTAXwUFfkwPaGpKTKW5SQGR5owCnB7LNYwfRVD5qVL+wYjQTYbF HgMTq/Pv/eUp4PY2v9T9gqw2WracEPsh+P7CmhOCsNwEbAiW5/RUnomUJ7SPxmP6XCB73S0E2wE TpZtnishXuC32ls2qlqu81wHDYbTV2dy23IYDjCe0DKE7YsF4sWDjQrQ903rcOBFeSHXYHVWjps NyQvB/c42WC/oUpYdMA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-18_02,2026-05-15_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 impostorscore=0 spamscore=0 bulkscore=0 phishscore=0 priorityscore=1501 adultscore=0 suspectscore=0 lowpriorityscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605180090 Content-Type: text/plain; charset="utf-8" q6asm_dai_close() and q6asm_dai_compr_free() currently issue CMD_CLOSE whenever prtd->state is non-zero. After prepare() closes an existing stream, the state is updated to Q6ASM_STREAM_STOPPED. Since this state is also non-zero, the close and free paths can send CMD_CLOSE again for a stream that has already been closed. Restrict CMD_CLOSE to the Q6ASM_STREAM_RUNNING state so the command is sent only when the ASM stream is still active. Fixes: 2a9e92d371db ("ASoC: qdsp6: q6asm: Add q6asm dai driver") Cc: Stable@vger.kernel.org Signed-off-by: Srinivas Kandagatla --- sound/soc/qcom/qdsp6/q6asm-dai.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/sound/soc/qcom/qdsp6/q6asm-dai.c b/sound/soc/qcom/qdsp6/q6asm-= dai.c index 56f0d8913904..ef86b5b9a951 100644 --- a/sound/soc/qcom/qdsp6/q6asm-dai.c +++ b/sound/soc/qcom/qdsp6/q6asm-dai.c @@ -455,12 +455,12 @@ static int q6asm_dai_close(struct snd_soc_component *= component, struct q6asm_dai_rtd *prtd =3D runtime->private_data; =20 if (prtd->audio_client) { - if (prtd->state) + if (prtd->state =3D=3D Q6ASM_STREAM_RUNNING) { q6asm_cmd(prtd->audio_client, prtd->stream_id, CMD_CLOSE); - - q6asm_unmap_memory_regions(substream->stream, + q6asm_unmap_memory_regions(substream->stream, prtd->audio_client); + } q6asm_audio_client_free(prtd->audio_client); prtd->audio_client =3D NULL; } @@ -670,7 +670,7 @@ static int q6asm_dai_compr_free(struct snd_soc_componen= t *component, struct snd_soc_pcm_runtime *rtd =3D stream->private_data; =20 if (prtd->audio_client) { - if (prtd->state) { + if (prtd->state =3D=3D Q6ASM_STREAM_RUNNING) { q6asm_cmd(prtd->audio_client, prtd->stream_id, CMD_CLOSE); if (prtd->next_track_stream_id) { @@ -678,11 +678,11 @@ static int q6asm_dai_compr_free(struct snd_soc_compon= ent *component, prtd->next_track_stream_id, CMD_CLOSE); } - } =20 - snd_dma_free_pages(&prtd->dma_buffer); - q6asm_unmap_memory_regions(stream->direction, + q6asm_unmap_memory_regions(stream->direction, prtd->audio_client); + } + snd_dma_free_pages(&prtd->dma_buffer); q6asm_audio_client_free(prtd->audio_client); prtd->audio_client =3D NULL; } --=20 2.47.3 From nobody Mon May 25 05:55:53 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4806C3E5ED0 for ; Mon, 18 May 2026 09:23:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779096244; cv=none; b=MwRZz1WkVII3SUtnIA/EizzkCeMBtScIq6YNRpb+hkSTX37TguAD1ITEqC7d15ljHIGbX+8OD1eCp94Y9g0e8syfO/VeVJE/GHKRlFUKjsSXWF7YfS315wSrY+EMhAOWheGcRfyMXUYnWFKVIrx2G2UaN4GHm3uuyN98Tz6GcAk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779096244; c=relaxed/simple; bh=46oO58C6qyz+oSF3AkdKCK/hAYNIkihn1nqY49j8PJY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Jd5fRLzEuhAQlueqaWPeAwIYSlZYv2/xvJu35hM25Omg+bVBXUbMeXpuXp/3IzPAHmDe8xK/JhpijInowJVOPHkf/mP5pyYZZ9ZPDXL/6x2Zu3tRa9k6fWqB1DP7sS+LsxN32LB+ss7J/sUhgFJQrq2Y+WxlA6UxnHI96hip0fE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=UbMrueYk; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=CrKqB8Am; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="UbMrueYk"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="CrKqB8Am" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64I7e7Rv2892861 for ; Mon, 18 May 2026 09:23:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=eF0aOw/ne8U OJ7hbYAxIT1oxXliCf3HbLnmolxKozDc=; b=UbMrueYkgjyXRAPARDJN9oW3Hip DoLN6N7sThhrT1fUs1HFTl7ECWgUpmXWdBt6Wx69gAE/TqzwBa10Y89V010+aRfg IlsVDdo0qlkBakE9U5Gmkyl0/pf3KtqxD1GISta05W31mxE0fv9/YTrmq9pBR2Mt aYBnEKaTFuTMcXK3IL3SB85z1elno2zQiBEQySVSYmFuRMviIgi4V6hZx5AmfIFU gTOkqDDd/KCKwqqef+46fuvmEhl9CBA8GjLuTuX/fVJK4YUBjPDeVWM1b/JqFF0B Q7/3kXb7Pp1m0m7Uzq11IgGbWDOQSyQFq9utqtTRO9TvHkfD+PlBjZUXADw== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e7xk18efn-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 18 May 2026 09:23:57 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-5165d10e036so42058671cf.3 for ; Mon, 18 May 2026 02:23:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779096236; x=1779701036; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=eF0aOw/ne8UOJ7hbYAxIT1oxXliCf3HbLnmolxKozDc=; b=CrKqB8AmBsUmHbC8cMkGb9Y3TWZMutpcz8HNvh/K3B4i+UiOo6SGMWDIPfjnHefWdP uxY0MH40cI1mOrN2yvoYhpxwFDDfLV608lRN8TIGllM58a+aFo2cai0e1T9tfpC4SMIy KvphCC5OOVrpBkC92N70lEIDFxgIdd+iiNh5aCUa9abTgvYLazXgLaaEaq//43trUaG8 CCIxLRlnPfDq/5gUFZ9FmBuyUbrCG5y9VHZ/XsAYYI7KlVbm0G+PV9G1KVPd33nAf3Wx c1nMxI8ZFgDoxs6axOQo1pHoUOC9lWCyJLc7x8lTyWxbOuqUhXDOQWEbsAZt+hz8Hymb rCSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779096236; x=1779701036; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=eF0aOw/ne8UOJ7hbYAxIT1oxXliCf3HbLnmolxKozDc=; b=fuYUNE4vmzkQ97Mrelm1ZH64TYo+lPHCMFo2moYNCAzbxZ0wH+mhNGVKHEHRufTPxl 0kI74jYWbpfTr7oom0F+7T+P1vEtZTuob5xMt3bC8xlDh7McoDcBTRKMo3GpQku+KQuV qdBQwtNfob5UNysFqPfoS8kAQnilj2hqPIzndt40NcMx6ANG/gy6yL8zXg3hpntLCLTj pS+pBiMFat6usAhaainMWvm/xJEQxBi8bZzYJ7u/yPOTYWDDletSDfkcW/1d8MqAaW5k gxk3sNyv+TavN/ZSaPO6YYEX78s6qGeEsqoJuxTbxN01wXOBhzc+yeEbfGKYS7AMNKvw puFg== X-Forwarded-Encrypted: i=1; AFNElJ8VZhgVjlzXHa48JyZln4lWDTJv38iM5DLG4/IodagyxQ9bLy8dyufkrmpVKubQrdYVJQJ2zmXIxcj+K5U=@vger.kernel.org X-Gm-Message-State: AOJu0YzuHHbq0lIUeyPIUpj3OIunX6Ja74KwCAGCdLuUwXsKCvfP9daU pZku4Eup1a2xSf1/l89WglYZLx3HnJXvGvouapejDzdxY0v94Ync2VB94DWp5fKuKrIfogVzUwM 3vJZoxXpo3qtvWZxCW1eYVYwi7Cl33G5L7apWor1EnqptAWeRz/QlXKlN2nFSvJT7bqk= X-Gm-Gg: Acq92OFzhqGeb0gXldWWqXEpLm2RlP95/Xd4Nu6M8kV3u7/KupjHYq+HnvmfQ4bWPN0 L7hg+bNaRXYP9Ms5c0EjxSsOs1k3R/YoYAfGjbCH0VMHvaA+onMCkrxMghgGuqZ3B5PBo7U3YSB C3qe2fsws2vI+HJavAK/pWCku1V9ogMKKh8KVbKgq0bClMER8F19R6QWYupUDD9tMl0LXTaIu+i nSCsNEkjQ9uc177Fi9fz3CrSUYd1E+jLdCjFOr9B5fPCI35R6+o3nm3oKRRNr2euJhB2ZRwhfQ9 +/VoknfxxhKuL0nxzwaFU7dN9VElTXjAaR/vP38LaFASPbax37mjmOe+7W27x5hIqNM/zbksC84 N77WRXFSWzyGuYw0n4ldBdFswnNHbC/eZpAR3j/arRKwpwEm3jmgWAVrUwQTjPuBYag== X-Received: by 2002:a05:622a:430f:b0:50f:ae24:ecdb with SMTP id d75a77b69052e-5165a276492mr152146961cf.37.1779096236358; Mon, 18 May 2026 02:23:56 -0700 (PDT) X-Received: by 2002:a05:622a:430f:b0:50f:ae24:ecdb with SMTP id d75a77b69052e-5165a276492mr152146761cf.37.1779096235788; Mon, 18 May 2026 02:23:55 -0700 (PDT) Received: from localhost.localdomain ([5.133.47.210]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45da0fe0fecsm33265900f8f.26.2026.05.18.02.23.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 May 2026 02:23:55 -0700 (PDT) From: Srinivas Kandagatla To: broonie@kernel.org Cc: jens.glathe@oldschoolsolutions.biz, linux-sound@vger.kernel.org, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, val@packett.cool, mailingradian@gmail.com, Srinivas Kandagatla , Stable@vger.kernel.org Subject: [PATCH 3/5] ASoC: qcom: q6asm-dai: fix error handling in prepare and set_params Date: Mon, 18 May 2026 09:23:45 +0000 Message-ID: <20260518092347.3446946-4-srinivas.kandagatla@oss.qualcomm.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260518092347.3446946-1-srinivas.kandagatla@oss.qualcomm.com> References: <20260518092347.3446946-1-srinivas.kandagatla@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: HgV25Y8wN5QrqwkPUdiPpf89VgWh6wPJ X-Proofpoint-ORIG-GUID: HgV25Y8wN5QrqwkPUdiPpf89VgWh6wPJ X-Authority-Analysis: v=2.4 cv=BICDalQG c=1 sm=1 tr=0 ts=6a0adaad cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=ZsC4DHZuhs/kKio7QBcDoQ==:17 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=D1n_lw8EissL0yZ26mEA:9 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTE4MDA5MCBTYWx0ZWRfX4GZ9zQamxXlm RFitWhbUq6yiv9UHszQN5QHKpxKjio74suvX7oSxBC6XWV5MWAqxn4g3/rfB0YlX4XCakKgyVlK w6oAif7dFXWbcA6BcSqyzpP1IChTkCybz4Si2aGBlLw0tnAJQHwv9LO4U8sNZmnxWaZhnJMPclP wEWeiP1LgK9A7acGFS17vGzr2gK1dLTccls3bGh8V/4i5DrD+hBKMjblDvqPluzwN57aTBLkjb7 yiwq0K9wSyBmvXxlvzMtiCBAkGAMI4pVbCs718vwTgWeG/CJDgnTQ8QvHGZdqUkH5sqyOavQpIA i5mDD+SYm0qFpP8Xe1SYLB/kEU5j2r4RaEMUE8jzoTaPQPyKWSFsIws8ZEVeoOcGrdq1KMx8g7s 1tnKLwy7cEqcoB9SB036pG1IE4+4HPc/l/X+Pl6g+nPHER2n2MMS8avtDHumW/QWiYhIy1HOdcf Z5U2SkUgGgDATU5RIdA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-18_02,2026-05-15_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 spamscore=0 lowpriorityscore=0 malwarescore=0 suspectscore=0 priorityscore=1501 impostorscore=0 phishscore=0 clxscore=1015 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605180090 Content-Type: text/plain; charset="utf-8" Fix error handling in q6asm_dai_compr_set_params() and q6asm_dai_prepare() for both CMD_CLOSE and q6asm_unmap_memory_regions(). In both the functions, we are doing q6asm_audio_client_free in failure cases, which means if prepare or set_params fail, we can never recover. Now open and close are done in respective dai_open/close functions. Fixes: 2a9e92d371db ("ASoC: qdsp6: q6asm: Add q6asm dai driver") Cc: Stable@vger.kernel.org Signed-off-by: Srinivas Kandagatla --- sound/soc/qcom/qdsp6/q6asm-dai.c | 24 ++++++++++++++++-------- 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/sound/soc/qcom/qdsp6/q6asm-dai.c b/sound/soc/qcom/qdsp6/q6asm-= dai.c index ef86b5b9a951..fd691004a657 100644 --- a/sound/soc/qcom/qdsp6/q6asm-dai.c +++ b/sound/soc/qcom/qdsp6/q6asm-dai.c @@ -226,9 +226,19 @@ static int q6asm_dai_prepare(struct snd_soc_component = *component, /* rate and channels are sent to audio driver */ if (prtd->state =3D=3D Q6ASM_STREAM_RUNNING) { /* clear the previous setup if any */ - q6asm_cmd(prtd->audio_client, prtd->stream_id, CMD_CLOSE); - q6asm_unmap_memory_regions(substream->stream, - prtd->audio_client); + ret =3D q6asm_cmd(prtd->audio_client, prtd->stream_id, CMD_CLOSE); + if (ret < 0) { + dev_err(dev, "Failed to close q6asm stream %d\n", prtd->stream_id); + return ret; + } + + ret =3D q6asm_unmap_memory_regions(substream->stream, prtd->audio_client= ); + if (ret < 0) { + dev_err(dev, "Failed to unmap memory regions for q6asm stream %d\n", + prtd->stream_id); + return ret; + } + q6routing_stream_close(soc_prtd->dai_link->id, substream->stream); prtd->state =3D Q6ASM_STREAM_STOPPED; @@ -296,8 +306,6 @@ static int q6asm_dai_prepare(struct snd_soc_component *= component, q6asm_cmd(prtd->audio_client, prtd->stream_id, CMD_CLOSE); open_err: q6asm_unmap_memory_regions(substream->stream, prtd->audio_client); - q6asm_audio_client_free(prtd->audio_client); - prtd->audio_client =3D NULL; =20 return ret; } @@ -912,7 +920,7 @@ static int q6asm_dai_compr_set_params(struct snd_soc_co= mponent *component, prtd->session_id, dir); if (ret) { dev_err(dev, "Stream reg failed ret:%d\n", ret); - goto q6_err; + goto routing_err; } =20 ret =3D __q6asm_dai_compr_set_codec_params(component, stream, @@ -938,11 +946,11 @@ static int q6asm_dai_compr_set_params(struct snd_soc_= component *component, return 0; =20 q6_err: + q6routing_stream_close(rtd->dai_link->id, dir); +routing_err: q6asm_cmd(prtd->audio_client, prtd->stream_id, CMD_CLOSE); =20 open_err: - q6asm_audio_client_free(prtd->audio_client); - prtd->audio_client =3D NULL; return ret; } =20 --=20 2.47.3 From nobody Mon May 25 05:55:53 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 481923E5EDD for ; Mon, 18 May 2026 09:23:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779096241; cv=none; b=ccC8iu5VOp1VI9fN+35DPULyGmsS6bxA7q97kWQgHKA0bNH1t0yZI6ttKqN3M9/+88lYJpwlCccFaabqyfOtYcMi6kokODqahE+PRPsI1F76Q4HNLpBzr3N/FlRmYN15fiLopqAejwWHlAVw+SHkiMwc3epKZuWnVnJ7nibAQ6w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779096241; c=relaxed/simple; bh=ZygEn0EETQGqYGeHUWtAH/6JmsqAEExRFa3DDJxxyDI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=XKBwUOM50jSrWQpuG4XpYTMwiC3DqVzBQadz4mI817X0TJ9K6eGyA849LmxDhFEGTaSVoz3y3Iz8TloCob68ZGUqrwsomjdIGojRxmgdnNbW1bc/aEWDn6HNNsyfhYsnqKR35kWKqNw7pZe7msiar/Ylp2L6yN19oG+seZZaSpE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=bDV6s7SK; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=bpfVB8T9; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="bDV6s7SK"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="bpfVB8T9" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64I8FchI2444106 for ; Mon, 18 May 2026 09:23:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=fcKyMgNIlAn wWT1JTHrlq9inj+SGc4L28t2ADtCeMQ4=; b=bDV6s7SKHuIlUgZWt2rrYvB6Ei3 iREAyzldM+vRMMxNypLteb1tkyKUP1K17m7A1pKp9O0tvaLk2NRp6dt2YmdvSqqV PIOjRbiSAvWZthzB4zhSlx8KD1r0cFoILIp+9sD35sPX6vXtLxjamOZkLlB/K1h2 igblBXQZbDnYSid+2ZsS/2EGdI4kNodvDnOG+uEBauVjXNK4kx0IJTwJFsfcnQtD lJ+C/c7vJZtESgo3/Saz/N68KeSOCz3yncm4oe3jTBB7obF2Ah2nN88BfI0XGwu3 ipDf5JJjTM9oCELTH4r1yXCP2Ejdm/NkYhMGCnJ2QJQLpKCHRLiA21UOWMw== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e6gx6wpdy-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 18 May 2026 09:23:58 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-5162ee45a77so56680431cf.1 for ; Mon, 18 May 2026 02:23:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779096238; x=1779701038; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=fcKyMgNIlAnwWT1JTHrlq9inj+SGc4L28t2ADtCeMQ4=; b=bpfVB8T9YtS8vCrz0WLHkqwL9cltDr6SQpZ2mU4dE/uE4qx90pn5UYPO8Qaxztz33F wiGIHd5XS7vzsLIymFg6iwsgt2P0dLNIZFrYEeZ6tI/ixiYtOY8tFQwW1oFbF/xAeq6J KAJKlomtuTuf6hNANQIIVxd4gvFpqXNcFqT5DjtYGcZR/KbAzuFBgc4oGd/fWwNgQpnD /A+dYI3xhwGjjAppEqji94wSq8hOx2sPSxYWnnBWE7V5hbUa9ZCzgesDw0zgyWVSb3bZ bEoalxwDnHkhyssyb1ArMgzbzV1gsgKqZYt4Uj2aZkK+WAn7BPCdtMbZQxnRGEr2hjm0 n7cQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779096238; x=1779701038; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=fcKyMgNIlAnwWT1JTHrlq9inj+SGc4L28t2ADtCeMQ4=; b=SN9+AR3GF3M9dQTjYi1XFrRxnO+RRaaoo/JTMHd+Rhk2iUhxlfNlWQhKipxpaGVBt9 GqYQmAvmQ3XlgCYU4U3bwvUNQzIuiNRP2KQPJiJ5gwe/jTHeIG7WLSB1UznLXPQaVf/v BzcWGFgL2rC3iezKCoIHxM3uUDeSxJ7ijkQKf253q3xjoqqNw2IvtP1tjbCFp45ThBBi 2zYk58tlT6QUfbr8jm2k2p503kCM1n8XDaf7dubj0jyOY8ZGDONUmbbNVURRJhX+9mfe J6JljOgQVDGzwQIUzPXPHMJKiZ98zM9FsYy/I3N24TIvkTng7xEKeoeL55BiVmotuA3a ik3A== X-Forwarded-Encrypted: i=1; AFNElJ++URwKfMvs+g4q1FZ4RQ+Scb1Y/i1+6LkktNoepKi/VV81W8ls+UglPLkolW3ZOg+KzgTQtqWN4GF/skY=@vger.kernel.org X-Gm-Message-State: AOJu0YxNdS4kiyRbHXUGNtN3YAhAkF9f4VYmD6QYPI9QRMYtndcrcRIS 7mIR477jRWLdaA4Kh/qBlSJPLaqGzkHqubSZTS9JssT9odLln3KqGUhq0eyvEIF8pn2u8kVm/x3 qmSYVOhyxQLEqAmkAS+ZTzTIPysDMfPetZUdLIlvhVSynEXekjqTzGQeba8JVduMnE5U= X-Gm-Gg: Acq92OE/j+w/J8aDeJn2LQaatCQLJj09zDWST+O8htf8+ABtczWSNvDVDV3Zk/PtsVZ sZJ2cuVPqQwkZt0wpzsvhytMU9ru3czRA9IM6DicB5b0e4/aQyvJn3VMFl12aUPqVDtuIMP+5lR XHQkHWt6NJzYkeSGfzxp8gs2zdtBLcOll9hZ7it0gvklXVitRwN1BWIT6446eKRWi3g5Jg7By6z EJe4i+UzuLF/f7SSX9i4hlF/aIGVpGKIlRsBWZYL+GL5mXKmKi6V3f6RpYv0sPmgfbSzKadbRo6 R9ZzJObosViky6eGXGRNXQkrwRD3cpVN0S8wCoSzGkmh2dbbXh6bmd8YbFnIqCckFo/WVRpXXSU pV0s+Wm+xshJb7q3/ElDCT9vZQA5YX2pMMJpgaE1n4cj5dr/Bo5/cay4= X-Received: by 2002:a05:622a:1f16:b0:50f:bc57:d69 with SMTP id d75a77b69052e-51659ed0e67mr188582871cf.0.1779096237541; Mon, 18 May 2026 02:23:57 -0700 (PDT) X-Received: by 2002:a05:622a:1f16:b0:50f:bc57:d69 with SMTP id d75a77b69052e-51659ed0e67mr188582571cf.0.1779096237068; Mon, 18 May 2026 02:23:57 -0700 (PDT) Received: from localhost.localdomain ([5.133.47.210]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45da0fe0fecsm33265900f8f.26.2026.05.18.02.23.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 May 2026 02:23:56 -0700 (PDT) From: Srinivas Kandagatla To: broonie@kernel.org Cc: jens.glathe@oldschoolsolutions.biz, linux-sound@vger.kernel.org, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, val@packett.cool, mailingradian@gmail.com, Srinivas Kandagatla Subject: [PATCH 4/5] ASoC: qcom: q6asm-dai: remove unnecessary braces Date: Mon, 18 May 2026 09:23:46 +0000 Message-ID: <20260518092347.3446946-5-srinivas.kandagatla@oss.qualcomm.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260518092347.3446946-1-srinivas.kandagatla@oss.qualcomm.com> References: <20260518092347.3446946-1-srinivas.kandagatla@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-ORIG-GUID: 4EGvxpg1-n-1ZlS2MLmSe7Gy2YT6imrI X-Authority-Analysis: v=2.4 cv=f614wuyM c=1 sm=1 tr=0 ts=6a0adaae cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=ZsC4DHZuhs/kKio7QBcDoQ==:17 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=_k_GUD08GHZRIojl7QgA:9 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-GUID: 4EGvxpg1-n-1ZlS2MLmSe7Gy2YT6imrI X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTE4MDA5MCBTYWx0ZWRfXxEgJ0CpMz9vJ n+zrWTEgGFUIDUVJEHbKQ2VlvpSDjdncYPL8SX5Vz4yA5lgY8qjFN4lWdS4R6JaaoM5MPUbRe/M PsZfLkRv9rxkwZT6q6MLgq4CGF0aIapNtinv4C3GEDujF3KXB5MBKR5EGkLcU37ZF7iKfG66iBK IUsb3tHe2ioGd6OKd8UHgoXcSR0GttAffJ7lezul8mK5uTRTTlT0TjMcfXm1n7dYj2r5aodLcKq Hnu80vNX+9Qk2/8+3LzXfAgQ2fjjoXy0+HgO1UAxbqp0FzsWzbVb5NfpX4MGdixVGS1RP2RrIq4 xGKT916TecqEVrS4f6kqzmKdLcdtA6NQ3dUCSgoyl77ZiFpthxwbhoWQEoPYV92LwUfuAdEDvvf xn3jjtzMRNcu/YzfcMjvczk0vP5w+qBm5DHZx8BugXN98o9E5tH5xR87QRuINI0uPPkSdjO20Q1 Z0bG3fKIdLD93OC1b1Q== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-18_02,2026-05-15_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 adultscore=0 bulkscore=0 clxscore=1015 malwarescore=0 spamscore=0 suspectscore=0 impostorscore=0 phishscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605180090 Content-Type: text/plain; charset="utf-8" The ASM_CLIENT_EVENT_DATA_WRITE_DONE case does not declare any local variables or require a separate scope, so drop the unnecessary braces. Signed-off-by: Srinivas Kandagatla --- sound/soc/qcom/qdsp6/q6asm-dai.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sound/soc/qcom/qdsp6/q6asm-dai.c b/sound/soc/qcom/qdsp6/q6asm-= dai.c index fd691004a657..5774c2611197 100644 --- a/sound/soc/qcom/qdsp6/q6asm-dai.c +++ b/sound/soc/qcom/qdsp6/q6asm-dai.c @@ -187,10 +187,9 @@ static void event_handler(uint32_t opcode, uint32_t to= ken, break; case ASM_CLIENT_EVENT_CMD_EOS_DONE: break; - case ASM_CLIENT_EVENT_DATA_WRITE_DONE: { + case ASM_CLIENT_EVENT_DATA_WRITE_DONE: snd_pcm_period_elapsed(substream); break; - } case ASM_CLIENT_EVENT_DATA_READ_DONE: snd_pcm_period_elapsed(substream); if (prtd->state =3D=3D Q6ASM_STREAM_RUNNING) --=20 2.47.3 From nobody Mon May 25 05:55:53 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8EEF83E5594 for ; Mon, 18 May 2026 09:24:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779096245; cv=none; b=s8ZCk3v41ka67rFuNnR6zqn6OI3GtNOsQFQVKI+ZnlfqwlhGHCIHKGvfwvPaZ10FvCyFqdgTtWUQaNltKYcohPC1Hsjg2VA26WvTS2vAwgBpx5hA5gO3nbVdDtBlHSaUfjnc3aEnGLv/WeSHHuGwlPNW37X4d5u3pMFRCcS9BC0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779096245; c=relaxed/simple; bh=yQnj7TVBLDmn2Qy5AALoRYVF8NDQjV3Fde9VEu7Oq1I=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=pDNhdTV1eGfxC25iTkdQIQLzt5Mz+N87YsKQ8K8qfSwrwyFelAfZSOw+a8iJCiYN9gvLVG60yRAqPsR/ThkfbltfGuLTMJFBf5Fudhs8w1YE4bI8LmMZn5ueXWzEaErpWNRhNKaD6VbgY4YfvEB3zGzoAEzn6Dy5jalKsDnaWSc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=kgxHecbt; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=EdmwoB+c; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="kgxHecbt"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="EdmwoB+c" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64I5YgOw2685076 for ; Mon, 18 May 2026 09:23:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=LE2VOebIUqd tVT8e2EHlDsCGbbYuRW4p5TNYl9S0wKY=; b=kgxHecbtnCluImfLYNf3hMtcMj6 PRwuIwFQdp/Cg2skHd8ggwRrve79d0Ep1htRbJ4SXeJZeVP6IftMYlgegY9OFA6f 8giW5bw1SComsQbgW4MlbBHJhaHSrA6I5luu1R+QTyFIdGFKIFHzx5lBGJ9aWUbq oMfWPBldDZWFZOjIedLIkzs8TEJB9enb2/U/kYIWg+IqrORScAScIOGIU/RyB3t8 6202SSo+iB4bv6/bWRH8I0BPzxWvUQFicYdRV+NF+7zxRkoGy3YDMpojzEL1Y4t0 KmsrmCGpwmhfW00mP4PjgJcMPBgnV9L+ALtOTnUoqL9W/d46KX9s4n0roOQ== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e7vrbs055-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 18 May 2026 09:23:59 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-50faf575af4so60834591cf.0 for ; Mon, 18 May 2026 02:23:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779096239; x=1779701039; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=LE2VOebIUqdtVT8e2EHlDsCGbbYuRW4p5TNYl9S0wKY=; b=EdmwoB+cctq53xwjMUqGmuKs3hDM3UP54otxODf8+mzDlrM501zdvvKu5Mt3uO20iX pNOlcWH/8MxanZvg5e+cXKSpa63rTWD9N+ixXFHk2+gOmx0Nfj2Q1twyrpsjXK0prkMO HVs0gwUMXgOR4K3jzQ6WxAbzIxlwv/qwJy6tK2u7eUBjwGI/hz8fMIZ5M0lf6lR4I/YV ZdVQ6adBGQpHN9dbrOa8DuzF/oEdUjkykZodidothNpRlbWgNPKJQOMyZ/lOYvvjWpKW 2iJcOJofnUalnbK1Hoxks9Iln1lJ01uyJfd4imkWVvlRqWTQxH1KEZ4hyrRlkhzb22kh cF8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779096239; x=1779701039; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=LE2VOebIUqdtVT8e2EHlDsCGbbYuRW4p5TNYl9S0wKY=; b=Xq1qPNmvrXSZuNNCMZd6PKZ5HUYdf9mD9fDYc7T4OAFcbfGrUh5VrjXwkdinfd+AXp 58HHZwgFP8FgFBHCBsSnKdosQYIGFGOsNk8DORaBSnDmvf0TLDCXTeIqvzQZlWdzzevA /6JjjdrUcsZwRNMe04BTF3n3anRWpLYmkcxqyEwXE6Ho8E4P6zFx9wnnsO1QP/iJ0Aom rbnMDKtvof0XtCMWlgnCJZrn2pguvK+pmFEZHSfcHsR3O9JElAJ+SwShlSEqPUvpFZCC vDSOZ3RwMbVmZWiVFk+5bbDY647rAbm5DOHH3SStrdVh4NwYhqXYVcWhwZIhXPIuUK39 Pb3g== X-Forwarded-Encrypted: i=1; AFNElJ9VwnS+XOg8S5DFBnATT8CiKvLaHs4+hHqd/thjQosMbruot7id6Xfw3B9H8OIfywXRkluLDAJpw5CNiow=@vger.kernel.org X-Gm-Message-State: AOJu0YwABhNoj0R7/ZR7lA6zettqg8rIVg1PxGMw4tmVss9kw9LHb9iS b9LcBgr+KZ9IqIUJXrKCH/WKDHR/m8MocCKcriioMOR7BUoRilypE/UDe3nTCZW7WjleIlFQyAo Spb5lfxIxzpS9ZAD+w4oC8Ab5ihHQKHBbjWLCBF+AU/qP9CvmzHRuar72PPL90zsdhjE= X-Gm-Gg: Acq92OE/sy+sLv+27sYj4DMOi3NNH+9eY/kYQOX6lCYU70pd575K5HnVjPfqpClW3Jc SR35vL8sTgKA9dAXnH1WXBa2CB/mIv+tfETEbDSXTAfEp+ELN7lGH9kzxY1TdaiC5wHE28cYPlQ NQ/cEIzHPIQwoPUmGuJFR5FCzViIv8DSqmNAABcFuMwCGWeaNbDP2AuZs3iNpAgEFbQ9pEmgVe/ sOCu1Ii/cGzlAk64Gq5UYq8h6+40zY2DTs3YP7FGrviszDKwYdiWUijc72TEKB/wFl3mAmZSP56 7zAk0hZgfZRnQhVq7eNgg1L8nxEEvo8NYuQkIrgTy6KaObQk1pnjp6jeSQXXwMU3Qna+L96USJB qGx2lxFN0EZV8GljYi3iS2S5jA5MMViIu+V120jq156cVBgiUtZqGRZM= X-Received: by 2002:a05:622a:a911:b0:50d:a644:699d with SMTP id d75a77b69052e-5165a219a81mr162055711cf.46.1779096238616; Mon, 18 May 2026 02:23:58 -0700 (PDT) X-Received: by 2002:a05:622a:a911:b0:50d:a644:699d with SMTP id d75a77b69052e-5165a219a81mr162055511cf.46.1779096238246; Mon, 18 May 2026 02:23:58 -0700 (PDT) Received: from localhost.localdomain ([5.133.47.210]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45da0fe0fecsm33265900f8f.26.2026.05.18.02.23.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 May 2026 02:23:57 -0700 (PDT) From: Srinivas Kandagatla To: broonie@kernel.org Cc: jens.glathe@oldschoolsolutions.biz, linux-sound@vger.kernel.org, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, val@packett.cool, mailingradian@gmail.com, Srinivas Kandagatla Subject: [PATCH 5/5] ASoC: qcom: q6asm-dai: use pointer type with kzalloc_obj() Date: Mon, 18 May 2026 09:23:47 +0000 Message-ID: <20260518092347.3446946-6-srinivas.kandagatla@oss.qualcomm.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260518092347.3446946-1-srinivas.kandagatla@oss.qualcomm.com> References: <20260518092347.3446946-1-srinivas.kandagatla@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: qmUJcgaxdvdxrl5VDWzbAeDG-0XCL-Wi X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTE4MDA5MCBTYWx0ZWRfX2og/NsvEo4gk Sr3V7QPJm/PSGN+D8PHx98iF01IDZvmTAjWUqk33/8KCQwM7r/ioEzNtSx9JA1xoyIGeihhXryj ZjcOWVNJI9mNe6B+QvTx6JJ3iGnSBkq3oOo6GjV+RHNwg2JjsLiqwhhhfyzutKfjNm3Of3D5eF6 sG3eGAw3DXf62uQlBOdcwHAdaz3uYAWYlekaz9kpIGzh2bECcnp9hXCGRAr8CH2Zc1nn/2OQcCh FwA3yUP34QHBLInss7vIq2zrENSiBSI43XEjwOI/8pRuFk5Ar7gTG6AE4c/Znd4IGsagnjET8ch xGbsAOcdp0ejJ1UN4OBoTzm1eOlYRDK89i01cZC17dyk5OcbjSrKC0EHvIkwD+HbbYSj/KjEI1I DcNcKj5FmjX9tXMUE4qQvLQu0NhhkpEPifDL2noQB104jMjQqmDurFBCX9/Mt0WfYg9hEnDoAeN zQEVxvAYfzMErw6LGTg== X-Authority-Analysis: v=2.4 cv=KZ3idwYD c=1 sm=1 tr=0 ts=6a0adaaf cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=ZsC4DHZuhs/kKio7QBcDoQ==:17 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=Ka70VOZtGcZw4ZCj8HQA:9 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-ORIG-GUID: qmUJcgaxdvdxrl5VDWzbAeDG-0XCL-Wi X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-18_02,2026-05-15_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 suspectscore=0 phishscore=0 priorityscore=1501 adultscore=0 clxscore=1015 spamscore=0 lowpriorityscore=0 bulkscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605180090 Content-Type: text/plain; charset="utf-8" Use kzalloc_obj(*prtd) instead of explicitly naming the structure type. Signed-off-by: Srinivas Kandagatla --- sound/soc/qcom/qdsp6/q6asm-dai.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/qcom/qdsp6/q6asm-dai.c b/sound/soc/qcom/qdsp6/q6asm-= dai.c index 5774c2611197..4f09fdd40905 100644 --- a/sound/soc/qcom/qdsp6/q6asm-dai.c +++ b/sound/soc/qcom/qdsp6/q6asm-dai.c @@ -383,7 +383,7 @@ static int q6asm_dai_open(struct snd_soc_component *com= ponent, return -EINVAL; } =20 - prtd =3D kzalloc_obj(struct q6asm_dai_rtd); + prtd =3D kzalloc_obj(*prtd); if (prtd =3D=3D NULL) return -ENOMEM; =20 --=20 2.47.3