From nobody Mon May 25 09:57:54 2026 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DE8643E3153 for ; Mon, 18 May 2026 08:26:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779092772; cv=none; b=P+6PTi/He85YNXnWPcvLbI31WT8oneqshZUbGAJ+vROZdis0czn2mxIjKQ1VkH/UDjlRE7KmXRtIEXaCJYnPYRwKAPHWHigm14C8Eiw+FrrcYSJpgrirJ9ZxS1mNrJJCgDTZli3Yl9JBdb20JEcgygA0GEYuaj85LUqdoil41Sg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779092772; c=relaxed/simple; bh=ZDLOyJOswmo5RlyF6Yu298Y8xMNBbTt2rTJK+rV5gis=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version:Content-Type; b=QrA6iTn1v5e9V2/Q6sEzGurhenztb+yQyDfz10KNQYwW366JYWhjjjVYaQPPkquBYg4XWlA+j6kACFXYp3+53HyqgRWbpIaF+JiVp3gmN7quPY7AF+8aOhshJkN3JRZSZ7iGOUiB2ZnJS2BDv7o+spXahMg+vAH5ZqhTwyGXqSM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QC/y0LZl; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QC/y0LZl" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-488af96f6b2so21917565e9.0 for ; Mon, 18 May 2026 01:26:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779092769; x=1779697569; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=If39ClIckMydOmcpj07jcbSov5r81Hv5FFSYom+H+B0=; b=QC/y0LZljriaOuCoOsyw5IhoDRiChN6l6qnvOdAiBljSLh/Mv7m0yMOJsum1Hsb611 GzM94S2FHK38LnGWrUMv34AB28LVNrg7RPtRIaPecGH/XBWkfCBPV5eGGxkiyiLLC339 W4NooG0Kx6sz6tmKKqvPWtRVAUOOk85nugbVwSAStxBq5h+Yw97wPODsOGTMkVhPU3k1 zTN6im/YOhH9Gr1rtp86QwjDWNAgPNYqjQiJE/x6uhArlvYcFllUXG89Wo9JPVOcD+yM MQCyAY6V+sdiphyB1DEuE8c+W8Ot7QwzGydX77WRJbhN6Rz75jTDe9ozPm2s/WLfaKuq 9tAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779092769; x=1779697569; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=If39ClIckMydOmcpj07jcbSov5r81Hv5FFSYom+H+B0=; b=YHOhvRY8eT/sfx9aBakbXTE235VkHS3BkWHZhDbT8ou1EeJlAPqmOMICGMOIKAY6uh y15+PeVPOQ2hUYZJJEy8CogWWActMAFGIfMhp4tasQMfRzwATKsnqUTXo8eZEPD/TRk4 gXtzTVCujHff6Ddsx6yOSpmB1x7g/3hCvcjDT/ZgIPBmOYa/895q2KXx7qkXh6B6KOc5 qIs9zD0A90lWDeFXpk/KvTWz26VkMMtKicmofKNHxgLrpfPjqJyQIGikDoyswOLpVl+o wleMqEZwLGuVz4ncbeF4j5rd7pPZyW1keJPeoSU4DUjvDCL3s10o/dGkNjh1+3pz4/nM g8DA== X-Forwarded-Encrypted: i=1; AFNElJ9n+/hRga4YWcbd8EX4eQE2/PA2L6hFszWifb3AkCNJfuiOy7p/O2H27fAT2vnWxKsVO7BtyDEpCtvtrWc=@vger.kernel.org X-Gm-Message-State: AOJu0YwgA0qRPru36rRvGVUgXfwAYTrg8aT+ToSpFbSM9aJqAyjBHu3z CgBs0tc+271/1PF0GeGOyZ/fbchEyKAel4f3o6Rjb70LnwCkmuV8V9Fg X-Gm-Gg: Acq92OFS4cuiWg5Vuzp/nLpRmnNgy+JJ1avqixYrI0WlcwwBGYHcbSaByItfoqXYuY6 zm06zkuqeIJvIxveiTMqSF308JoMiQWMr4vj1sD+tERv3ageqJnHoVpHgwH0RA/q5lriPVT5f0f qYfFz7lU0gzS/Z9W7N7w7nhSjO2GL4eCfbsuZoLo00Crgqfl1WexDyOSdBD/oDbFTta3R/qA4KQ Zt9c9ts5uIEEjXkACDWraG+MW5s/WaD3sdsnZpa1sCpbA1WJbDj1vX9kBrQtpQJTtde8imP4xeX I631axbtPDgIBfAvZ1pArCTfI8fH8mwF7kZcu2o+98+MstEBAPxkcdSeHpP/OWuMHwQbEoiRtap qRqI3hwkzo31+1lRXIIcGQYAvRR2VKRbuShF1ocfQq9SAgUMzyrCmpYk5mTz/mneCnX5COJ1035 HA8SoPtvjMREk87i8JdCCYNcX1tkn9xkdRa6ayHCK8yyc= X-Received: by 2002:a05:600c:8905:b0:48e:5d91:cffb with SMTP id 5b1f17b1804b1-48fe60e7d6emr173167515e9.10.1779092769255; Mon, 18 May 2026 01:26:09 -0700 (PDT) Received: from localhost.localdomain ([41.116.1.81]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45d9adc2209sm32834085f8f.0.2026.05.18.01.26.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 May 2026 01:26:08 -0700 (PDT) From: =?UTF-8?q?G=C3=BCnther=20Muller?= To: steffen.klassert@secunet.com Cc: =?UTF-8?q?G=C3=BCnther=20Muller?= , Herbert Xu , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] xfrm: fix missing headroom check in xfrm_dev_direct_output Date: Mon, 18 May 2026 10:23:30 +0200 Message-Id: <20260518082330.11483-1-gunther.muller2008@gmail.com> X-Mailer: git-send-email 2.39.5 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Ensure the skb has enough headroom for the hardware offload device's hard_header_len. If the headroom is insufficient (e.g., when routing through certain virtual or tunnel devices), __skb_push() underflows skb->data below skb->head, causing silent memory corruption. Fix this by using skb_cow_head() to dynamically expand headroom if needed, and switch to the checked skb_push() variant. Fixes: 5eddd76ec2fd ("xfrm: fix tunnel mode TX datapath in packet offload m= ode") Signed-off-by: G=C3=BCnther Muller --- net/xfrm/xfrm_output.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/net/xfrm/xfrm_output.c b/net/xfrm/xfrm_output.c index cc35c2fcbb..35f974d209 100644 --- a/net/xfrm/xfrm_output.c +++ b/net/xfrm/xfrm_output.c @@ -649,7 +649,10 @@ static int xfrm_dev_direct_output(struct sock *sk, str= uct xfrm_state *x, * to netdevice. */ skb->dev =3D x->xso.dev; - __skb_push(skb, skb->dev->hard_header_len); + err =3D skb_cow_head(skb, skb->dev->hard_header_len); + if (err) + return err; + skb_push(skb, skb->dev->hard_header_len); return dev_queue_xmit(skb); } =20 --=20 2.39.5