From nobody Mon May 25 09:56:49 2026 Received: from out-174.mta0.migadu.com (out-174.mta0.migadu.com [91.218.175.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 820EA381C4 for ; Mon, 18 May 2026 07:39:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779089976; cv=none; b=t3u06wWe/qvek3N1xJbnLilJggjcYHmuWrQLu3xqkn0Hb9p7s9bc0tK16XLx/8zPJRQdfVLFWRAY+fy7OgpTLRl6aY66TyAh4Vmr8qD4UE3nvPOdc4zRv3UdZkdO0BXDRrQaHjK11Kd4PDM6zRlvoex/w8mwhcnFmHspXShy4H4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779089976; c=relaxed/simple; bh=PsvpaOiLWPDgUnJ2TSsBJL323TZYhkkewYe75m3ukKw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=CobSa8RT4pDy516qmH9U1k7HZ/nw7T8niKnCJj9E9JmkSb/XJ8yBfvEnRlw5NgBQMzshgqQWhvO/Ga6RYgxDrI0cVpB4a85c0tuD4Tt2HKepwnKlcN9rjhXWnLR/8hrwFtbdOg8oq4HSIOVYATDZq1DVqNG+XAvkVzj4jBs/Mto= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=ck39mhSs; arc=none smtp.client-ip=91.218.175.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="ck39mhSs" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1779089963; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=EvOhjXrTEhaGFgkEgCnzjTZP4SlNBCOU1PI5l4LuI7g=; b=ck39mhSsM29mbAw83FQnkQeAYi4caLkb6o45OhC9n5zqZGfLX9Bh60QtQM4b3zFRXJxahj zp7la6iy2IusI0q9wWcVYMy4mR3RDbgVlJOGG96cvIFu3v2JlttZ4shPHUW2KGnXgRifys MuFH2BtPmSY+04Z4/9e/tDshW+3EhOM= From: Thorsten Blum To: Tyler Hicks Cc: ecryptfs@vger.kernel.org, linux-kernel@vger.kernel.org, Thorsten Blum Subject: [PATCH] ecryptfs: use kasprintf in ecryptfs_crypto_api_algify_cipher_name Date: Mon, 18 May 2026 09:38:45 +0200 Message-ID: <20260518073842.57501-4-thorsten.blum@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1426; i=thorsten.blum@linux.dev; h=from:subject; bh=PsvpaOiLWPDgUnJ2TSsBJL323TZYhkkewYe75m3ukKw=; b=owGbwMvMwCUWt7pQ4caZUj3G02pJDFlch5hWXJLYqWous+rus7TN0/ct92/Q+LWH/9OVVf9f9 ev+2z2ztKOUhUGMi0FWTJHlwawfM3xLayo3mUTshJnDygQyhIGLUwAmEsHJyLDm33afnz++Rd/a Lxb0ZaPh6xvvF7/8dOycyNpKy6JJ+4QnMPyVPb3M7dy1mBT+B+pXozbW3Gw//XXxz7CF1/bs+zf h/fnZvAA= X-Developer-Key: i=thorsten.blum@linux.dev; a=openpgp; fpr=1D60735E8AEF3BE473B69D84733678FD8DFEEAD4 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset="utf-8" Use kasprintf() to simplify ecryptfs_crypto_api_algify_cipher_name(). Use const char * for the read-only cipher name and chaining modifier while at it. Signed-off-by: Thorsten Blum --- fs/ecryptfs/crypto.c | 24 +++++++----------------- 1 file changed, 7 insertions(+), 17 deletions(-) diff --git a/fs/ecryptfs/crypto.c b/fs/ecryptfs/crypto.c index 5ef67b2674ee..74b02b55e3f6 100644 --- a/fs/ecryptfs/crypto.c +++ b/fs/ecryptfs/crypto.c @@ -49,25 +49,15 @@ void ecryptfs_from_hex(char *dst, char *src, int dst_si= ze) } =20 static int ecryptfs_crypto_api_algify_cipher_name(char **algified_name, - char *cipher_name, - char *chaining_modifier) + const char *cipher_name, + const char *chaining_modifier) { - int cipher_name_len =3D strlen(cipher_name); - int chaining_modifier_len =3D strlen(chaining_modifier); - int algified_name_len; - int rc; + (*algified_name) =3D kasprintf(GFP_KERNEL, "%s(%s)", chaining_modifier, + cipher_name); + if (!(*algified_name)) + return -ENOMEM; =20 - algified_name_len =3D (chaining_modifier_len + cipher_name_len + 3); - (*algified_name) =3D kmalloc(algified_name_len, GFP_KERNEL); - if (!(*algified_name)) { - rc =3D -ENOMEM; - goto out; - } - snprintf((*algified_name), algified_name_len, "%s(%s)", - chaining_modifier, cipher_name); - rc =3D 0; -out: - return rc; + return 0; } =20 /**