From nobody Mon May 25 09:57:53 2026 Received: from n169-111.mail.139.com (n169-111.mail.139.com [120.232.169.111]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7261C3803C2; Mon, 18 May 2026 04:24:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=120.232.169.111 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779078295; cv=none; b=q2yxvLsXfYB4hQe5B6BWoCPAexC0U5Enx9yDw+hFkDYn5sP3ZxLldyiYwRjGnjLivjdHLrTFSJk8nEeWsbf00RLJYsHOXzUa+n2CCZmFX/QQbq7ZM6fAZOCuX7sLYJCUQbvrB81Loq0u7+EZZP5g/91DDeTUG01uT2IpWENAlnA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779078295; c=relaxed/simple; bh=2kGfG/QFvpPuYLFnnCltNJVHsYdYT4CVHgSM1heSi48=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=uGRskFLihECWxKeS3+XB4dupTXfDgK3Py0XOK7pDrA3mNvOsH0V9zaw1z0swczicw8A9R5QYeL1uJXSUQctkYQnX+0KCLqgvTuy4OMaXsG0/Pm+Vj+VcqSKPaF0yD2ov7M8ZgMYh3dPa9B37JQPPmxl0nW1i4l4II/30edRsCcc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=139.com; spf=pass smtp.mailfrom=139.com; dkim=pass (1024-bit key) header.d=139.com header.i=@139.com header.b=H4Ku3cn8; arc=none smtp.client-ip=120.232.169.111 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=139.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=139.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=139.com header.i=@139.com header.b="H4Ku3cn8" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=139.com; s=dkim; l=0; h=from:subject:message-id:to:cc:mime-version; bh=47DEQpj8HBSa+/TImW+5JCeuQeRkm5NMpJWZG3hSuFU=; b=H4Ku3cn83CTvT0gGZdYHzvuqWw6KTlM+WopubAziz5I/KBY1fniKCMV7FA0hF5pEsi5aHjB0ilAYa coGxvAqE5Xipay5z6ofVBKPkwx/6tqKvw1vqgv4kHV97Z6STkYM+2wTYZXa1nCx7ZvNW9dRXwYm8Va mhSImpoFcXNDeXJM= X-RM-TagInfo: emlType=0 X-RM-SPAM: X-RM-SPAM-FLAG: 00000000 Received: from NTT-kernel-dev (unknown[60.247.85.88]) by rmsmtp-lg-appmail-15-12004 (RichMail) with SMTP id 2ee46a0a93d4435-0144e; Mon, 18 May 2026 12:21:41 +0800 (CST) X-RM-TRANSID: 2ee46a0a93d4435-0144e From: Li hongliang <1468888505@139.com> To: gregkh@linuxfoundation.org, stable@vger.kernel.org, viro@zeniv.linux.org.uk Cc: patches@lists.linux.dev, linux-kernel@vger.kernel.org, almaz.alexandrovich@paragon-software.com, ntfs3@lists.linux.dev Subject: [PATCH 6.6.y] ntfs: ->d_compare() must not block Date: Mon, 18 May 2026 12:21:40 +0800 Message-Id: <20260518042140.489545-1-1468888505@139.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Al Viro [ Upstream commit ca2a04e84af79596e5cd9cfe697d5122ec39c8ce ] ... so don't use __getname() there. Switch it (and ntfs_d_hash(), while we are at it) to kmalloc(PATH_MAX, GFP_NOWAIT). Yes, ntfs_d_hash() almost certainly can do with smaller allocations, but let ntfs folks deal with that - keep the allocation size as-is for now. Stop abusing names_cachep in ntfs, period - various uses of that thing in there have nothing to do with pathnames; just use k[mz]alloc() and be done with that. For now let's keep sizes as-in, but AFAICS none of the users actually want PATH_MAX. Signed-off-by: Al Viro Signed-off-by: Li hongliang <1468888505@139.com> --- fs/ntfs3/dir.c | 5 ++--- fs/ntfs3/fsntfs.c | 4 ++-- fs/ntfs3/inode.c | 13 ++++++------- fs/ntfs3/namei.c | 17 ++++++++--------- fs/ntfs3/xattr.c | 5 ++--- 5 files changed, 20 insertions(+), 24 deletions(-) diff --git a/fs/ntfs3/dir.c b/fs/ntfs3/dir.c index 6b93c909bdc9..894fd44164b4 100644 --- a/fs/ntfs3/dir.c +++ b/fs/ntfs3/dir.c @@ -425,8 +425,7 @@ static int ntfs_readdir(struct file *file, struct dir_c= ontext *ctx) if (!dir_emit_dots(file, ctx)) return 0; =20 - /* Allocate PATH_MAX bytes. */ - name =3D __getname(); + name =3D kmalloc(PATH_MAX, GFP_KERNEL); if (!name) return -ENOMEM; =20 @@ -504,7 +503,7 @@ static int ntfs_readdir(struct file *file, struct dir_c= ontext *ctx) =20 out: =20 - __putname(name); + kfree(name); put_indx_node(node); =20 if (err =3D=3D 1) { diff --git a/fs/ntfs3/fsntfs.c b/fs/ntfs3/fsntfs.c index e17d4c1ba06f..a38547bd12bb 100644 --- a/fs/ntfs3/fsntfs.c +++ b/fs/ntfs3/fsntfs.c @@ -2666,7 +2666,7 @@ int ntfs_set_label(struct ntfs_sb_info *sbi, u8 *labe= l, int len) struct ntfs_inode *ni =3D sbi->volume.ni; const u8 max_ulen =3D 0x80; /* TODO: use attrdef to get maximum length */ /* Allocate PATH_MAX bytes. */ - struct cpu_str *uni =3D __getname(); + struct cpu_str *uni =3D kmalloc(PATH_MAX, GFP_KERNEL); =20 if (!uni) return -ENOMEM; @@ -2709,6 +2709,6 @@ int ntfs_set_label(struct ntfs_sb_info *sbi, u8 *labe= l, int len) err =3D _ni_write_inode(&ni->vfs_inode, 0); =20 out: - __putname(uni); + kfree(uni); return err; } \ No newline at end of file diff --git a/fs/ntfs3/inode.c b/fs/ntfs3/inode.c index ce381eafd084..787e15ba0ca4 100644 --- a/fs/ntfs3/inode.c +++ b/fs/ntfs3/inode.c @@ -1327,7 +1327,7 @@ struct inode *ntfs_create_inode(struct mnt_idmap *idm= ap, struct inode *dir, fa |=3D FILE_ATTRIBUTE_READONLY; =20 /* Allocate PATH_MAX bytes. */ - new_de =3D kmem_cache_zalloc(names_cachep, GFP_KERNEL); + new_de =3D kzalloc(PATH_MAX, GFP_KERNEL); if (!new_de) { err =3D -ENOMEM; goto out1; @@ -1733,7 +1733,7 @@ struct inode *ntfs_create_inode(struct mnt_idmap *idm= ap, struct inode *dir, ntfs_mark_rec_free(sbi, ino, false); =20 out2: - __putname(new_de); + kfree(new_de); kfree(rp); =20 out1: @@ -1756,7 +1756,7 @@ int ntfs_link_inode(struct inode *inode, struct dentr= y *dentry) struct NTFS_DE *de; =20 /* Allocate PATH_MAX bytes. */ - de =3D kmem_cache_zalloc(names_cachep, GFP_KERNEL); + de =3D kzalloc(PATH_MAX, GFP_KERNEL); if (!de) return -ENOMEM; =20 @@ -1770,7 +1770,7 @@ int ntfs_link_inode(struct inode *inode, struct dentr= y *dentry) =20 err =3D ni_add_name(ntfs_i(d_inode(dentry->d_parent)), ni, de); out: - __putname(de); + kfree(de); return err; } =20 @@ -1793,8 +1793,7 @@ int ntfs_unlink_inode(struct inode *dir, const struct= dentry *dentry) if (ntfs_is_meta_file(sbi, ni->mi.rno)) return -EINVAL; =20 - /* Allocate PATH_MAX bytes. */ - de =3D kmem_cache_zalloc(names_cachep, GFP_KERNEL); + de =3D kzalloc(PATH_MAX, GFP_KERNEL); if (!de) return -ENOMEM; =20 @@ -1830,7 +1829,7 @@ int ntfs_unlink_inode(struct inode *dir, const struct= dentry *dentry) =20 out: ni_unlock(ni); - __putname(de); + kfree(de); return err; } =20 diff --git a/fs/ntfs3/namei.c b/fs/ntfs3/namei.c index f5901c23ab93..1b0c075c1485 100644 --- a/fs/ntfs3/namei.c +++ b/fs/ntfs3/namei.c @@ -68,7 +68,7 @@ static struct dentry *ntfs_lookup(struct inode *dir, stru= ct dentry *dentry, u32 flags) { struct ntfs_inode *ni =3D ntfs_i(dir); - struct cpu_str *uni =3D __getname(); + struct cpu_str *uni =3D kmalloc(PATH_MAX, GFP_KERNEL); struct inode *inode; int err; =20 @@ -85,7 +85,7 @@ static struct dentry *ntfs_lookup(struct inode *dir, stru= ct dentry *dentry, inode =3D dir_search_u(dir, uni, NULL); ni_unlock(ni); } - __putname(uni); + kfree(uni); } =20 /* @@ -304,8 +304,7 @@ static int ntfs_rename(struct mnt_idmap *idmap, struct = inode *dir, return err; } =20 - /* Allocate PATH_MAX bytes. */ - de =3D __getname(); + de =3D kmalloc(PATH_MAX, GFP_KERNEL); if (!de) return -ENOMEM; =20 @@ -350,7 +349,7 @@ static int ntfs_rename(struct mnt_idmap *idmap, struct = inode *dir, ni_unlock(ni); ni_unlock(dir_ni); out: - __putname(de); + kfree(de); return err; } =20 @@ -497,7 +496,7 @@ static int ntfs_d_hash(const struct dentry *dentry, str= uct qstr *name) /* * Try slow way with current upcase table */ - uni =3D kmem_cache_alloc(names_cachep, GFP_NOWAIT); + uni =3D kmalloc(PATH_MAX, GFP_NOWAIT); if (!uni) return -ENOMEM; =20 @@ -519,7 +518,7 @@ static int ntfs_d_hash(const struct dentry *dentry, str= uct qstr *name) err =3D 0; =20 out: - kmem_cache_free(names_cachep, uni); + kfree(uni); return err; } =20 @@ -558,7 +557,7 @@ static int ntfs_d_compare(const struct dentry *dentry, = unsigned int len1, * Try slow way with current upcase table */ sbi =3D dentry->d_sb->s_fs_info; - uni1 =3D __getname(); + uni1 =3D kmalloc(PATH_MAX, GFP_NOWAIT); if (!uni1) return -ENOMEM; =20 @@ -588,7 +587,7 @@ static int ntfs_d_compare(const struct dentry *dentry, = unsigned int len1, ret =3D !ntfs_cmp_names_cpu(uni1, uni2, sbi->upcase, false) ? 0 : 1; =20 out: - __putname(uni1); + kfree(uni1); return ret; } =20 diff --git a/fs/ntfs3/xattr.c b/fs/ntfs3/xattr.c index 72bceb8cd164..a03b4bce5fbf 100644 --- a/fs/ntfs3/xattr.c +++ b/fs/ntfs3/xattr.c @@ -551,8 +551,7 @@ struct posix_acl *ntfs_get_acl(struct mnt_idmap *idmap,= struct dentry *dentry, int err; void *buf; =20 - /* Allocate PATH_MAX bytes. */ - buf =3D __getname(); + buf =3D kmalloc(PATH_MAX, GFP_KERNEL); if (!buf) return ERR_PTR(-ENOMEM); =20 @@ -583,7 +582,7 @@ struct posix_acl *ntfs_get_acl(struct mnt_idmap *idmap,= struct dentry *dentry, if (!IS_ERR(acl)) set_cached_acl(inode, type, acl); =20 - __putname(buf); + kfree(buf); =20 return acl; } --=20 2.34.1