From nobody Mon May 25 09:56:44 2026 Received: from mail-dy1-f196.google.com (mail-dy1-f196.google.com [74.125.82.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 20FCF405C49 for ; Mon, 18 May 2026 02:41:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.196 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779072064; cv=none; b=lU94m8LhIn9iY140M6clV8oOSDjnbcCSq37FL6AiYpPXAWxBe163E2VKqji3qOjmg0C2+SPNUGStRw+BL63K/wFlspvbjyP4QtCVownSgSPDiK6hMhnhSql6L+iXDjBkH8cKutHf3fCMW2lE88XagcQPb2tryIaU/RaUMelOV5U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779072064; c=relaxed/simple; bh=DFfhHio2stg7Owp/K89LqNRuKupdAZGfcTq6GOKJWxc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=I7HlRyJnOgj3sr6A27FJ/B29e98/tAkbqRrlGtZ/ruksefxHkIr+vVEOh/7sm0S/SgwhivCegmSdalwWkpx8gvEXsJE/iQYX3NpVWUrSAuWx/BIZBD3ZvoUiHqbhZ363YAT5xBYYs45/SgWcrYgqj9Hn9hwsyL04V/WnV6LFt9E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=od9udfti; arc=none smtp.client-ip=74.125.82.196 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="od9udfti" Received: by mail-dy1-f196.google.com with SMTP id 5a478bee46e88-2f7ca62a3c4so1503543eec.0 for ; Sun, 17 May 2026 19:41:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779072062; x=1779676862; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=ZkVweKMoSdI85cubZOQgniTBESiwe3e+6vJ5f2S/Hv4=; b=od9udftiRMXXmN7Uf4jDIGzf3ttUhBdh4hv/0lLB4ZgHgrAlHIjouULqoI8HljLdzI EwZSUFDHZY0L8OU3+laXsngtBUuZdWoxv6enPAT/lrd0OpfCoGrl+uyOk0SKwufvkof4 wb2ZcmPNKCpbUO4JPjom48fPJTH2CDsKHjmwi0+wNmDM/ltdmwcSLmx2ELwU6l236fkS pAQX7KH0z7bo6lg/QurCmuTfTlgDPXzy76ma0n5B14YfTitBF5wukPAWYAb5Q6IIBilJ jj1bJ0I73xIasaQwfD/saYq3kgIAF72/DHV/LJDSbVrqDK9szvj8d23m61mVqvedH8Mm LYMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779072062; x=1779676862; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ZkVweKMoSdI85cubZOQgniTBESiwe3e+6vJ5f2S/Hv4=; b=n+VosUqEaO4S9gsu9DNvWtod0CGgBgtzDklCfP0ZGpp42U65SuHbm/E5UdQ1S+P0SK woqdnZZ+z8lKhhnVhaJb1Lf7KhryZl/iH95m9lRV6thJT0e7tuCzmuCArdFNO9h4TUTK OD7amu82M9aqyL5m6rca17E8+uhW9i3ngxNQkNToLvBIjcKGs99mN39YD39JXn1MnVvl qRbT3rpDmCwfAsTp1FxLRk26dirkw43fuWoUF63QhSMwTzm0Xx+HOepZMWc4gqTnNzKU 6qmNkl7OqVHIYkuM4uDR5bxrHcL4b4b4qnlldPTm4kNTshWGIvCJhBptwSbLJtKTuMZG rLzA== X-Forwarded-Encrypted: i=1; AFNElJ/KJXVLvaoEW0DJdUIgb22bzKzorOCz447giBMwpfV65wz/cHb0HPtsYlwj7BAFwIPgfKQxhla8ufXpFHY=@vger.kernel.org X-Gm-Message-State: AOJu0YxzQO6o2VMBt/LkCZkzxTkVEaVlUZQNi4ixF2gRyshCTvsNNjUv xZKBAnmCvSWgV+DlH9wIhKQATWS8gIvRMMBG/zXtfogaW+Tq/OhbMH39 X-Gm-Gg: Acq92OG+u7xwJGrTp+78HFvLi5Sbb1Hhf6bOZuAZ6NcIF72QAWYW7ilOkjLf3gOOE12 9Krkad8+NZbxClw+Xkg1/mZHdstvwl02k4GGtoEFCSs34DA/d8HApPGuOZo+pF+xukxNtfePbpl 4+j72Z/RY4kyMPZHrwzx7HlRnOk2jXsYi8/fJh7bpRmjmeii3Gg+ZoxsO+1iCM7U7UukGA0MAxG hLxX1338tM8n22ps2/9grZ14r/eS/sFca/MvBBbEQfjNeK8IpGF77s9BiHMQNLkUod5oYeJYtzk XUQ9gfPJJF4DpxvaNvuZl7DjzjC1f8UptWIuI+M0OqgyIEH3uZyFrs037kQ95q+2U/yyP1We5f0 WGwjyDYZx9u+stoj5cpQhiOa47OkquoarQGpyx9zsvoMFMLhAsoKixrBmoFk2UfBvzWC7Wzcquh NMySmIXHPu8errTVqGCWp02hIO/0TaQTK1KPWtgYpjuELrGdmmaJoDM4WFCL6lY6lNMWsbeIsg8 vecWaO1pStes5gjMRLgutJv4EfxJgueDyxDBjC/l/ZJkHqmwWeCAOuLvFMqfthvKTZJFt6tE+9t myMSZjO6Vy8a1cXBgfJgGM7+6HO+xotoZQrxXUw= X-Received: by 2002:a05:7300:d706:b0:2d9:f0b3:1d98 with SMTP id 5a478bee46e88-303982860f0mr5402573eec.7.1779072062179; Sun, 17 May 2026 19:41:02 -0700 (PDT) Received: from ethan-latitude5420.. (host-127-24.cafrjco.fresno.ca.us.clients.pavlovmedia.net. [68.180.127.24]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-302978b3cb2sm16356144eec.30.2026.05.17.19.41.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 May 2026 19:41:01 -0700 (PDT) From: Ethan Nelson-Moore To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Ethan Nelson-Moore , Russell King , Linus Walleij , Thomas Gleixner , Bartosz Golaszewski , Greg Kroah-Hartman , Kees Cook , Arnd Bergmann , =?UTF-8?q?Adrian=20Barna=C5=9B?= Subject: [PATCH] ARM: remove the last few uses of do_bad_IRQ() Date: Sun, 17 May 2026 19:40:45 -0700 Message-ID: <20260518024051.189979-1-enelsonmoore@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The do_bad_IRQ() macro simply calls handle_bad_irq() with a lock around it. It also carries a comment stating that uses of it should be replaced. According to commit aec0095653cd ("irqchip: gic: Call handle_bad_irq() directly"), which replaced another use of do_bad_IRQ(), locking the IRQ descriptor is not necessary for error reporting. Therefore, replace all uses of do_bad_IRQ() with calls to handle_bad_irq() and remove do_bad_IRQ(). Signed-off-by: Ethan Nelson-Moore Reviewed-by: Linus Walleij --- arch/arm/common/sa1111.c | 2 +- arch/arm/include/asm/mach/irq.h | 10 ---------- arch/arm/mach-footbridge/isa-irq.c | 2 +- drivers/irqchip/irq-versatile-fpga.c | 2 +- 4 files changed, 3 insertions(+), 13 deletions(-) diff --git a/arch/arm/common/sa1111.c b/arch/arm/common/sa1111.c index 449c8bb86453..a0f854cf4748 100644 --- a/arch/arm/common/sa1111.c +++ b/arch/arm/common/sa1111.c @@ -221,7 +221,7 @@ static void sa1111_irq_handler(struct irq_desc *desc) writel_relaxed(stat1, mapbase + SA1111_INTSTATCLR1); =20 if (stat0 =3D=3D 0 && stat1 =3D=3D 0) { - do_bad_IRQ(desc); + handle_bad_irq(desc); return; } =20 diff --git a/arch/arm/include/asm/mach/irq.h b/arch/arm/include/asm/mach/ir= q.h index dfe832a3bfc7..fdcd8388977d 100644 --- a/arch/arm/include/asm/mach/irq.h +++ b/arch/arm/include/asm/mach/irq.h @@ -17,14 +17,4 @@ struct seq_file; extern void init_FIQ(int); extern int show_fiq_list(struct seq_file *, int); =20 -/* - * This is for easy migration, but should be changed in the source - */ -#define do_bad_IRQ(desc) \ -do { \ - raw_spin_lock(&desc->lock); \ - handle_bad_irq(desc); \ - raw_spin_unlock(&desc->lock); \ -} while(0) - #endif diff --git a/arch/arm/mach-footbridge/isa-irq.c b/arch/arm/mach-footbridge/= isa-irq.c index 842ddb4121ef..48c7b3efd555 100644 --- a/arch/arm/mach-footbridge/isa-irq.c +++ b/arch/arm/mach-footbridge/isa-irq.c @@ -89,7 +89,7 @@ static void isa_irq_handler(struct irq_desc *desc) unsigned int isa_irq =3D *(unsigned char *)PCIIACK_BASE; =20 if (isa_irq < _ISA_IRQ(0) || isa_irq >=3D _ISA_IRQ(16)) { - do_bad_IRQ(desc); + handle_bad_irq(desc); return; } =20 diff --git a/drivers/irqchip/irq-versatile-fpga.c b/drivers/irqchip/irq-ver= satile-fpga.c index 034ce6afe170..6eaad836d9ff 100644 --- a/drivers/irqchip/irq-versatile-fpga.c +++ b/drivers/irqchip/irq-versatile-fpga.c @@ -89,7 +89,7 @@ static void fpga_irq_handle(struct irq_desc *desc) =20 status =3D readl(f->base + IRQ_STATUS); if (status =3D=3D 0) { - do_bad_IRQ(desc); + handle_bad_irq(desc); goto out; } =20 --=20 2.43.0