From nobody Mon May 25 05:54:12 2026 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 268322750E6 for ; Sun, 17 May 2026 23:49:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779061774; cv=none; b=S8Ose1SccxpcPdDe2XmVB/Mgfs47iPRpCpWlVJ8OktKuBgImPx0ZOxftrF9ZK/ky2tBAq+4l4Y25XHIIV1KMigmUxqvVdABs/d1D4XnoCuF+C8Jz/3p8eU6okWNRRY9V5zgeRBLgmSUlWKJuLHDxg+iJSVqb/I2xwmZHkS5bezQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779061774; c=relaxed/simple; bh=18r8WGr0sLy2v2ONuN/uyQDOzOFcYvt1CAOLrZySO8I=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=AX5UIMS9ROesmzRwb70bBA+R5XxMhVe62/fujjElnm3RM0v4/fGcD1+VsjnEYKGt17bWApcJD9i6stYLbQQKzPbjppLxWdUnsQFAivLoP8VenMmNFi+q4u9wrY9JRDe7uHFRZ8IX0qodnOobOY0uMLTAtfSwPskJveheTKj32S0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AbYGiYS8; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AbYGiYS8" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-43d75312379so1663262f8f.1 for ; Sun, 17 May 2026 16:49:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779061771; x=1779666571; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=q4JPW1ddnaHfBwPTUg/aODR+UFy3JRdz5SXqJfspXx8=; b=AbYGiYS8nkbo+JbSnshL6H+aBDgClnztbe+pd/QC8uUrJRU+dnJFtiIPFfAyfVjiui 47tpix7Zk/1Tp68LaGFvzZnrE6TUaTFQv9DemY3TeVSKCSasJkGwIqEG9U5xJOmRYTjN X/6Fyop7+EzgCBrukGNDBCkLZnq2PQrRMkDyirPg/olp1e57olXRqVd/xYdmllEoxesn V4+N3VyL4jeVMnuS76ua3BGCYEvfHv9FXhuNaqIK+Wdu20edGbbSp7vh8AEbmJ/QQ9+6 Jlpzv/dro3z/TNYU5v+o1ITHfZ+Kp3sKbTiEVW0YQywqLXFX0VXI/mqRU7mi8E2ple5o qkaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779061771; x=1779666571; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=q4JPW1ddnaHfBwPTUg/aODR+UFy3JRdz5SXqJfspXx8=; b=biDJyEL6b7DDLp7Cs3LYE7gkdFVhI3xAuQruqAoJWRZnkRdEhqKFNrImhH5wAQ+v4S 5qdyeR9XsmWapghPAA0gtGy2SutwHW4bAYp2TEQAuqQhJbAFSgogA/NkIHR1S3GV7LoO 4h3dFDGJJ1Cq4NnQ9/YHCn/y6d6pb+jjgkTHIk6mxH4PUZ9YSRzKK8u8bbRxYtYaBghb Ps4Yx38KXtLSlNXKBohgxYa7Kkm935KgbDcN1KMzU1/45twmJUQsRHty8b3zC1DVaZKy 2r8jxtFG1oMygxj7xXzv1RSpU4kI1mP/PWLQIjqZ4wCfZX6dp2I6AQe16OE9TmyqfDIc tldg== X-Gm-Message-State: AOJu0YyatSFeVTJTFF3SBLZ+ukYxNbebLPEuk2QtXee/jHb9AMnJIG4F 0zHITIaark5t+7LusWEgQ7EkQUUeLON5NV+atnW19r3r95jw50Q5s4k6 X-Gm-Gg: Acq92OHzALbZxZxuC9Hdb79BMDoaIS94VprqMU5Tyq2KNlF9YeDfxQFN5eCjtRyd/kx fhvxGNKIouz8gKjprVqRzrYRuGF2q2yKaLN4pyxd/wW5tJ1u0IOw/wGYM3C2rHAC+Mi17deMdVO 6EPqP39yZO6u/UH5+7hpUNnlX7EjeXgc7GWWzxa81Yxgj4uKXlQWphxf8BffRuwuL/uFnlJjz3R oX6rlOGWPsmW52ZW99yR/y8X3FGiFrhf0hvOFz/LJYA5lyY958DFDpd+ZlhepaomsSzefJXh+PY 3tuUxXjDjaqj8DY978lYo5JsZmYMIUfQ5gbsc8yQXkSDIyJ4TKLfnzQtf8J+C1yYo1kD+V6ctju VTw9RVnhcFlRTR01MfHZ2kk+JDp/iNnrDLRmgdwja9njLF+YABBuRnRSvAfZrIvvikjtWJ1TbEM J4kP2cRDwZC+NZ9lsYzdouobCg5kAe7oUqCgkPF1Xe+6hEA1RhBvBncwGgKvcmcxZU6HHb23+05 zwH2H7p9WGJ X-Received: by 2002:a05:600c:a406:b0:489:32b:ac0b with SMTP id 5b1f17b1804b1-48fe4fa1902mr154323275e9.6.1779061771345; Sun, 17 May 2026 16:49:31 -0700 (PDT) Received: from node ([202.47.63.86]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48febf86db7sm100133505e9.6.2026.05.17.16.49.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 May 2026 16:49:30 -0700 (PDT) From: Muhammad Bilal To: linux-bluetooth@vger.kernel.org Cc: linux-kernel@vger.kernel.org, marcel@holtmann.org, luiz.dentz@gmail.com, johan.hedberg@gmail.com, stable@vger.kernel.org, Muhammad Bilal Subject: [PATCH] Bluetooth: HIDP: fix missing length checks in hidp_input_report() Date: Sun, 17 May 2026 19:48:05 -0400 Message-ID: <20260517234805.116570-1-meatuni001@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" hidp_input_report() reads keyboard and mouse payload data from an skb without first verifying that skb->len contains enough data. hidp_recv_intr_frame() pulls the 1-byte HIDP header before dispatching to hidp_input_report(). If a paired device sends a truncated packet, the handler reads beyond the valid skb data, resulting in an out-of-bounds read of skb data. The OOB bytes may be interpreted as phantom key presses or spurious mouse movement. Add a check that skb->len is non-zero before the type switch, and per-report-type minimum length checks before accessing the payload. Signed-off-by: Muhammad Bilal --- net/bluetooth/hidp/core.c | 19 ++++++++++++++++--- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/net/bluetooth/hidp/core.c b/net/bluetooth/hidp/core.c index 976f91eeb..03838a6ff 100644 --- a/net/bluetooth/hidp/core.c +++ b/net/bluetooth/hidp/core.c @@ -179,12 +179,22 @@ static void hidp_input_report(struct hidp_session *se= ssion, struct sk_buff *skb) { struct input_dev *dev =3D session->input; unsigned char *keys =3D session->keys; - unsigned char *udata =3D skb->data + 1; - signed char *sdata =3D skb->data + 1; - int i, size =3D skb->len - 1; + unsigned char *udata; + signed char *sdata; + int i, size; + + if (!skb->len) + return; + + udata =3D skb->data + 1; + sdata =3D skb->data + 1; + size =3D skb->len - 1; =20 switch (skb->data[0]) { case 0x01: /* Keyboard report */ + if (size < 8) + break; + for (i =3D 0; i < 8; i++) input_report_key(dev, hidp_keycode[i + 224], (udata[0] >> i) & 1); =20 @@ -213,6 +223,9 @@ static void hidp_input_report(struct hidp_session *sess= ion, struct sk_buff *skb) break; =20 case 0x02: /* Mouse report */ + if (size < 3) + break; + input_report_key(dev, BTN_LEFT, sdata[0] & 0x01); input_report_key(dev, BTN_RIGHT, sdata[0] & 0x02); input_report_key(dev, BTN_MIDDLE, sdata[0] & 0x04); --=20 2.54.0