From nobody Mon May 25 06:41:05 2026 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 116532E7179 for ; Sun, 17 May 2026 18:10:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779041455; cv=none; b=cwb+5YrB+4x0BerkJGoEJdIqSf1TBtW2Z8eVMxjagiTye7WaneVIjItei5oDh2cbZv/sA3n5iPkD//djel6BfD1mHpkaC/pfDKvO0OoHOBY9c+bDa+uwwkD3AKpFMByhFCeKTkeUmkkHvv7TfnwVwSFiofAr5hltimtve7iAppI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779041455; c=relaxed/simple; bh=DkkdoOLUNnsiWTVFEPwYrf3bDQkuvu0J+zPC3NxuEBY=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=p9gkcdyKrHah1B8wUKhD2OK/uocgBiDTmsLuVao7ER4yN3PFra5wF4a8EPDNBm9v/HEzfJHQwwI6zZWxIqdMclioKjPi98QO5V4mXLwS/SOPSjMrGIIi5M8cugy6in7Pdl9gucxZyP1WzKZP+t6DYJbdeuFAoKrGG19iPkKZp8g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=iLOXj0Vv; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iLOXj0Vv" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-48fe6629235so1843455e9.1 for ; Sun, 17 May 2026 11:10:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779041452; x=1779646252; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=xsVwJO6jf7637HzPKQn0ozxs4bJowjYzN8lCpJYo0b4=; b=iLOXj0VvQmdUXSx0e9UMDTMhzSJdxzVgI71hlngZmBVhEKmpiqLDfvmncG1w4/yOKD 1VvQhA9nbsZuL65cuG+Mk+VT82yRzom3m/XUgLn9dus6YuY8jnSuVbwIg1vAfl/uBnbo 9uWYMKCUaAZLaWiMdedYxTkV4YACvt3J+pdb7VD9f0ySOArCBBKH5wxbkXBF8VAUeie7 tKS1/HqODpClSKpeqJL9kRgErGVEBxjPdXAOauwMhAGdXRlpPKM3TJo/S/0/JMPP2JtK eFGwBT7UTC4CHcmYK0o2pStxG0U+Cab/25z/x8vXA3d4ZQRTo0+uiJRAUiHVobT/yZqe SrYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779041452; x=1779646252; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=xsVwJO6jf7637HzPKQn0ozxs4bJowjYzN8lCpJYo0b4=; b=EyngZVh/VoEQJ0SSe9ptMkQr4oGHeYPrB88XIHqXC5mwDt603uhNo6ZgHYCZn6IIWk wA76MpSBifQJKvzSYKILeiVS6EdTSzo3p5odJL5iFue0AOQbcjf/EF7JzzlTftVmPhng lDhL9DpKeLo6s6erMr92sO78jUf7wts7O7lW6v24JWybXXkqRv8EbKjIGkg5ve+8P84e iAa+h52lNtD3yz/Zgf+gS3ZDtoBleOebBCxvUN+pb8qoIU3Ailkb+0QC6UiMuYO3x4eh gTwVTpmeDVy8fnqnK1U/V01vm0KJb1JTrW0k1hv/t4IYcm55m9rBnB3v+xskkx0LRnH8 sKTg== X-Forwarded-Encrypted: i=1; AFNElJ+ZgUhzRJE4fGsNiVaeOa34cEgoAyuDLck7cJE2Q/QlmolsVb2kqZeXz+/igPxA0HL6PZuKuedhwxslGKQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwFEEca5xFi+dE0jHshbKZaOhvoDpMbjtywajYoVGdQ+E1BZ0Bn AXelKXboJVQr1sDX5hvRHm9W0vEg8LlJ0URquIC0+r0bkzVHjJusCgop X-Gm-Gg: Acq92OF68Z6hMLTDZPZtyvMUCIjen1nTSrd7IIajPqwXU9HV8fuYgeVd7B6Z/kvnkDb EVQTVGzz/A/nPim64qiK7TVFkNuN4PYXqkzvfT1wb4RcBh1LJXvusbmQYCpj62Sd0kyKnXG2sfi YFpA0kgx7Dm50o3sLlg+2dPtuu8699tBYJ7lc/1SqeXZwulHIPV9+N3vj134BLtAsWKgTJFU/Lb 0hBu+krZVpvw615JqM7v5PDfVpwEJlaYqo7ocKzGd2s7+PIhILoWd8YEm0D+//yfNvrTGi8lkk0 cXz+Z29J7DsH+bKb9GxtpoyofDFdLErOPOk6xw+CJ5JFfKpU5amaUhBQqiwSS99oNmKtNTF15Ze IiUqJaDnQLhGZX4qF0PuB1oQiJ/VdkLFYZdUIhaN8JBfC7xdYKsApAMRCjIwnkxSjSsVmcy0oTC HrfvpMgVpAvPo/lmytA5r/tTDBtSIh7gRF6xSLYU9cAwoUBqBvmkSoe2A= X-Received: by 2002:a05:6000:1ac7:b0:450:4980:b4fe with SMTP id ffacd0b85a97d-45e5c57d063mr8988312f8f.2.1779041452398; Sun, 17 May 2026 11:10:52 -0700 (PDT) Received: from localhost.localdomain ([82.215.118.79]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45d9ed2ffdfsm28958322f8f.15.2026.05.17.11.10.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 May 2026 11:10:51 -0700 (PDT) From: Stepan Ionichev To: jic23@kernel.org Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, hcazarim@yahoo.com, gregkh@linuxfoundation.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, sozdayvek@gmail.com Subject: [PATCH] iio: light: tsl2591: return actual error from probe IRQ failure Date: Sun, 17 May 2026 23:10:42 +0500 Message-Id: <20260517181042.668-1-sozdayvek@gmail.com> X-Mailer: git-send-email 2.33.0.windows.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When devm_request_threaded_irq() fails, probe calls dev_err_probe() but then returns -EINVAL, dropping the real error code and breaking the deferred-probe flow that dev_err_probe() handles for -EPROBE_DEFER. Return the value from dev_err_probe() instead. Fixes: 2335f0d7c790 ("iio: light: Added AMS tsl2591 driver implementation") Signed-off-by: Stepan Ionichev Reviewed-by: Joshua Crofts --- drivers/iio/light/tsl2591.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/iio/light/tsl2591.c b/drivers/iio/light/tsl2591.c index c5557867e..4b0a2a302 100644 --- a/drivers/iio/light/tsl2591.c +++ b/drivers/iio/light/tsl2591.c @@ -1137,10 +1137,8 @@ static int tsl2591_probe(struct i2c_client *client) NULL, tsl2591_event_handler, IRQF_TRIGGER_FALLING | IRQF_ONESHOT, "tsl2591_irq", indio_dev); - if (ret) { - dev_err_probe(&client->dev, ret, "IRQ request error\n"); - return -EINVAL; - } + if (ret) + return dev_err_probe(&client->dev, ret, "IRQ request error\n"); indio_dev->info =3D &tsl2591_info; } else { indio_dev->info =3D &tsl2591_info_no_irq; --=20 2.43.0