From nobody Mon May 25 06:40:24 2026 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 47A893CAA39 for ; Sun, 17 May 2026 18:06:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779041211; cv=none; b=Hly94hvgncSHElgVLUGbCitssx5lKs/b9tEUARElnLdz7DCFR+zXyilQ9ZzMyDU0Wtpn60WGz08eMHOZio3N0jdVryhK2wO13xm1qg/9jexI5R92IbTtnboDVpnJsJwFjwTGFlOOK8XCN5lQDvjAlqzjQYIbEc37rr7IZbDkCDY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779041211; c=relaxed/simple; bh=q9vahDLeF0paWqfekbQjBqfdEH/373Mc1f3Pd2pMUUY=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=tiGi5NEPyGUnuAHywfympDWTnRtamdwPfURH4ESPUn1DFdGaAjVMdiiyh0TmSWd8+nim8ZFoxw8/QRAdaC2h68iqcE4456K0fTPx8l7vBKyyhB6ic0cYtXqKFnoAAcYvuwxZWuK23Vb/hZjxHKXtJHEjHdjhGBu5U5X7NYZNc/Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=qvNUMt+V; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qvNUMt+V" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-4891cd5927dso2085705e9.0 for ; Sun, 17 May 2026 11:06:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779041208; x=1779646008; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=UnEz4kb5yNtR6Ed+ZspZs0azXccaDtFZKA7zrYYeQpw=; b=qvNUMt+V6o2pPzgY7CCODkWCDvdzRKq+HJtFK3Np+JjgoGln3kZV/a9iYeL9dfjn7b 1fssLoZ1vcKgedZhs6raVDTwx54GX9VzBpPabFehFIUBc2HnEWQjoJVG9NpwqzRyuh0h VVVAqKD0ecoc3CB5hIdc+Lo3R5E2wmFB7wzHhuRLCEKY/8RJ4sKjHnMVgOzk/8MaE9KC pE1+PZ4R6rLHugDXk1T6cc4sniwrduA2RWjDHQ+EbRMrC70tw32RLAOm561UBZ7lnr9B FLDoutzfFFQRMmtKLCW/+/17W5INK/033/w0BzzRc5ARl0IhVhFzXpKA7L3gmcI9xAiQ wD4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779041208; x=1779646008; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=UnEz4kb5yNtR6Ed+ZspZs0azXccaDtFZKA7zrYYeQpw=; b=rQ/r9Mldiz8d/nLVGRZm09D1KLmbs7T5bMjRPFNw+mFAq578KaYxho8CnyG47ULj1+ sdLJpOwWmusqqQVZ481pK1iui4KK4uEWeXkxwwQROIbpooI58R30UL0NTU0YVPWcaGOL HPbVxDQsOtehZRF4uUcfMrzvmLSxqoebaY89bLRoLeZTY+llU+q3sw3eAu3uY7kj5dAY r0Nz/hDw9gtG1OxablPRQbuQqe1+WWOttyhJ/WzWzlbYyRUotdA9LxDzJYOEJv300UfU Ulrd0UGXU3efFCXBAUbMlU9CpIMqmK0je1DFx0X4qZd3GmcYeYJttywl7UgsVf7Tkxtk zMjQ== X-Forwarded-Encrypted: i=1; AFNElJ+yOUR+zSqyV6AYIzwD0xxn4Kutx5zw6kWbNgi2ORMJiFiiJNKN1Z0Dk4Q2xhxcSi2q/uoJaccAWzUHz4Y=@vger.kernel.org X-Gm-Message-State: AOJu0Yxa0GegcJcRcRIShlXq1kjKA0425zbWagS0lZB+IQzfb+tKTT4V W82XhPwRBAEPeLOu7LN+9Kuzsj95IlAd+PMExrf8+1LVx8t/Kxhvkvd0I/7Q1w== X-Gm-Gg: Acq92OF+AD9Ufc72NxT8/dBCPZoP6Mm7rDWxEAR850RJjAbuWvdVB3/Me37M0fW0lXs rTUIZrBo5wEYrVZxkTYG8NDGY/zXR8G8izikeYC9OPjElkrcSHfW+tEth2IvCwpqPQkN7pX6eZF VM6KFgbbORH5TtstqUk+o0LoMwDms201jKGQMU9Q5rEHbBhB/JeBPZGurDp3JJOhjJsM+cdF5XV OHJLKhziAZ0MAlYYS+9Zjfc6V9Djjp5yhbZem2AwSSTh7nGGwExsikODULnC3uTNyXRguKwFbL1 JdVsbda9ZTU09SwZRWVQQ5Zj4DS0I3tEMg43sSdsWxSpqaPe//XyIqdz8nzriyMUxhr2FZmDIhD gJ/QsRMDT+GaJlIp/Dj1++B6vYeQigZlqO2L0DOyBTARRmfrtFvVAHFxoWUUDj3EOpRxQDmz5RE Y7nHkmb+oEdDAtUIRwQG/IxDtxMej1oNwpr/PYZ3wlPmPnEm8fzqo87ViLf7QNTL8= X-Received: by 2002:a05:6000:29cf:b0:452:db27:b3ca with SMTP id ffacd0b85a97d-45e5c60a590mr5430759f8f.7.1779041206655; Sun, 17 May 2026 11:06:46 -0700 (PDT) Received: from menon.v.cablecom.net (84-74-0-139.dclient.hispeed.ch. [84.74.0.139]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45da15a6454sm31766775f8f.34.2026.05.17.11.06.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 May 2026 11:06:46 -0700 (PDT) From: Lothar Rubusch To: thorsten.blum@linux.dev, herbert@gondor.apana.org.au, davem@davemloft.net, nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com, claudiu.beznea@tuxon.dev Cc: linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, l.rubusch@gmail.com Subject: [PATCH] crypto: atmel - add capability-based I2C client selection Date: Sun, 17 May 2026 18:06:27 +0000 Message-Id: <20260517180639.9657-2-l.rubusch@gmail.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20260517180639.9657-1-l.rubusch@gmail.com> References: <20260517180639.9657-1-l.rubusch@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add capability filtering to the I2C client allocator to support feature-aware selection of hardware clients. Each client now exposes supported features via a capability mask. The allocator selects only clients matching the requested capability and still prefers the least-loaded device. ECC marks ECDH support during probe and requests matching clients during tfm setup. SHA204A exposes no capabilities for now. This is preparatory work for upcoming features that will extend hardware usage beyond a single algorithm type. Signed-off-by: Lothar Rubusch --- drivers/crypto/atmel-ecc.c | 4 +++- drivers/crypto/atmel-i2c.c | 5 ++++- drivers/crypto/atmel-i2c.h | 8 +++++++- drivers/crypto/atmel-sha204a.c | 2 ++ 4 files changed, 16 insertions(+), 3 deletions(-) diff --git a/drivers/crypto/atmel-ecc.c b/drivers/crypto/atmel-ecc.c index f877f236552f..0eeee9ae6c48 100644 --- a/drivers/crypto/atmel-ecc.c +++ b/drivers/crypto/atmel-ecc.c @@ -214,7 +214,7 @@ static int atmel_ecdh_init_tfm(struct crypto_kpp *tfm) struct atmel_ecdh_ctx *ctx =3D kpp_tfm_ctx(tfm); =20 ctx->curve_id =3D ECC_CURVE_NIST_P256; - ctx->client =3D atmel_i2c_client_alloc(); + ctx->client =3D atmel_i2c_client_alloc(ATMEL_CAP_ECDH); if (IS_ERR(ctx->client)) { pr_err("tfm - i2c_client binding failed\n"); return PTR_ERR(ctx->client); @@ -286,6 +286,8 @@ static int atmel_ecc_probe(struct i2c_client *client) =20 i2c_priv =3D i2c_get_clientdata(client); =20 + i2c_priv->caps =3D BIT(ATMEL_CAP_ECDH); + spin_lock(&atmel_i2c_mgmt.i2c_list_lock); list_add_tail(&i2c_priv->i2c_client_list_node, &atmel_i2c_mgmt.i2c_client_list); diff --git a/drivers/crypto/atmel-i2c.c b/drivers/crypto/atmel-i2c.c index 4beab68997c4..b7ee2ec37531 100644 --- a/drivers/crypto/atmel-i2c.c +++ b/drivers/crypto/atmel-i2c.c @@ -57,7 +57,7 @@ static void atmel_i2c_checksum(struct atmel_i2c_cmd *cmd) *__crc16 =3D cpu_to_le16(bitrev16(crc16(0, data, len))); } =20 -struct i2c_client *atmel_i2c_client_alloc(void) +struct i2c_client *atmel_i2c_client_alloc(enum atmel_i2c_capability cap) { struct atmel_i2c_client_priv *i2c_priv, *min_i2c_priv =3D NULL; struct i2c_client *client =3D ERR_PTR(-ENODEV); @@ -73,6 +73,9 @@ struct i2c_client *atmel_i2c_client_alloc(void) =20 list_for_each_entry(i2c_priv, &atmel_i2c_mgmt.i2c_client_list, i2c_client_list_node) { + if (!(i2c_priv->caps & BIT(cap))) + continue; + tfm_cnt =3D atomic_read(&i2c_priv->tfm_count); if (tfm_cnt < min_tfm_cnt) { min_tfm_cnt =3D tfm_cnt; diff --git a/drivers/crypto/atmel-i2c.h b/drivers/crypto/atmel-i2c.h index ba5a860011c8..70579b438256 100644 --- a/drivers/crypto/atmel-i2c.h +++ b/drivers/crypto/atmel-i2c.h @@ -115,6 +115,10 @@ struct atmel_i2c_cmd { #define ECDH_PREFIX_MODE 0x00 =20 /* Used for binding tfm objects to i2c clients. */ +enum atmel_i2c_capability { + ATMEL_CAP_ECDH =3D 0, +}; + struct atmel_i2c_client_mgmt { struct list_head i2c_client_list; spinlock_t i2c_list_lock; @@ -130,6 +134,7 @@ extern struct atmel_i2c_client_mgmt atmel_i2c_mgmt; * @wake_token_sz : size in bytes of the wake_token * @tfm_count : number of active crypto transformations on i2c c= lient * @hwrng : hold the hardware generated rng + * @caps : feature capability of the particular driver * * Reads and writes from/to the i2c client are sequential. The first byte * transmitted to the device is treated as the byte size. Any attempt to s= end @@ -146,6 +151,7 @@ struct atmel_i2c_client_priv { size_t wake_token_sz; atomic_t tfm_count ____cacheline_aligned; struct hwrng hwrng; + u32 caps; }; =20 /** @@ -190,7 +196,7 @@ void atmel_i2c_init_genkey_cmd(struct atmel_i2c_cmd *cm= d, u16 keyid); int atmel_i2c_init_ecdh_cmd(struct atmel_i2c_cmd *cmd, struct scatterlist *pubkey); =20 -struct i2c_client *atmel_i2c_client_alloc(void); +struct i2c_client *atmel_i2c_client_alloc(enum atmel_i2c_capability cap); void atmel_i2c_unregister_client(struct atmel_i2c_client_priv *i2c_priv); =20 #endif /* __ATMEL_I2C_H__ */ diff --git a/drivers/crypto/atmel-sha204a.c b/drivers/crypto/atmel-sha204a.c index 923e462ff6b0..1a28c6434669 100644 --- a/drivers/crypto/atmel-sha204a.c +++ b/drivers/crypto/atmel-sha204a.c @@ -173,6 +173,8 @@ static int atmel_sha204a_probe(struct i2c_client *clien= t) =20 i2c_priv =3D i2c_get_clientdata(client); =20 + i2c_priv->caps =3D 0; + /* add to client list */ spin_lock(&atmel_i2c_mgmt.i2c_list_lock); list_add_tail(&i2c_priv->i2c_client_list_node, --=20 2.53.0