From nobody Mon May 25 06:41:09 2026 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EC02530CD9E for ; Sun, 17 May 2026 16:15:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779034547; cv=none; b=OYScJ+sfQxEVXOLzyR8LLKG7NlatiTO5i3Zc/M8v7ndrwFuYFe6JlyvBDITCyeOdcKsMr5Hm8A5P+ZrrSMNdeN7JLtbgehjjCnNk8k8LWQwEaeiRBfIimQRgpuq8q47FZtdDMUJstiRnp/zKNqW/aCBzYLbowJ7GC/UKjerJGO4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779034547; c=relaxed/simple; bh=1L3zPpdK+XTaPDAZy33QIx+6Spr0ZSthXEqQgReNVoI=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=FpNsdtpGJWuh25UWsSqUW2soZhEdJ3sAtO15VEqFIEoZUghWM4jMv+zlQQYM4Ahz1wFrSjxhR9o4SDuMy+BZsHV1a928qEjUuaZ5VeN0JbCOm8Wj+8EnoKuOqo65EQqzwjnMlJst6zNVzUeowmh6XJVpfXlPGAmY+YMYMcSZOAk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=pVwQNc4a; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pVwQNc4a" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-4891cd5927dso2019445e9.0 for ; Sun, 17 May 2026 09:15:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779034544; x=1779639344; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=EAjpg+yPM1wXX0LTdZB7XKnnu66uLDhV1TDY4KTTlNE=; b=pVwQNc4ap8z/44HoBU/3O3HUCv6937/Jnvrajy9kSDp3auX7OfQytA4BZAGYt2MYx2 5eikIagiLcE9uImI0rip7PhjC87IQJNBtDjJ61/I7+5xJc20XLD+U6yXcGGodDVVWjLm 8xShv1Nt1hCI5ulLJ2yl9iFvTzoKo9sWjExSS5wAVOhLSt9Ov+KIeCIlMEKxjJNpmia/ TmFiNFOn7cMggYup9+7Yu3T5MrSv0lcjV543+vQ9xPBZ+UOialQNCPFhVJmiThlBudMS +HQcQfSqP667Z3thYEkpkBmTV24AfIaCqvjWylV0aOqjKJ5UcJrjsHAfmiMgJXf3czmw pazQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779034544; x=1779639344; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=EAjpg+yPM1wXX0LTdZB7XKnnu66uLDhV1TDY4KTTlNE=; b=G/3kdRJu8ga+Q7hmfxjwuPftUNRm/OJyZSnJ1Kr1kTdnMHSiHhCLNjyKoQyHrIbjJ5 16K0dIvECxYb1vVwwr8XkiIURpp6izHhhWvWvU0sg1goCOL5R57IzaqUkAZwgmA+dJ4J WdD//Q7uCy4JuuwwanW9ffzLEp9becWMCaVHFn2lOshQhYI4Jhv/2yBcxByUv2KjSAns 86y1yhMGCZwXaNhJz++SRAfvcJTygkpoUxrXe58qr8mn7SYPdF9dW0WCEe0oumaYYJoK hKB6gf7Lnpa8upmql4B6Kxkj8aJoYs+zPa6Y9/z3NM+DGvi10aaUHwjqjNvyzro6Mhk9 YvFw== X-Forwarded-Encrypted: i=1; AFNElJ8mLlgo/c7tFX2sb77pUz1u3qMOy1HzRlORfnHfVtQT14LEZbwOo3wCR1HQoUG58XRchc0DZC1hy0RrKZY=@vger.kernel.org X-Gm-Message-State: AOJu0YyzHhLO615qa0nmpVBsUeWYYul/uL5g+uE9JLKDkWUKG8Gim2+0 5D91j9epylu8jFFFBu0mz15gKcQqIy8dDz/mI88sMRSFL8OUiEqiuzUF X-Gm-Gg: Acq92OGw6POZncFfc7hMkaspu3IcYaUA3QFkGsLp2ywByaOpedOjxq9TDMSGhyIhhvc kgoltShdjzqd5M9qKR8++FNke720RhyZ7JrYFkx3ECCX2mW2EybQZwhFYUe9ttoo/3/S2+Qioq7 YpaM2XVLL9va+1Y0joDxP1x0h/wtb+FUGaF/smFJENiUzqqAFKvP2ORApf/Ur7zmDlNd7OZjBH2 JG1XG9j7T6YpNNm+glqNiJ1g6ID0tB5hNKmsGxjOS5gnnitrZRUsK9UaN0vWEiYWmoTkRlrWTyJ hRD3nzewCHf3aimmSBPoL1FbWDfo8Ltn5yhVX36nN3wtYeyxgBGlrL7ieqBF4JYI5ZmVjYPkGSE Z1w+P1ARDkpLOBhigmAAyc+09SRhnI52CNv7I1lY3eD8buVppOAQWD0Tr8zR7whffcp7DEMX5DR s21QGZ46DUvH58YzOV91kxUprNOqZZM/yaFQdZl2U3rnoa8D6p0v5XyC8= X-Received: by 2002:a05:600c:450c:b0:490:6ab:4063 with SMTP id 5b1f17b1804b1-4900d55aed4mr1429375e9.6.1779034544134; Sun, 17 May 2026 09:15:44 -0700 (PDT) Received: from localhost.localdomain ([82.215.118.79]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48febe6aff4sm62243015e9.25.2026.05.17.09.15.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 May 2026 09:15:43 -0700 (PDT) From: Stepan Ionichev To: andy@kernel.org Cc: mika.westerberg@linux.intel.com, linusw@kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, sozdayvek@gmail.com Subject: [PATCH v3] pinctrl: intel: move PWM base computation past feature check Date: Sun, 17 May 2026 21:15:30 +0500 Message-Id: <20260517161530.1037-1-sozdayvek@gmail.com> X-Mailer: git-send-email 2.33.0.windows.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Compute base inside intel_pinctrl_probe_pwm() only after the PINCTRL_FEATURE_PWM and CONFIG_PWM_LPSS checks have passed. Tidy up; no functional change. Suggested-by: Andy Shevchenko Link: https://lore.kernel.org/linux-gpio/aglu5jy5SbW9Wjwj@ashevche-desk.loc= al/ Signed-off-by: Stepan Ionichev Acked-by: Mika Westerberg --- Changes since v2: - Trim commit message per Andy. Changes since v1: - Drop the array zero-initialisation approach. - Move base assignment past the feature checks, per Andy. - Drop the Fixes: tag. v2: https://lore.kernel.org/linux-gpio/20260517154002.1994-1-sozdayvek@gmai= l.com/ v1: https://lore.kernel.org/linux-gpio/20260515150049.33761-1-sozdayvek@gma= il.com/ drivers/pinctrl/intel/pinctrl-intel.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/pinctrl/intel/pinctrl-intel.c b/drivers/pinctrl/intel/= pinctrl-intel.c index 97bf5ec78..2e2526e01 100644 --- a/drivers/pinctrl/intel/pinctrl-intel.c +++ b/drivers/pinctrl/intel/pinctrl-intel.c @@ -1556,13 +1556,13 @@ static int intel_pinctrl_probe_pwm(struct intel_pin= ctrl *pctrl, struct intel_community *community, unsigned short capability_offset) { - void __iomem *base =3D community->regs + capability_offset + 4; static const struct pwm_lpss_boardinfo info =3D { .clk_rate =3D 19200000, .npwm =3D 1, .base_unit_bits =3D 22, }; struct pwm_chip *chip; + void __iomem *base; =20 if (!(community->features & PINCTRL_FEATURE_PWM)) return 0; @@ -1570,6 +1570,7 @@ static int intel_pinctrl_probe_pwm(struct intel_pinct= rl *pctrl, if (!IS_REACHABLE(CONFIG_PWM_LPSS)) return 0; =20 + base =3D community->regs + capability_offset + 4; chip =3D devm_pwm_lpss_probe(pctrl->dev, base, &info); return PTR_ERR_OR_ZERO(chip); } --=20 2.43.0