From nobody Mon May 25 06:43:07 2026 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 59C2B345CA1 for ; Sun, 17 May 2026 11:50:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779018635; cv=none; b=awln36E9NNIL15c7H0riQzK8rI/guoknnue7fg6u5CHtGEuYnekRWuqyrLPFVqgCGeOpg/3FUrqBeHG8F4PLEeD/3/jjRkclLGyUUxUvQkpbzTWSJSUuyntvdJi8t/wH4P9tAO7fdewuCXtgqeEcFETFt8l8e9rgEPn0JYeu8XY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779018635; c=relaxed/simple; bh=ySMfbMwfO6T/V49VrNcMVhHqVu7LazqpqQbozRcsqyc=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=VXEzfzzaM1z70C8KuuQYcMYkzPS6QwmKfib8YTRDaFUMyYvwuSFcvwxzrDZ+bLC3oHBZIbjN1+tPE3mCCDb5ISFhgfsBl8g3erc8yJJIHK8P41QVar+OlekiMf+FRvBf1Q+OdIHe+KdTI7gGy/O+JDkq2lcDrCgnX9eC3KlyKiM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UhPfn0ah; arc=none smtp.client-ip=209.85.210.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UhPfn0ah" Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-836ebdeb969so509380b3a.3 for ; Sun, 17 May 2026 04:50:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779018634; x=1779623434; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=NK0FGbUhthCvGO/GheNRpPws8eCC2XUOkNPRY7jlpXA=; b=UhPfn0ahz50AIyPlh8UWemGyzrEpUy9EMuOf0cbbisprbWsEtIokareeDplVMM8gzW am/yTu2QctvZemaqDXZC3zZKlMsb7Hdry52nHtuEO/tWwCk3SjdHuRbZpnQ6QkgBumlk 2GUWPSepcz1R7WNdZB0pv/X6e+AFKk/EclsRAHQMn9ccAQeGeTZgGV9hBAbtBeRaHz14 6EKhwyZMzEiejoNDauZbowYqVE71QVbtlWYbuURCvosbIavWs4eeyOiUAWl8IjsogH/u RfEn3rzcQayQgYjGMJ73K+eUj6qujHCjkI5vsQv8T9bcvv/2Rz9apmo8SIRCjo9Vj7VM YRaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779018634; x=1779623434; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=NK0FGbUhthCvGO/GheNRpPws8eCC2XUOkNPRY7jlpXA=; b=jeiSJk+VJkSm/iDGeKtX/aGryGuCRWKRTwaaX1UWfMQC10ZYgeL/bzevKxU/mfWYzL TVSh+yTwvV9XVISOVUJ7wp38MM0ef9vJaXHZ2q7bKC/PbEJPHnDwqA4innIim9dXjMci ThZTjMJUQ0Mo9N6uymOgzy47DgCi5uqP5IOQ5TxRE5zbKVHxd3lJ1MHXCPaWvfJiwG9E KVOrzUVsICgdYmsq1y68tMP+Xh2KvV+KC3oB7xtAcbwXJbsog5PawFv2FUFna5ma6DgF Js3Xt2srt6OcNIM3YBtk4qYgQOQ26NDC5oc1TNttLR3JqWsWgcgqLGbqOloqcivSY48e gpVA== X-Forwarded-Encrypted: i=1; AFNElJ8MtrY8BWV2C4PxgC5osAibbUkyCrNXD2x0m1XlRLAlpjGlzKJGQB+N31NY/irHCGezJNdgseZpcDsvv7A=@vger.kernel.org X-Gm-Message-State: AOJu0YztvY4pXfUjyIFa8+GUF+EK+adMkxcTfCRlItYeyoiAnUF8gUn9 GzIl/bcga4Zm5qCSqkyKVxK+SoibaemyTrDrGqTCNYGcvuGcqVaZbwiG X-Gm-Gg: Acq92OFo0kLInnvvvZph1plOqzckpb9p5puBCLHoFVqNkLtwR1AnWnalBr/WGVODXCf i5wZXEGRzbqVqa302hmV9EvzuIQDWoqHU5FLS+fKnPt1FxHAR1DiwEw4RfH1oaatCHk/4jnpa8p i69WH6EomlAAMG0EEpSgDk61zmLXI4b+y5lnzvvtPSxCCE8Ku9/BWCjg+2OYsHCANY0Ev1RQWYJ I8Wk3hNEFbKokeX2CaknYgx4QRL7B9BJoHPoISf0Ejl5f/uCldHVphPRMluOTpM1SK7JJuBf0Jz CnhDVoqSIt9udXiLL2Dqt7cQHLyXkZsGLKmcQG1jm02KilCdWSb/hWOpuEz4Vkvv4G28Wh7UKqP XZS8alW94iSHHHFmz/rLFzAbAlqveaOwUQenQ2u3trJACr8rC8X3gX8oKeQPp6XCZoGyTqD1JxQ ePtgNf/nV1AE4C X-Received: by 2002:a05:6a00:391a:b0:82c:ebae:3cb with SMTP id d2e1a72fcca58-83f33d93f29mr11645175b3a.43.1779018633637; Sun, 17 May 2026 04:50:33 -0700 (PDT) Received: from lgs.. ([118.193.39.55]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-83f2b9bec8fsm9725745b3a.33.2026.05.17.04.50.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 May 2026 04:50:31 -0700 (PDT) From: Guangshuo Li To: Mauro Carvalho Chehab , Hans Verkuil , Laurent Pinchart , Kees Cook , Guangshuo Li , Jacopo Mondi , Sylwester Nawrocki , Javier Martin , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] media: mx2-emmaprp: avoid double free on video register failure Date: Sun, 17 May 2026 19:50:20 +0800 Message-ID: <20260517115021.953212-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" emmaprp_probe() allocates a video_device with video_device_alloc() and releases it from the rel_vdev error path if video_register_device() fails. This can double free the video_device when __video_register_device() reaches device_register() and that call fails: video_register_device() -> __video_register_device() -> device_register() fails -> put_device(&vdev->dev) -> v4l2_device_release() -> vdev->release(vdev) -> video_device_release(vdev) emmaprp_probe() -> rel_vdev -> video_device_release(vfd) Use video_device_release_empty() while registering the device so that registration failure paths do not free vfd through vdev->release(). emmaprp_probe() then releases vfd exactly once from rel_vdev. Restore video_device_release() after successful registration so the registered device keeps its normal lifetime handling. This issue was found by a static analysis tool I am developing. Fixes: 8091cb7d9ce6 ("[media] MEM2MEM: Add support for eMMa-PrP mem2mem ope= rations") Signed-off-by: Guangshuo Li --- drivers/media/platform/nxp/mx2_emmaprp.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/platform/nxp/mx2_emmaprp.c b/drivers/media/platf= orm/nxp/mx2_emmaprp.c index d51a62100778..a27809b7730e 100644 --- a/drivers/media/platform/nxp/mx2_emmaprp.c +++ b/drivers/media/platform/nxp/mx2_emmaprp.c @@ -834,6 +834,7 @@ static int emmaprp_probe(struct platform_device *pdev) } =20 *vfd =3D emmaprp_videodev; + vfd->release =3D video_device_release_empty; vfd->lock =3D &pcdev->dev_mutex; vfd->v4l2_dev =3D &pcdev->v4l2_dev; =20 @@ -867,6 +868,7 @@ static int emmaprp_probe(struct platform_device *pdev) v4l2_err(&pcdev->v4l2_dev, "Failed to register video device\n"); goto rel_m2m; } + vfd->release =3D video_device_release; =20 return 0; =20 --=20 2.43.0