From nobody Mon May 25 06:42:10 2026 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 372A9358363 for ; Sun, 17 May 2026 11:46:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779018416; cv=none; b=To4xV5xnQF3hS0U5m20gbTs8Raj6ER09bDyJ9o7lNURGEpJTzO4Xxo/x1/WbWNhajKlXlkJGYN4DPNoxcQeoaBC6EtjVGsftTe3aBAQoJBBkQsPOKHlmqT5Rs0Ne4TsxCHEhpkZ2+f2HJEG/QxpbkEyeFB6X6G3QQbCJqwv7qnY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779018416; c=relaxed/simple; bh=+bZSASniVZxkluqLHkj9KmClq+3fBddfwzzhV+xEhIA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=kLTw5KEWThnDTWWyuwXY5waPiI0ZNqC0iKafdtvR3GYjBfAICnqnicZT6v0rHp68wFlGr6gjS++XmXvY6pM6gCxv7ieabhJwNIAay2SzVPy0J1TbnOZqBy/ZFA1bRQzSaKOIB++VfSQtLIsWuy0kLh4AxdnzhpwooktrFkgm+ec= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=c2ytDYwA; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="c2ytDYwA" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-2ba3e3c4f87so13432065ad.3 for ; Sun, 17 May 2026 04:46:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779018414; x=1779623214; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Viu192jC4/rs0pGZtKEKHYWVgQLZru9+DaFpVD17To8=; b=c2ytDYwAEpck2Pf3PGwO6iHGyVkMB5PYFUIvUo2vo1U3/ocDv2dV54/pu5v+HoksAC F4XH7+2GQvCBYhRtpW8lCxEF/J5BeQaosFYHdi/XPNPwBlASP02xbz8ADyHhVzqTrdcC o1q1IDx+scmSYFivHmS2s5D2HUKL6J+4JSVNwoDXbCQt1sYzuV6MAIckbke82MDHHGkQ IzQ/5QMpsa6quIZCHO6bVkw6PH56kgBbrIulyjXsIopjbuC/YrLFgtKJ7CoS46crxPsW iV/dkQHcXMf6j5zCoU3oxqsGmSNdmhaaHo5ESGjg6dGFHuhsv2yE8hecYWcgM0gXcU0s bLGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779018414; x=1779623214; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Viu192jC4/rs0pGZtKEKHYWVgQLZru9+DaFpVD17To8=; b=npYNq9MFMJJwy+1M06+k5O8ERh1Orx+Zxd1U0i4bf4LJtPnZ4Naj9J04vI6gn2b13h v9uMj5m6AYUG/pUSlCaeHV4k1FGw7aD5jiuiVMUvnFpcm1ligs/9RnBt9jLCd0BDauBj z4ss3hU/QboTNQ4uEBpuIfwXtvgePv9IA+9iWFFxR3Z302vvVyb0UXvT4M9lEPJi2gku JumuljKkzOUDV1iGVOv6FW432cP8NTs1naj2gIFx4AmGmy5p5Nr9n1p8eK0jNrYfRqH3 RkLFJEQmc5E1uFJCP/7Vx4qtyZTP1I4JDNrEVNXOoU5pUPlZB6ppbwNyegbm1J8bpI1Y kV+w== X-Forwarded-Encrypted: i=1; AFNElJ9NGifd2medJ8v8sC8vfK78gZJXMeI7KMPZiJC8KeNw8Tfz61P7kG+qPmaCUC2RE2vvgs4q3o7cPZW5ZO4=@vger.kernel.org X-Gm-Message-State: AOJu0YzJdv8+KoOKsTVkjDA23wruKkjSV00yckxlM+oyrVeyusw4qTKf Yr3eA/9Y2RxIg6M20U5Y1EvKnDjxpnQ+bXjogrnD6QBL2nufVh7Yaiyi X-Gm-Gg: Acq92OFx5b2IZbENWOkInJ07PIl2mmWDpM6mowG1VvjxLh6DkaFLM8EDJ0MvB5KNBWK plEYRiO9NHhqaY4dT3Y29XfCtj6lPtoGyH008A/edz1kBNwzplJ/xQOJzvyI2Bic4ElathU7wTE Tcc/P/oepODuUR7UvXt5h7+xhmKD+JkbeunjMFQxgywOr3nz75SnaA6f3fBoJICqUqx/qUWl4jd 89Yra5zBsKExMngvjk219RViccz4YjuIzBmceifgGw8/j4A2oJZNAGcPBcZ+oOX/9wwqU8zZACo sGVAvyhWerFHmbjzix/vxvEaApVuakBiCb/3i0CtVqVigGlwIWPDnIVcDW4vJ0GgYDLivd6J8Vj IzmvMZdd49pDsvrhhGTkl4kQYMkiircY6Reavxr3pwWRMomNtX+rN1GFAG3IWo6Ymia3GMTGkOV wBmRe+3DxGwe9c X-Received: by 2002:a17:902:da82:b0:2bd:2de3:5198 with SMTP id d9443c01a7336-2bd7e7fa235mr119231005ad.3.1779018414549; Sun, 17 May 2026 04:46:54 -0700 (PDT) Received: from lgs.. ([118.193.39.24]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2bd5cfe6492sm110180065ad.45.2026.05.17.04.46.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 May 2026 04:46:54 -0700 (PDT) From: Guangshuo Li To: =?UTF-8?q?=C5=81ukasz=20Stelmach?= , Mauro Carvalho Chehab , Kamil Debski , Kyungmin Park , Marek Szyprowski , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Guangshuo Li Subject: [PATCH] media: s5p-g2d: avoid double free on video register failure Date: Sun, 17 May 2026 19:46:42 +0800 Message-ID: <20260517114642.951949-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" g2d_probe() allocates a video_device with video_device_alloc() and releases it from the rel_vdev error path if video_register_device() fails. This can double free the video_device when __video_register_device() reaches device_register() and that call fails: video_register_device() -> __video_register_device() -> device_register() fails -> put_device(&vdev->dev) -> v4l2_device_release() -> vdev->release(vdev) -> video_device_release(vdev) g2d_probe() -> rel_vdev -> video_device_release(vfd) Use video_device_release_empty() while registering the device so that registration failure paths do not free vfd through vdev->release(). g2d_probe() then releases vfd exactly once from rel_vdev. Restore video_device_release() after successful registration so the registered device keeps its normal lifetime handling. This issue was found by a static analysis tool I am developing. Fixes: 918847341af0 ("[media] v4l: add G2D driver for s5p device family") Signed-off-by: Guangshuo Li --- drivers/media/platform/samsung/s5p-g2d/g2d.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/media/platform/samsung/s5p-g2d/g2d.c b/drivers/media/p= latform/samsung/s5p-g2d/g2d.c index a18b13db19d5..f38c28abd6d9 100644 --- a/drivers/media/platform/samsung/s5p-g2d/g2d.c +++ b/drivers/media/platform/samsung/s5p-g2d/g2d.c @@ -684,6 +684,7 @@ static int g2d_probe(struct platform_device *pdev) goto unreg_v4l2_dev; } *vfd =3D g2d_videodev; + vfd->release =3D video_device_release_empty; set_bit(V4L2_FL_QUIRK_INVERTED_CROP, &vfd->flags); vfd->lock =3D &dev->mutex; vfd->v4l2_dev =3D &dev->v4l2_dev; @@ -711,6 +712,8 @@ static int g2d_probe(struct platform_device *pdev) v4l2_err(&dev->v4l2_dev, "Failed to register video device\n"); goto free_m2m; } + + vfd->release =3D video_device_release; video_set_drvdata(vfd, dev); dev->vfd =3D vfd; v4l2_info(&dev->v4l2_dev, "device registered as /dev/video%d\n", --=20 2.43.0