From nobody Mon May 25 06:42:36 2026 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D11361B808 for ; Sun, 17 May 2026 11:42:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779018152; cv=none; b=SkK/dN7bcI3YqhWg1+FbSYOhuldObnTKItPPpyI3tsdCoo/D2szPAdBsBeOKyAaMbVyBkiFI5V+RtlWZLWs7hF2RGOwC/9rQc2w3RzrEZ6kx8VscGxCPiFqYGSYbqZwZW3fKVxbi8Lrnj41gbkm/C8aEO8TBYH/MONvzUGwzStA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779018152; c=relaxed/simple; bh=ldfhWekgKUz65lgUVgxyv+2f02yeSr66f4iVl3OLWNk=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=uJhGB5cikqzeBp1hVElkKHhACtm6rJjFr46Dkyt91eBLhRdF7OCdDxYEsYoettGqBNz0p4oAIu41iwKibwl/LqkZowh+wIg6MCMWjqdguJTvfu0pBdcH4JpHriCQEJi3zJ2anaFgiQvp9zoxaSpNQ9GP2anYTfZm1BhQhZBDS2A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=eno9kdH7; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eno9kdH7" Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-2ba0fc8b1f0so7828465ad.3 for ; Sun, 17 May 2026 04:42:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779018150; x=1779622950; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=aybAOu/Wnku8jJKJm8nyG/Glu+5oR3YJ4061r8jTr0g=; b=eno9kdH7+qA3RMKG/m/WxV8tDempTu2kEwAFQMKxzP1/esQ8YDcP4+J8/usy3uGCn9 2m7dhTG09DIY/HmlLq+TRK9mvMuxubytAfDxvQB5P0XyGh5GCneKYYOoys9ZhbZ9nyPk Xt29Ddxq5OMd8WlrAY+J8Fe5N63cqRKgptc2z6iPmfB3MCxPC9nlbd9p5pk1EeD1S2/W 5bxue7OBm41H1DQxb6uUJc9FuIMVDaX3ECkZOqDJxu55AqWqlUT0o/TSQDWu4kuNZT9X qgBlDqwGiZfoj1Mkk1XZcFe8U4TcdcOG5p4DECdSUt9/rGFCZJ4ZphNal8KLnPuXLPvI 0RkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779018150; x=1779622950; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=aybAOu/Wnku8jJKJm8nyG/Glu+5oR3YJ4061r8jTr0g=; b=FQMK98w26cFBB56ihI+hp+zfkwEy8UP4bHE58x8p9mj2eBqQd3xkhSXT63al6nmmKw gXURuyxAy3xnOGPIQCtVLaPsJR0fRtMFWFpTO5pUeO1/PNKRlFgfRHRNHB3uxMt3yCF1 JyTBXPul2VApRDu1DNXPHHxP4GXpxCPWcXTYphTMvC9QdKTrO7W2+8+toAm6Sn0hq4nn I2q9GT9Odmo2gUsZ74RPV2BqVAWijjRgono8U9x9+3vO6ihui03VxTkiQcWsmY46Vapl j5viNdODsoIGpnutR5O7mcXp34EcrieTXRS+JV9nHBfEA+gowahMJZoxcnzkC2DlotGs M2yA== X-Forwarded-Encrypted: i=1; AFNElJ++lhRLFw58BnTPZLnISTyDuUTMQmcjIIe6EPL84dIYoZbW5sGS44WT4Fbs2ALMdGEFX17SbuamJ/S791Y=@vger.kernel.org X-Gm-Message-State: AOJu0YwvWD2PyJB+4P37H8lkIQwhKWsB8z9bUTVx+JaQxqf+hIrEkmO9 PcMbvc3F/Qbzqj8etPmZA4cegzUsq7GKhQ/VXeAeFvMbws/AGx32vgNZ X-Gm-Gg: Acq92OG74rxxBHEeTcSzDsUJj1N2lCpoRLsYHRNhXcEDm+oJ61bXLCqtYWe1RIK5Rvu 6IfeYAPn3QdRlkPbqo2TkNegwsvWM6qee8O6TDAPEMpLTqYFlDHiBJim4X0YOOC0/mH/V/YLS+6 xG8kvcNr8KoRgTGi4lDXSrY8ZTWYXSQen8Y/FSWvt+ywnlMdu5bAytWxVqx65IcP63Jtcm5qq/p J+eDKy8Z0v4xK3t4h5ihFLncBNmspPSzPp4g9JFf8WJfZZy8VOh121SPDFhxrXc3jKw6u/e1SZl ZIrG/q2NEU0O2JbuDMIRk0uD1QXu6uVkX9MVXIgzGlh4nW+hQEUF869/2IITuLTzecZuqFAq81z 8+g8ukEBsc7dUz3HE2Tt02BWFvy+KdOvVUDyZtfURZpQ8MUwWrqSrZZxPyVtwzl5P6LM9xI0Lsb JtLRoIk5fz0TS6 X-Received: by 2002:a17:903:1b45:b0:2bc:ffe1:c380 with SMTP id d9443c01a7336-2bd7e86c179mr114076265ad.8.1779018150104; Sun, 17 May 2026 04:42:30 -0700 (PDT) Received: from lgs.. ([101.36.106.88]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2bd5bd5f30bsm135198645ad.16.2026.05.17.04.42.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 May 2026 04:42:29 -0700 (PDT) From: Guangshuo Li To: Mauro Carvalho Chehab , Maxime Coquelin , Alexandre Torgue , Hans Verkuil , Laurent Pinchart , Benjamin Gaignard , Kees Cook , Guangshuo Li , Jacopo Mondi , Dillon Min , linux-media@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] media: stm32: dma2d: avoid double free on video register failure Date: Sun, 17 May 2026 19:42:16 +0800 Message-ID: <20260517114216.950713-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" dma2d_probe() allocates a video_device with video_device_alloc() and releases it from the rel_vdev error path if video_register_device() fails. This can double free the video_device when __video_register_device() reaches device_register() and that call fails: video_register_device() -> __video_register_device() -> device_register() fails -> put_device(&vdev->dev) -> v4l2_device_release() -> vdev->release(vdev) -> video_device_release(vdev) dma2d_probe() -> rel_vdev -> video_device_release(vfd) Use video_device_release_empty() while registering the device so that registration failure paths do not free vfd through vdev->release(). dma2d_probe() then releases vfd exactly once from rel_vdev. Restore video_device_release() after successful registration so the registered device keeps its normal lifetime handling. This issue was found by a static analysis tool I am developing. Fixes: 002e8f0d5927 ("media: stm32-dma2d: STM32 DMA2D driver") Signed-off-by: Guangshuo Li --- drivers/media/platform/st/stm32/dma2d/dma2d.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/media/platform/st/stm32/dma2d/dma2d.c b/drivers/media/= platform/st/stm32/dma2d/dma2d.c index a3ad19256859..0e36ddfa8c7b 100644 --- a/drivers/media/platform/st/stm32/dma2d/dma2d.c +++ b/drivers/media/platform/st/stm32/dma2d/dma2d.c @@ -651,6 +651,7 @@ static int dma2d_probe(struct platform_device *pdev) } =20 *vfd =3D dma2d_videodev; + vfd->release =3D video_device_release_empty; vfd->lock =3D &dev->mutex; vfd->v4l2_dev =3D &dev->v4l2_dev; vfd->device_caps =3D V4L2_CAP_VIDEO_M2M | V4L2_CAP_STREAMING; @@ -669,6 +670,8 @@ static int dma2d_probe(struct platform_device *pdev) goto free_m2m; } =20 + vfd->release =3D video_device_release; + video_set_drvdata(vfd, dev); dev->vfd =3D vfd; v4l2_info(&dev->v4l2_dev, "device registered as /dev/video%d\n", --=20 2.43.0