From nobody Mon May 25 06:42:10 2026 Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C974337B97 for ; Sun, 17 May 2026 11:37:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779017840; cv=none; b=PtThxNDFm4aDV7L3d5iZA2A+mUovLpN6NV0kkXUrFbD8eYsE9YmvmFKTS8kjcz5UXiFL0MdVNRX62/Jyh0aevm1ygA5MR8vL4WFvk2Tp9ZOaDhbs0sBNEtyAT8ziixfHwnkTWUvjyNzGX2qaIg+k0aFumgJb0rx2tn24bUGqHzI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779017840; c=relaxed/simple; bh=GYeLmyLcYBRO2WMlE11F/2pqaJGP/wShi264pbJUNjM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=tXC/jY/RpbHiHd62Qr2rwIOSiOOASQH1rf16mXdmVEBP76sezN2V91FXeUhIilXUEOLbpfH2nfyrlzOUo2Dty0mMGZvP63Yss3ANVdt3JfK1ozNwwXkXtzJ7rQKQ68e9wjZUcnxbFtuNevB5n7L7NQ0S9TEDurkPHnz/SKcTL8Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YH/p/0T1; arc=none smtp.client-ip=209.85.216.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YH/p/0T1" Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-36974217d4eso584949a91.2 for ; Sun, 17 May 2026 04:37:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779017839; x=1779622639; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=YwCtNa2bNCMGQ/e87qwfib5kmy7GWvXNJtX206pcf+A=; b=YH/p/0T1E7a30xYGmGmvsUHleZy4LEz4RLQKCigKGznjoEw/oH9wdRS3tMS749ex4P 4xcTd041dzuhS4y+RiWoLV5dtM+PFkSvkaioRrJS5u721LbseZRMnX0pnbQVR+KHcq/V TsRsvHRF9YxWUgLh8N/lbejse77Elon4v7cfDoOdLU8sJtWkXvEPnTVsRGbOXPZwnQeI GEJalh5k8lsNRrgd9VQTcA5Ss6xQimKVtg1lNVoC7fv/qfqvGUQ4TtrcMnlAJcRV2AHu ov6uum/QyXuUdvzJUlXAwQQ79ioKfrPvgL6feKhlvuAcyGRqyxuNp2NSm/XAzWmkKWaK /4iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779017839; x=1779622639; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=YwCtNa2bNCMGQ/e87qwfib5kmy7GWvXNJtX206pcf+A=; b=BNMykfYWypVZhjanzEi9DrftNnefzoGVaZ7Tk5kqlGF9d07AMTUCgUN+NftP/LVwCl jsjDbHRbn34c0iYyr+QnX9MZYQTwJMHHGqAC7m0X8XbOwaHybcQehh8tefd2KWrvXYGs E22Wi76iG31X6R4dEP6/muTeGNLrnzJjVbh8QmFji+K5npLeEd0pvM/onVxIymLa5no8 KfWVqW69+oPbdhhmajoq+J5PhIPYOy1KTqwQP3wsvCt/QC/p8/TOZcLubr9xgaaf3yNB YAYxozFk6C9eyhhn2mx3iU6GAzvikPQddBDXku/GKBrFAWTm3zGL9/27I66PUtKNhH3q xKNQ== X-Forwarded-Encrypted: i=1; AFNElJ+7MsVoQk7XlLG81rQxhU1m3NK0LyxXgBqmNi/HHHKJ4Nfwc+uQceffx/qtDZWm/2Qou/7jIM8/KXuiwQ4=@vger.kernel.org X-Gm-Message-State: AOJu0Yx7aXpss/EOryiezpzpkmzbyosVZ5q3l+QTwrshBCHXTAI7Q6nh bnz3Z9ZmeHHxn7wH4TdoOOS2+dZTNMvyDV7TfUGLcv5FXe2lQGWds8QM X-Gm-Gg: Acq92OFvHw0av/KYIoy0bpyeoD+USgvB+uBXW98FC0B6J2SZObhfSu/MS6bYTf9hLE5 fwObhXYpNW0sh4uPzyDpRwN5SRTJNLtpt+PVshOso0QGY8vzLL1/bAD+HwDYeS8M1OTlsUAR8Lg ZpS4B0wIn5A52sjP07722EeLb18hKvK1QGhhcFqA79DMgKYqnrt+63t/lBy54oQTRLS8Z1n9VuP GhxQyIzJuSZarNDCOA7MfRZbChENZ2M8eSOKxze6xkbZ9eZLAlCeOM4e3mAHp3oyFiiXzsGgv8+ AQY/FaIsGnPJ7XgN1kXiPS0/7deC+LZ5D2tmeHKHEebxutHYEP1fFKELh929UcvlvRLyFAAKcPr eE1L3BYs2c7tYdpmLZF14TH8RMNT6N+BA6EffBDP+0yeTYby/jy47FEps0N+AU8Nl+HUQsKn+OR BQy8dquA== X-Received: by 2002:a17:90a:d648:b0:368:95e1:8d45 with SMTP id 98e67ed59e1d1-36951cb7706mr10428613a91.26.1779017838713; Sun, 17 May 2026 04:37:18 -0700 (PDT) Received: from lgs.. ([2001:250:5800:1000::f280]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-36957261d59sm3162871a91.4.2026.05.17.04.37.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 May 2026 04:37:18 -0700 (PDT) From: Guangshuo Li To: Jacob Chen , Ezequiel Garcia , Mauro Carvalho Chehab , Heiko Stuebner , Hans Verkuil , linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Guangshuo Li Subject: [PATCH] media: rockchip: rga: avoid double free on video register failure Date: Sun, 17 May 2026 19:34:49 +0800 Message-ID: <20260517113449.949222-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" rga_probe() allocates a video_device with video_device_alloc() and releases it from the rel_vdev error path if video_register_device() fails. This can double free the video_device when __video_register_device() reaches device_register() and that call fails: video_register_device() -> __video_register_device() -> device_register() fails -> put_device(&vdev->dev) -> v4l2_device_release() -> vdev->release(vdev) -> video_device_release(vdev) rga_probe() -> rel_vdev -> video_device_release(vfd) Use video_device_release_empty() while registering the device so that registration failure paths do not free vfd through vdev->release(). rga_probe() then releases vfd exactly once from rel_vdev. Restore video_device_release() after successful registration so the registered device keeps its normal lifetime handling. This issue was found by a static analysis tool I am developing. Fixes: f7e7b48e6d79 ("[media] rockchip/rga: v4l2 m2m support") Signed-off-by: Guangshuo Li --- drivers/media/platform/rockchip/rga/rga.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/media/platform/rockchip/rga/rga.c b/drivers/media/plat= form/rockchip/rga/rga.c index fea63b94c5f3..90ae01de3216 100644 --- a/drivers/media/platform/rockchip/rga/rga.c +++ b/drivers/media/platform/rockchip/rga/rga.c @@ -851,6 +851,7 @@ static int rga_probe(struct platform_device *pdev) goto unreg_v4l2_dev; } *vfd =3D rga_videodev; + vfd->release =3D video_device_release_empty; vfd->lock =3D &rga->mutex; vfd->v4l2_dev =3D &rga->v4l2_dev; =20 @@ -895,6 +896,8 @@ static int rga_probe(struct platform_device *pdev) goto free_dma; } =20 + vfd->release =3D video_device_release; + v4l2_info(&rga->v4l2_dev, "Registered %s as /dev/%s\n", vfd->name, video_device_node_name(vfd)); =20 --=20 2.43.0