From nobody Mon May 25 06:42:36 2026 Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0DC6734CFB9 for ; Sun, 17 May 2026 11:28:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779017316; cv=none; b=VgQqlsNIBAeJZ7K7Atk/MdAodY6zxndw4ORYteEbI/QtMXrNciIXz1Bvod+DHCJD57ArnSiplAcUs6QddZzIhzX7hksDcnvXuIsp1cn/vcYZcFB8l+vAeh7QQ1J5mtZbLa1GQZKkdoRLqQ+EdcrvmPBt0RNWyxyNY3We/GmIZdo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779017316; c=relaxed/simple; bh=nTtDAhHlxRu8GFL/czu4etZg9Ouuv3xLOIpHKixnKzI=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=X98SlZsEXrKlklqR9OAoDBpW5wqMjA9GOMTmBgAfAp9DIfohXAHzXYWzLcqwJmebIGcjEhnoR/F+aLErL6NIOXJDstWeu/d958h7X/bVxfOvCGI/SaGYXfBxWdE7KrqQhfQvYsCA5e2sCDshSKorJQvVAaBgVHSlia+d90we7qI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Ph92M+Xm; arc=none smtp.client-ip=209.85.210.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ph92M+Xm" Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-835399c11e0so479921b3a.0 for ; Sun, 17 May 2026 04:28:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779017314; x=1779622114; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Q2HNvBLsSkl5+JzqDGgnt/yv9ml8/MlQvATo1olceFk=; b=Ph92M+XmtCDf3laZ9++xr07PqHhc987UahoXHgJ6GQlHtTwuqyZZxnWVzADfSlpw5u Eb7VuczMC8TBxY71ff24OVrVjtuRuSDtkZProTaNTBDAUMF5Em0+FbcHMs98EXPm+5R7 ig739PhVJwRwx4ZF4rkXey6v3Q5fZXdJ20pvTvAyEXeai1xuArhi8zNDGJNmzGCYnnDM zgAqyR+KLS6Kxv6pEDzosOUUPE3/WiWuMkW7fvpM0EINaUx2+AuwYr+xmVyyhJGRLUzW yWv/GKDIIrXFXjQoV4Gd4mYmcCui5LNWI9O0ltJFlDWP+HybGPe0JNI0P5DZgSMB+xUs JhUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779017314; x=1779622114; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Q2HNvBLsSkl5+JzqDGgnt/yv9ml8/MlQvATo1olceFk=; b=G+WTfGNstRMVVGBHLmB2eoejUCx+UBSvUlIrgFXs6V44jq5FaqgSQwIfsKHO86Z3Hg 65DbcTsiMs7sBF2iwAQAmicV6fm71oe/6/OCtB4oHqpOx54P13o1N+gKDUscPg77MAqi 2xNEoFPDrl9GOz+EJLoEjYJA0iue4+TkGxDKNqcANJgDxeMnOX0cgDSqZ+qRq/5qGpQj xyn98TvMDkk5G7/T+/1Mcxy7TlnPzf3iYuey7ApgR6M7riY3DdeDBpd5v+fTXPF7BCDN rYCmGSufWOBibXKRlN2mqjQz03JEQ2jomYoNl0Z5JaQxmpi5K+qdhFokfuqpJLMUsIVD Hcqg== X-Forwarded-Encrypted: i=1; AFNElJ+/UrK5sAmgcqYLJlptZig7jKHWk88CXIruwbDYcp5oFsUkg2EqGYA8lpg6LKY+nNyVp+hvTcDllMNW3PQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yy8M8qm+WjuIVLWYO5CFnD3hZ4A6CGth7shFy52FTNwAKTyDeNL ZQF03TVrhS187aX+z46Umuurq5MDkTh0XKg4Ed41/FZLVrnOWJMGAtFx X-Gm-Gg: Acq92OHHarzhbTYQ0j2Eku6WU8BOfsafiy5RPiAfFRYNLow2bmM9B8ON4hsQleyZE54 MjSr7PFmjoZI6ZA7ZoTeLtWX7ZZnwfiCkXwSs47hHcFsAxQZcSwxaIZagCKHymgxmc0Qm4ebBXy TPJQ5/BTjcNxP/WtiRco9Pfl88VdsQRB6Crpl7tGR4uMokZqaEs5/Cc6Tzzz5rD1dF5sthyU/oS XXFdAvmA4av2qpalUvH21wXTjsd6deEK5biW19mGV/N28XAYLWphw4wX4JkRJvBgx6h00cU9qe6 qB43kvXnszgM6VnckfC9KCMXZI5F/0+4iChRWaEFQD/a7PD/CFsNuLeEpqNXiJfln5wNYnOtWSE fgVTYkgenZviOm5CeCB9SEekxWFpKDICuBoVxJnqx18Csq9mKjUOo0AstI/2M1/CnQ4sNMSG4xI ANSdp3iw== X-Received: by 2002:a05:6a00:39a8:b0:82f:7252:38cf with SMTP id d2e1a72fcca58-83f33cc34bcmr10847620b3a.16.1779017314366; Sun, 17 May 2026 04:28:34 -0700 (PDT) Received: from lgs.. ([2001:250:5800:1000::f280]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-83f19c5ce1fsm11392149b3a.35.2026.05.17.04.28.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 May 2026 04:28:33 -0700 (PDT) From: Guangshuo Li To: Bluecherry Maintainers , Andrey Utkin , Ismael Luceno , Mauro Carvalho Chehab , Hans Verkuil , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Guangshuo Li Subject: [PATCH] media: solo6x10: avoid double free on display register failure Date: Sun, 17 May 2026 19:26:03 +0800 Message-ID: <20260517112603.947790-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" solo_v4l2_init() allocates a video_device with video_device_alloc() and releases it from the fail error path if video_register_device() fails. This can double free the video_device when __video_register_device() reaches device_register() and that call fails: video_register_device() -> __video_register_device() -> device_register() fails -> put_device(&vdev->dev) -> v4l2_device_release() -> vdev->release(vdev) -> video_device_release(vdev) solo_v4l2_init() -> fail -> video_device_release(solo_dev->vfd) Use video_device_release_empty() while registering the device so that registration failure paths do not free solo_dev->vfd through vdev->release(). solo_v4l2_init() then releases solo_dev->vfd exactly once from fail. Restore video_device_release() after successful registration so the registered device keeps its normal lifetime handling. This issue was found by a static analysis tool I am developing. Fixes: a4056c2fb4c4 ("[media] solo6x10: convert the display node to vb2") Signed-off-by: Guangshuo Li --- drivers/media/pci/solo6x10/solo6x10-v4l2.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/media/pci/solo6x10/solo6x10-v4l2.c b/drivers/media/pci= /solo6x10/solo6x10-v4l2.c index 35715b21dbdf..6ce489919ecf 100644 --- a/drivers/media/pci/solo6x10/solo6x10-v4l2.c +++ b/drivers/media/pci/solo6x10/solo6x10-v4l2.c @@ -647,6 +647,7 @@ int solo_v4l2_init(struct solo_dev *solo_dev, unsigned = nr) return -ENOMEM; =20 *solo_dev->vfd =3D solo_v4l2_template; + solo_dev->vfd->release =3D video_device_release_empty; solo_dev->vfd->v4l2_dev =3D &solo_dev->v4l2_dev; solo_dev->vfd->queue =3D &solo_dev->vidq; solo_dev->vfd->lock =3D &solo_dev->lock; @@ -690,6 +691,8 @@ int solo_v4l2_init(struct solo_dev *solo_dev, unsigned = nr) if (ret < 0) goto fail; =20 + solo_dev->vfd->release =3D video_device_release; + snprintf(solo_dev->vfd->name, sizeof(solo_dev->vfd->name), "%s (%i)", SOLO6X10_NAME, solo_dev->vfd->num); =20 --=20 2.43.0