From nobody Mon May 25 06:41:57 2026 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 770A134D3B0 for ; Sun, 17 May 2026 11:20:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779016851; cv=none; b=XF83M0wRjzpxOk7xEVf25CtctNnhHVXn+Ib+cP8aqCS/DltNquHDFcSN00GN9dLnsAwI833NwRv/viyl1D16bbOgaEUxlkGU0P5AMkk9gLNb8DynWZ2MRLe6UZ4TDpHQc1KkuTKsg5CwnSjLAjGIuUG9Ylw8h+u/+zv4pAO99BI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779016851; c=relaxed/simple; bh=742HpjWfBunlX0gLCx1MU56Y6xvCxdB6ILp/o8mwkMk=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version:Content-Type; b=rgMBga/xFmXmC+JmeSJwpCvyCtGD669jrh4LZafAgi0iHD9BvvweHX0TVJ+iqmY3LqkaSv4tbiRmQSvjgpIpkQxAx8PY23IrgjdbKnbtzzdeWUjM+BIluugAzKv/fHLtm2if457mfnd1ZSn9pAnlYHU45H5iuNW5D8JIgoqKANY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=T11L9qFX; arc=none smtp.client-ip=209.85.221.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="T11L9qFX" Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-43d734223e4so666701f8f.0 for ; Sun, 17 May 2026 04:20:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779016849; x=1779621649; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=aBNYR3i72PjHFZuErvRNxZRW1PJhw7Wm714gx7/9InQ=; b=T11L9qFX5Pw4Qt5B9ZPZOTXsHCAxdYDk/DOPDPW1IOySXS187NvrLUkM+9foYS/HoO 6K/qWLIq/mCbq2uLzMpY+5TxRPyF4VKWok8BNvxrdO6YNsLTLWAkLEZL9bZoe9iLrPvO DHxN8ReHY580iBCFkZFGgD3tv7ePfKDOw26VCurkevXd93738PgNBcoTSoo0ezhWP7iZ R+cnCB+Bdy7RLsJfVqXXGSV9PMSPiTCI2REbZJnF3/ddClVs95gB422asLPQPROABXY/ 1JUozCKrSgBjpDFLhjbBE5PxaSKCHMTMDOBjxN3e1e9h2vaWD1ywP0kqsyfioICh/wI2 0zuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779016849; x=1779621649; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=aBNYR3i72PjHFZuErvRNxZRW1PJhw7Wm714gx7/9InQ=; b=VEM713frAP+08gftpL8/XN8IYhkkSDxnHmLTWlWd3aCYV+9i37cITTWRlX4zOM/7Qu WUeLszaYm44c9Nxo7wGxjXDsbo1wuyRv++NjATKzH7HjiKF/NTuPvKmsDpiy13GxfSLP Dg+0YAc8i1HdG50INSyjT2Ss8Pn3Wehmyf00ZiHXWTAu9RHs2O2HgvtO0E5T++lU/pcH HnbhqbftOLu1MX/3AowU/uPXVLhTOJ9807IblbxzXOMjMWFnd2EFkPNAbLGaekY4uBVK IB8jddoM+4grw46lEcA+WKvACn0hT+DyJUipYJv+3UEZXZ/QTaf+p6qjThETlVSUSX0N QuWw== X-Forwarded-Encrypted: i=1; AFNElJ9tgkm2A7UWjmMQlSOEdASZAJy99Lp7DQvem+UCg5QaUbo+Boi9RUedsZ5cW65JcOMfZuDCe4BPlx27ksQ=@vger.kernel.org X-Gm-Message-State: AOJu0YzugljpA3+XLY7CcwOfQK3nxyrT313JUgdqQLQEJfTyegekaWEn tj71zA2dEn4GJbcK+vi0yVDFs5ld2FrcTzTHCZtaKf7lL4z1wVp+VfE6 X-Gm-Gg: Acq92OG0getkSpvrvmA5UK+55hrStggO8OPGIS0Dup9OCG8d+NRfXAvprSPa4nUbvQp fmGls+uHSxF8vQpk7ekGvQe6cZAaltB4EXSawezOIGFHOi08Bk7PQjogHLxvQoHMZWFr4TKWFuJ 0lMk86wT58tQ5AxokuzgfSOk+T3nzMpjiHwRTZKR2U5TNi1IpRJR9Xt6Hx/wKiLSzVlwJc/sKMl s5wcF3Wmd4yDhhZ6k9oSMSjScPeKMyJK2cYWROpSb7UBHPegi31hcVD1EwERUtch1zz+n5VMr6C 70nr+6c9mCpc8GbqnNtNDuIJv9w5UPTB80AdUl6VstCVrN4WQzNo7SJafCFRL4GrYAJfxvay1Ok 18FSLJ89F5Bln8ppl2ihXQgSLKI5+ZT4XPWq5S6ZQSVuAWejTuj8iZYIFPO3c0ZGeMlTsNHJ0+r BKhZY5vDjLvW8vpdDuIEGVahqAIZ+XDGMmgZgs3z4rclw= X-Received: by 2002:a05:6000:2a02:b0:453:dc4d:9265 with SMTP id ffacd0b85a97d-45d90d76962mr16707359f8f.10.1779016848713; Sun, 17 May 2026 04:20:48 -0700 (PDT) Received: from localhost.localdomain ([41.116.1.81]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45da0a19a0csm27878624f8f.20.2026.05.17.04.20.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 May 2026 04:20:48 -0700 (PDT) From: =?UTF-8?q?G=C3=BCnther=20Muller?= To: steffen.klassert@secunet.com, herbert@gondor.apana.org.au Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, =?UTF-8?q?G=C3=BCnther=20Muller?= Subject: [PATCH] xfrm: fix missing headroom check in xfrm_dev_direct_output Date: Sun, 17 May 2026 13:19:40 +0200 Message-Id: <20260517111940.8987-1-gunther.muller2008@gmail.com> X-Mailer: git-send-email 2.39.5 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Ensure the skb has enough headroom for the hardware offload device's hard_header_len. If the headroom is insufficient (e.g., when routing through certain virtual or tunnel devices), __skb_push() underflows skb->data below skb->head, causing silent memory corruption. Fix this by using skb_cow_head() to dynamically expand headroom if needed, and switch to the checked skb_push() variant. Signed-off-by: G=C3=BCnther Muller --- net/xfrm/xfrm_output.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/net/xfrm/xfrm_output.c b/net/xfrm/xfrm_output.c index cc35c2fcbb..35f974d209 100644 --- a/net/xfrm/xfrm_output.c +++ b/net/xfrm/xfrm_output.c @@ -649,7 +649,10 @@ static int xfrm_dev_direct_output(struct sock *sk, str= uct xfrm_state *x, * to netdevice. */ skb->dev =3D x->xso.dev; - __skb_push(skb, skb->dev->hard_header_len); + err =3D skb_cow_head(skb, skb->dev->hard_header_len); + if (err) + return err; + skb_push(skb, skb->dev->hard_header_len); return dev_queue_xmit(skb); } =20 --=20 2.39.5