From nobody Mon May 25 06:42:36 2026 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AEC4B35A3B9 for ; Sun, 17 May 2026 11:20:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779016859; cv=none; b=fzzrTCC9euNScUSoGZfgqN/rL6RRu5cbAJRaUl6xigsJ9dGW/sRYSTZP7MMObFx5Z3KyZCZignVY/h1pMXzAR3u9ZOvaO7OsfaTKrXGEudZiCHYV055BGlCwvUltllBruJRIIGMPN3ZqoY0f8MepGMVmO3rNgvn9ug+bg3nB/2w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779016859; c=relaxed/simple; bh=0FEaLogsDoMA10mynhfXjWCCmhduignknw3VZEplDtw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=M85gBQkRBr4qYbN0yYkXOHck6WBP6M5k+fiGN1NwMbn+sWvBYfcVUy7cNcYVzPr/Vb9/qW/xaR9a3IUBvL2110DQoRtiN/GM7J19rna6Wckka6dmlXMvkoQsD7ggJ26OpbH7cmg+tTZQVGXrsyONKyWZSamZ4NSxWsJ8EChIU8o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KD9hztnJ; arc=none smtp.client-ip=209.85.216.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KD9hztnJ" Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-367cbac9cb1so1263420a91.3 for ; Sun, 17 May 2026 04:20:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779016858; x=1779621658; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Q/ortlMh8x+p+Fhr+BMJcjANUffMVhXyAdYtT0wR3sU=; b=KD9hztnJIimyNEY4KBlZxQwoXyuzqSmx0XoxRkT65bcTcsSe8f7tPGoDfL3YDDEgaN 74wqF5YsvpU+miuIUBCKX8BNO9QOHanBykK2hstWi11aD79WlCuFi3tMk+WQCKoYY/NI TTSkrYDaXhiuu8JXzTkyCEMxYYfX8tTddoUktFxXGnB3qPJvpFRjqoeU+eRTNyFCmXSq 7kFgvT/h52f5mxRYqX/Xk6SnQEjGpdlNGyIvo0ZINiWNNtw85VZpOj+4tJUcg0cUFnlD rFntKFpJYs77U87nX8U6ekTyDlKvERrVs/7txqWFVnQfPrYHAzVNzdLC6qNXRLQbmMNV nGZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779016858; x=1779621658; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Q/ortlMh8x+p+Fhr+BMJcjANUffMVhXyAdYtT0wR3sU=; b=dd0/a5LPzPqtBNZ9lMmJxaYI0XDcFunZ9vnSNCAp9bZbTa8qoZ6XzGZDaiFwbLIDWd IeB8nYLv/2RDYmPExIpsjuCuHRT7Af/xUayVvndeLbOMCFWlKKYXpaaHJ9/boSVc4ddF EQIS+IVGNxrKi753RmfjSkPhlXe4I7QFTzbP9sQhQwjQtpy7v3uvdjgUoj3VIE8c58KO P48rfbJlUYLCV84Z5Ax5QZGdP2hfLchJBvrINEgSI8mTdMEzzgSnSf/vVb24/sk7KLgk MkuGzsmI2/mQvsCJcQMUnumTYnc0N7nHd/pDbRXgdAsADn8+O14ga8xd/IC5b8GP+9lx pDfA== X-Forwarded-Encrypted: i=1; AFNElJ8EBhQLCVxpYc6YX8fE/wDbGRcozL+VW1K93uaYTYvXvHxCBIL/hVNQcgQAYvucsYkuXrEErj3qOFN65wQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yw6kt03o9x3lHvWgchNZsZrev0qDzEna3OG3TnKkvX1iFBXn6X4 VZJ5KygVZO3UiiupsEhfxhehG7g0NTkD117yzol0b4Uz3HDt7bmAKjIZ X-Gm-Gg: Acq92OGzZPkJst8TVMgsDcRxlpWsvOIfGh2LtmEpRP1fviWgQF32+rnz+nQ8tha9HAN VhMor3TzsTVAItsCJr/ahQBis+7/Q3J5QKA4Em+xmmCzNGc4Uo5b8XXogzfuGQXf2AH5q9W9wbQ Q6UJyxgIafrYLauEJVh6WQzdri21w3kLxsMmzj/qVuop1faNjAg/4dcPv/Auezwtsl+YSfWi31D sdVcOZzobMOmLeKW+9xhDJRQDGlj8SF/T9mp5hZvHbSb1RFeA/xFZHbJWWh+ohjRwYjF0KM1VEc RDOWAxouhxK/k1Yy0YLolaJcTdd2OBffdV7YA1r2V8xpOB9zCe19m1rlUBQV7AsyvDsv0IryNMz ni+wy4jeGhh00iaCeJQMDSmp1peKhVYuWAMZ+uQKmWfrLo5JzLFz7F7+nz5AekhlY9PNnZIPe7k jJnTnYOQ== X-Received: by 2002:a17:90b:5706:b0:369:a9e8:dbf6 with SMTP id 98e67ed59e1d1-369a9e8dc5cmr2010367a91.12.1779016858087; Sun, 17 May 2026 04:20:58 -0700 (PDT) Received: from lgs.. ([2001:250:5800:1000::f280]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-36959fa9d84sm2883385a91.8.2026.05.17.04.20.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 May 2026 04:20:57 -0700 (PDT) From: Guangshuo Li To: Bluecherry Maintainers , Andrey Utkin , Ismael Luceno , Mauro Carvalho Chehab , Hans Verkuil , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Guangshuo Li Subject: [PATCH] media: solo6x10: avoid double free on encoder register failure Date: Sun, 17 May 2026 19:17:54 +0800 Message-ID: <20260517111754.946843-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" solo_enc_alloc() allocates a video_device with video_device_alloc() and releases it from the vdev_release error path if video_register_device() fails. This can double free the video_device when __video_register_device() reaches device_register() and that call fails: video_register_device() -> __video_register_device() -> device_register() fails -> put_device(&vdev->dev) -> v4l2_device_release() -> vdev->release(vdev) -> video_device_release(vdev) solo_enc_alloc() -> vdev_release -> video_device_release(solo_enc->vfd) Use video_device_release_empty() while registering the device so that registration failure paths do not free solo_enc->vfd through vdev->release(). solo_enc_alloc() then releases solo_enc->vfd exactly once from vdev_release. Restore video_device_release() after successful registration so the registered device keeps its normal lifetime handling. This issue was found by a static analysis tool I am developing. Fixes: a7eb931d635c ("[media] solo6x10: move global fields in solo_enc_fh t= o solo_enc_dev") Signed-off-by: Guangshuo Li --- drivers/media/pci/solo6x10/solo6x10-v4l2-enc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/media/pci/solo6x10/solo6x10-v4l2-enc.c b/drivers/media= /pci/solo6x10/solo6x10-v4l2-enc.c index 91b5c4161930..ab85d86b68fc 100644 --- a/drivers/media/pci/solo6x10/solo6x10-v4l2-enc.c +++ b/drivers/media/pci/solo6x10/solo6x10-v4l2-enc.c @@ -1295,6 +1295,7 @@ static struct solo_enc_dev *solo_enc_alloc(struct sol= o_dev *solo_dev, goto pci_free; =20 *solo_enc->vfd =3D solo_enc_template; + solo_enc->vfd->release =3D video_device_release_empty; solo_enc->vfd->v4l2_dev =3D &solo_dev->v4l2_dev; solo_enc->vfd->ctrl_handler =3D hdl; solo_enc->vfd->queue =3D &solo_enc->vidq; @@ -1304,6 +1305,8 @@ static struct solo_enc_dev *solo_enc_alloc(struct sol= o_dev *solo_dev, if (ret < 0) goto vdev_release; =20 + solo_enc->vfd->release =3D video_device_release; + snprintf(solo_enc->vfd->name, sizeof(solo_enc->vfd->name), "%s-enc (%i/%i)", SOLO6X10_NAME, solo_dev->vfd->num, solo_enc->vfd->num); --=20 2.43.0