From nobody Mon May 25 06:41:58 2026 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 34360353EE5 for ; Sun, 17 May 2026 09:15:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779009316; cv=none; b=kdfJJXiawkU3mNWtOZnBrCi+hTSByEyI1U+7OHRJ9/sbcc5G/G7XPsDsF+uMlyPCJCHQeH+TMq4wzZrbrsdRfCIlmqGZoZzQIcgy4iJ46lHwpMD3cHm4NC3oEkudzlqKj6r0rK09ganyQjibRX2O5UaH77Ewwg30YQYMndQ6IjU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779009316; c=relaxed/simple; bh=Gitw1P0LSmMPXPFhHzWFWU6P4rMn1EG2FuqNjSvyhwY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=tbGPmU3VCGNV4ECqq1KTzwT1+xpDoI5ERWrQi7XjbgRgJQ6ucRF5ZT6Os7JNTSbLOE2B/KVf0SpF7lp0M8b09vfsFjCmbJ7KlUuz5ZxvzfVOg4zRaBqALtUog8nFPNP66bewH9h36vZlFo2hmg2rbm90tT5fIaZQ/yjJF/6OjBk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=aG7w5aHk; arc=none smtp.client-ip=209.85.221.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="aG7w5aHk" Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-453903ee4adso1020775f8f.3 for ; Sun, 17 May 2026 02:15:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779009313; x=1779614113; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1GuFtyrSu06bTVmesqPXmePmrs3EAUNX6oaNcPtvvmc=; b=aG7w5aHkGuImB0pkmnvRRaNtKh2I85nt/tblW+JDH8mus6D7eOkAY3f7DaHEQTp2ZU N4XQ9BpWPWPd7z0P0YtgLMmLJAkb2X/8kKcEEfIJZEKWWLnZ9U/+FWQCrfIbQNtkfJjU nVBHKX+ijuk2ZomH1KyY+01JLml+w0zLc6i+9V8v495NbpFqFE1aXXRqAeLu6Rv460aX JUY2ko0uhSN9Rpb9QfaxzScs4SDtjrn25GiP9WGVmGA7gNmBmxn9Cu8FlSVGaqkerBr2 eEXHsiDR0CJwvb9BEk2S1PshlQgKAa0yP4DZMSYRMbSUfDHD+5q4IHK0qc15woT/ehav ucgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779009313; x=1779614113; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=1GuFtyrSu06bTVmesqPXmePmrs3EAUNX6oaNcPtvvmc=; b=P4U1drlNMSwavGwbFBYCKmRC/8MsalFgcfbD2i2HBYRQzTdXTQHujABhH3lT6zhj3K QLFpaP646JLzSNLAGNB+TAqd4LWeagh4w3jqZHc7TOJN4VbBwS/XxpZLw2wMnnL0QItF fmrgmiMAlB+RWGaZgZIzVMYw1KF4vZnqSR7jq30k3qoLgrIxWnEaNjSsBZo2LnlOWyb2 Cf8D3DORKP1bfdNeoQSlaldD5quQj+eX8tuRpkgIyv6O8s4RXtimfT9cn4FhYPAPUdG5 +SJy1jgB742beVD/agjyXdreXB7m54xrS/8fqPyFTpyGYL5DgJ24JYG3HQPzNc+buqYU ZlVQ== X-Forwarded-Encrypted: i=1; AFNElJ+dqVqT4R7hkvvjNuKyn1fJq3EVkMgxTJoi/5kmRwhx417czLnWpztiyXV6zYySZamKdi6IvzarnqIHM9o=@vger.kernel.org X-Gm-Message-State: AOJu0YwTaCPP5YWWxgjKIXWEUgYbg3EY3qO78J8SKQ++diUoU2I/7l/I 3EbTSgjtLKyjc28b2rCF2JEim3UMv9aNZ8Ob7scy+Yts8WPBaygf+aI8 X-Gm-Gg: Acq92OHpo12J9M2Xly6A/IdzbAZjO7fpDOKaQbB25zfvSODL1B+YVU7dPdf/dvAgkSA T1hKokg7mzPapsLVk4cGllSZZ04tawqcLLLmHacaMczfYUgWD4YNZ8CjFJVJnUATT4cTETqQeYa 5E8XzBSo6hrMsnGRrTyURGOjiAHwhfZjKEVPSnD+Z4AVQduOxecHGB/rrCasFm3P1cgWeGd2dn6 5o8prUg8K+8qHcMNURqsN7SVMESHL0zRhHNb7LUwzJsmPuwkOjzTl3IfQ5cvSQFjyvYZpjGeos7 b6H5ZDjZnfvriRQNXdA86qWmY7uBXvF29j0hnmQTZKEHf9PgUSpbbZucAbinV82XUJJkcD7AO7t v3no2rRy2WKzl/dbwszGv6NAF04w51tX3WgUwt1fwx6hwjl8FVftf89G2Z4DCizxjQ2SYmODfkd nk/Etu888WuI3cwCcHCvnUfauyVCYYKU1+dw== X-Received: by 2002:a05:6000:4010:b0:43f:df1b:9e07 with SMTP id ffacd0b85a97d-45e5c5a5580mr15716198f8f.42.1779009313403; Sun, 17 May 2026 02:15:13 -0700 (PDT) Received: from xeon ([188.163.112.61]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45da0a17a22sm29560235f8f.22.2026.05.17.02.15.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 May 2026 02:15:12 -0700 (PDT) From: Svyatoslav Ryhel To: Thierry Reding , Mikko Perttunen , David Airlie , Simona Vetter , Jonathan Hunter , Ion Agorria , Svyatoslav Ryhel Cc: dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 1/2] drm/tegra: gr2d/gr3d: Initialize address register map before HOST1X client is registered Date: Sun, 17 May 2026 12:14:49 +0300 Message-ID: <20260517091450.46728-2-clamor95@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260517091450.46728-1-clamor95@gmail.com> References: <20260517091450.46728-1-clamor95@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The host1x_client_register() function is called just prior to register map initialization loop, making the device available to userspace. This may result in userspace attempting to submits a job before the register map is initialized. Address this by moving register initialization before host1x client registration. Acked-by: Mikko Perttunen Signed-off-by: Svyatoslav Ryhel --- drivers/gpu/drm/tegra/gr2d.c | 8 ++++---- drivers/gpu/drm/tegra/gr3d.c | 8 ++++---- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/tegra/gr2d.c b/drivers/gpu/drm/tegra/gr2d.c index 21f4dd0fa6af..e4148b034af7 100644 --- a/drivers/gpu/drm/tegra/gr2d.c +++ b/drivers/gpu/drm/tegra/gr2d.c @@ -276,16 +276,16 @@ static int gr2d_probe(struct platform_device *pdev) if (err) return err; =20 + /* initialize address register map */ + for (i =3D 0; i < ARRAY_SIZE(gr2d_addr_regs); i++) + set_bit(gr2d_addr_regs[i], gr2d->addr_regs); + err =3D host1x_client_register(&gr2d->client.base); if (err < 0) { dev_err(dev, "failed to register host1x client: %d\n", err); return err; } =20 - /* initialize address register map */ - for (i =3D 0; i < ARRAY_SIZE(gr2d_addr_regs); i++) - set_bit(gr2d_addr_regs[i], gr2d->addr_regs); - return 0; } =20 diff --git a/drivers/gpu/drm/tegra/gr3d.c b/drivers/gpu/drm/tegra/gr3d.c index 42e9656ab80c..47b0c6c56bfd 100644 --- a/drivers/gpu/drm/tegra/gr3d.c +++ b/drivers/gpu/drm/tegra/gr3d.c @@ -506,6 +506,10 @@ static int gr3d_probe(struct platform_device *pdev) if (err) return err; =20 + /* initialize address register map */ + for (i =3D 0; i < ARRAY_SIZE(gr3d_addr_regs); i++) + set_bit(gr3d_addr_regs[i], gr3d->addr_regs); + err =3D host1x_client_register(&gr3d->client.base); if (err < 0) { dev_err(&pdev->dev, "failed to register host1x client: %d\n", @@ -513,10 +517,6 @@ static int gr3d_probe(struct platform_device *pdev) return err; } =20 - /* initialize address register map */ - for (i =3D 0; i < ARRAY_SIZE(gr3d_addr_regs); i++) - set_bit(gr3d_addr_regs[i], gr3d->addr_regs); - return 0; } =20 --=20 2.51.0 From nobody Mon May 25 06:41:58 2026 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5B49C35AC10 for ; Sun, 17 May 2026 09:15:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779009319; cv=none; b=mDe3+IVkfR6BlhOos9LygyFsoi371V0mN/K2zoHDsuavZkMAsVm1awZL6oM8Y1dwJHdTZH5GTAEgFS+FucAxw80Lp7eX4algkFhAoa3Sd4QYJumwFw8gjpPm1N+J3yU8Qo4wrgyPNFKyc5uRqjl3WB32Tj6Lu5OvLanFFHsk0dk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779009319; c=relaxed/simple; bh=EDBxatnEUburKx8/zwpFGL7C2qiZgLPMLEqp6wZqtG4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=oCz2PzTYzzcX4vj5JwRj8VylDzZFbOJiBnYvHuMlmVBqZWRVNJlcVL+zhl7m2IBkh9fYTwJf5aTTiEXpS0jtn0bpNUaQk4nmakuzabPkq+E7jJHvBssBQ6wAs7mXoMcnhyOdABNGlB+0v+p6cJrah3BV8y/jjvuJagOB15TrRcY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ME1tqFPb; arc=none smtp.client-ip=209.85.221.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ME1tqFPb" Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-43fe3e22e33so556788f8f.0 for ; Sun, 17 May 2026 02:15:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779009316; x=1779614116; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=VaCaJ0wOxTOll8aVdydgJ1rChHHJqX36x9WrjTxVV0A=; b=ME1tqFPbotSkt0qS0HPKTEEhhpAbmWeKt8k7e9hcdux8ISc3tTJBzFBWIVmBX7HSm1 CQtTNR0DRuzcHBJyXffAWuJJVRH7cocOYdhISeDbT6ntxKkCcd3JxuIgptfTQKfsMTjW 7TVO8zO0JWN/smoFOLlDuj1OSSvxEl3BzDh3dyjndE3GqPRrMd1xHp5bIMtq25tf4C/W Ufsnd+1QStCNfkEsP/doqHT/I4eGL+6oEueUkR9eh7GkKvzk163nsxcLzlg6jRhRMfYZ /O5UfxsvzFJ0CILoyievzkkFxa3UNWU7SmHcEFYM7hWnFDvr1sECd1m1xPXSNm+o5yL4 45Tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779009316; x=1779614116; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=VaCaJ0wOxTOll8aVdydgJ1rChHHJqX36x9WrjTxVV0A=; b=OY2RReTVLBXfHli40Ab/0DQUHZI60pRL87C5/KvjBMALDALLJsg3Gzrp52I6MVxYJ8 yFM674OYv8R+yHqjw0KxVBNFKg0FRmjALrNtmL62qp6WButw8ivcd0kxj/HreaLzmzsI KHV7vmIyUUZ7pHYQg8oeP2a1x5Y4zOCz7DBPhYy5wEn5WO/9UOEsWVWqBype2+Tu0m3H BaKnnMDDl7lElQZRXZKxNiwKASrv25pxyxwpXQQuz2wMPae8hM28Ob2suHKbZU6sjggz xi36J+7+rHiYLX5rRvYGR/qr2Yuw7okNMfV96JmAi1J1GJyPPvBskFNV2yXD99RNqa+v 1p+g== X-Forwarded-Encrypted: i=1; AFNElJ+Hk4XgywjWBeFu9azzkTv8ZoMpWQQ3FR1pPjgbAYK0nLNMXzRcEZrb+/2WoTBrgfYuwBlOpLGw8b2IaAA=@vger.kernel.org X-Gm-Message-State: AOJu0YwKHDfE/W1vJ8TN06kLDnGgLkjFSXJiLWtYhzpqdhQ8Sz3s1QuS 7XS9FZ+W0y+NAM9eogPIXrJgELhTbL16VEfRmmlHmzznJ4rWy3oQlDdA X-Gm-Gg: Acq92OGcezJ+dgN+YzHP6EgF96kErnNtJ2nEG0/iqD4bKgiRILy70w1e9eETQxsgjby MOpIpHYX6O3ag0GmeoGMPP26mB3Dz0E3NoN0oDlPOY8TKgNLXMr4wLWfKIltyfAjqROT1kSNXFR eM+Wan6uIKPa3SvU/h/HntfM1oukSqnbywR5XCiyzoAbO2jnp7Z7Vsg4xVZ/OTESGX+OEJTpS0v vHSAF5IQIjXUp30GjIuCScp0gggHmfk5SHUEr5KVJh6xtU1pGcN0/vmDjhAk0bFRj7IbWMMh5hv iUba0ltdEHg2dPgsvmunxnSbKT/Q5x4B0sopyYU+mw0SBoTkZxiGK6/6Vdg3GIv6Kb4seJ99wPd WZmRD5lnjI3wQ+FwQBd1vmQAEWJy++nM6uiUttaatnBTR8OJ3fucFXW1GMtOM+IQWDq3rcz85RZ R4jUaV1yCwS5jP X-Received: by 2002:a05:6000:18c6:b0:45e:73a1:8db5 with SMTP id ffacd0b85a97d-45e73a18e91mr1859932f8f.40.1779009315567; Sun, 17 May 2026 02:15:15 -0700 (PDT) Received: from xeon ([188.163.112.61]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45da0a17a22sm29560235f8f.22.2026.05.17.02.15.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 May 2026 02:15:14 -0700 (PDT) From: Svyatoslav Ryhel To: Thierry Reding , Mikko Perttunen , David Airlie , Simona Vetter , Jonathan Hunter , Ion Agorria , Svyatoslav Ryhel Cc: dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 2/2] drm/tegra: gr2d/gr3d: Contain PM in the gr*d_probe/gr*d_remove Date: Sun, 17 May 2026 12:14:50 +0300 Message-ID: <20260517091450.46728-3-clamor95@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260517091450.46728-1-clamor95@gmail.com> References: <20260517091450.46728-1-clamor95@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Ion Agorria The current power management configuration causes GR2G/GR3D to malfunction after resume. Reconfigure all PM actions to be handled within the GR*D probe and remove operations to address this. Fixes: 62fa0a985e2c ("drm/tegra: Enable runtime PM during probe") Acked-by: Mikko Perttunen Signed-off-by: Ion Agorria Signed-off-by: Svyatoslav Ryhel --- drivers/gpu/drm/tegra/gr2d.c | 13 ++++++------- drivers/gpu/drm/tegra/gr3d.c | 13 ++++++------- 2 files changed, 12 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/tegra/gr2d.c b/drivers/gpu/drm/tegra/gr2d.c index e4148b034af7..892e3450b281 100644 --- a/drivers/gpu/drm/tegra/gr2d.c +++ b/drivers/gpu/drm/tegra/gr2d.c @@ -100,9 +100,6 @@ static int gr2d_exit(struct host1x_client *client) if (err < 0) return err; =20 - pm_runtime_dont_use_autosuspend(client->dev); - pm_runtime_force_suspend(client->dev); - host1x_client_iommu_detach(client); host1x_syncpt_put(client->syncpts[0]); host1x_channel_put(gr2d->channel); @@ -280,12 +277,18 @@ static int gr2d_probe(struct platform_device *pdev) for (i =3D 0; i < ARRAY_SIZE(gr2d_addr_regs); i++) set_bit(gr2d_addr_regs[i], gr2d->addr_regs); =20 + pm_runtime_enable(dev); + err =3D host1x_client_register(&gr2d->client.base); if (err < 0) { + pm_runtime_disable(dev); dev_err(dev, "failed to register host1x client: %d\n", err); return err; } =20 + pm_runtime_use_autosuspend(dev); + pm_runtime_set_autosuspend_delay(dev, 500); + return 0; } =20 @@ -367,10 +370,6 @@ static int __maybe_unused gr2d_runtime_resume(struct d= evice *dev) goto disable_clk; } =20 - pm_runtime_enable(dev); - pm_runtime_use_autosuspend(dev); - pm_runtime_set_autosuspend_delay(dev, 500); - return 0; =20 disable_clk: diff --git a/drivers/gpu/drm/tegra/gr3d.c b/drivers/gpu/drm/tegra/gr3d.c index 47b0c6c56bfd..388e47943d5e 100644 --- a/drivers/gpu/drm/tegra/gr3d.c +++ b/drivers/gpu/drm/tegra/gr3d.c @@ -109,9 +109,6 @@ static int gr3d_exit(struct host1x_client *client) if (err < 0) return err; =20 - pm_runtime_dont_use_autosuspend(client->dev); - pm_runtime_force_suspend(client->dev); - host1x_client_iommu_detach(client); host1x_syncpt_put(client->syncpts[0]); host1x_channel_put(gr3d->channel); @@ -510,13 +507,19 @@ static int gr3d_probe(struct platform_device *pdev) for (i =3D 0; i < ARRAY_SIZE(gr3d_addr_regs); i++) set_bit(gr3d_addr_regs[i], gr3d->addr_regs); =20 + pm_runtime_enable(&pdev->dev); + err =3D host1x_client_register(&gr3d->client.base); if (err < 0) { + pm_runtime_disable(&pdev->dev); dev_err(&pdev->dev, "failed to register host1x client: %d\n", err); return err; } =20 + pm_runtime_use_autosuspend(&pdev->dev); + pm_runtime_set_autosuspend_delay(&pdev->dev, 500); + return 0; } =20 @@ -578,10 +581,6 @@ static int __maybe_unused gr3d_runtime_resume(struct d= evice *dev) goto disable_clk; } =20 - pm_runtime_enable(dev); - pm_runtime_use_autosuspend(dev); - pm_runtime_set_autosuspend_delay(dev, 500); - return 0; =20 disable_clk: --=20 2.51.0