From nobody Mon May 25 06:40:12 2026 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C297B1F09AD for ; Sun, 17 May 2026 07:28:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779002902; cv=none; b=rHb1VDJ0sADHc/ESQKORyTUYnkmTw13JjmUiMB0jc7BI7MROmSAPyfygJ8+r24arPTyI93xqakPZX/IpnNrI01QRXo7cx97xadNqQn/6Mvby1eOnl8RpE+TKLwpwRJRX+Jr5gVIWFkSGXZAkiy9EDiPRzr4UHSd9b4/5aAKHqOQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779002902; c=relaxed/simple; bh=L5eO3pixj5NmxOTpRZvnfQnRMAnXDscCqyCnXCtwBnM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=EMTtEnZZ5LzhkoygHDZ6lHPTfE6yOTnEkcDhHahqFWm2RFjjZYhOVlUO/Y00qKn7vUxKXVn0El6Hqhu1BxGYpcvDbInhEw7xQNhPOo7seNfl+8MGj1b66zCVH0BDQZEe8a+8fVUtAV5QNQ/LK0hARutUgoDgQIltn9Ufck9BEEI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gCKeqgBJ; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gCKeqgBJ" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-488b0e1b870so17373025e9.2 for ; Sun, 17 May 2026 00:28:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779002899; x=1779607699; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=ZfqgepPcLkpTbnXkfrRVH8YKdVaUwttUDjhi9Uy4sVY=; b=gCKeqgBJ0Iqqj/W9sfRMFAzZLmZc3LEEjxKNbWr4tj0kYf2beMfmwpPD6XLoCnk2vn eTdohU2VsgFzBMhbZlbaQ80eWgOxq0I+HptFFxYBSPHqRL2wK9GEs10pflZvdGTDLlcY +KYQDh7KPbHKvsXCvVjSdnxc+08JFDq/gmdzpfwLuaaLtZNyYuPVBcNxRwsm13BHXQJW Y6jo4yK89Hke4vnF7/kB27MTPQmC2gaTL5paYeVNvrPB2qWJeL2Nte8LlwX0vbkaKZzI vFGiO37U/8VFbuAKy0kAvJweG/gNV2ZJsOhoSuHhI7FFoZBQ/RWxWUS+l7kdMtEAmDsH ZTag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779002899; x=1779607699; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ZfqgepPcLkpTbnXkfrRVH8YKdVaUwttUDjhi9Uy4sVY=; b=eyxi5P6dPIRbOq+uO1T/Q7j0nD8h/qnHzhHeJEGaL5Km8m+SiBTDjkoI4GBGjXBV57 c4fgGCmN6aME3iPzMVjAnVkTROvkbtlXauqWINB511cdIfZ3BkEbv75iOiFBJXwUVYWN VICt0PNC+pph1qztabCyH0dUzcU3dW92rcAD2Gyhap96153kCBILtlm229c16ihGS3sp TIpZvMirTs0VXLDqwpDRXGAXSAUQg1Xpo+megI6jBAVpvjJD7kpNsXh4JeJqsmalcKGN Q/gMNAJXNCVHNO5tmYlvpLdCZggK9GlFjzM+clvGsGCrKmgbd2k42ZLrpnkvftUa1/XN gQ1Q== X-Forwarded-Encrypted: i=1; AFNElJ8nAt+M11MC2G9BJV+1fxAJeHDDQoHyLYfRVVtP9NPeyBrsP5Nf0pCm/uclyrFB+bcoE376QeMp9mTxQwo=@vger.kernel.org X-Gm-Message-State: AOJu0Yys1DXlH/j2LsO790hmr7PbuQVRIwB0gtKUEBqW0EMXmNSmcgE8 yUa4Lv5JmVwShRhrtATixqeExGMTX0GB+U9RZS2vlqoM7ZLhuMEV5rJBx7zfJg== X-Gm-Gg: Acq92OF2pU3oZfUw0FUtDKju6W0gtPzbKTw+SDwVIqSJTjRwm6DAnAXXLl6YlvUdWlG WbZSl/aNGm9K5uowO6yKpkNbwJBVE0+0kvJTpjgiE5OyzdZaVK1eVch3ETFq9Huz8ieXQNPKj02 fQy1MrMmyN7gyODer/tAZL033c4XiUvFPhrBBWHTAVaPt4EdKPCCyXv/0sEtDpRmOVY9+Yk6/0h FF+Pq1d1DCBw3P1XdS4/ZfHNYz5UwTYEGcdwHlMKpVSThcH1dyfnVTrhLD58yFjAT0qEb/MCAJQ 8MGNASpuEDdhc/IQYmxjxWn6yn7bG/Bz9fYzuTreyLxhSdAeYInWmH7zDM+CZqFIFJJ5uJmeid/ LWE1xM5xXYF2S1/i3ShNwAJ0GDQ5aSlynxOIo/MDOk03py6eWFE8Hd00JGJ1Z/Ir34V3j0ziT9r kGw5qV/ObLO89MnV1RjQwiDIE= X-Received: by 2002:a05:600c:3e1b:b0:48a:9562:7a30 with SMTP id 5b1f17b1804b1-48fe6515f20mr138558215e9.24.1779002898976; Sun, 17 May 2026 00:28:18 -0700 (PDT) Received: from tumbleweed ([95.90.185.4]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48febe6b9efsm79400585e9.5.2026.05.17.00.28.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 May 2026 00:28:18 -0700 (PDT) From: Michael Straube To: gregkh@linuxfoundation.org Cc: hdegoede@redhat.com, Larry.Finger@lwfinger.net, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH] staging: rtl8723bs: remove READ_AND_CONFIG_MP macro Date: Sun, 17 May 2026 09:28:02 +0200 Message-ID: <20260517072802.71149-1-straube.linux@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove the READ_AND_CONFIG_MP macro from odm_HWConfig.c and call the ODM_ReadAndConfig_MP_* functions directly to reduce code complexity and improve readability. Signed-off-by: Michael Straube Reviewed-by: Dan Carpenter --- drivers/staging/rtl8723bs/hal/odm_HWConfig.c | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/odm_HWConfig.c b/drivers/staging= /rtl8723bs/hal/odm_HWConfig.c index 4784d33eab0e..937002495d09 100644 --- a/drivers/staging/rtl8723bs/hal/odm_HWConfig.c +++ b/drivers/staging/rtl8723bs/hal/odm_HWConfig.c @@ -7,9 +7,6 @@ =20 #include "odm_precomp.h" =20 -#define READ_AND_CONFIG_MP(ic, txt) (ODM_ReadAndConfig_MP_##ic##txt(pDM_Od= m)) -#define READ_AND_CONFIG READ_AND_CONFIG_MP - static u8 odm_query_rx_pwr_percentage(s8 ant_power) { if ((ant_power <=3D -100) || (ant_power >=3D 20)) @@ -415,9 +412,9 @@ enum hal_status ODM_ConfigRFWithHeaderFile( ) { if (ConfigType =3D=3D CONFIG_RF_RADIO) - READ_AND_CONFIG(8723B, _RadioA); + ODM_ReadAndConfig_MP_8723B_RadioA(pDM_Odm); else if (ConfigType =3D=3D CONFIG_RF_TXPWR_LMT) - READ_AND_CONFIG(8723B, _TXPWR_LMT); + ODM_ReadAndConfig_MP_8723B_TXPWR_LMT(pDM_Odm); =20 return HAL_STATUS_SUCCESS; } @@ -425,7 +422,7 @@ enum hal_status ODM_ConfigRFWithHeaderFile( enum hal_status ODM_ConfigRFWithTxPwrTrackHeaderFile(struct dm_odm_t *pDM_= Odm) { if (pDM_Odm->SupportInterface =3D=3D ODM_ITRF_SDIO) - READ_AND_CONFIG(8723B, _TxPowerTrack_SDIO); + ODM_ReadAndConfig_MP_8723B_TxPowerTrack_SDIO(pDM_Odm); =20 return HAL_STATUS_SUCCESS; } @@ -435,11 +432,11 @@ enum hal_status ODM_ConfigBBWithHeaderFile( ) { if (ConfigType =3D=3D CONFIG_BB_PHY_REG) - READ_AND_CONFIG(8723B, _PHY_REG); + ODM_ReadAndConfig_MP_8723B_PHY_REG(pDM_Odm); else if (ConfigType =3D=3D CONFIG_BB_AGC_TAB) - READ_AND_CONFIG(8723B, _AGC_TAB); + ODM_ReadAndConfig_MP_8723B_AGC_TAB(pDM_Odm); else if (ConfigType =3D=3D CONFIG_BB_PHY_REG_PG) - READ_AND_CONFIG(8723B, _PHY_REG_PG); + ODM_ReadAndConfig_MP_8723B_PHY_REG_PG(pDM_Odm); =20 return HAL_STATUS_SUCCESS; } --=20 2.53.0