From nobody Mon May 25 06:41:10 2026 Received: from mail-pg1-f175.google.com (mail-pg1-f175.google.com [209.85.215.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 51DA81B78F3 for ; Sun, 17 May 2026 03:36:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778989001; cv=none; b=bx0SAfjCl8UF3/0hSsg7sWz2NbsyqQuLSgEWE5ASTyw1zK10wCzxgPL9Zj1y1MuuPBePVOK4w4zFFshE3n54nTC0/MlTLuEgEbHsf/kclcMvvWWpf6CyghecpenymMEpxbQ8YXYhR8krapIgY2Dzbkl3Dm+T5r83kX9h/OVSOLk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778989001; c=relaxed/simple; bh=whH7887zyQvZA11L50ur5qZC+bE5FTEbc1kM9w0jpA8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=uzsJCp+4QlGowl4Dfb4NEJV0BE4dGQBwjoqwKBwvd9rQrniHGlO8+WY4gAuPedhlSsERo9CvYS/ueLZPISwah0ATmHkS7TiCcB450zkHN1sCp7sbgr4OZm8GAkkqUUZ9obTpL0JDsPcqSk6PwKMbf4BbE4QRwEpM9Na9KV5E33M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZlDspdIL; arc=none smtp.client-ip=209.85.215.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZlDspdIL" Received: by mail-pg1-f175.google.com with SMTP id 41be03b00d2f7-c80227c9572so407091a12.2 for ; Sat, 16 May 2026 20:36:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778989000; x=1779593800; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=D+qhnPe16QutqxQXlzcsyVZTSBMTfqcLNuKVINp5gDU=; b=ZlDspdILyR3kihlV4kcu9KEnbdLBUEPrVvvoelPHIKUesT2OD5l0bNNugkZnVcbjFC bEEeTmVNayhXoxYQKt56k50KnaDBL0DldKGW7a8m3Ak+1CHg5CWwIb3T8hOVbRsjkBPb 0htWgILvKZhIuW5b1mSZBo4KOy/rnewIcuMDR6+Hws0purVv+HyPlbayEGe4XQs7OTlW Rv7t9nE0q2LMIGbjwg6Aa9uuHTyhs5K8QfIZpxOvAOTN2llQDjI6T4DuJnOBpTYopMbH JS/9g9NqRg/HjIubIAmj1UlXFPiofAQNq4AcCjMjit8MZMmAlIOd5z/VChRL5XDHR80l Njsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778989000; x=1779593800; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=D+qhnPe16QutqxQXlzcsyVZTSBMTfqcLNuKVINp5gDU=; b=hG8tw0w5ouKLUIRQzow2lzi8jECW1JK/kyipIUnPUpDg3xqUCBIjnwMkDTgJXAL0N1 8j+VtliwyxAax4A3+F3wMQgqGtZ8wG7vwTeax6Zdp6woSihxK5K1I1x2JfgAJO+7U6XM 4+2e87TyqioLyBjT5KUCSRpqYdvB/Ykv9eEqMPCt3snvvkdRBngtZ8FRhNxXQz1FWR4q gEnadwQlgZz1XaDBMaBt2HC3kUzn2h/9MRM6D4S9ASj9NS251sI2+60ACHx8AeegVjAs tCA9FkgMgwDlLiAS0uparGiT1DkyxcU1YbTUq0Ar0I7XXH9eabXpCtgi3wpEiwA0m/LI PZ+Q== X-Forwarded-Encrypted: i=1; AFNElJ/r9ys+/BxeQyAS8ivJbUM44HkLfFPB2xJ2T987cIiWkDXESLsicuUtnR2NkZMlQQ4kOUri3S6KSAIk5Ns=@vger.kernel.org X-Gm-Message-State: AOJu0YwboFvR942uYrbsFTaQWm3omWgk9JXPxDKVXMHGMX/ifNGh24yA 1ozWi0ck5Tt1JsavHNc7R6THdHQj4pXHTJuFNbSE10D54OE6uTVE6hfN X-Gm-Gg: Acq92OF2IscUM7nhdm3z5NYwhdvsWkL+q3pVTcosxWal+TRb+vd/Ry9fiWO7uo9XDsi fY3L63BQMXyYsKbVs7XWLKbB+1Gqm27m6SvghWR8hWWL3Dd7rrAiuVL4RNc26/omhomlHlapke8 QjAghqkGZYgbpotFG/uIgyx4qNo9FxFBM4tYFjuV9d6TCeiAfUAE2GEs2uuWhX9MhjMG+J9ixfl Lr7X/zC8di25JL6JlMrDnwp0FywTPEeCO/1HSrtSAaL6kbIN5pWbWg61e1nYf72fGFXC5HgE3JR ksYLWG/G0KSxjXS4IjjtL6PMhn7Q3AywxTCn8TISYrix+TxwkYkVuIJzmXkV6v51sCQ1KG/v77K Aqkb9nelFQYeq2JxRYiThQw+hOYTfpmtu9mOPNMKAOJyN5mteBgmFRQJ+6NpT1sTaqBs01NYJO1 avAvdmf29qsE7A3Soc/HaqvIyZTM56+7xdmYtHOrd+3OqnfOI0+YW23CrpFCpqnoOfn1FEkPCCd CZNrVAeups8g6SYT8SrJKlhj0/sLPpmqTo= X-Received: by 2002:a05:6a00:3925:b0:838:29b3:9ed1 with SMTP id d2e1a72fcca58-83f33df85ecmr10195406b3a.41.1778988999295; Sat, 16 May 2026 20:36:39 -0700 (PDT) Received: from ryzen ([2601:644:8000:5b5d:7285:c2ff:fe45:8a32]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-83f196647aasm9794224b3a.5.2026.05.16.20.36.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 16 May 2026 20:36:38 -0700 (PDT) From: Rosen Penev To: netdev@vger.kernel.org Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-kernel@vger.kernel.org (open list) Subject: [PATCH net-next] net: ibm: emac: Clear MAL descriptors without memset Date: Sat, 16 May 2026 20:36:21 -0700 Message-ID: <20260517033621.1839397-1-rosenp@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Clear MAL descriptor rings with explicit field stores instead of memset(). The descriptor rings are carved from MAL coherent DMA memory, which may be mapped uncached on 32-bit powerpc. The optimized memset() path can use dcbz there and trigger an alignment warning. The skb tracking arrays remain ordinary CPU memory and still use memset(). Assisted-by: Codex:GPT-5.5 Signed-off-by: Rosen Penev --- drivers/net/ethernet/ibm/emac/core.c | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/ibm/emac/core.c b/drivers/net/ethernet/ib= m/emac/core.c index 1fd7cb50c568..7ab5c944f5de 100644 --- a/drivers/net/ethernet/ibm/emac/core.c +++ b/drivers/net/ethernet/ibm/emac/core.c @@ -1161,6 +1161,17 @@ static void emac_clean_rx_ring(struct emac_instance = *dev) } } =20 +static void emac_clear_mal_desc(struct mal_descriptor *desc, int count) +{ + int i; + + for (i =3D 0; i < count; i++) { + desc[i].ctrl =3D 0; + desc[i].data_len =3D 0; + desc[i].data_ptr =3D 0; + } +} + static int __emac_prepare_rx_skb(struct sk_buff *skb, struct emac_instance *dev, int = slot) { @@ -3121,8 +3132,8 @@ static int emac_probe(struct platform_device *ofdev) DBG(dev, "rx_desc %p" NL, dev->rx_desc); =20 /* Clean rings */ - memset(dev->tx_desc, 0, NUM_TX_BUFF * sizeof(struct mal_descriptor)); - memset(dev->rx_desc, 0, NUM_RX_BUFF * sizeof(struct mal_descriptor)); + emac_clear_mal_desc(dev->tx_desc, NUM_TX_BUFF); + emac_clear_mal_desc(dev->rx_desc, NUM_RX_BUFF); memset(dev->tx_skb, 0, NUM_TX_BUFF * sizeof(struct sk_buff *)); memset(dev->rx_skb, 0, NUM_RX_BUFF * sizeof(struct sk_buff *)); =20 --=20 2.54.0