From nobody Wed Jun 10 07:46:21 2026 Received: from mail-qv1-f48.google.com (mail-qv1-f48.google.com [209.85.219.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B11DE175A81 for ; Sun, 17 May 2026 00:02:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778976161; cv=none; b=RiA7DvBaUZDTsNZLiWZiyVKT5ph2+4UHsz+cvlg0rgPUGHum7kTKQ9o7t1HBoE0ChnugOqiZeIiosPLlBcAOc9uctM1YjQ+vwMIJQ7jCwYdIIfIbWDzW9XLFDj3H0eC0VJkswVmECT1+EQSb10BT06/fY7ASEChKpLNXtRmDlfs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778976161; c=relaxed/simple; bh=oQJngmEu0j3+tcN/u4AN3DlXYKxuepMSFr6Cvgon1iA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=HklbpcLHFHqKPTkkjCTooj2YviNci4UuwIJq+LDrMdkbD9Y3bTa+Jz6FRfzFjwLT+BSwZYxUbO5In4V66N90CgJIj2Z3gS25z4wz7+Sxl8x6zi3JXI+yYtG/ZPFXyHZHltESunekXtaqmpB3T3steS8mmH0Nly5+HrRz19KA/wE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=K3h4W2Q0; arc=none smtp.client-ip=209.85.219.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="K3h4W2Q0" Received: by mail-qv1-f48.google.com with SMTP id 6a1803df08f44-8b5232009a6so19963356d6.1 for ; Sat, 16 May 2026 17:02:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778976158; x=1779580958; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=jJ2BXWX+6MupH7Oh26vJ/9N7l3A/xSH7CB0Vx9j5o38=; b=K3h4W2Q0UL3EqLBl8pzwIxM80sSqPBiDRv2nf2ad+9hmDsAk8MAIvJnbGIfK3lcYvq Umi4JiC7rAa3W4z0c3Nt2zt6TGpukole5mbPq4yl1ga7RRwi0xPbQdkVGOnSQiFPTU1m qJtZQxmNc4Es2mQ3E72CuPkJn2j1u8CSYOu0NOzl060WzV0i2VB86s7zJEwO7ExiYbvh t3kVIZSj2kkvA94drArJr5ZjFo2m61GT7HpTec+TAwJNiAeKpMDt6/gJGSe9VbvM3fwa uOLUsc00XNm0uOUS5mLXB//8qBKmQ8PJ8Wlo8QZv4v9cc6RfM+83UuE/eHsXVyR6LZHe tCOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778976158; x=1779580958; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=jJ2BXWX+6MupH7Oh26vJ/9N7l3A/xSH7CB0Vx9j5o38=; b=XY6JQ5Yab09hv6X2XnofpmZOVvwCEqcC4LsVykoAZ9Q2MAnhZuzTq//AiP+Ci/oxeh wbmX3sGGXqp4QpGcIolhaLuja6rZpYIFjUxi7YZOiS+dkoFzGxp1Hq1ilCjEUwoKHmA9 DPdmcxHnsueO+DYIN8O+PpAh6igzb5GKvvjZoZkNe3NzfayMG/SIP22cvsTOqowsM8vl u1cMBrZXJxS9WeLXeZX/imJ2evMUUt62I8iSXw1MyUvygOQDjZHUlQcnT+N7TejyfzLm Iblf4otFt8A2TgOwQAaoerwx9GmnPMHwM+0NN0UXLYwK/fmyAiTHywQ4FWodbIy2PjO9 c8Ow== X-Forwarded-Encrypted: i=1; AFNElJ+vwNb+oMso6JRPIeFE9G3BHjPRNzT7X0txmEcA0z2B/2RuVNC6JG8j/T/UTw7Jm4pFpx+A+J65j0fsWTE=@vger.kernel.org X-Gm-Message-State: AOJu0YwC0xdVO05r88IjpVcB8yvITX23G0dCqJdPmbNr4tI/v6GGEgAQ BX1PjJs4MAVCa5SoxrW2lRtTM8BJTDEWR9zrTqEjrNAHlpAQ650CjNOUBoeR2LpN X-Gm-Gg: Acq92OHSDmzqNwbP4IZtnnFVkeJyJ71lCN008br2vaxE1g/LmnFdTbI+W8NDX2IMy5y 5DWrP2pXZdZDAj/61lImZcXel3ULlKu5KDYS/PtHWs6EnEcgyJO7B0uBWt2fjehi5l/fholyCb3 st3eqhk43DBr3laoeT39CCmmCIWGdVvm4P0Z2PqbaWawDDZZP6pcjZc+MZqr5pMUzmKB1aILYAp 2goSXtX1Z266RaBtBE+jeRQ7S7NMLrs9iL1zAwMGGR4BvHDSDZ3kdlaoizUexufuH5HhJHnQQTG nrFsSRJUM9dhWyZo1W5HFM4xe8k0Nyys9PPVATtp2o1wTDEroErjCc8aOfJIMoRNd14MMMkVMDc Z34795ORI2ho6LtY+n2ALGHscs2CSd/mjkaXEtRqAewn25aTHmvIAH4B+6dTD5bd1bDAnmCwbwD AvtOmw3Ddkvl1n2Scfu5woP58SSNa00VuR7QOMrm982geW4mQcf7GeDjXYRzbR7w== X-Received: by 2002:ad4:5bef:0:b0:8ca:25c1:ec45 with SMTP id 6a1803df08f44-8ca25c1ef16mr70226216d6.10.1778976158578; Sat, 16 May 2026 17:02:38 -0700 (PDT) Received: from mango-teamkim.. ([129.170.196.182]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8ca361b8b10sm2980956d6.46.2026.05.16.17.02.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 16 May 2026 17:02:37 -0700 (PDT) From: pip-izony To: Greg Kroah-Hartman Cc: Seungjin Bae , Kyungtae Kim , Kees Cook , Dan Carpenter , David Mosberger , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] usb: host: max3421: Fix shift-out-of-bounds in max3421_hub_control() Date: Sat, 16 May 2026 20:01:46 -0400 Message-ID: <20260517000145.1868817-2-eeodqql09@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Seungjin Bae So if a malicious userspace task with access to the root hub via /dev/bus/usb/.../001 issues a USBDEVFS_CONTROL ioctl with `wValue` greater than or equal to 32, the left shift operation invokes shift-out-of-bounds undefined behavior. This results in arbitrary bit corruption of `port_status`, including the normally-immutable change bits, which can bypass internal state checks and confuse the hub status. Fix this by rejecting requests whose `value` exceeds the shift width before performing the shift. Fixes: 2d53139f3162 ("Add support for using a MAX3421E chip as a host drive= r.") Signed-off-by: Seungjin Bae --- drivers/usb/host/max3421-hcd.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/usb/host/max3421-hcd.c b/drivers/usb/host/max3421-hcd.c index 0e17c988d36a..3d6b351dcb1a 100644 --- a/drivers/usb/host/max3421-hcd.c +++ b/drivers/usb/host/max3421-hcd.c @@ -1694,6 +1694,8 @@ max3421_hub_control(struct usb_hcd *hcd, u16 type_req= , u16 value, u16 index, !pdata->vbus_active_level); fallthrough; default: + if (value >=3D 32) + goto error; max3421_hcd->port_status &=3D ~(1 << value); } break; @@ -1747,6 +1749,8 @@ max3421_hub_control(struct usb_hcd *hcd, u16 type_req= , u16 value, u16 index, max3421_reset_port(hcd); fallthrough; default: + if (value >=3D 32) + goto error; if ((max3421_hcd->port_status & USB_PORT_STAT_POWER) !=3D 0) max3421_hcd->port_status |=3D (1 << value); --=20 2.43.0