From nobody Mon May 25 05:54:39 2026 Received: from mail-wm1-f74.google.com (mail-wm1-f74.google.com [209.85.128.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4CA2F1F4176 for ; Sun, 17 May 2026 23:37:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.74 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779061066; cv=none; b=m6531polMLFle4FigOs+HjUSbO1kjQ0KwLtG4VUGukFQpqp7leoqv2YXVgLL3xRFU48KZPK0tN8QCOvx0EaNezKuwarOTHQJUXJoolUIVRB2+RpPuDFyK8JrqrInH8LUQnPfUp1FUEXnKpA3qrgwpPH1wFa5CQM4TId/hsV1x9k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779061066; c=relaxed/simple; bh=tt2IVtFgwcZpFQCWOPn5S5vhok5Xituinl/B/eBVkgQ=; h=Date:Mime-Version:Message-ID:Subject:From:To:Cc:Content-Type; b=qNWfq9WAi7j54RL0/1HAvquNPYswA6B/U5MSB7wCJh+4ssMNcdxR3YpjdsNtYpNrkAFKv/KoUSaPS3t7nO/uDJg9nseHjF5atTPQK/7Cxi6vAm+/c/uWbJgCnpuO7CDtzUIMhhorejtLVEvhlEremuweVMUUQsyUDYSzMzscw/s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--jackmanb.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=k9J7XV/E; arc=none smtp.client-ip=209.85.128.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--jackmanb.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="k9J7XV/E" Received: by mail-wm1-f74.google.com with SMTP id 5b1f17b1804b1-48ff0eb77b5so15107385e9.0 for ; Sun, 17 May 2026 16:37:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1779061064; x=1779665864; darn=vger.kernel.org; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=IIw4dgFcNyD4s+iRRHHoK6SylCzaJ865VSAF+4CcMNI=; b=k9J7XV/EJx+Z2dyKG2IFbCQhGBSfq7TMfCMrTyOeZ9Xc/gXaBD33vWf4gNbbra6M1d /zdsDBNreZeCKhoRyP41ZOGKd8UxblPp9VV6y/ZoFd4VwMfdGQu7pvFiAQEXJT1S1yah MXQnB9fh0wNrED7/ud7zUOSCIdzLnogJZ/A1S7RAEEGyrryPEowXFCTcmQyCSS2+5B16 eLmaq/fTnIfSEpZ+7wVrpTF6hwAybdjgvSpmmdq4Hsm8dG/oNtZ5JgRNSbv2aWEkAG+q 3iRo5ezv0zkTuCrAJSNhvxAQSRkSbpvpRR4BxOdV/GYRdYm6zm6Whz+UJOE6pFoOtg90 2Czw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779061064; x=1779665864; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=IIw4dgFcNyD4s+iRRHHoK6SylCzaJ865VSAF+4CcMNI=; b=r3Eu9aMm2b/LvaPuqqzQmoPZsfyl/xCqM3h0MLmOMvZChTRj5I2IZ2eLKLshpkiYk6 kYCjTC6eZvhwv89DxNFj4Zg48s+b9u9EQWbqT1lnr0f4wjWxx+xDQHVbI+Qp4ZusYjwc G8SpXRj2/+Fml8gL+WWWlvffGIdqYZxf0hn12Vp/SKdSZTf+4nNyqWCse1D0pN1URaXh DQ8kQ60PzksGShNxxOJUAhmEwbbZ3/gwJzQntaHSfmbVY1xYact30HwUmb/OdCjVpnhY b7qTaGAFxkUTDUV4EMUI/Gyvahham88ZgrZDCZoCagOSO+aqNMPJ+7peSgwkhupnxYue bZLg== X-Forwarded-Encrypted: i=1; AFNElJ+adnkLOX4JBGIzbE+vhYZxMVayzljZ1uxIXZ+aVU6mzbIFRlu7M0cNPEjYV2LwEG5EQkhMufVDv8EZu3U=@vger.kernel.org X-Gm-Message-State: AOJu0Yy5CizDkgr3j34n1dWuec2So5bxXzzxjZYZMhr9rd0yIO4EoCxT yYsnq9djqjE02K7bxk2E3Xp8IA53/N17rgOIDetcKO2LdpFLYgMDUyvnd++D1TdVah0AJdwt4+8 YS0nYYmApfHL/7w== X-Received: from wmqn21.prod.google.com ([2002:a05:600c:4f95:b0:48a:8fea:9222]) (user=jackmanb job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:3f1b:b0:489:1c5f:3a9e with SMTP id 5b1f17b1804b1-48fe60e7fa1mr196320125e9.13.1779061063690; Sun, 17 May 2026 16:37:43 -0700 (PDT) Date: Sun, 17 May 2026 23:37:05 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-B4-Tracking: v=1; b=H4sIACBRCmoC/x3MTQqAIBBA4avErBtQqYyuEi2mmmpALBT6Ibx70 vJbvPdC5CAcoSteCHxKlN1n6LKAaSO/MsqcDUaZRtXa4ljhHPYDyV30RBTvxDNqa5VRrZ4MEeT 2CLzI/X/7IaUPj+apaWcAAAA= X-Change-Id: 20260517-b4-drop-always-inline-17702081c2aa X-Mailer: b4 0.14.3 Message-ID: <20260517-b4-drop-always-inline-v1-1-97b90930e8b8@google.com> Subject: [PATCH] mm/page_alloc: drop a misleading __always_inline From: Brendan Jackman To: Andrew Morton , Vlastimil Babka , Suren Baghdasaryan , Michal Hocko , Johannes Weiner , Zi Yan Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Brendan Jackman Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable get_pfnblock_migratetype() is called from outside page_alloc.c, so it cannot always be inlined. Remove the annotation to avoid misleading readers. At least in my minimal config, with GCC, this doesn't change mm/page_alloc.o at all. Suggested-by: Vlastimil Babka Link: https://lore.kernel.org/all/016c8bef-57ef-44ef-bf60-86dbfd368dcd@kern= el.org/ Signed-off-by: Brendan Jackman Acked-by: Johannes Weiner Reviewed-by: SeongJae Park Reviewed-by: Vishal Moola Reviewed-by: Vlastimil Babka (SUSE) Reviewed-by: Zi Yan --- mm/page_alloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index e262d1316259d..be7f5671d421c 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -434,7 +434,7 @@ bool get_pfnblock_bit(const struct page *page, unsigned= long pfn, * Use get_pfnblock_migratetype() if caller already has both @page and @pfn * to save a call to page_to_pfn(). */ -__always_inline enum migratetype +enum migratetype get_pfnblock_migratetype(const struct page *page, unsigned long pfn) { unsigned long mask =3D MIGRATETYPE_AND_ISO_MASK; --- base-commit: 0cec77cfd5314c0b3b03530abe1a4b32e991f639 change-id: 20260517-b4-drop-always-inline-17702081c2aa Best regards, --=20 Brendan Jackman