From nobody Wed Jun 10 07:48:00 2026 Received: from mail-qt1-f169.google.com (mail-qt1-f169.google.com [209.85.160.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4EBBF377015 for ; Sat, 16 May 2026 21:26:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778966798; cv=none; b=IquFFDzyUAyNpaT3BJAFzEwFb74wFCyGoZVks0nMEryNX8YXVCqmUtw5vNt3kVl+xScAe6R6VVrdVFqmSqv9XIb0jZM+y9l6qegVD92jGiV7zoWDFK72WF6kctCvwW30g4r01wmi3O94TVL1Gg2ANvYgN5/80Zi83531JsQcb1o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778966798; c=relaxed/simple; bh=f9ZwFuaKGQRA+DBYG7F+VjxVpKzmwhziUkp/RHQr0eQ=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=ILNInJVo1zNDL5Pzr1QKh8VlRQh0VmHxUnS7jbGydlk8KuLaXNl89JW3728eB3r1NHAFoY8IpT87+jL5CzOSDKMXloahsgYXvklnAVtwc1rEq/MztKyheXAdoEv/G4rgxXczvoEtSRjiSgcyhZKxT6wTIu8k0OW/to/gVbQLknw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AuUzrrzh; arc=none smtp.client-ip=209.85.160.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AuUzrrzh" Received: by mail-qt1-f169.google.com with SMTP id d75a77b69052e-51306c9f2e1so15586751cf.0 for ; Sat, 16 May 2026 14:26:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778966796; x=1779571596; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=65ej9TODkD4mh9cNuPqJS9kfozbOcNNTiAmzyQQYmMc=; b=AuUzrrzhPDq1jfnzDysx9JR6YM1aHpkoFUdJf2s9kbPxPrwHxNCOgABHz8mjw1n5Uz e6qbH4MP4DH/t6yQFCvzBmaUuqZkvcNxy2pjm+mrNuIznfdQrDLw63RmX6V+6it1knCZ H7GHq0KzsNGb5jDCz3RaukquBtVw28qwfUfzKcL/dLSW4SYv2OdnK4/eb1iXflrzuw1A 30eu7geAB8/6xobtsC1xUPmjPRFEpVWIV8HerQOOarlgOz3tm+mbgXogfwjp5k4yk61F WPmmTDQnLrvU29bNg0aCFrkYIGQsMGVSTJ4IY73zmn9NRIcGHqAwCLVJtsNNApkAgrA6 M2BQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778966796; x=1779571596; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=65ej9TODkD4mh9cNuPqJS9kfozbOcNNTiAmzyQQYmMc=; b=PYrd0COB79XBh5JBdq8DFwNaWAsMoNWdkTqNAxozRN2TEgvbaONEF2iL8uOLO8gQcw M8QQ84eMI0QkeeGyDlETpt5/y2XKH+27vJ9e8GrfFQG4FT8dmaCrPbuIhFcYwN+EU4iw ZxITfHECFpLvmj4pchfRl5X5wcZLGOAABqJQCKwqoQlaQ18msa0galGjXr41mSsfU42V PUXkGh7kD7itSdRHlY9mpPjGbeeF7ZODC1RMuU3LbQbaWpdvLL3z4Hdt2jMJgUZJKf4j HByuhakWLmADSmjNo9/PMTQz6iL+NbOatIccdJWJsznN4X/ojNzvGq/3bd7Yo5dOGL0a szDg== X-Forwarded-Encrypted: i=1; AFNElJ+DUhbSQuSXmJFhIj6Jv255Ardsz08juv1Uxnm0UPfbJBtsSQmcNmQCvZzw0HOlhUQ1zjsy2PrsFwJv644=@vger.kernel.org X-Gm-Message-State: AOJu0YxN1hDBCL8cJ2pTQMpk7m3KFH7t7yOyzHidw71zz0ZOHgLXbUaU WPVFwpALF7k45xZM4ulmHqUwpVa99MVeiWh89uROkBqDLErd0zeNk80n X-Gm-Gg: Acq92OHesMgfujh/yCHKdyRyDt3NtlpXNdWfL69LZlLFKWQCjS42oVPJrt5ydLGXBu9 6NsbxSqStNzEt5Ue4dqbpJlMdxn2TB22H+e7PBJk3nLc4yWLbM7dvLERXgqFFQggKXJjzvkE6HL g2gcrBjomAfYTFlGdkJ+k3odhfPtmBlpU2DS2aWwxsPmOmPUg4/4b0tuMZMfz/RUJM9m83Epxtf 2w2ATjk+flT9V3l/SmGNinmTFRvVXHqh4xJrbJQuLdhSBWur3m6QkTS+p6K+o0nlIPlKN8wcnJ5 PMMXVUb+U/vYT0sx3HOa1Gml5lN2Du9TPnn2II2twdLVqEK6nTldQyUUOCkkXrPZcDaO9Kx7vZ2 Y0O4thS8R9/7deLxFWz8PN4RfuzagrKyay5xgozKwximTt7v/Og+b+jK5q8G7xrNVlNnKrbwdMF JouKmweXPHB+29N1aFvYA3REB5mjRbA9oJAzHmK+cJ8eK8ukflu+30Jm/o2akOJNFDtvCo8olHr f+IlyEZgzuKexbdIKOmJg5NnozPu6LMxyc= X-Received: by 2002:a05:622a:1e92:b0:50f:bd51:f1d2 with SMTP id d75a77b69052e-5165a253abbmr136300431cf.50.1778966796201; Sat, 16 May 2026 14:26:36 -0700 (PDT) Received: from ryzen ([2601:644:8000:5b5d:7285:c2ff:fe45:8a32]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-516460cda02sm85319761cf.18.2026.05.16.14.26.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 16 May 2026 14:26:35 -0700 (PDT) From: Rosen Penev To: netdev@vger.kernel.org Cc: Chris Snook , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Oleksij Rempel , linux-kernel@vger.kernel.org (open list) Subject: [PATCHv2 net] net: ag71xx: check error for platform_get_irq Date: Sat, 16 May 2026 14:26:16 -0700 Message-ID: <20260516212616.11758-1-rosenp@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Complete error handling for a failed platform_get_irq() call Fixes: d51b6ce441d3 ("net: ethernet: add ag71xx driver") Signed-off-by: Rosen Penev Reviewed-by: Oleksij Rempel --- v2: adjust description drivers/net/ethernet/atheros/ag71xx.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ethernet/atheros/ag71xx.c b/drivers/net/ethernet/a= theros/ag71xx.c index a5ab99474179..4e4794c4dfdc 100644 --- a/drivers/net/ethernet/atheros/ag71xx.c +++ b/drivers/net/ethernet/atheros/ag71xx.c @@ -1856,6 +1856,9 @@ static int ag71xx_probe(struct platform_device *pdev) ag71xx_int_disable(ag, AG71XX_INT_POLL); =20 ndev->irq =3D platform_get_irq(pdev, 0); + if (ndev->irq < 0) + return ndev->irq; + err =3D devm_request_irq(&pdev->dev, ndev->irq, ag71xx_interrupt, 0x0, dev_name(&pdev->dev), ndev); if (err) { --=20 2.54.0