From nobody Mon May 25 08:11:54 2026 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 83965381B0A for ; Sat, 16 May 2026 11:44:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778931851; cv=none; b=o4ujjCwvOwG/Baer1Hlx0hy4fq3c4dbidMQDTRUPRKfTIdjPcOC82+0iWXgqgu9HBOjY/Qb6Vvv+MxPGYP6sQD7waL37H897XHuIUvUecR76deeudJRthOe7bSQeNQaw8zC6MhM1Qyqmh6IgSKVjQlBZb+cMsXINLgAUdBEYowY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778931851; c=relaxed/simple; bh=++BkVs6zd7CoLhOO3C+xH2eBltu/4VfD8o0OiHfcmv8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=iMj1TLis/2IJOAJPN/IYC9ewThD2xfswYFB5iJy0cQ/mVBQNk6pO72wI0ko4znUcG8EB3XaeZyChitLDU+BwzfYYhwE3A/gHthS4/QkhDgaAXq3w8+kZLlcLAhG+M58a6cBYHjay0+NpJUvi3XxBPzoHFq+mDdOiY8gx58evjVg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XFt2K+Fu; arc=none smtp.client-ip=209.85.221.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XFt2K+Fu" Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-459bf19e87bso327670f8f.1 for ; Sat, 16 May 2026 04:44:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778931848; x=1779536648; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:sender:from:to:cc:subject:date:message-id:reply-to; bh=xQSGGdfR3qK5EGYwiYLtow8+RTdavMFkAuIx9DxFHaE=; b=XFt2K+Fu+LU1Zz00STqqf5c+lMK3y/hadYTeP5wXUdkRqbTqtwnTFEpK3yYNeJcKnE 5//3CJoREM9mJ95VSeLeEVrQYgs1TbCWAtaGgoG/J+7/pf0CtzO80d5UdLFBy0brNo+Z Y8lSAt5hoJ3Q8JbOeBCID7mJIHVJKlDmMHElcrpYI5JOpeyMfuyASS2/y901Dz2P7WsK JiqM7UuNLFnoNXT2UcKolP7yyIYJ9LYMGWkawaoGL/t6crefNkYQhxbHUNgQkHxYqcKi JzgEfasnd6zUsfIcvm/apusNUAdkUDM9SbUnfTbxGAJJTDFVDZjXGHy4UGZroGGSGIyc ntlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778931848; x=1779536648; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:sender:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=xQSGGdfR3qK5EGYwiYLtow8+RTdavMFkAuIx9DxFHaE=; b=T8WInHqSq+4mvsCAtnBLmtnHOchButDlRj3qlmC9oxTItLsR5IcYfEthvT87A/I1Ks HI0UFHAz3U3ohHUXkvs0dZvwwj6+TGB3wIwkFgIr8gj4sjuztrlSLD5i869BPd4VZwQk 0oZKjGiCihiCczrWZiMj0eyJ3pycgB0aMKB2hegAcYRDUEgAdlKRdw7elQaO47ws/HWb b4vbn2h0I4iVDxDGzowIynax+KanpM03KCfFdcFUx9/2Ycopn2Q7NFncEyQlNE60LqyW QcSHkzWQkvqZMOkJLjCXstsS6iTpl4WbJCx4H2AQjF/4hHSCZ+UPIs3s7cHCTAp3JOgo 6BqQ== X-Forwarded-Encrypted: i=1; AFNElJ8EBh7q0DcS4BtmBspPpa6K4L1jVc+V2prUioiiUsv94gSjiuNQXE9O0VVWeKriEP6OcOaT9xt0aj/IVuA=@vger.kernel.org X-Gm-Message-State: AOJu0YySDqEQyHyhF9PfqBwBRO0yGVLrAIlGL+V7clZ5yMhRZAcLh1ZK If1rmURroUT3qaF8I6LLB9n2hQ98aKZpBwAyjRApTUcQLytwyxCeMvo= X-Gm-Gg: Acq92OFimNDOCYrflpJP6FCgNajaRINDZ5vI8o4c8Pcp71zERk2ucFRI50p9i0Lx0sX qO79V+/tBY11linI+Kiv5FXo6HrFcWXj8N72RN0DGxPa0X1AamfWy/FhOYE+7otgq1ttQYjpNrY 7nxfQ+xmml7gseQxMbWQ//UTBUADzI1zJipDNtKZCziG31VkW9eGosy3GLk01CJi8ypFgRunSBQ 6rgxaXvzGJlb/a8onFzxvYNLtxbc+HO0KuMQyq39aYW2PkNNmlt6fuulRRVSPcVRbAj9HmUa0QH Bzz5HGDlSNXyodB87LaRJgH1JYqb5F7rsRArlziCsybyJohruN4+raHsKR4Ia8bH4izI/XsoDgP Is67aN7/0BwoJv4x2BvwtZHqRgwmTP85laGv0ehAvd4fiscSqjb3rx8+EurcV5GwywYrwK+4Iqn zWlupNhLfURB6UoqGJ1Fi6LFlFqj8w9KFKo5nBX/whB3f1aaBNg8yCeiXHbLN10WmPVIWfyssUS YLP8pmd3gfcd4p6Z91gM1EZ1KtOI/UI4nnah6Slm+z4MEDSKhvQlw== X-Received: by 2002:a5d:64c6:0:b0:43b:4136:1e6f with SMTP id ffacd0b85a97d-45e5c5dadbamr10534747f8f.38.1778931847777; Sat, 16 May 2026 04:44:07 -0700 (PDT) Received: from nn ([2001:1ab8:1003:0:5454:f357:ba89:4e22]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45da0a178adsm22836469f8f.18.2026.05.16.04.44.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 16 May 2026 04:44:06 -0700 (PDT) Sender: N B From: =?UTF-8?q?Nerijus=20Bend=C5=BEi=C5=ABnas?= To: Andrew Lunn , Heiner Kallweit Cc: Russell King , "Russell King (Oracle)" , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, regressions@lists.linux.dev, stable@vger.kernel.org Subject: [PATCH net] net: phy: skip EEE advertisement write when autoneg is disabled Date: Sat, 16 May 2026 14:43:34 +0300 Message-ID: <20260516114334.812828-1-nerijus.bendziunas@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable genphy_c45_an_config_eee_aneg() writes the EEE advertisement to the auto-negotiation device's MMD register space (MDIO_MMD_AN, register MDIO_AN_EEE_ADV). These registers are only consumed by the link partner during auto-negotiation, so writing them while autoneg is disabled is semantically a no-op. On at least the Broadcom BCM54213PE PHY, however, the indirect MMD write triggered from this path while the link is currently forced (autoneg off) disturbs the receive datapath: the kernel still reports the link as UP at the configured speed/duplex, but no frames are received until the link is renegotiated. Concretely, running ethtool -s eth0 speed 100 duplex full autoneg off ethtool --set-eee eth0 eee off leaves eth0 with TX working and RX completely silent on a Raspberry Pi 4 / CM4 board (bcmgenet + BCM54213PE in rgmii-rxid). Switching back to autoneg recovers the link. Prior to commit f26a29a038ee ("net: phy: ensure that genphy_c45_an_config_e= ee_aneg() sees new value of phydev->eee_cfg.eee_enabled"), the disable path was effectively a no-op because the helper read the stale eee_cfg.eee_enabled, so the underlying PHY behavior never surfaced. Bisected on rpi-6.12.y between commits 83943264 (good) and effcbc88 (bad) to f26a29a038ee. Fixes: f26a29a038ee ("net: phy: ensure that genphy_c45_an_config_eee_aneg()= sees new value of phydev->eee_cfg.eee_enabled") Cc: stable@vger.kernel.org Signed-off-by: Nerijus Bend=C5=BEi=C5=ABnas --- drivers/net/phy/phy-c45.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/phy/phy-c45.c b/drivers/net/phy/phy-c45.c index d48aa7231b37..65de6a5fa204 100644 --- a/drivers/net/phy/phy-c45.c +++ b/drivers/net/phy/phy-c45.c @@ -940,6 +940,10 @@ EXPORT_SYMBOL_GPL(genphy_c45_read_eee_abilities); */ int genphy_c45_an_config_eee_aneg(struct phy_device *phydev) { + /* MMD AN advertisements are only consumed during autoneg. */ + if (phydev->autoneg =3D=3D AUTONEG_DISABLE) + return 0; + if (!phydev->eee_cfg.eee_enabled) { __ETHTOOL_DECLARE_LINK_MODE_MASK(adv) =3D {}; =20 --=20 2.54.0