From nobody Mon May 25 08:11:31 2026 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0EE9F37474F for ; Sat, 16 May 2026 21:51:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778968268; cv=none; b=okpI5KONQ6RmZ87vdskptrxhrOGsXjcaf0KAZNH8jllnCbbW1GjK1px9hxLHyvYH5y9AWbQo67T7x4IfLk50g+AqeVCCmCN9fHECgo0Fxe1ktY+HVWCh/vLBd4T68nG8nHEgX5gmvgUxJCsL6CH1kk3nzzBoHsAPXAaAV2nfdfs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778968268; c=relaxed/simple; bh=tkKwJSzX69+ZLLlj6f/6N0J5cQ65rcLEtHoMvxQDG5g=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=BAUiWUaQhEb0P4hMVOYNwrljboPoVlitwZk9/OCeY++BiIBe9H4u+xMGBb4/m6B8PyYYQizogLp6c1pJfbuG0sEXwxdbvdXQLyQo3y0NZXuOOmFTCsaU5+mwptb7nRABufeNf6SPw8FOi8imRDyNoTUXie64GRriaz+uO/QAvGY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dSjs77FJ; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dSjs77FJ" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-48fde648a71so5921365e9.0 for ; Sat, 16 May 2026 14:51:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778968264; x=1779573064; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=qzj9hVwXyoEDx7FHjAZ2Q/bMDZ0+nBcau7PpEfZAqlI=; b=dSjs77FJvnFrsbnFB9LCnsV1gPY70fOvDa/ttwiO0Vke1jq0K41sVOA/BA8WmNH709 zcuL7Gj64UOpky8MpMTHRuVxORQUUeSNld5kpi5aC48H7yKs1ewrlnxliwsxCzlIUp2L gL7XdhdFP2i/04y1IgL2ds8b3TAW9GX+0Z/V6Cgb4rX9RhFAdQJq368F5QhNFpVdaX0R Bibx4VJydyTtLmxlfzzLfXoiHtAUM9DhKikb6OTwN28F5SW0VZ5+1kHOADS64tiNGpCf Y6tCFZl+AUyLySGg9YJj1CH/DYAGjlcNezAQerH0JDhaYYMXPPMoxBBhsa3/zPqSCE7h IO/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778968264; x=1779573064; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=qzj9hVwXyoEDx7FHjAZ2Q/bMDZ0+nBcau7PpEfZAqlI=; b=KKyhXd+1E7HZCoSf7RwGoGJJbBLTmXh/eKwe2h2Ymvh4mbHOsTc3Ro/2VlJfRfKwtK 88WaGWTDyhqSvj1L6gJNQHShz0ZSyqmryg/2qBWdYahINJhqhVC3iwV609KEvh4DJidO st5xMCRMLOVz28KctC7c8l8pH7VOunf2Kp8vnqrLloC2+21sE0Oc1aBwY/K7XZ0Wj8tE m0ncv9/JwRnnLF8zY8oTArKW+WWxwStDgHTWd6jg9/f61KPKiuaGX8c73iSs/gjqZ8Fe q6nuGbtv3+aLjfiLkokdZ7rvj7VetxLWkXlBlCW2ErFexFzW9d95XYETbc50jgTQvMUd j1lw== X-Forwarded-Encrypted: i=1; AFNElJ8/mU2gpgCrv/n2XbOqatoibgMefYnpdE0igFLWF8rcBVuGeX7K+ZDFf/rrGfhciGcnSJQkvetG+gIunBA=@vger.kernel.org X-Gm-Message-State: AOJu0Yxl8I0Yza3mV1FlQy0qpMav9q0o6j+uUF3yJO8wIqzZ7JXYojkK XbYO9Sy7c1hsi5eBqX+wK1vWfYDZ0HqUctDise8gWUweJ6YfEeqAQ4IV X-Gm-Gg: Acq92OH+gpWU9YCUH9TIP8tOEO85sJJhmPQeYoSS0MBxcgCPAY5C/STF0rpqgrbAX+H gc3wTkn85K/T1ZOxkF/wuMB8E4LU3x/nuYParwx/XSKoj7Jnkvp5Sw7Rsn0eVMe8z1koExPK4Ez YTL4dZiCcwJ6r6OuQwT4VDQF1Rb8npIbZbJ39BougfEwQmveiZ07z3HKSUuUNcMjONY5+pwuINz AXnXYwMVFT5f5obXZpsZ4oC7FPFjRoSW0KSkEiyOzdf//nVnhjxI94064KVZE8hum6grPHjCvAl HZBoicGFww/CUjnnCzYuXG+qbFvINMtdGBytLd+4MmmDoWa3UfG84Jk/e0XPdQ0p9WhzUYHc8Ol XdR1fRwLqZcAjjEsrfaifcNSZ+nEJF3AO2ttu3RfvVKO1VCKj75ooQ81bqPDmPLfDFAQjrJcCWq EZ6YFA1cfbjgMFtWCXZ2Y5sX9mwxmCXomNdcFVuOaE5dIfbo1LEd3xI7ugPo8l73rDEqR6DLn1G O1oxfiGrHwPSz/slmc8VIy8Cea0dc9dcBJ4XE1vFKw64qcRutXQDSB5MiyqNWZzKzLALHA7zwn4 kcme1Lv9DwlqkoOGcdBW6jBwYhHoOinvDHfXLypugkWzoO2y X-Received: by 2002:a05:600c:6d83:b0:486:fcc7:6811 with SMTP id 5b1f17b1804b1-48fd635966cmr148714055e9.10.1778968264181; Sat, 16 May 2026 14:51:04 -0700 (PDT) Received: from systembl0wer.localdomain ([213.194.212.155]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45da15a5653sm25819528f8f.35.2026.05.16.14.51.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 16 May 2026 14:51:03 -0700 (PDT) From: Joshua Crofts Date: Sat, 16 May 2026 23:50:53 +0200 Subject: [PATCH 1/2] iio: light: veml3328: add devicetree binding for new sensor Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260516-veml3328-v1-1-1d4b663e2fe3@gmail.com> References: <20260516-veml3328-v1-0-1d4b663e2fe3@gmail.com> In-Reply-To: <20260516-veml3328-v1-0-1d4b663e2fe3@gmail.com> To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Joshua Crofts X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1778968262; l=2270; i=joshua.crofts1@gmail.com; s=20260516; h=from:subject:message-id; bh=tkKwJSzX69+ZLLlj6f/6N0J5cQ65rcLEtHoMvxQDG5g=; b=iEKIzV9vvk2IMuBpyftZWBWLzu3zX2STOBRWsNY2pDzg0kJdG/WEmOHvfsDuWlNlOu0yEKtcG PYts8cP2dw8AivI9/Rqcor2qz0wviGGt+j+GOhcw2JnuCdLFge8iRGV X-Developer-Key: i=joshua.crofts1@gmail.com; a=ed25519; pk=d2X8EVKEB2uF4AaPPi3iSSI+IJF3/9kOoDYVVmc+G1o= Add devicetree binding for the Vishay VEML3328 RGB/IR light sensor connected via I2C (SMBus compatible). Additionally, add an entry in MAINTAINERS. Signed-off-by: Joshua Crofts --- .../bindings/iio/light/vishay,veml3328.yaml | 45 ++++++++++++++++++= ++++ MAINTAINERS | 6 +++ 2 files changed, 51 insertions(+) diff --git a/Documentation/devicetree/bindings/iio/light/vishay,veml3328.ya= ml b/Documentation/devicetree/bindings/iio/light/vishay,veml3328.yaml new file mode 100644 index 000000000000..1a30e8470fc6 --- /dev/null +++ b/Documentation/devicetree/bindings/iio/light/vishay,veml3328.yaml @@ -0,0 +1,45 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/iio/light/vishay,veml3328.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Vishay VEML3328 RGBCIR Light Sensor + +maintainers: + - Joshua Crofts + +description: + Vishay VEML3328 color RGBCIR light sensor. + + The VEML3328 datasheet can be found at https://www.vishay.com/docs/84968= /veml3328.pdf + +properties: + compatible: + enum: + - vishay,veml3328 + + reg: + maxItems: 1 + + vdd-supply: true + +required: + - compatible + - reg + - vdd-supply + +additionalProperties: false + +examples: + - | + i2c { + #address-cells =3D <1>; + #size-cells =3D <0>; + + light-sensor@10 { + compatible =3D "vishay,veml3328"; + reg =3D <0x10>; + vdd-supply =3D <&vcc_3v3>; + }; + }; diff --git a/MAINTAINERS b/MAINTAINERS index d6c3c7d22403..134690aa9866 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -28386,6 +28386,12 @@ S: Maintained F: Documentation/devicetree/bindings/iio/light/vishay,veml6030.yaml F: drivers/iio/light/veml3235.c =20 +VISHAY VEML3328 RGB IR LIGHT SENSOR DRIVER +M: Joshua Crofts +S: Maintained +F: Documentation/devicetree/bindings/iio/light/vishay,veml3328.yaml +F: drivers/iio/light/veml3328.c + VISHAY VEML6030 AMBIENT LIGHT SENSOR DRIVER M: Javier Carrasco S: Maintained --=20 2.34.1 From nobody Mon May 25 08:11:31 2026 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BD9BC37C0FA for ; Sat, 16 May 2026 21:51:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778968268; cv=none; b=PgTEKkh3Bci1Tgc4d6+ea/6HdDzY4u11NttzqZAwMuhLrGwW49XDbbDn33Lo8Qzbw+m5jSDor3QpYFPBIvv7T1eZ8AQcnOCycQOGk/d90AlBnq+ifHTZPP7/fIrATkSHIZKD8h9fmcAGHy6k0xuL260gSu/p/9/gSt7sfEXWRX0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778968268; c=relaxed/simple; bh=KZW5/Dll6J6EEbWPhU7nuTEI5oB+csDjYEK41JlHkY8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=f6MRAf6DZL0j+HfG+nRF6oNxeB9i7H7DlFAE9BJZPQUppNQmczPyJ2KeMc0IeHvlq7aGfjAGcMTKVyCH90wPceC6J6ogkrYoBXLV0sJFdAeewncaC4NY65sQRWFjJxYTyZuSxagLlUMJm/iEVCiYZimg4LeZu7OxcCx2audpjws= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IZwBEia8; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IZwBEia8" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-44c350a5b87so460377f8f.3 for ; Sat, 16 May 2026 14:51:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778968265; x=1779573065; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=M1tECVgMGwqDJlxm0nkrTu8RzXxKUzfjy6GbpXEs9tc=; b=IZwBEia8MYTXIcRksfLky40ltibADY1DnvRefdoMJN2RFT/ADcrX7T3GMsI9ig/YTy 8bVQAfkCF/ruAY/vwvMpwGqBHiSHoL+X1jwXKz8h6eR12X/r1mEZZlMK8v5FqXWOV0vk uWBIlMVK+YZhaH7y/JNw83hzLW4J42AFDeiH1ZWw3UAi/GfIwndzluoe5w6h/RWjYKiR iLJc/PgdK/ZzXu1PNj6ueFDGwLVuE3AJeR1z+fuIcfCmoBIFSy9RzfdiI4vhHyEVQYu7 zrbLa3tiP1Nxu03GZ1qpUsZGB/n5Y0akDWAtIM/ihYQsP+6v90opYXOkTNt7TcZBfCD+ 0+Lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778968265; x=1779573065; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=M1tECVgMGwqDJlxm0nkrTu8RzXxKUzfjy6GbpXEs9tc=; b=J0szIF+afd2RC9C6NKDz90WKVfPNNXkskCYwz03eI92NVSmarLxSNaU7+FDWADfojE /pAJHAjLgo9cHTtCBv3i4amS97hwIAdgzrkoDgI/4At02a/Lv983fi5J3WPTbsH3LboY CJ/CHJfVNI923p5q10qJzQ0Czp427f07jeTLIHAkE9hmj0u+7KLyVNu3gqac/WNPLCmX 4Y3UD3QWl6OWAbyiDsDX6oRFeAo2O7EENS5kz4B/uaM7imSFYng8Lyf79UY0W4YgqVuo shSJWQQamwIxDdTlOUkKVLK45zur45zHIIYRcELI5oE2c/BRdc6iIEB5Gqlxywx1z2tG tZCw== X-Forwarded-Encrypted: i=1; AFNElJ/rO3VAPYUrjVsJ3PYtXdeju8loq0ivXvsquaf3eCzLE69NlQ86WYgQRyc1bIuLB3ixgFhdgNqsxuyzn0w=@vger.kernel.org X-Gm-Message-State: AOJu0YzvarH5m+JDos8aRtj/eiUhVA9WTbuqpo1GM+f+CWJGWofV0yOJ 7LLx0ycumG/n8lfkiWRlwRWEaODUIaSgw9rKTF1QJ3GtCAji52Uv/Wcw X-Gm-Gg: Acq92OEfCnPR0vdFvE54BBYmpuOO+PZaqs3JBC94VwhSaQ4+eAgX3dOVIo/2o1jgHym zd6gdZk1AhCD8nQUcqM6T8y3DDI8wSx4kFiF58yBKvQDa4e+lcS90TX+SBE0GCf5se+LpALqyF3 14zCuBaIcQR0dWZuDMq3b9mBTBxwWog1tkrYjlOhSwv8enmxdeQebmNU9CS0uoYxwa956JCPW0N HNCOikI3w3jpFDIvOJfV91DV18O6zD1OOeUO6D9mjRfZY2kHsF9ErdjrqyfEnos75/yBtrOA2kI 5pyaQq4YMB6OEQ0/V/QHG7za0vhv6w8TPcxZOAhM3iqgtciGA8CjXnbUV0MNqmwgUSN0jYLM5Qf osLZb2ZTofGRCt7xIXHyhn3Nkaq+tahdu68nC9NvmawrAYsBhaTHWf9yAG/Wab1U59M/UcVnac4 T99G1oXqPQ5t8/jDygY28q6ZDBdaVFYYk/cLw0bjGvJWDRs/5s6xUJyqvqfg1ES/WuX12ebP96P C8YypJHiGrJ9nVdRW6VHOEa5rvvMjswsFtmwoOy0nZs8g78pChJSQK+JGaEGZxeEeKqFxB85Prm FQviR7B2JOG4QkE9cpmA1QTZCwIR+5yiSdxc/5xD6nGytNjdOTH3HWvb3es= X-Received: by 2002:a05:6000:1787:b0:45b:d5d7:1f59 with SMTP id ffacd0b85a97d-45e5c5e3282mr13468934f8f.24.1778968264916; Sat, 16 May 2026 14:51:04 -0700 (PDT) Received: from systembl0wer.localdomain ([213.194.212.155]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45da15a5653sm25819528f8f.35.2026.05.16.14.51.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 16 May 2026 14:51:04 -0700 (PDT) From: Joshua Crofts Date: Sat, 16 May 2026 23:50:54 +0200 Subject: [PATCH 2/2] iio: light: veml3328: add support for new device Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260516-veml3328-v1-2-1d4b663e2fe3@gmail.com> References: <20260516-veml3328-v1-0-1d4b663e2fe3@gmail.com> In-Reply-To: <20260516-veml3328-v1-0-1d4b663e2fe3@gmail.com> To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Joshua Crofts X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1778968262; l=12175; i=joshua.crofts1@gmail.com; s=20260516; h=from:subject:message-id; bh=KZW5/Dll6J6EEbWPhU7nuTEI5oB+csDjYEK41JlHkY8=; b=vVoYdC5cMa5D3OLeAs0EIgvhpzKmzZdahPvALm0eMUxjHCr22JQNR+mJhBjD6HiPJUrvQWfu9 p4BiM4/Z6aUBmGEaRLD5wRH8d8HvO81TXn/lwyiNhyFK40SRLaTtIpg X-Developer-Key: i=joshua.crofts1@gmail.com; a=ed25519; pk=d2X8EVKEB2uF4AaPPi3iSSI+IJF3/9kOoDYVVmc+G1o= Add support for the Vishay VEML3328 RGB/IR light sensor communicating via I2C (SMBus compatible). Also add a new entry for said driver into Kconfig and Makefile. Signed-off-by: Joshua Crofts --- drivers/iio/light/Kconfig | 11 ++ drivers/iio/light/Makefile | 1 + drivers/iio/light/veml3328.c | 405 +++++++++++++++++++++++++++++++++++++++= ++++ 3 files changed, 417 insertions(+) diff --git a/drivers/iio/light/Kconfig b/drivers/iio/light/Kconfig index eff33e456c70..1c00bb0de6c8 100644 --- a/drivers/iio/light/Kconfig +++ b/drivers/iio/light/Kconfig @@ -699,6 +699,17 @@ config VEML3235 To compile this driver as a module, choose M here: the module will be called veml3235. =20 +config VEML3328 + tristate "VEML3328 RGBCIR light sensor" + select REGMAP_I2C + depends on I2C + help + Say Y here if you want to build a driver for the Vishay VEML3328 + RGB IR light sensor. + + To compile this driver as a module, choose M here: the + module will be called veml3328 + config VEML6030 tristate "VEML6030 and VEML6035 ambient light sensors" select REGMAP_I2C diff --git a/drivers/iio/light/Makefile b/drivers/iio/light/Makefile index c0048e0d5ca8..e03c6e23a9a4 100644 --- a/drivers/iio/light/Makefile +++ b/drivers/iio/light/Makefile @@ -65,6 +65,7 @@ obj-$(CONFIG_US5182D) +=3D us5182d.o obj-$(CONFIG_VCNL4000) +=3D vcnl4000.o obj-$(CONFIG_VCNL4035) +=3D vcnl4035.o obj-$(CONFIG_VEML3235) +=3D veml3235.o +obj-$(CONFIG_VEML3328) +=3D veml3328.o obj-$(CONFIG_VEML6030) +=3D veml6030.o obj-$(CONFIG_VEML6040) +=3D veml6040.o obj-$(CONFIG_VEML6046X00) +=3D veml6046x00.o diff --git a/drivers/iio/light/veml3328.c b/drivers/iio/light/veml3328.c new file mode 100644 index 000000000000..9eb5429c813d --- /dev/null +++ b/drivers/iio/light/veml3328.c @@ -0,0 +1,405 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Vishay VEML3328 RGBCIR light sensor driver + * + * Copyright (c) 2026 Joshua Crofts + * + * Datasheet: https://www.vishay.com/docs/84968/veml3328.pdf + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#include + +#define VEML3328_REG_CONF 0x00 +#define VEML3328_REG_ID 0x0c +#define VEML3328_REG_DATA_C 0x04 +#define VEML3328_REG_DATA_R 0x05 +#define VEML3328_REG_DATA_G 0x06 +#define VEML3328_REG_DATA_B 0x07 +#define VEML3328_REG_DATA_IR 0x08 + +#define VEML3328_IT_MASK GENMASK(5, 4) +#define VEML3328_GAIN_MASK GENMASK(11, 10) + +#define VEML3328_ID_VAL 0x28 + +#define VEML3328_CONF_SD0 BIT(0) +#define VEML3328_CONF_SD1 BIT(15) +#define VEML3328_SHUTDOWN (VEML3328_CONF_SD0 | VEML3328_CONF_SD1) + +struct veml3328_data { + struct regmap *regmap; + struct device *dev; + struct mutex lock; +}; + +static const struct regmap_config veml3328_regmap_config =3D { + .name =3D "veml3328", + .reg_bits =3D 8, + .val_bits =3D 16, + .max_register =3D VEML3328_REG_ID, + .val_format_endian =3D REGMAP_ENDIAN_LITTLE, +}; + +#define VEML3328_CHAN_SPEC(_color, _addr) { \ + .type =3D IIO_INTENSITY, \ + .modified =3D 1, \ + .channel2 =3D IIO_MOD_LIGHT_##_color, \ + .info_mask_separate =3D BIT(IIO_CHAN_INFO_RAW), \ + .info_mask_shared_by_all =3D BIT(IIO_CHAN_INFO_INT_TIME) | \ + BIT(IIO_CHAN_INFO_SCALE), \ + .info_mask_shared_by_all_available =3D BIT(IIO_CHAN_INFO_INT_TIME) | \ + BIT(IIO_CHAN_INFO_SCALE), \ + .address =3D _addr, \ +} + +static const struct iio_chan_spec veml3328_channels[] =3D { + VEML3328_CHAN_SPEC(CLEAR, VEML3328_REG_DATA_C), + VEML3328_CHAN_SPEC(RED, VEML3328_REG_DATA_R), + VEML3328_CHAN_SPEC(GREEN, VEML3328_REG_DATA_G), + VEML3328_CHAN_SPEC(BLUE, VEML3328_REG_DATA_B), + VEML3328_CHAN_SPEC(IR, VEML3328_REG_DATA_IR), +}; + +/* scale values per datasheet */ +static const int veml3328_scale_vals[][2] =3D { + { 0, 500000 }, + { 1, 0 }, + { 2, 0 }, + { 4, 0 }, +}; + +/* integration times in microseconds */ +static const int veml3328_it_times[][2] =3D { + { 0, 50000 }, + { 0, 100000 }, + { 0, 200000 }, + { 0, 400000 }, +}; + +static int veml3328_power_down(struct veml3328_data *data) +{ + return regmap_update_bits(data->regmap, VEML3328_REG_CONF, + VEML3328_SHUTDOWN, VEML3328_SHUTDOWN); +} + +static int veml3328_power_up(struct veml3328_data *data) +{ + int ret; + + ret =3D regmap_update_bits(data->regmap, VEML3328_REG_CONF, + VEML3328_SHUTDOWN, 0); + if (ret < 0) + return ret; + + fsleep(veml3328_it_times[3][1]); + + return 0; +} + +static void veml3328_power_down_action(void *data) +{ + veml3328_power_down(data); +} + +static int veml3328_read_raw(struct iio_dev *indio_dev, + struct iio_chan_spec const *chan, + int *val, int *val2, long mask) +{ + struct veml3328_data *data =3D iio_priv(indio_dev); + struct regmap *regmap =3D data->regmap; + unsigned int reg_val; + int ret; + int reg; + + guard(mutex)(&data->lock); + + ret =3D pm_runtime_resume_and_get(data->dev); + if (ret < 0) + return ret; + + switch (mask) { + case IIO_CHAN_INFO_RAW: + ret =3D regmap_read(regmap, chan->address, ®_val); + if (ret < 0) + goto exit; + + *val =3D reg_val; + ret =3D IIO_VAL_INT; + break; + + case IIO_CHAN_INFO_INT_TIME: + ret =3D regmap_read(regmap, VEML3328_REG_CONF, ®_val); + if (ret < 0) + goto exit; + + reg =3D FIELD_GET(VEML3328_IT_MASK, reg_val); + if (reg >=3D ARRAY_SIZE(veml3328_it_times)) { + ret =3D -EINVAL; + goto exit; + } + + *val =3D veml3328_it_times[reg][0]; + *val2 =3D veml3328_it_times[reg][1]; + ret =3D IIO_VAL_INT_PLUS_MICRO; + break; + + case IIO_CHAN_INFO_SCALE: + ret =3D regmap_read(regmap, VEML3328_REG_CONF, ®_val); + if (ret < 0) + goto exit; + + reg =3D FIELD_GET(VEML3328_GAIN_MASK, reg_val); + if (reg >=3D ARRAY_SIZE(veml3328_scale_vals)) { + ret =3D -EINVAL; + goto exit; + } + + *val =3D veml3328_scale_vals[reg][0]; + *val2 =3D veml3328_scale_vals[reg][1]; + ret =3D IIO_VAL_INT_PLUS_MICRO; + break; + + default: + ret =3D -EINVAL; + } + +exit: + pm_runtime_put_autosuspend(data->dev); + + return ret; +} + +static int veml3328_read_avail(struct iio_dev *indio_dev, + struct iio_chan_spec const *chan, + const int **vals, int *type, int *length, + long mask) +{ + switch (mask) { + case IIO_CHAN_INFO_INT_TIME: + *length =3D ARRAY_SIZE(veml3328_it_times) * 2; + *vals =3D (const int *)veml3328_it_times; + *type =3D IIO_VAL_INT_PLUS_MICRO; + return IIO_AVAIL_LIST; + + case IIO_CHAN_INFO_SCALE: + *length =3D ARRAY_SIZE(veml3328_scale_vals) * 2; + *vals =3D (const int *)veml3328_scale_vals; + *type =3D IIO_VAL_INT_PLUS_MICRO; + return IIO_AVAIL_LIST; + + default: + return -EINVAL; + } +} + +static int veml3328_write_raw(struct iio_dev *indio_dev, + struct iio_chan_spec const *chan, + int val, int val2, long mask) +{ + struct veml3328_data *data =3D iio_priv(indio_dev); + struct regmap *regmap =3D data->regmap; + int ret; + int i; + + guard(mutex)(&data->lock); + + ret =3D pm_runtime_resume_and_get(data->dev); + if (ret < 0) + return ret; + + switch (mask) { + case IIO_CHAN_INFO_INT_TIME: + if (val !=3D 0) { + ret =3D -EINVAL; + goto exit; + } + + for (i =3D 0; i < ARRAY_SIZE(veml3328_it_times); i++) { + if (veml3328_it_times[i][1] =3D=3D val2) + break; + } + + if (i =3D=3D ARRAY_SIZE(veml3328_it_times)) { + ret =3D -EINVAL; + goto exit; + } + + ret =3D regmap_update_bits(regmap, VEML3328_REG_CONF, + VEML3328_IT_MASK, + FIELD_PREP(VEML3328_IT_MASK, i)); + break; + + case IIO_CHAN_INFO_SCALE: + for (i =3D 0; i < ARRAY_SIZE(veml3328_scale_vals); i++) { + if (val =3D=3D veml3328_scale_vals[i][0] && + val2 =3D=3D veml3328_scale_vals[i][1]) + break; + } + + if (i =3D=3D ARRAY_SIZE(veml3328_scale_vals)) { + ret =3D -EINVAL; + goto exit; + } + + ret =3D regmap_update_bits(regmap, VEML3328_REG_CONF, + VEML3328_GAIN_MASK, + FIELD_PREP(VEML3328_GAIN_MASK, i)); + + break; + + default: + ret =3D -EINVAL; + } + +exit: + pm_runtime_put_autosuspend(data->dev); + + return ret; +} + +static int veml3328_write_raw_get_fmt(struct iio_dev *indio_dev, + struct iio_chan_spec const *chan, + long mask) +{ + switch (mask) { + case IIO_CHAN_INFO_SCALE: + case IIO_CHAN_INFO_INT_TIME: + return IIO_VAL_INT_PLUS_MICRO; + default: + return -EINVAL; + } +} + +static const struct iio_info veml3328_info =3D { + .read_raw =3D veml3328_read_raw, + .write_raw =3D veml3328_write_raw, + .read_avail =3D veml3328_read_avail, + .write_raw_get_fmt =3D veml3328_write_raw_get_fmt, +}; + +static int veml3328_probe(struct i2c_client *client) +{ + struct device *dev =3D &client->dev; + struct veml3328_data *data; + struct iio_dev *indio_dev; + unsigned int reg_val; + int ret; + + indio_dev =3D devm_iio_device_alloc(dev, sizeof(*data)); + if (!indio_dev) + return -ENOMEM; + + data =3D iio_priv(indio_dev); + i2c_set_clientdata(client, indio_dev); + data->dev =3D dev; + + data->regmap =3D devm_regmap_init_i2c(client, &veml3328_regmap_config); + if (IS_ERR(data->regmap)) + return dev_err_probe(dev, PTR_ERR(data->regmap), + "Failed to initialize regmap\n"); + + ret =3D devm_mutex_init(dev, &data->lock); + if (ret) + return ret; + + ret =3D devm_regulator_get_enable(dev, "vdd"); + if (ret) + return dev_err_probe(dev, ret, "Failed to enable regulator\n"); + + ret =3D regmap_read(data->regmap, VEML3328_REG_ID, ®_val); + if (ret < 0) + return dev_err_probe(dev, ret, "Failed to read ID register\n"); + + if ((reg_val & 0xff) !=3D VEML3328_ID_VAL) + return dev_err_probe(dev, -ENODEV, "Invalid device ID\n"); + + ret =3D veml3328_power_up(data); + if (ret) + return dev_err_probe(dev, ret, "Failed to power on sensor\n"); + + ret =3D devm_add_action_or_reset(dev, veml3328_power_down_action, data); + if (ret) + return dev_err_probe(dev, ret, "Failed to register teardown\n"); + + indio_dev->name =3D "veml3328"; + indio_dev->modes =3D INDIO_DIRECT_MODE; + indio_dev->info =3D &veml3328_info; + indio_dev->channels =3D veml3328_channels; + indio_dev->num_channels =3D ARRAY_SIZE(veml3328_channels); + + pm_runtime_set_active(dev); + pm_runtime_set_autosuspend_delay(dev, 2000); + pm_runtime_use_autosuspend(dev); + + ret =3D devm_pm_runtime_enable(dev); + if (ret) + return dev_err_probe(dev, ret, "Failed to enable runtime PM\n"); + + return devm_iio_device_register(dev, indio_dev); +} + +static int veml3328_runtime_suspend(struct device *dev) +{ + struct veml3328_data *data =3D iio_priv(dev_get_drvdata(dev)); + int ret; + + ret =3D veml3328_power_down(data); + if (ret < 0) + dev_err(dev, "Failed to suspend: %d\n", ret); + + return ret; +} + +static int veml3328_runtime_resume(struct device *dev) +{ + struct veml3328_data *data =3D iio_priv(dev_get_drvdata(dev)); + int ret; + + ret =3D veml3328_power_up(data); + if (ret < 0) + dev_err(dev, "Failed to resume: %d\n", ret); + + return ret; +} + +static DEFINE_RUNTIME_DEV_PM_OPS(veml3328_pm_ops, veml3328_runtime_suspend, + veml3328_runtime_resume, NULL); + +static const struct of_device_id veml3328_of_match[] =3D { + { .compatible =3D "vishay,veml3328" }, + { } +}; +MODULE_DEVICE_TABLE(of, veml3328_of_match); + +static const struct i2c_device_id veml3328_id[] =3D { + { "veml3328" }, + { } +}; +MODULE_DEVICE_TABLE(i2c, veml3328_id); + +static struct i2c_driver veml3328_driver =3D { + .driver =3D { + .name =3D "veml3328", + .of_match_table =3D veml3328_of_match, + .pm =3D pm_ptr(&veml3328_pm_ops), + }, + .probe =3D veml3328_probe, + .id_table =3D veml3328_id, +}; +module_i2c_driver(veml3328_driver); + +MODULE_AUTHOR("Joshua Crofts "); +MODULE_DESCRIPTION("VEML3328 RGB Light Sensor"); +MODULE_LICENSE("GPL"); --=20 2.34.1