From nobody Mon May 25 08:12:39 2026 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C25993A9618 for ; Fri, 15 May 2026 22:33:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778884431; cv=none; b=Yw0YXa1clmUG4x/fhESsTZo8JUySKrOobLq4sOF1j433uYk5iwSDkLbg32H9AmGAXkmlSo7P/rCXuJKMGHgTz3OYvVMNYqTxubRRFvrVieAvfsaQyxh4pDF78+Gi4gaMyW2yCJ0cmdIC85HTPcuDBdnhTjzTyYgJFU2yNWjQx3w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778884431; c=relaxed/simple; bh=T1iPHmWtNlQuAzHdbdnhCFtMqvQVUSecMJO6hlMkiB0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=LobxnG4Zs9XH0l2ATNOWgyRKf9/vPD5WRXYHj9NQHI/ZNBLH+jr3PaPyJzBTZie+yzSMgwnsoOEAK4ts/W2s/0X/+t1rI5zeLIxbY+gbwv9eg7cclMmq931sfTBnfjmFSbhf97r6EtTIhxQqbx3woQuFfwoYIHKePslaORL6+OM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GItDyMzW; arc=none smtp.client-ip=209.85.221.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GItDyMzW" Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-44e5624c053so109336f8f.2 for ; Fri, 15 May 2026 15:33:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778884428; x=1779489228; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=kt/xoXGBinKdMkcDOAaFA2n5mMy6AJx5Gs0Z2Cs3kJw=; b=GItDyMzWW5XusAnJnX8TadvjAgND1PZvYkrW+hAsJdKaTIz+b7PMf28OkNGNaLfZf6 +lbE4lK7I0kuIiKlQsY25v/+hs3QSFF+cRNVJDYeVyjDM/I2aRzFmJpQMSSf5gUncnZD Cl9sK8zpF2lf+afwWsS9E4x/WwzCeB0ZswSyCrR6xwMxaVIxEWT1bALmqcoJQ0HIfEqO mY3U2VBIgnMboJm7+gF/rFJUjDcamTebsCZgehue5ug+GKwnIae1nNH6lKBVX0jYOls1 HnxEbn1Ro5V5fNMgNUg1Amt6KZPSdywsBoNVHZuMMjijsAP0QyNJaJade6/cqOzqTZX+ Sm9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778884428; x=1779489228; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=kt/xoXGBinKdMkcDOAaFA2n5mMy6AJx5Gs0Z2Cs3kJw=; b=JD0ATjVhB7oMWElV+7b7oZrlPLTDBS4bbhzhCFRhyQYz27Pd3Szd4VkNReRw8lg8IC nXYTHXVMbBZpceKu75hKpoPQBGtaLyHA4zLhLCRQSjYEbBrw6JF9hLWx0l4qPN/05YsN f8HilV/gT4LlERv7ZxB/Ku3uVk95S7989+5VhK9iMrzydXlthTFOVJAxTxOlgMni5snW T0+1nYiL455GGwGhDWS3cj5V3/4unUbDOXlFoOeM/QTcxWQuGPDcTfLmRRZU/bq3Oh7y naIq0ZUvs81chz9/oxdUeWO+7KKM/a/QVuoWwfQ5QooN6ThLt8bRSfjXENc4b8rlW2Rv SIHA== X-Forwarded-Encrypted: i=1; AFNElJ9PyUAJYOEnCTVxNFBG4qMGgUgXb0mDQwAQBaNlyuvkDkw/ea0IFRFsVvGIiy0q7gHHuZEpWI+RRqgGSJQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyA4O20WzEzkhKHL0BN8WkI/gqcSFWySAAYu7MtYhoY2Xliq72y cIMhW43QRSJatVh/P/BepqcLANGQY5WdN/Yqs3aNgDNTrIz5iOiYpgIO X-Gm-Gg: Acq92OFzBSd1l4W+LmeXgzHvVFnwWxmbN/V8pJbdDB42nFcErthUbBpZJvOEfvgPx45 85IFuuZXWNk92bqyEfoYJOETVg0NDGvL4UCbbeA5HmCqOY7uVPamBL79mCgyIi1x7yP8nSU9x1C uS01kC+BN/hFtoJ7MwxHKaj3NFYbHP83AO/ns0igHjPxhaSAYK8G1ejuJEpi7ttUzUAcc1C2irh ae9JEI8BPV2bFjERJpClkzaN2K65FrBV6Fc9yGSsPkEnwpo6tTSJr5/y1+hGkTQ9yugbBbA9W57 JYJaa7fnzfIGVpoV6NYpdfEpilzzfkvdGcRYdRbytJMM/wNv3xIgWgEi0KQdfqRxp/pPkz0HGqJ cXKhxVLyX9H/MWAegz1faLeOlf41vrUcilbZ58IxaKXqTJ7PxRD+AE+XlkDkt8FiSJHPai8Xfei X8RlqWz77Budlt5qNeHgY+2iJbQyGih3+H5aHa X-Received: by 2002:a5d:5f45:0:b0:45d:4a00:b927 with SMTP id ffacd0b85a97d-45e5c5dd627mr8378359f8f.31.1778884427892; Fri, 15 May 2026 15:33:47 -0700 (PDT) Received: from Dev-Null-MSI ([2a0d:3344:52ac:a808:98a4:4381:be45:536f]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45da0a1aeafsm17849288f8f.23.2026.05.15.15.33.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 May 2026 15:33:47 -0700 (PDT) From: Yousef Alhouseen To: Vaibhav Agarwal , Mark Greer , Johan Hovold , Alex Elder , Greg Kroah-Hartman Cc: greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Yousef Alhouseen Subject: [PATCH] staging: greybus: add missing newlines to sysfs_emit() output Date: Sat, 16 May 2026 00:33:42 +0200 Message-ID: <20260515223342.40869-1-alhouseenyousef@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Sysfs show() callbacks should emit a trailing newline for text output. Several Greybus audio manager module attributes currently omit the newline, which triggers checkpatch warnings and makes the attributes less convenient to read from userspace. Append missing newlines to the affected sysfs_emit() format strings. Signed-off-by: Yousef Alhouseen --- drivers/staging/greybus/audio_manager_module.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/greybus/audio_manager_module.c b/drivers/stagi= ng/greybus/audio_manager_module.c index dc90cc2d2308..5737f2a32f5a 100644 --- a/drivers/staging/greybus/audio_manager_module.c +++ b/drivers/staging/greybus/audio_manager_module.c @@ -75,7 +75,7 @@ static void gb_audio_module_release(struct kobject *kobj) static ssize_t gb_audio_module_name_show(struct gb_audio_manager_module *m= odule, struct gb_audio_manager_module_attribute *attr, char *buf) { - return sysfs_emit(buf, "%s", module->desc.name); + return sysfs_emit(buf, "%s\n", module->desc.name); } =20 static struct gb_audio_manager_module_attribute gb_audio_module_name_attri= bute =3D @@ -84,7 +84,7 @@ static struct gb_audio_manager_module_attribute gb_audio_= module_name_attribute =3D static ssize_t gb_audio_module_vid_show(struct gb_audio_manager_module *mo= dule, struct gb_audio_manager_module_attribute *attr, char *buf) { - return sysfs_emit(buf, "%d", module->desc.vid); + return sysfs_emit(buf, "%d\n", module->desc.vid); } =20 static struct gb_audio_manager_module_attribute gb_audio_module_vid_attrib= ute =3D @@ -93,7 +93,7 @@ static struct gb_audio_manager_module_attribute gb_audio_= module_vid_attribute =3D static ssize_t gb_audio_module_pid_show(struct gb_audio_manager_module *mo= dule, struct gb_audio_manager_module_attribute *attr, char *buf) { - return sysfs_emit(buf, "%d", module->desc.pid); + return sysfs_emit(buf, "%d\n", module->desc.pid); } =20 static struct gb_audio_manager_module_attribute gb_audio_module_pid_attrib= ute =3D @@ -103,7 +103,7 @@ static ssize_t gb_audio_module_intf_id_show(struct gb_a= udio_manager_module *modu struct gb_audio_manager_module_attribute *attr, char *buf) { - return sysfs_emit(buf, "%d", module->desc.intf_id); + return sysfs_emit(buf, "%d\n", module->desc.intf_id); } =20 static struct gb_audio_manager_module_attribute @@ -114,7 +114,7 @@ static ssize_t gb_audio_module_ip_devices_show(struct g= b_audio_manager_module *m struct gb_audio_manager_module_attribute *attr, char *buf) { - return sysfs_emit(buf, "0x%X", module->desc.ip_devices); + return sysfs_emit(buf, "0x%X\n", module->desc.ip_devices); } =20 static struct gb_audio_manager_module_attribute @@ -125,7 +125,7 @@ static ssize_t gb_audio_module_op_devices_show(struct g= b_audio_manager_module *m struct gb_audio_manager_module_attribute *attr, char *buf) { - return sysfs_emit(buf, "0x%X", module->desc.op_devices); + return sysfs_emit(buf, "0x%X\n", module->desc.op_devices); } =20 static struct gb_audio_manager_module_attribute --=20 2.54.0