From nobody Fri Jun 19 00:40:34 2026 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D90933F99F4; Fri, 15 May 2026 17:52:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.13 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778867580; cv=none; b=RGQuNMK9PkCvyzeLLr9i77ls5zo3uf6RKfQXaQ+CP2wuX+jfpM8zWrPp+iWLE1WkTjw+3AByl479Dj/TiPo9BrFKwb/+cTT5cjGP0xjPIckSjZkZFxp4EXD/5OA0ReRPoH8EJIGHg1k0wpJFx9Xqjt63FNxfAUjhMjA8DigHeps= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778867580; c=relaxed/simple; bh=BX4QW3hxBSPX7xhWjOQ7LQO1rmatuD2o5waVWiDsPP8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=HpuPkT+3blIO7v3XxqqnADyDS8ILDKa4KJH5WZvmgqWzCp+t2xtGLde76hf/Lwo6yinZCZ5La9aVcQ78AWjMUH3d6UuTEXTb2q5lUd1y260GXqhaKbqf8rP2Ls+ERlpvWNBtaDDlt891YDXMTO3Y7kifYvUBGtfntWDfOq64pM4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=C86VexPP; arc=none smtp.client-ip=198.175.65.13 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="C86VexPP" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1778867578; x=1810403578; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=BX4QW3hxBSPX7xhWjOQ7LQO1rmatuD2o5waVWiDsPP8=; b=C86VexPPGBTKI49o0fB6BXIEcmX/U0saKVKLV0RX8FS3clvr1csEPNRR AM7bkKz2tr7x7Isaq9khYhn9jG2MNt4eU1qeAY4utGcB+ldZc6Itf/W7p mOHWX0UgJicF+77niOi994j5EymxZwzBwoyv08QXrVWwYQ0gsX2LUFTpM OKPKWM7GCradPoAe1Y/JqFmb/BFcP0UNim7ARFjXuTUu5KM95GGXLUKZJ LavwBPaXHbiaexfy0VnYl5UW9kCAJ3kDJhAci7FhK4dSYFSyo5Rc+q6wc w5k1/udxh3qvjcckiuvQJtuilKJUQ7QDGPC7zdc8rgdlzWvqfk5g9EiD6 A==; X-CSE-ConnectionGUID: 3tz3Z+GnTi6Tjf9vrzWALg== X-CSE-MsgGUID: ddjl9FwFSp6JvXasZptbrg== X-IronPort-AV: E=McAfee;i="6800,10657,11787"; a="90931328" X-IronPort-AV: E=Sophos;i="6.23,236,1770624000"; d="scan'208";a="90931328" Received: from orviesa006.jf.intel.com ([10.64.159.146]) by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 May 2026 10:52:58 -0700 X-CSE-ConnectionGUID: DiA++BRCRXeM7cDZKSwS4Q== X-CSE-MsgGUID: vgzVAFX4S+mZQtjbubu8zw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,236,1770624000"; d="scan'208";a="237760901" Received: from intel-nuc8i7beh.iind.intel.com ([10.223.163.35]) by orviesa006.jf.intel.com with ESMTP; 15 May 2026 10:52:55 -0700 From: Arun T To: arun.t@intel.com, johannes.goede@oss.qualcomm.com Cc: sakari.ailus@linux.intel.com, arec.kao@intel.com, ilpo.jarvinen@linux.intel.com, dan.scally@ideasonboard.com, platform-driver-x86@vger.kernel.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, mehdi.djait@intel.com Subject: [PATCH v11 1/3] platform/x86: int3472: Rename daisy-chain GPIO props to generic Date: Fri, 15 May 2026 23:15:10 +0530 Message-ID: <20260515174514.3752028-2-arun.t@intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260515174514.3752028-1-arun.t@intel.com> References: <20260515174514.3752028-1-arun.t@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename the MSI-specific daisy-chain GPIO properties and software node to generic names so they can be reused by other platforms that also require daisy-chain GPIO configuration for TPS68470. Signed-off-by: Arun T --- drivers/platform/x86/intel/int3472/tps68470_board_data.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/platform/x86/intel/int3472/tps68470_board_data.c b/dri= vers/platform/x86/intel/int3472/tps68470_board_data.c index 28c9e12c85bf..4358dc601923 100644 --- a/drivers/platform/x86/intel/int3472/tps68470_board_data.c +++ b/drivers/platform/x86/intel/int3472/tps68470_board_data.c @@ -323,13 +323,13 @@ static struct gpiod_lookup_table msi_prestige_ai_evo_= ovti5675_gpios =3D { } }; =20 -static const struct property_entry msi_prestige_ai_evo_gpio_props[] =3D { +static const struct property_entry int3472_tps68470_daisy_chain_gpio_props= [] =3D { PROPERTY_ENTRY_BOOL("daisy-chain-enable"), { } }; =20 -static const struct software_node msi_prestige_ai_evo_tps68470_gpio_swnode= =3D { - .properties =3D msi_prestige_ai_evo_gpio_props, +static const struct software_node int3472_tps68470_daisy_chain_gpio_swnode= =3D { + .properties =3D int3472_tps68470_daisy_chain_gpio_props, }; =20 static const struct int3472_tps68470_board_data surface_go_tps68470_board_= data =3D { @@ -364,7 +364,7 @@ static const struct int3472_tps68470_board_data dell_72= 12_tps68470_board_data =3D static const struct int3472_tps68470_board_data msi_prestige_ai_evo_tps684= 70_board_data =3D { .dev_name =3D "i2c-INT3472:06", .tps68470_regulator_pdata =3D &msi_prestige_ai_evo_tps68470_pdata, - .tps68470_gpio_swnode =3D &msi_prestige_ai_evo_tps68470_gpio_swnode, + .tps68470_gpio_swnode =3D &int3472_tps68470_daisy_chain_gpio_swnode, .n_gpiod_lookups =3D 1, .tps68470_gpio_lookup_tables =3D { &msi_prestige_ai_evo_ovti5675_gpios, --=20 2.43.0 From nobody Fri Jun 19 00:40:34 2026 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4AE0B3FBB66; Fri, 15 May 2026 17:53:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.13 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778867582; cv=none; b=i5zCBddthxg/EXC2X+WNxOkcDGrwlp5PZHK3TRSIcHEPfuqaKCkx4/VxbDSodwmm1eZWGdjqdtYjgmH0xvGgglzyeq8WjBPXqQkb74cxdlGD40dxLHKO/X8VdYAbD0VBflvKoXgPEG2AeX8UYVkTnU3FlrENKKljqKmsz2MO4Zo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778867582; c=relaxed/simple; bh=jjZZM6lfryfZRg5sp4iuDZP4QyiveQTpOU0OLsemFWc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qyYPdms3nrp/yLHEuekK3ldElP28hh9yXPwF2ptc2aooTWjH91M4z+qMZUZXg60kpfOkQrN6c0jxI4mGOsmLeMGm5dId9bC0wFMfT4J7OiaUZBrGqXmTDViQE4waUtyN9kBl3P9z6r+g1cAYesEysb4BT4IC/zGL170i1PC3/Wk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=KYjOBPPb; arc=none smtp.client-ip=198.175.65.13 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="KYjOBPPb" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1778867582; x=1810403582; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=jjZZM6lfryfZRg5sp4iuDZP4QyiveQTpOU0OLsemFWc=; b=KYjOBPPbWCLKmbZJfNracZY9CIFHZgLLVB3rBSCPHKCcO8FeUt/qNSiE QF9D/+tL4ISvx/DIPGflbRj8661xZGVifQYdZjJbL6RAu8KcBQt3gNtu8 KBb6+8PP7A1/Ny15hPbfk4TZlVu2g7gGe7TH8v/Wo/H7bQ7ckYzk6KVZf pycik9tHs6/y1/N4iLQdAnh/TH+J3QvLXUyt9nWpwDP6Znyk8zk86e1cV 1Dy8faEyaW4rWXLBCvtiPYt/OgWLZVY6kUYXZVXp4FPQ9bwYh36qJILEw AvYpwersO54XTt498ep9zUXpZdfD6p3yd/KXDVVn5WCwJ9FYBZ1dPOS/R Q==; X-CSE-ConnectionGUID: Msk/pC0GRZaSqro6GVY6aw== X-CSE-MsgGUID: 8o+sLiZbTeiERIjkdbl5+A== X-IronPort-AV: E=McAfee;i="6800,10657,11787"; a="90931344" X-IronPort-AV: E=Sophos;i="6.23,236,1770624000"; d="scan'208";a="90931344" Received: from orviesa006.jf.intel.com ([10.64.159.146]) by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 May 2026 10:53:02 -0700 X-CSE-ConnectionGUID: jUbLgxZhQN6x16fAW11Ppw== X-CSE-MsgGUID: c3pRk4kcT3eDXg4zWOx8Iw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,236,1770624000"; d="scan'208";a="237760918" Received: from intel-nuc8i7beh.iind.intel.com ([10.223.163.35]) by orviesa006.jf.intel.com with ESMTP; 15 May 2026 10:52:58 -0700 From: Arun T To: arun.t@intel.com, johannes.goede@oss.qualcomm.com Cc: sakari.ailus@linux.intel.com, arec.kao@intel.com, ilpo.jarvinen@linux.intel.com, dan.scally@ideasonboard.com, platform-driver-x86@vger.kernel.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, mehdi.djait@intel.com Subject: [PATCH v11 2/3] platform/x86: int3472: Add TPS68470 board data for intel nvl Date: Fri, 15 May 2026 23:15:11 +0530 Message-ID: <20260515174514.3752028-3-arun.t@intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260515174514.3752028-1-arun.t@intel.com> References: <20260515174514.3752028-1-arun.t@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The Intel NVL platform uses IPU8 powered by a TPS68470 PMIC, requiring board data to configure the GPIOs and regulators for proper camera sensor operation. Signed-off-by: Arun T Reviewed-by: Daniel Scally Reviewed-by: Hans de Goede --- .../x86/intel/int3472/tps68470_board_data.c | 105 ++++++++++++++++++ 1 file changed, 105 insertions(+) diff --git a/drivers/platform/x86/intel/int3472/tps68470_board_data.c b/dri= vers/platform/x86/intel/int3472/tps68470_board_data.c index 4358dc601923..c53542465fb4 100644 --- a/drivers/platform/x86/intel/int3472/tps68470_board_data.c +++ b/drivers/platform/x86/intel/int3472/tps68470_board_data.c @@ -289,6 +289,86 @@ static const struct tps68470_regulator_platform_data m= si_prestige_ai_evo_tps6847 }, }; =20 +/* Settings for Intel NVL platform */ + +static struct regulator_consumer_supply ovti13b1_core_consumer_supplies[] = =3D { + REGULATOR_SUPPLY("dvdd", "i2c-OVTI13B1:01"), +}; + +static struct regulator_consumer_supply ovti13b1_ana_consumer_supplies[] = =3D { + REGULATOR_SUPPLY("avdd", "i2c-OVTI13B1:01"), +}; + +static struct regulator_consumer_supply ovti13b1_vcm_consumer_supplies[] = =3D { + REGULATOR_SUPPLY("vcc", "i2c-OVTI13B1:01-VCM"), +}; + +static struct regulator_consumer_supply ovti13b1_vsio_consumer_supplies[] = =3D { + REGULATOR_SUPPLY("dovdd", "i2c-OVTI13B1:01"), +}; + +static const struct regulator_init_data intel_nvl_tps68470_core_reg_init_d= ata =3D { + .constraints =3D { + .min_uV =3D 1200000, + .max_uV =3D 1200000, + .apply_uV =3D true, + .valid_ops_mask =3D REGULATOR_CHANGE_STATUS, + }, + .num_consumer_supplies =3D ARRAY_SIZE(ovti13b1_core_consumer_supplies), + .consumer_supplies =3D ovti13b1_core_consumer_supplies, +}; + +static const struct regulator_init_data intel_nvl_tps68470_ana_reg_init_da= ta =3D { + .constraints =3D { + .min_uV =3D 2815200, + .max_uV =3D 2815200, + .apply_uV =3D true, + .valid_ops_mask =3D REGULATOR_CHANGE_STATUS, + }, + .num_consumer_supplies =3D ARRAY_SIZE(ovti13b1_ana_consumer_supplies), + .consumer_supplies =3D ovti13b1_ana_consumer_supplies, +}; +static const struct regulator_init_data intel_nvl_tps68470_vcm_reg_init_da= ta =3D { + .constraints =3D { + .min_uV =3D 2815200, + .max_uV =3D 2815200, + .apply_uV =3D true, + .valid_ops_mask =3D REGULATOR_CHANGE_STATUS, + }, + .num_consumer_supplies =3D ARRAY_SIZE(ovti13b1_vcm_consumer_supplies), + .consumer_supplies =3D ovti13b1_vcm_consumer_supplies, +}; + +/* Ensure the always-on VIO regulator has the same voltage as VSIO */ +static const struct regulator_init_data intel_nvl_tps68470_vio_reg_init_da= ta =3D { + .constraints =3D { + .min_uV =3D 1800600, + .max_uV =3D 1800600, + .apply_uV =3D true, + .always_on =3D true, + }, +}; +static const struct regulator_init_data intel_nvl_tps68470_vsio_reg_init_d= ata =3D { + .constraints =3D { + .min_uV =3D 1800600, + .max_uV =3D 1800600, + .apply_uV =3D true, + .valid_ops_mask =3D REGULATOR_CHANGE_STATUS, + }, + .num_consumer_supplies =3D ARRAY_SIZE(ovti13b1_vsio_consumer_supplies), + .consumer_supplies =3D ovti13b1_vsio_consumer_supplies, +}; + +static const struct tps68470_regulator_platform_data intel_nvl_tps68470_pd= ata =3D { + .reg_init_data =3D { + [TPS68470_CORE] =3D &intel_nvl_tps68470_core_reg_init_data, + [TPS68470_ANA] =3D &intel_nvl_tps68470_ana_reg_init_data, + [TPS68470_VCM] =3D &intel_nvl_tps68470_vcm_reg_init_data, + [TPS68470_VIO] =3D &intel_nvl_tps68470_vio_reg_init_data, + [TPS68470_VSIO] =3D &intel_nvl_tps68470_vsio_reg_init_data, + }, +}; + static struct gpiod_lookup_table surface_go_int347a_gpios =3D { .dev_id =3D "i2c-INT347A:00", .table =3D { @@ -323,6 +403,14 @@ static struct gpiod_lookup_table msi_prestige_ai_evo_o= vti5675_gpios =3D { } }; =20 +static struct gpiod_lookup_table intel_nvl_tps68470_gpios =3D { + .dev_id =3D "i2c-OVTI13B1:01", + .table =3D { + GPIO_LOOKUP("tps68470-gpio", 9, "reset", GPIO_ACTIVE_LOW), + { } + } +}; + static const struct property_entry int3472_tps68470_daisy_chain_gpio_props= [] =3D { PROPERTY_ENTRY_BOOL("daisy-chain-enable"), { } @@ -371,6 +459,16 @@ static const struct int3472_tps68470_board_data msi_pr= estige_ai_evo_tps68470_boa }, }; =20 +static const struct int3472_tps68470_board_data intel_nvl_tps68470_board_d= ata =3D { + .dev_name =3D "i2c-INT3472:04", + .tps68470_regulator_pdata =3D &intel_nvl_tps68470_pdata, + .tps68470_gpio_swnode =3D &int3472_tps68470_daisy_chain_gpio_swnode, + .n_gpiod_lookups =3D 1, + .tps68470_gpio_lookup_tables =3D { + &intel_nvl_tps68470_gpios, + }, +}; + static const struct dmi_system_id int3472_tps68470_board_data_table[] =3D { { .matches =3D { @@ -424,6 +522,13 @@ static const struct dmi_system_id int3472_tps68470_boa= rd_data_table[] =3D { }, .driver_data =3D (void *)&msi_prestige_ai_evo_tps68470_board_data, }, + { + .matches =3D { + DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Intel Corporation"), + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Nova Lake Client Platform"), + }, + .driver_data =3D (void *)&intel_nvl_tps68470_board_data, + }, { } }; =20 --=20 2.43.0 From nobody Fri Jun 19 00:40:34 2026 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 07C6F3FDBF5; Fri, 15 May 2026 17:53:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.13 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778867586; cv=none; b=agK6eI5YbOszzk6j4BIf+UDveWbPfS2IHZDm/c+ZnKIv+uZYYiFUvjlhvzIKyU+SDTOWujkoHMShCXKnmYEmqNN8Nw0bIW+a4DTj/xnhOVsVm0Ud+btX6StNDICCfUfoaxGXS/TcTtEAFA40G3j4txs9iCwwtCWOtiWJ8bcnacQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778867586; c=relaxed/simple; bh=LTeQaUWHvsph4joDVjSb9M34kexlgvWpIEuOIo8m45k=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=YSP/486IjQc3G0+QT46XJcsnM2dgpDYAHGFVls2KsmAC+sVJGP24bqSLdqlo6PXkav+0TvwmTQhm543Jwidlx1AK43TEfr78tEzOEhDQv18azBVP101XGcbZX1Mdec9YfWIN4jxkLX0/xKzOPa4UP3jjzWhVYw0b1n4VCYzYuHQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=WmNfr84g; arc=none smtp.client-ip=198.175.65.13 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="WmNfr84g" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1778867585; x=1810403585; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=LTeQaUWHvsph4joDVjSb9M34kexlgvWpIEuOIo8m45k=; b=WmNfr84g+y+NIMJRd4qmUkXW1j+AlKxRB2XJShbr8mWKrgmGs06wJJMo GJnEpgMuQC4V7hiXuUiKe9Cl+epwERB+iRQq2lzVdyips36clkgLZ0Ruh JHuLxV6TuFgwp2Os1UScJ3jnAutSFEI/jfw34pY0OVXl4R75qtXGKJU4f B2prffJdJ5WyifMmjf0YMi7LT/NrKVQ2C9lY3GPt9Ds2FSu6Fv6hqV8xl 1cQ8k93Y7dpGLrSl/BQ56NIMYQ6rbB6EkPaV6zdQJX9WHQmMlF9QxAQtK lWTcn0IWdZ2j3xojx2ksIZoz3LPWvGa/jT7EMy8ndklsk3lSPYsOjwU7i g==; X-CSE-ConnectionGUID: +CuLbGf3TwiX5cSwO3CFoA== X-CSE-MsgGUID: alvhBFYKSGGvyQOE9o995g== X-IronPort-AV: E=McAfee;i="6800,10657,11787"; a="90931366" X-IronPort-AV: E=Sophos;i="6.23,236,1770624000"; d="scan'208";a="90931366" Received: from orviesa006.jf.intel.com ([10.64.159.146]) by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 May 2026 10:53:05 -0700 X-CSE-ConnectionGUID: YiZiEgG0S3Ov6RP+5rnulw== X-CSE-MsgGUID: 8CWXwfNeQHSxjmpngmq00g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,236,1770624000"; d="scan'208";a="237760934" Received: from intel-nuc8i7beh.iind.intel.com ([10.223.163.35]) by orviesa006.jf.intel.com with ESMTP; 15 May 2026 10:53:02 -0700 From: Arun T To: arun.t@intel.com, johannes.goede@oss.qualcomm.com Cc: sakari.ailus@linux.intel.com, arec.kao@intel.com, ilpo.jarvinen@linux.intel.com, dan.scally@ideasonboard.com, platform-driver-x86@vger.kernel.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, mehdi.djait@intel.com Subject: [PATCH v11 3/3] media: ov13b10: Support multiple regulators Date: Fri, 15 May 2026 23:15:12 +0530 Message-ID: <20260515174514.3752028-4-arun.t@intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260515174514.3752028-1-arun.t@intel.com> References: <20260515174514.3752028-1-arun.t@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The OV13B10 sensor driver currently handles a single regulator called avdd, however the sensor can be supplied by up to three regulators. Update the driver to handle all of them together using the regulator bulk API. Signed-off-by: Arun T Reviewed-by: Hans de Goede --- drivers/media/i2c/ov13b10.c | 47 ++++++++++++++++++++----------------- 1 file changed, 26 insertions(+), 21 deletions(-) diff --git a/drivers/media/i2c/ov13b10.c b/drivers/media/i2c/ov13b10.c index 5421874732bc..b0d34141a13a 100644 --- a/drivers/media/i2c/ov13b10.c +++ b/drivers/media/i2c/ov13b10.c @@ -8,6 +8,7 @@ #include #include #include +#include #include #include #include @@ -699,6 +700,12 @@ static const struct ov13b10_mode supported_2_lanes_mod= es[] =3D { }, }; =20 +static const char * const ov13b10_supply_names[] =3D { + "dovdd", /* Digital I/O power */ + "avdd", /* Analog power */ + "dvdd", /* Digital core power */ +}; + struct ov13b10 { struct device *dev; =20 @@ -708,7 +715,7 @@ struct ov13b10 { struct v4l2_ctrl_handler ctrl_handler; =20 struct clk *img_clk; - struct regulator *avdd; + struct regulator_bulk_data supplies[ARRAY_SIZE(ov13b10_supply_names)]; struct gpio_desc *reset; =20 /* V4L2 Controls */ @@ -1194,9 +1201,8 @@ static int ov13b10_power_off(struct device *dev) struct ov13b10 *ov13b10 =3D to_ov13b10(sd); =20 gpiod_set_value_cansleep(ov13b10->reset, 1); - - if (ov13b10->avdd) - regulator_disable(ov13b10->avdd); + regulator_bulk_disable(ARRAY_SIZE(ov13b10_supply_names), + ov13b10->supplies); =20 clk_disable_unprepare(ov13b10->img_clk); =20 @@ -1214,14 +1220,12 @@ static int ov13b10_power_on(struct device *dev) dev_err(dev, "failed to enable imaging clock: %d", ret); return ret; } - - if (ov13b10->avdd) { - ret =3D regulator_enable(ov13b10->avdd); - if (ret < 0) { - dev_err(dev, "failed to enable avdd: %d", ret); - clk_disable_unprepare(ov13b10->img_clk); - return ret; - } + ret =3D regulator_bulk_enable(ARRAY_SIZE(ov13b10_supply_names), + ov13b10->supplies); + if (ret < 0) { + dev_err(dev, "failed to enable regulators\n"); + clk_disable_unprepare(ov13b10->img_clk); + return ret; } =20 gpiod_set_value_cansleep(ov13b10->reset, 0); @@ -1475,7 +1479,8 @@ static int ov13b10_get_pm_resources(struct ov13b10 *o= v13b) unsigned long freq; int ret; =20 - ov13b->reset =3D devm_gpiod_get_optional(ov13b->dev, "reset", GPIOD_OUT_L= OW); + ov13b->reset =3D devm_gpiod_get_optional(ov13b->dev, "reset", + GPIOD_OUT_LOW); if (IS_ERR(ov13b->reset)) return dev_err_probe(ov13b->dev, PTR_ERR(ov13b->reset), "failed to get reset gpio\n"); @@ -1491,15 +1496,15 @@ static int ov13b10_get_pm_resources(struct ov13b10 = *ov13b) "external clock %lu is not supported\n", freq); =20 - ov13b->avdd =3D devm_regulator_get_optional(ov13b->dev, "avdd"); - if (IS_ERR(ov13b->avdd)) { - ret =3D PTR_ERR(ov13b->avdd); - ov13b->avdd =3D NULL; - if (ret !=3D -ENODEV) - return dev_err_probe(ov13b->dev, ret, - "failed to get avdd regulator\n"); - } + for (unsigned int i =3D 0; i < ARRAY_SIZE(ov13b10_supply_names); i++) + ov13b->supplies[i].supply =3D ov13b10_supply_names[i]; =20 + ret =3D devm_regulator_bulk_get(ov13b->dev, + ARRAY_SIZE(ov13b10_supply_names), + ov13b->supplies); + if (ret) + return dev_err_probe(ov13b->dev, ret, + "failed to get regulators\n"); return 0; } =20 --=20 2.43.0