From nobody Fri Jun 12 11:08:41 2026 Received: from mail-07.mail-europe.com (mail-07.mail-europe.com [188.165.51.139]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4F4A546AF1E for ; Fri, 15 May 2026 11:54:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=188.165.51.139 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778846070; cv=none; b=Ei2zSZnS7LjMiChqTUWvV9fv4ZXkvrPifTOriAix5nZk13KWzj69IARzXqCODSQG7S6oaNFdlXe35NgDu3kYT7fV4cGbsQJPHQRvY2HW4JrjsvoptHofIGyER715YoAjOo+8yvdShV9U8Gp8iJp5IaMKRAUFDUAcKAeIrfHA3Pk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778846070; c=relaxed/simple; bh=VTnLv9ZxCf8IH9AnKYTUkkigGj4tj3euaM/JHw+koJE=; h=Date:To:From:Cc:Subject:Message-ID:MIME-Version:Content-Type; b=fJ0J4BoEq9OHV99+D2VHmvGjvrwM0ay+5o/aPOj52jRXIm5P8IyE3QsuTUGPGqKluDnwpVE/DAw4cXlEEZQWuWxo8z6wwu0XKe8zUO5hMg+aoIh1NP7lkUpBIt3detk2VyRUwM4fFI3HWWMUlA9TxdD1rCbgNkaWE9KgcP10ixw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com; spf=pass smtp.mailfrom=protonmail.com; dkim=pass (2048-bit key) header.d=protonmail.com header.i=@protonmail.com header.b=fuxr8e75; arc=none smtp.client-ip=188.165.51.139 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=protonmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=protonmail.com header.i=@protonmail.com header.b="fuxr8e75" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1778846057; x=1779105257; bh=QxtCszucR2ecHDKXKl3lNVrCe53WJHoNtSwfDpYlT1s=; h=Date:To:From:Cc:Subject:Message-ID:Feedback-ID:From:To:Cc:Date: Subject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector; b=fuxr8e75e4VwA/0Wrmk6+ICrpk7vbCydAWdakFzZiJ6g23hsjclC2lg3G5z2tOb60 K9t+ElkqTLPXhV9El7FEj0KT93fFHHGTlpzN08/0kF/rak3cUbOw56qhCJwUVkpeNX k4c90Op0e3Ie5lDUUXUxPKdddmn+xWG1KUFJhjgw5ThvSjPnfIcWHgpBcJ2mOLjLXm aYgOwLDDDdCEVvOQX/zoVnPs53nDvwa9fvzImMmzMzLvk/WYf7DrYm+Qz0KGWvruED YbmQff9wbXSm/O4Mt6i+haESNg5P8KlLyTYJQNgd9NnBJoIs7/JzEyQK8QIuFPq7+g c1NiU/kzaEgOQ== Date: Fri, 15 May 2026 11:54:07 +0000 To: tomeu@tomeuvizoso.net, ogabbay@kernel.org From: Abhai Kollara Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Abhai Kollara Subject: [PATCH] accel/rocket: use dev_err_probe() for MMIO mapping errors Message-ID: <20260515115335.4104438-1-abhai@protonmail.com> Feedback-ID: 8137229:user:proton X-Pm-Message-ID: 747d057083a37a9b5a7bd0c343887a96dda76bb1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The reset and clock paths in rocket_core_init() already use dev_err_probe(), but the three devm_platform_ioremap_resource_byname() calls still open-code dev_err() followed by return PTR_ERR(). Convert them for consistency. dev_err_probe() additionally silences the -EPROBE_DEFER noise in dmesg and records the failure reason against the device, where /sys/kernel/debug/devices_deferred can surface it. Signed-off-by: Abhai Kollara --- drivers/accel/rocket/rocket_core.c | 21 +++++++++------------ 1 file changed, 9 insertions(+), 12 deletions(-) diff --git a/drivers/accel/rocket/rocket_core.c b/drivers/accel/rocket/rock= et_core.c index b3b2fa9ba645..1b27a2c2f435 100644 --- a/drivers/accel/rocket/rocket_core.c +++ b/drivers/accel/rocket/rocket_core.c @@ -33,22 +33,19 @@ int rocket_core_init(struct rocket_core *core) return dev_err_probe(dev, err, "failed to get clocks for core %d\n", cor= e->index); =20 core->pc_iomem =3D devm_platform_ioremap_resource_byname(pdev, "pc"); - if (IS_ERR(core->pc_iomem)) { - dev_err(dev, "couldn't find PC registers %ld\n", PTR_ERR(core->pc_iomem)= ); - return PTR_ERR(core->pc_iomem); - } + if (IS_ERR(core->pc_iomem)) + return dev_err_probe(dev, PTR_ERR(core->pc_iomem), + "couldn't find PC registers\n"); =20 core->cna_iomem =3D devm_platform_ioremap_resource_byname(pdev, "cna"); - if (IS_ERR(core->cna_iomem)) { - dev_err(dev, "couldn't find CNA registers %ld\n", PTR_ERR(core->cna_iome= m)); - return PTR_ERR(core->cna_iomem); - } + if (IS_ERR(core->cna_iomem)) + return dev_err_probe(dev, PTR_ERR(core->cna_iomem), + "couldn't find CNA registers\n"); =20 core->core_iomem =3D devm_platform_ioremap_resource_byname(pdev, "core"); - if (IS_ERR(core->core_iomem)) { - dev_err(dev, "couldn't find CORE registers %ld\n", PTR_ERR(core->core_io= mem)); - return PTR_ERR(core->core_iomem); - } + if (IS_ERR(core->core_iomem)) + return dev_err_probe(dev, PTR_ERR(core->core_iomem), + "couldn't find CORE registers\n"); =20 dma_set_max_seg_size(dev, UINT_MAX); =20 --=20 2.43.0