From nobody Fri Jun 12 11:39:05 2026 Received: from acj35aaf127.lhr1.oracleemaildelivery.com (acj35aaf127.lhr1.oracleemaildelivery.com [130.35.116.127]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4282043E48A for ; Fri, 15 May 2026 09:53:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=130.35.116.127 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778838820; cv=none; b=L3xpgA1fBhzXQHgabBwDYNmiu8ObcTkgLCILWZS8V1SR9ZUm95gUoNp43LyOxnqRACZpPRBVPZyHvS2FMPQMYCmo9hRoihDMnrkTqY35/UN2wAiYGMHO9sbjrwd8iZk14EzQ7c4SYfpTsuWJEAmQmqDV+P6i6nswD8+n8q4R+UM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778838820; c=relaxed/simple; bh=QLygpKb2dZMhs/Db+eZZHoi1JZ9i/aczi6DYmubhJMI=; h=From:To:Cc:Subject:Date:Message-id:In-reply-to:References: MIME-version:Content-type; b=IEaJMh1cv8V1RpZOxEuum5nr9MLKn4GjzeNj0tgLgh27hHtNQSr3YBVNQrgRq9RSQPSvdY9+4u4BbRNFOVxSueu2fF+5Kd8HIJkhlt8vkzLdVtIxKh8fUF9Gtc14uR0VAERI02VBtWUV4hSsrdqk99vBxmC0jKTpG0KD5JlS2JY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=raczylo.com; spf=pass smtp.mailfrom=lhr1.rp.oracleemaildelivery.com; dkim=pass (2048-bit key) header.d=raczylo.com header.i=@raczylo.com header.b=Tl9wDPXR; dkim=pass (2048-bit key) header.d=lhr1.rp.oracleemaildelivery.com header.i=@lhr1.rp.oracleemaildelivery.com header.b=X+Sx/Td5; arc=none smtp.client-ip=130.35.116.127 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=raczylo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lhr1.rp.oracleemaildelivery.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=raczylo.com header.i=@raczylo.com header.b="Tl9wDPXR"; dkim=pass (2048-bit key) header.d=lhr1.rp.oracleemaildelivery.com header.i=@lhr1.rp.oracleemaildelivery.com header.b="X+Sx/Td5" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=oracle-uk-012026; d=raczylo.com; h=Date:To:From:Subject:Message-Id:MIME-Version:Sender:List-Unsubscribe:List-Unsubscribe-Post; bh=KhYQsRh4VyQqcPigw9u1q21Z8nnaa7Jt0zu3uVsvbqU=; b=Tl9wDPXRyIjybTrMQM8KfvOD/eKbhk4ABRjVNtKukS/MzjflHgctGDeq9mQfQ2WfC3vXI0lgusiO Dyb7AFaEInz8L+NBhSLHLsXVe8Gkt5oOcl+yjOyErUr82u00K1Bt4oL1mHoIBOwnu62x2cRUMeZ4 oeQuPyx0D5xMd+ep4Wvi+m6Czn47ky/0DHXADZfkp5uMF5asHChbbOHQy47XArNfJJi/dy2HNHoy ruZo+1ZozdhcFE9J3aY1KpUfXYcHz4/5JpcXbl7Vl+OzCPBxDVluEMEQWX+19djdl5M0wKvF00rJ uaSdBeMyhBIzN4tMRGYGN49O6GWD7asZiHBK7Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=prod-lhr-20191104; d=lhr1.rp.oracleemaildelivery.com; h=Date:To:From:Subject:Message-Id:MIME-Version:Sender:List-Unsubscribe:List-Unsubscribe-Post; bh=KhYQsRh4VyQqcPigw9u1q21Z8nnaa7Jt0zu3uVsvbqU=; b=X+Sx/Td5jc0APsMLXnRdqw5blGLLm62CQfX28mk4fXq6ek4/fTs4O1VsmMEo+6HeTpQP++UrCcu+ raNA6mlnc0JZgPk0fGntlOq8L7VzF1ZEQzCmrMK59oKVbAV4BC6Lqr0B8VgHLbLIKWWMUETzNSKc UweG5FcgmP0hGWmzKHJCU70tqoOPWpn7153+qRymBqH/xDM0aZXRcl1itFD86uQGidqHRPD0doBQ 5q9f+hu2Wj5uor5K2Xzjl5aksFTN3zG0hoNfVz7MgVp3V3Wu8oMYWripLSODChzLwzocDdeMicDf U1U6FOi9Lexk3p0rlCIb0OSNzg2gvtFkIEjeOQ== Received: by omta-ad1-fd1-1401-uk-london-1.omtaad1.vcndplhr.oraclevcn.com (Oracle Communications Messaging Server 8.1.0.1.20260212 64bit (built Feb 12 2026)) with ESMTPS id <0TF21808ROTC1E30@omta-ad1-fd1-1401-uk-london-1.omtaad1.vcndplhr.oraclevcn.com> for linux-kernel@vger.kernel.org; Fri, 15 May 2026 09:53:36 +0000 (GMT) List-Unsubscribe-Post: List-Unsubscribe=One-Click From: Lukasz Raczylo To: netdev@vger.kernel.org Cc: Theo Lebrun , Andrea della Porta , Nicolas Ferre , Claudiu Beznea , Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org Subject: [PATCH net-next] net: macb: fix build of TX stall watchdog by replacing undefined netdev_warn_ratelimited Date: Fri, 15 May 2026 10:53:36 +0100 Message-id: <20260515095336.92237-1-lukasz@raczylo.com> X-Mailer: git-send-email 2.54.0 In-reply-to: <20260514215459.36109-4-lukasz@raczylo.com> References: <20260514215459.36109-1-lukasz@raczylo.com> <20260514215459.36109-4-lukasz@raczylo.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-version: 1.0 Content-transfer-encoding: quoted-printable Reporting-Meta: AAGGMLVl544WMl84tN2V29poZax5nOlse0gFMRELc/TH6YxsiNZHF6OLG0TWO1Bd uRwGSxavSrmdgKx8Xt/5+S5+RT3Vo97Xt8gzqihDChy5ESKfTGuymMKHfVd7cNvX WCBhQHQkc4AibDHiaPqNoSm38x1uxEM3w61Y1763/gNqiyzVGT28AQedGqgL3hLe kvN/1kfLgRluM6NykozxHM8ToCQahANA2Zwpjqnglz06p9fNF7SFVm/97A2lfgaK 0u/H8qo2Kg1Q4Upk4XOg0pHKrZe62QLQb45wZpDguCx+1FdG+YWtYnrdN3Ba+sZQ M50N9FQxZd3haxujOYJZxnVk9hIlVopnftt+/CFmx6yhElFZfG/vsnBkcbURlMJg tKCLEDmYDUuOU1zk3KVE29nqoqg6alvolRmzGammcElXOwM0fu1GOA3iMwFpW7dv Hw== Content-Type: text/plain; charset="utf-8" netdev_warn_ratelimited() does not exist in this kernel -- neither mainline net-next nor raspberrypi/linux rpi-6.18.y define a netdev_*_ratelimited() family. I confused it with the existing net_warn_ratelimited() / pr_warn_ratelimited() macros when authoring v2 patch 3 of the macb silent TX stall series, and the result fails to build with implicit-function-declaration. Replace with the standard `if (printk_ratelimit()) netdev_warn(...)` pattern. Same semantics intended by v2 patch 3 (bounded log noise, retains the netdev prefix in the message); works in every kernel version. Fixes the build of patch 3/3 of: https://lore.kernel.org/netdev/20260514215459.36109-1-lukasz@raczylo.com/= T/ Caught by an independent build test on the Talos Linux Pi 5 build (John Laur / johnlaur on GitHub), reported at: https://github.com/siderolabs/sbc-raspberrypi/issues/91#issuecomment-4456= 874307 Signed-off-by: Lukasz Raczylo --- drivers/net/ethernet/cadence/macb_main.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/etherne= t/cadence/macb_main.c --- a/drivers/net/ethernet/cadence/macb_main.c +++ b/drivers/net/ethernet/cadence/macb_main.c @@ -2057,10 +2057,11 @@ static void macb_tx_stall_watchdog(struct work_stru= ct *work) spin_unlock_irqrestore(&queue->tx_ptr_lock, flags); if (stalled) { - netdev_warn_ratelimited(bp->dev, - "TX stall detected on queue %u (tail=3D%u head=3D%u); re-kicking TSTA= RT\n", - (unsigned int)(queue - bp->queues), - cur_tail, cur_head); + if (printk_ratelimit()) + netdev_warn(bp->dev, + "TX stall detected on queue %u (tail=3D%u head=3D%u); re-kicking T= START\n", + (unsigned int)(queue - bp->queues), + cur_tail, cur_head); macb_tx_restart(queue); } -- 2.54.0