From nobody Fri Jun 12 12:49:00 2026 Received: from m16.mail.163.com (m16.mail.163.com [117.135.210.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B74163E3C5E for ; Fri, 15 May 2026 07:04:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=117.135.210.3 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778828661; cv=none; b=eK7D/1sJv7tzzEZw5OWxZvyVOgGEluW84PepDKKss+MxMTM2dQlsH0WGBppT/foPsbPu1RPo9iiLOgm41OfD4NM9s9fTO/sU5SyGT62/Tmb3wYryrjvcYkTY4wUDPT3WDK+RJ1WUOlSURX3Fz5H77oYpTYJAY5RFH56zAeVzaJU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778828661; c=relaxed/simple; bh=9tJ4AkESFT5hEmU9XUrqlNfbYTLcNaIGid2Dr/tXWV0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=WJd7yRiOh/ZO7G9mVnibCQcXG8vieSimitC559wM61wHLFTjYARPS0wCWpKyOPybjRTZAcKATQPvveyCxq+K9wtBFA8uKnqNrZ35sVTi50vzPIYETI+fCFs6pqewFjDjuB/G2yTMj/llqxjqXj01YBVBObcHopelhmse/vc0ICc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com; spf=pass smtp.mailfrom=163.com; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b=bGRGnkZD; arc=none smtp.client-ip=117.135.210.3 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=163.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="bGRGnkZD" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:To:Subject:Date:Message-ID:MIME-Version; bh=DP 0uN85hN/P6bKF4QuAuHVFx5r5zGiybbDRcEIgSFik=; b=bGRGnkZDyZTd3VL9qo lUQealMhw50wlFCXOGYzn+FbSOd0vYPCspuMpbfgavCHVQrruP4L/l4HW0tzwQoC sbqYQQlXZVdpUpfs8dmeljklQtfFssfIWryJ23ftJeS/xMH/YV5Ou3/nWN/XeHgA 4Y9VXZ9vHNOh1ymcr7VkhZks4= Received: from neo-TianYi510Pro-15ICK.. (unknown []) by gzsmtp1 (Coremail) with SMTP id PCgvCgDXnOEyxQZqinfCDg--.24181S2; Fri, 15 May 2026 15:03:17 +0800 (CST) From: liuqiangneo@163.com To: akpm@linux-foundation.org, apopple@nvidia.com, jgg@ziepe.ca, leon@kernel.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Qiang Liu Subject: [PATCH v2] lib/test_hmm: fix error path in dmirror_devmem_fault() Date: Fri, 15 May 2026 15:03:11 +0800 Message-ID: <20260515070312.130435-1-liuqiangneo@163.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: PCgvCgDXnOEyxQZqinfCDg--.24181S2 X-Coremail-Antispam: 1Uf129KBjvdXoWrKw4xWw43Cry3Zr4UGrWxJFb_yoWkXFgE9r 4rt3Z3uF45JFZ0gr4xArsayrZayFyqyayfu3Z2yrWfK34UXw1Yqwn7WrZxt3WUuF4jyFWa k3WDtrn3Ar1fCjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IU0U8nUUUUUU== X-CM-SenderInfo: 5olx1xxdqj0vrr6rljoofrz/xtbC-Baa+2oGxTaqFgAA3o Content-Type: text/plain; charset="utf-8" From: Qiang Liu Handle migrate_vma_setup() failure via goto err for unified cleanup. Reviewed-by: Alistair Popple Signed-off-by: Qiang Liu --- v2: - Add comment explaining migrate_vma_setup() won't fail in practice - https://lore.kernel.org/all/20260514025328.21175-1-liuqiangneo@163.com/ --- lib/test_hmm.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/lib/test_hmm.c b/lib/test_hmm.c index 213504915737..a232b34f8d3b 100644 --- a/lib/test_hmm.c +++ b/lib/test_hmm.c @@ -1679,8 +1679,14 @@ static vm_fault_t dmirror_devmem_fault(struct vm_fau= lt *vmf) if (order) args.flags |=3D MIGRATE_VMA_SELECT_COMPOUND; =20 - if (migrate_vma_setup(&args)) - return VM_FAULT_SIGBUS; + /* + * In practice migrate_vma_setup() should never fail unless the + * test is wrong as it just tests some static VMA properties. + */ + if (migrate_vma_setup(&args)) { + ret =3D VM_FAULT_SIGBUS; + goto err; + } =20 ret =3D dmirror_devmem_fault_alloc_and_copy(&args, dmirror); if (ret) --=20 2.43.0