From nobody Fri Jun 12 12:46:29 2026 Received: from mailgw.kylinos.cn (mailgw.kylinos.cn [124.126.103.232]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 12470317164 for ; Fri, 15 May 2026 02:02:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=124.126.103.232 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778810546; cv=none; b=jFCEALBK4dlUv2WYGXRU/j8TM9aGZAnMg02ja4Kv0IaE7/LgNI9HwvPI6+1nW+HxUE3TJMJIh3dsu3DXJDk65XylpGhIOWmshLG1LfrFH1lJezJEvtJn0L1AZDfNXFtwVrymUJ2EE+9SWxs8VREdvRaXVpn640hnkGnkyBTfVdM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778810546; c=relaxed/simple; bh=2S1sKiW0jIiarmx1ouKNcyLJ7m2FNoavLYO0hzq+zt4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=diC/1jwfHLfadAr+ebkDmm8aVi1Z8axSaORFGgeBNi2CKQmZxIGqvc2JBsbMq8HbQCPJDI+R0g0V7F2iiSO2tN61d+syVGrMKRTpFAxJf78gTp6ZFyw6wUeLQNG7+LEMt4uzm8+d2gG3Cwb6+qd3BVDfDXZNCHLHz5mF9Vwscps= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn; spf=pass smtp.mailfrom=kylinos.cn; arc=none smtp.client-ip=124.126.103.232 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kylinos.cn X-UUID: 17988f08500211f1aa26b74ffac11d73-20260515 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.3.12,REQID:760c5b62-446b-4af5-b661-e25add304837,IP:0,U RL:0,TC:0,Content:-5,EDM:25,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTIO N:release,TS:20 X-CID-META: VersionHash:e7bac3a,CLOUDID:7671be52743ff18bfacf7cc4190eba34,BulkI D:nil,BulkQuantity:0,Recheck:0,SF:102|850|898,TC:nil,Content:0|15|50,EDM:5 ,IP:nil,URL:0,File:nil,RT:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA:0,AV :0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0,ARC:0 X-CID-BVR: 2,SSN|SDN X-CID-BAS: 2,SSN|SDN,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR X-CID-RHF: D41D8CD98F00B204E9800998ECF8427E X-UUID: 17988f08500211f1aa26b74ffac11d73-20260515 X-User: yanlonglong@kylinos.cn Received: from localhost.localdomain [(10.44.16.150)] by mailgw.kylinos.cn (envelope-from ) (Generic MTA with TLSv1.3 TLS_AES_256_GCM_SHA384 256/256) with ESMTP id 1355092927; Fri, 15 May 2026 10:02:14 +0800 From: Bob ynn To: dri-devel@lists.freedesktop.org Cc: linux-kernel@vger.kernel.org, Andy Yan , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Luca Ceresoli , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , yanlonglong Subject: [PATCH] drm/bridge: synopsys: dw-dp: fix bool function returning negative error code Date: Fri, 15 May 2026 10:01:55 +0800 Message-ID: <20260515020156.601-1-yanlonglong@kylinos.cn> X-Mailer: git-send-email 2.47.1.windows.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: yanlonglong The function dw_dp_video_need_vsc_sdp() is declared to return bool, but it returns -EINVAL when dw_dp_get_bridge_state() fails. Since -EINVAL is a non-zero value (-22), it is implicitly converted to true, which is the opposite of the intended behavior Fixes: 86eecc3a9c2e("drm/bridge: synopsys: Add DW DPTX Controller support l= ibrary") Signed-off-by: yanlonglong --- drivers/gpu/drm/bridge/synopsys/dw-dp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-dp.c b/drivers/gpu/drm/brid= ge/synopsys/dw-dp.c index 21541be094c4..7b99d91b3456 100644 --- a/drivers/gpu/drm/bridge/synopsys/dw-dp.c +++ b/drivers/gpu/drm/bridge/synopsys/dw-dp.c @@ -1143,7 +1143,7 @@ static bool dw_dp_video_need_vsc_sdp(struct dw_dp *dp) =20 state =3D dw_dp_get_bridge_state(dp); if (!state) - return -EINVAL; + return false; =20 if (!link->vsc_sdp_supported) return false; --=20 2.43.0