From nobody Fri Jun 12 12:49:01 2026 Received: from cvsmtppost104.wmail.worksmobile.com (cvsmtppost104.wmail.worksmobile.com [125.209.209.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9C6C43A2546 for ; Thu, 14 May 2026 19:53:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=125.209.209.16 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778788383; cv=none; b=AvUrznEPrea1uLubY96/QGE3yWxCOT46mqqlz9uHzTnCk6W8YjultOPNQsSoch2BfSXZIKmkcBB8OIEIjHNaAPbPIMYIV8RHLIzVEOLrseeVbvQxC7GMWgKyrpLTiXXecozV0Y2PW5BJAcgueEWUcH/VqTn4804j2nnw/r5oVwA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778788383; c=relaxed/simple; bh=1acIE6332zSbWTuobynlJDelq6HeX8f/lMzTcfmrhZI=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=Z3iRk1Fb37TBwhzctIF9/KZu/abX+NtVoCsARA5fuNX62e/PHPvgqwisQxDnCiwvybhoR/ykOZ2GjxAaYpGDJDZXaXDw9uCXGTMKCQidtsM8gfvino6LLOGHKLO4B7RYDcs0kY249J/TSX6Ap2mX1T79aAevfo8Av2+kzrsftIs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=korea.ac.kr; spf=pass smtp.mailfrom=korea.ac.kr; dkim=pass (2048-bit key) header.d=worksmobile.com header.i=@worksmobile.com header.b=Fdey8ZGO; dkim=pass (1024-bit key) header.d=korea.ac.kr header.i=@korea.ac.kr header.b=Wq/VWUnq; arc=none smtp.client-ip=125.209.209.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=korea.ac.kr Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=korea.ac.kr Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=worksmobile.com header.i=@worksmobile.com header.b="Fdey8ZGO"; dkim=pass (1024-bit key) header.d=korea.ac.kr header.i=@korea.ac.kr header.b="Wq/VWUnq" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=worksmobile.com; s=s20171120; t=1778787166; bh=1acIE6332zSbWTuobynlJDelq6HeX8f/lMzTcfmrhZI=; h=From:To:Subject:Date:Message-Id:From:Subject:Feedback-ID: X-Works-Security; b=Fdey8ZGOSfk104QZnJNMU4NpPN/Fryl3JSkyJe/0ULIMe2o6sGBcy59hp1av1j1DE 7ipFZFo00mOoRXvHjy+NsoHJSC2nEaRP4QQZpViNzU2xK7wPORgpkV0oVOogxH6mfF SrZ1J/McYN+GZUMAr1fSIi+VlRuKjfSz2265A1+rgXkEROqzswLbVzsYclfg42vxSD TvaqlGmemJdtJilvWXbCjmw5TmgnhlJz3EGp+K1+vDb90GvHA9G39v/jzyEn7xiDUI FmGwkFKdYMQxGhEjlLXYtYIetv1Hv37LKkoCvuOV0YSlyIiZIDtieerWTlRoARiAsP Z+BRbN3YyqyfA== Received: from cvsendbo005.wmail ([10.112.11.110]) by cvsmtppost104.wmail.worksmobile.com with ESMTP id 6Gut4fIVRRiWS5YX2UN4yQ for ; Thu, 14 May 2026 19:32:46 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=korea.ac.kr; s=naverworks; t=1778787166; bh=1acIE6332zSbWTuobynlJDelq6HeX8f/lMzTcfmrhZI=; h=From:To:Subject:Date:Message-Id:From:Subject:Feedback-ID: X-Works-Security; b=Wq/VWUnqLFTs80y9ME8gB8wdrpn1uyxsi9oYXmwk2JBqiU+0Vvy5CoNUI8FPREA1o i8QkTwOCPoWwsXoIgNnJkVprRrx+2l/msWVIr0rjqXNobmM/p9a81NaheR6CuYl3ET wcZ6Jvni5g/szquJFjFwLE9pG6ws/AzkNU4FLHVs= X-Session-ID: nGRzE80uSn2UmjmtNUGmRg X-Works-Send-Opt: 3lYwjAIYjHmXFoEXKBmwaAErKqpYjHmm X-Works-Smtp-Source: Adn9Fq2XFqJZ+Hm9Fobd+6E= Received: from s2lab05.. ([163.152.163.130]) by jvnsmtp401.gwmail.worksmobile.com with ESMTP id nGRzE80uSn2UmjmtNUGmRg for (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Thu, 14 May 2026 19:32:45 -0000 From: Ingyu Jang To: Felix Fietkau , Lorenzo Bianconi , Ryder Lee Cc: Shayne Chen , Sean Wang , Matthias Brugger , AngeloGioacchino Del Regno , linux-wireless@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] wifi: mt76: Use IS_ERR() check for mt76_register_debugfs_fops() Date: Fri, 15 May 2026 04:32:43 +0900 Message-Id: <20260514193243.2518979-1-ingyujang25@korea.ac.kr> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" mt76_register_debugfs_fops() returns the dentry from debugfs_create_dir(), which yields an error pointer on failure and never NULL. The NULL checks in the per-chip *_init_debugfs() helpers are therefore unreachable, and on a real failure the ERR_PTR would be returned to callers as a valid pointer. Use IS_ERR() and propagate the actual error via PTR_ERR() in mt7615/mt7915/mt7921/mt7925/mt7996. Signed-off-by: Ingyu Jang --- drivers/net/wireless/mediatek/mt76/mt7615/debugfs.c | 4 ++-- drivers/net/wireless/mediatek/mt76/mt7915/debugfs.c | 4 ++-- drivers/net/wireless/mediatek/mt76/mt7921/debugfs.c | 4 ++-- drivers/net/wireless/mediatek/mt76/mt7925/debugfs.c | 4 ++-- drivers/net/wireless/mediatek/mt76/mt7996/debugfs.c | 4 ++-- 5 files changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/net/wireless/mediatek/mt76/mt7615/debugfs.c b/drivers/= net/wireless/mediatek/mt76/mt7615/debugfs.c index 0f7b20152279c..5c3646a67e4b7 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7615/debugfs.c +++ b/drivers/net/wireless/mediatek/mt76/mt7615/debugfs.c @@ -550,8 +550,8 @@ int mt7615_init_debugfs(struct mt7615_dev *dev) struct dentry *dir; =20 dir =3D mt76_register_debugfs_fops(&dev->mphy, &fops_regval); - if (!dir) - return -ENOMEM; + if (IS_ERR(dir)) + return PTR_ERR(dir); =20 if (is_mt7615(&dev->mt76)) debugfs_create_devm_seqfile(dev->mt76.dev, "xmit-queues", dir, diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/debugfs.c b/drivers/= net/wireless/mediatek/mt76/mt7915/debugfs.c index 26ed3745af43e..f62a17c8958ac 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7915/debugfs.c +++ b/drivers/net/wireless/mediatek/mt76/mt7915/debugfs.c @@ -1296,8 +1296,8 @@ int mt7915_init_debugfs(struct mt7915_phy *phy) struct dentry *dir; =20 dir =3D mt76_register_debugfs_fops(phy->mt76, NULL); - if (!dir) - return -ENOMEM; + if (IS_ERR(dir)) + return PTR_ERR(dir); debugfs_create_file("muru_debug", 0600, dir, dev, &fops_muru_debug); debugfs_create_file("muru_stats", 0400, dir, phy, &mt7915_muru_stats_fops); diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/debugfs.c b/drivers/= net/wireless/mediatek/mt76/mt7921/debugfs.c index 4333005b3ad95..4da339867b6a7 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7921/debugfs.c +++ b/drivers/net/wireless/mediatek/mt76/mt7921/debugfs.c @@ -266,8 +266,8 @@ int mt7921_init_debugfs(struct mt792x_dev *dev) struct dentry *dir; =20 dir =3D mt76_register_debugfs_fops(&dev->mphy, &fops_regval); - if (!dir) - return -ENOMEM; + if (IS_ERR(dir)) + return PTR_ERR(dir); =20 if (mt76_is_mmio(&dev->mt76)) debugfs_create_devm_seqfile(dev->mt76.dev, "xmit-queues", diff --git a/drivers/net/wireless/mediatek/mt76/mt7925/debugfs.c b/drivers/= net/wireless/mediatek/mt76/mt7925/debugfs.c index e2498659c884e..01aa4a1071fdd 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7925/debugfs.c +++ b/drivers/net/wireless/mediatek/mt76/mt7925/debugfs.c @@ -291,8 +291,8 @@ int mt7925_init_debugfs(struct mt792x_dev *dev) struct dentry *dir; =20 dir =3D mt76_register_debugfs_fops(&dev->mphy, &fops_regval); - if (!dir) - return -ENOMEM; + if (IS_ERR(dir)) + return PTR_ERR(dir); =20 if (mt76_is_mmio(&dev->mt76)) debugfs_create_devm_seqfile(dev->mt76.dev, "xmit-queues", diff --git a/drivers/net/wireless/mediatek/mt76/mt7996/debugfs.c b/drivers/= net/wireless/mediatek/mt76/mt7996/debugfs.c index 34af800964d11..63cd490977106 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7996/debugfs.c +++ b/drivers/net/wireless/mediatek/mt76/mt7996/debugfs.c @@ -875,8 +875,8 @@ int mt7996_init_debugfs(struct mt7996_dev *dev) struct dentry *dir; =20 dir =3D mt76_register_debugfs_fops(&dev->mphy, NULL); - if (!dir) - return -ENOMEM; + if (IS_ERR(dir)) + return PTR_ERR(dir); =20 debugfs_create_file("hw-queues", 0400, dir, dev, &mt7996_hw_queues_fops); --=20 2.34.1