From nobody Fri Jun 12 12:49:00 2026 Received: from cvsmtppost103.wmail.worksmobile.com (cvsmtppost103.wmail.worksmobile.com [125.209.209.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B0AE73A8750 for ; Thu, 14 May 2026 19:52:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=125.209.209.19 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778788353; cv=none; b=KgrR3cPMtR/mnXn8Wo84T3DLe4GTg67RnE3f0hkMjCIyrmVl+s+ZhcorgWcYIrFQXTd7ExRFdnBXXTRFvOnwS6iGSmNZ3BRZC9HfnLjv4RO7qiB4Wg81ESo3Th3+v/qw5PxysWW299IExPLtvxM48I4gd2BfRz6FO1tBfz11yes= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778788353; c=relaxed/simple; bh=amiXjXVBJpA+yZ5UmzAvKSen58KL7Svqj9Ff4nouyec=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=GBhHRf4RChB1Xylj4uRmk3q33SDxcm7KD3g1MpvtPWnVUn177oN7uYulhnT48dZd9hr33K9IrcBp+VC2C+sZiRhq9JS5S+/b3yjurbJFfeIOAuLmg6CwpGA0iR0vGwJLLn8wugCsQ72AmMIppcGnQ3ho/v5HSRDxVR4fI0R1TjQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=korea.ac.kr; spf=pass smtp.mailfrom=korea.ac.kr; dkim=pass (2048-bit key) header.d=worksmobile.com header.i=@worksmobile.com header.b=O7APJIAn; dkim=pass (1024-bit key) header.d=korea.ac.kr header.i=@korea.ac.kr header.b=PuaK3xOa; arc=none smtp.client-ip=125.209.209.19 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=korea.ac.kr Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=korea.ac.kr Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=worksmobile.com header.i=@worksmobile.com header.b="O7APJIAn"; dkim=pass (1024-bit key) header.d=korea.ac.kr header.i=@korea.ac.kr header.b="PuaK3xOa" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=worksmobile.com; s=s20171120; t=1778787135; bh=amiXjXVBJpA+yZ5UmzAvKSen58KL7Svqj9Ff4nouyec=; h=From:To:Subject:Date:Message-Id:From:Subject:Feedback-ID: X-Works-Security; b=O7APJIAnxlx4jwx3wYB2oqI60G/I0/mCmmhwArVcjF1qaHCrSd6biv2heDZWnoNBe jC4TUb/vu5Q2mMIvHlm5mDOZAHdj4bk1Fz4ImI2/vZKY5ZAapLaNAM4P2EU2GBK08w MwZzobvWlUnrAKJIE+jP016NumUjYINdjAoxZNDsSo6R9uG5OVYIx/JI+uMT0GpbM2 nMq9PYteGKK0gSgQluxlXFvHtu8nvorGLbU3jBWQcO2Yl/lIBHDue4Wfuc9dycZlGL 5UPIpzjYqyp3x9LZZ4zOg+n+6WVY0khecGZhYC9Fw0U0WQzfZAd96H8JvidukOAJwa K1f0XyT9u2Uiw== Received: from cvsendbo002.wmail ([10.113.20.164]) by cvsmtppost103.wmail.worksmobile.com with ESMTP id GUqgq6AZQdWT+x6GEtMU0Q for ; Thu, 14 May 2026 19:32:15 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=korea.ac.kr; s=naverworks; t=1778787135; bh=amiXjXVBJpA+yZ5UmzAvKSen58KL7Svqj9Ff4nouyec=; h=From:To:Subject:Date:Message-Id:From:Subject:Feedback-ID: X-Works-Security; b=PuaK3xOa7Vu0Ul1jUoEt86/ie3xAfGi1YlBfCF7pVxSzh+dbo1BEnjIrL6UsYhIYF DA2s5N6CVKI+1USzeuggRVsjytHUctb0W9tsyCLJyNZKUsyLiauSugOMuysXfLqLBx B8pAhYx2n0vnYrYME44xNlyVgpIyC8M4T+I/uuUU= X-Session-ID: wyQ9V1yjQNaaKmfpPX-YSA X-Works-Send-Opt: LenZjAIYjHm/FqM9FqJYFxMqFNwYjAg= X-Works-Smtp-Source: AqY9Fq2XFqJZ+Hm9Kqbd+6E= Received: from s2lab05.. ([163.152.163.130]) by jvnsmtp401.gwmail.worksmobile.com with ESMTP id wyQ9V1yjQNaaKmfpPX-YSA for (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Thu, 14 May 2026 19:32:15 -0000 From: Ingyu Jang To: Andrew Morton Cc: linux-kernel@vger.kernel.org Subject: [PATCH] error-inject: Use IS_ERR() check for debugfs_create_file() Date: Fri, 15 May 2026 04:32:14 +0900 Message-Id: <20260514193214.2432769-1-ingyujang25@korea.ac.kr> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" debugfs_create_file() returns an error pointer on failure, never NULL, so the !file check in ei_debugfs_init() never triggers and the debugfs_remove() cleanup cannot run. Use IS_ERR() and propagate the actual error via PTR_ERR(). Signed-off-by: Ingyu Jang --- lib/error-inject.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/error-inject.c b/lib/error-inject.c index f3d1b70be605c..32f3d1ca9ea23 100644 --- a/lib/error-inject.c +++ b/lib/error-inject.c @@ -219,9 +219,9 @@ static int __init ei_debugfs_init(void) dir =3D debugfs_create_dir("error_injection", NULL); =20 file =3D debugfs_create_file("list", 0444, dir, NULL, &ei_fops); - if (!file) { + if (IS_ERR(file)) { debugfs_remove(dir); - return -ENOMEM; + return PTR_ERR(file); } =20 return 0; --=20 2.34.1