From nobody Fri Jun 12 12:48:50 2026 Received: from cvsmtppost105.wmail.worksmobile.com (cvsmtppost105.wmail.worksmobile.com [125.209.209.78]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 08A0A30E0C0 for ; Thu, 14 May 2026 19:12:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=125.209.209.78 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778785957; cv=none; b=dAkreTANIDSLVU8q02/sbGdGhbJjO+EoU46aGYPUT21yZrE0qfBxmAZuMMrKE6L4ED1ZayummqELPPdYVnwaPEUldUkjXEzgisznHboCvHNM5kz+jGpzeBgaO3I2fjdix295iLaFQ6uI+/dmVG6ndpf1PF/VMxuzMPGJob6Cz90= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778785957; c=relaxed/simple; bh=4ZgZ1jc5MZTVJWvr3jQ/Q+eroPwBgVQCOd4Bu0H768g=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=OtSK3OerNRkGp4I3GgCfsMV8jF7Ybuv0Z0ORtYALzQYvYNWXuJYTFvEPmeq8KnYXt6Qevbbf7z9DBQuBaBY2eUbVZXsjjDvTkmtXASDovMRirrqGcSMPRSsgt466M0v2cia87TejOe147ZNzaT3F/GiGtVYbUufOO2Vx9Fh5710= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=korea.ac.kr; spf=pass smtp.mailfrom=korea.ac.kr; dkim=pass (2048-bit key) header.d=worksmobile.com header.i=@worksmobile.com header.b=wue2K4r9; dkim=pass (1024-bit key) header.d=korea.ac.kr header.i=@korea.ac.kr header.b=D+hOjGIf; arc=none smtp.client-ip=125.209.209.78 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=korea.ac.kr Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=korea.ac.kr Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=worksmobile.com header.i=@worksmobile.com header.b="wue2K4r9"; dkim=pass (1024-bit key) header.d=korea.ac.kr header.i=@korea.ac.kr header.b="D+hOjGIf" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=worksmobile.com; s=s20171120; t=1778784738; bh=4ZgZ1jc5MZTVJWvr3jQ/Q+eroPwBgVQCOd4Bu0H768g=; h=From:To:Subject:Date:Message-Id:From:Subject:Feedback-ID: X-Works-Security; b=wue2K4r9JGeu98SDXNuxLFU0uEBiZ5HKS8aJXaduu/Q3zaCZNru0+TKIZm2UpIkkn h7odd6n1GF9a5UggVg5YfOCfJaa/6soTKfuMt1vlpgkKsHdthGsjAEUkLGWwurmv1c IkL1Ao3XUgZn6gZVwA2NC3EIpmBjk3hEqTBOVgj8rK74jkOWzyFeXFOo7fDnRKDXNW UvCwcuVduJEFkLuO4r9UlGofPO1qyjCoC6NrA0hns4+vlyyxYBq/p6tSAODelTbL2a CYljl+hssbaJdkvBC5IVoasmgPUvGsMovkbFSSUeAs+it40Qde239cVhA6ZiN/KPMM i3zBhziTNUeDQ== Received: from cvsendbo006.wmail ([10.112.11.111]) by cvsmtppost105.wmail.worksmobile.com with ESMTP id LO9hsh+aRBCndaRe-GXa7A for ; Thu, 14 May 2026 18:52:18 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=korea.ac.kr; s=naverworks; t=1778784738; bh=4ZgZ1jc5MZTVJWvr3jQ/Q+eroPwBgVQCOd4Bu0H768g=; h=From:To:Subject:Date:Message-Id:From:Subject:Feedback-ID: X-Works-Security; b=D+hOjGIfWmfOrZZn+a47+wbANy2/yfDKV8RrzJC88fsUe+/PmvRMf2UADkjwJxPFS hPeGvANTdCCqzmQwoXIflnwrFCjYNilEXkJT/HyU+U+fWMqy0ObtVZhpvqGwvKAPxz yKLTvhCWIIcaVQ+EBjE8LuwwrzRpWFzOAIGr8pj0= X-Session-ID: hkeWohAKTAe+OyJyNKSmDA X-Works-Send-Opt: penljAIYjHm/FqM9FqJYFxMqFNwYjAg= X-Works-Smtp-Source: AqK9Fq2XFqJZ+Hm/KqKZ+6E= Received: from s2lab05.. ([163.152.163.130]) by jvnsmtp402.gwmail.worksmobile.com with ESMTP id hkeWohAKTAe+OyJyNKSmDA for (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Thu, 14 May 2026 18:52:18 -0000 From: Ingyu Jang To: Peter Ujfalusi , Jarkko Nikula , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-sound@vger.kernel.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] ASoC: ti: omap-dmic: Fix IS_ERR() vs NULL check bug in omap_dmic_select_fclk() Date: Fri, 15 May 2026 03:52:15 +0900 Message-Id: <20260514185215.3753998-1-ingyujang25@korea.ac.kr> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" clk_get_parent() returns NULL when the clock has no parent (or when the input clk is NULL); it never returns an ERR_PTR. The current IS_ERR(mux) check therefore never triggers - a NULL return falls through silently to clk_set_parent(NULL, parent_clk), which simply fails with -EINVAL. Use a NULL check so the dedicated error path runs and the prior clk_get() reference is released via clk_put(). Signed-off-by: Ingyu Jang Acked-by: Sen Wang --- sound/soc/ti/omap-dmic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/ti/omap-dmic.c b/sound/soc/ti/omap-dmic.c index fb92bb88eb5c2..f6c393c9489d6 100644 --- a/sound/soc/ti/omap-dmic.c +++ b/sound/soc/ti/omap-dmic.c @@ -328,7 +328,7 @@ static int omap_dmic_select_fclk(struct omap_dmic *dmic= , int clk_id, } =20 mux =3D clk_get_parent(dmic->fclk); - if (IS_ERR(mux)) { + if (!mux) { dev_err(dmic->dev, "can't get fck mux parent\n"); clk_put(parent_clk); return -ENODEV; --=20 2.34.1