From nobody Fri Jun 12 13:56:05 2026 Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 688982E542C for ; Thu, 14 May 2026 17:41:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778780510; cv=none; b=AXFX1vMor2OSTImBllE7sC3CDa+dANVYLEAml4wTgUGPYTBuUsGZ2uI2WMyVs8thdtRIv90lht9cmZSUYgBhZmGHCqudk0kP+rZPnWa+RKbpn8uc2EPHzEsrw2H458Oz+6SGi2inqmPb7kH07tOCCn+EyzH7SJjqFhWSGURmUYM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778780510; c=relaxed/simple; bh=a6qf4q5erCpfqWo3EtTgD7hmO1N9nnqian+MBT4QVkI=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=YnerXe9aJvVQRhf/42zhZNhbmBz7Z69yBquVi432FqsNbgk6Ml026+kOqiutS7AcaA0PdF4No/I05Koz4+XsTodVnIYkjWb2OQVaDetvZXNYR/zHVTE/AVsfVkdnjgw2UiYq5LdH9j+XkM/Z5rzusYUu4AeXxhnH4WZvLCQXIo0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HhxNhRyN; arc=none smtp.client-ip=209.85.167.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HhxNhRyN" Received: by mail-lf1-f46.google.com with SMTP id 2adb3069b0e04-5a62f43b76aso7291252e87.3 for ; Thu, 14 May 2026 10:41:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778780508; x=1779385308; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=1l+SpR/UEyvWMAal4xyrEteWb4GfZNc3Ty6R5bexWb8=; b=HhxNhRyN/s+hlqGSgPnxXEIJeHa/3+GbtNgeELlwrSAvbzV4UhtmgVy2hW1BV3Tztl U5/LlbHKazNZTGGP1CLKGda4aUHFRGmMjdFt8JbK4nfDlX93vVrJqAnNoYrXXATavRlA XgM09p6MuqqiQr5IZvvUkkNhiNbWrh3ZY40O10ah24fE/Fvwm6odQIoMKfyk9JKuuF/X PGxe+7VuxWhO1P+856GCwuU9C6A/Vy7HH1wxnOEJ994k1vw2Ca0q+2JJPKj2QlHeaB9e 3v5IKp45YAEcPs6nRQHV68cvApWo2ViioVyqIAPKSQoPQ+631q2e+AeTGcieLRYZA0fS RN8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778780508; x=1779385308; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=1l+SpR/UEyvWMAal4xyrEteWb4GfZNc3Ty6R5bexWb8=; b=njxmvY9qlQvd96Ju0tmfgdgSEgQUQPYNZMShmJ2CaG7I1sHhJZaPIHxRR/halBT0KZ Rp6w9Rla8YcW+vsaS1X8a81rMr0SawzrlppmcA+jrtKZk4KWPfBJfCC6cfs9ll8AqlWN Va0xgtDpLc8YVEg+TqbZwvd5JvQ/xo8NdbT6fznYxquS6rtQUH8AWGXqFGBV1Wl8nINc l7ufvMeAicLWy3Pa+AMR4WztmQ+Rllvx/DcYPM5sOVMgr89pSue0yYHDX7okggtEVMXr QuvXsJSf9j3KAv87uUIhR+ee7vXmvrP8tc+OBYUtJuQYi1Bvg5YRpb8I5dCdhkj9t0WW nEtQ== X-Forwarded-Encrypted: i=1; AFNElJ9+EmEdg8TmW+1gBVKRJvf9iYuv3c3ZNfcWlsU3D2ISiphT0TLTkETxOWGzTuuBAQcvBTHFwpGqA82OQWE=@vger.kernel.org X-Gm-Message-State: AOJu0YzaZDNjurUO4EVeF1pKW9n0bOD/DMGg4ni5BD1w5HUJw/YBID5R mNgerDl40le2YN5n8P+Yi44wL0qnnrou3+shy1RWe6Kj1MjH0OqIJBPo X-Gm-Gg: Acq92OGkQuLo6mwH91UA8EWJClby02MlOR5V0WedA58JflMFlw5Jy23DTwhiR3wBjkr yrcFZi2hKq6Irl0FiTOYsvi8uhJSVqQOPaa3Oly4Nj3VWq02m9JajyHrZShSCIgF3+p4h5hZQFz KthSZGZOKC3ELANAUPfTwyct02QF4UXTT5wR7ELVI+oQmMwWdQWPqX1/EyuaXZiugYutNgnXk08 4CqoydLkx79Lxnj5G6NgsJnoat2fhkoKxIftgd7yL/olz0Atz4S1AvITcGjaADvbqMHlCM0FtHd 0ItM3IMWK4ykyRuEcEIpazN9XdWrv72aC3/S9QvP0fKfKY1qdp9Xk2aiDQzTydtMacaSo4Fcrsr kNwYAbjq14+py97PrIC5PMIQRtPk4sAqOTCo76aUrDx58dZe+xIoR1ITSpTJYlqxhnfb0M8zUj3 QGGNa0B3jLphIT21fiO5IDhwW+6zgI4FA+wU+uEdjL/HST0VBaVtk/CmTUmQtzedcOulc= X-Received: by 2002:a05:6512:1287:b0:5a9:bdab:2d19 with SMTP id 2adb3069b0e04-5aa0e5c3b4emr47624e87.0.1778780507399; Thu, 14 May 2026 10:41:47 -0700 (PDT) Received: from localhost.localdomain ([217.107.127.207]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a90f10c84dsm613528e87.10.2026.05.14.10.41.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 May 2026 10:41:46 -0700 (PDT) From: Bulatov Mark To: Lyude Paul Cc: Mark Bulatov , Danilo Krummrich , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Ben Skeggs , Dave Airlie , dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org Subject: [PATCH] drm/nouveau: handle nouveau_hw_get_clock() return value Date: Thu, 14 May 2026 20:40:08 +0300 Message-Id: <20260514174008.4515-1-ms.bulatov7@gmail.com> X-Mailer: git-send-email 2.39.5 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Mark Bulatov In the nv04_update_arb() function, MClk and NVClk are passed to nv04_calc_arb() or nv10_calc_arb(), where they are used as divisors. MClk and NVClk are calculated using nouveau_hw_get_clock(), which, via nouveau_hw_pllvals_to_clk(), can return 0, resulting in division by 0. The result of nouveau_hw_get_pllvals() in the nouveau_hw_get_clock() function can also return -ENOENT, which is not checked anywhere. Fix all this by adding a check. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: 6ee738610f41 ("drm/nouveau: Add DRM driver for NVIDIA GPUs") Signed-off-by: Mark Bulatov --- drivers/gpu/drm/nouveau/dispnv04/arb.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/nouveau/dispnv04/arb.c b/drivers/gpu/drm/nouve= au/dispnv04/arb.c index 1d3542d6006b..2f59b8739fc1 100644 --- a/drivers/gpu/drm/nouveau/dispnv04/arb.c +++ b/drivers/gpu/drm/nouveau/dispnv04/arb.c @@ -202,6 +202,9 @@ nv04_update_arb(struct drm_device *dev, int VClk, int b= pp, uint32_t cfg1 =3D nvif_rd32(device, NV04_PFB_CFG1); struct pci_dev *pdev =3D to_pci_dev(dev->dev); =20 + if (MClk <=3D 0 || NVClk <=3D 0) + return; + sim_data.pclk_khz =3D VClk; sim_data.mclk_khz =3D MClk; sim_data.nvclk_khz =3D NVClk; --=20 2.39.5