From nobody Fri Jun 12 14:18:25 2026 Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2AAB525393E for ; Thu, 14 May 2026 11:41:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778758863; cv=none; b=itUJi8391IDpfEic0vS7v2mWPkRJU2WIUGEPVCyPZnBEvhI3sLbCiw/7V0aUSWiNdQyXwZguaA1QjaU+3exqGUPj/KYJOFs+iVIqQgV6vczBmVVR98N7c0vXmoFNU6Q/0dep4q7SMRbjtpCHDGJo6CMN1b9SrF/Nb3plSlZ+IxI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778758863; c=relaxed/simple; bh=LJr59c/55DJC4Wsxi9rV58L2pCVOazI/rRq+AeCTc9Q=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=VUGkQl2Lv76sWKV+aTQkbjrUH4J9kmmv2GoKUGwKPWNq1t3Q76kvkzC6/OCC/6n4NS4/XtMxuBVx2UCld2/X6GfZ9qw7rw33W4Tk0+SzbX/vtgk9iLfMY7xrr+o0OET7hdDCX/sfB0aBLhGkAkJtbc5IJpqtKyWBFmV4IPQXy/4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VlB2KeMb; arc=none smtp.client-ip=209.85.210.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VlB2KeMb" Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-83ef1d17904so2711867b3a.1 for ; Thu, 14 May 2026 04:41:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778758860; x=1779363660; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=FckyD5Kv4+O1B9NLxmiPkGiYd0Izvn80A7tr//y55g4=; b=VlB2KeMb3xw0jFmkuy5IdF4L911jT7GSSQLDKjuDrbp1qhIb6Gid5ZgV8bNQhAnetV d5mjENFIyWDkzwPeB8u9yJwORFwChHhARwLp2y2gYPeNtyfEuDQo5XHL85Y3aHILvXn6 WVQOQlRZZmuiiSbnLT95oLB58On2qgkAmjf0nld0ylXWhFQ3iW9h4bU3ggtnZX55EBC4 HtyJzkzonae5awTDDbJKWgl4Im2urq5kPKrv5LsTZhfPN6j6joF3f+ZzK3RCFw9pNEyC 4mkW4r39scK6TeRRzOz+Xnc38XkQNMvobsIeYrjyEH4NZfKVVrVT8itlSDz0R/bMNA0s Qhmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778758860; x=1779363660; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=FckyD5Kv4+O1B9NLxmiPkGiYd0Izvn80A7tr//y55g4=; b=MYArVKCDZs6sQDr2W0DlbTf0bvbA/Ouxw4fQgvwLrFR/Yd7z+aEvUObvEGCCsAuRLu XC7Nr7cOJm+bdjvAg9Wz02Pof0zyMWDV5lJefLY2yOCR2/5EyQtOSlBBMnHuLMYAUad8 XknTL3zv7fTB0VY/gSbUzLSFUJqnL5atoOl7h2CgCS6oyWPasAHxTxA0Or7+IA5brK/p oD+TrjoliIPSLZthty5jesN9xQRtd74rMvtlJ716XONAjsE3Ui8dr+5Bi4p6ZFS69V4R xtcE4soG7L8syCdSCQtE4SLq0qrcwa0ynB1C8inB98lI+IEXNN5f7/roia6FRIgEgFoQ q33A== X-Forwarded-Encrypted: i=1; AFNElJ/WOcyuObNG8nqEPqWDrEg9Up8IunHj7y2U8ypNuUhunsEiYZ8l0Zs9WVj+KTma7iBs5tayaSNTymYNUdc=@vger.kernel.org X-Gm-Message-State: AOJu0YzLriubIiSkMExVmskMxDrIMkvuYgUonDgLEjQoPN1NrnFnGnv4 SPrHbPKZ4g24V/F/c3SH5H6MIZ3xGDSE8k6UU0HHsWuP6NpzLAZEsu7T X-Gm-Gg: Acq92OHB3KorgvbjUZRKHWH0oVRMnukg7T8ud6wjAQPThOXHhyfyZCgvARJ5Ss1f1eN o3dDD6KJfPu07wS4raeSW4ELtMvx3tcG43L2KJPpoa2MUV35Lu1KY7y+ladu4L7rJzuiwZnrfuD kNGTMiznIV+L0C72nmVY3EPmZOgxFwoyGcQhsBlaFoe/Mjwd2uc0/4vOcm5PzhkVVdgRpyMHWQ+ gyZbVTTNRw1MAOsi8SpAgBrPXt6AQdIO7LrFnVs6WHbHoC1ndkKXY58vC8Dw3oFIFb+VV62ykjV H+biyk4V3lEiQQ61X/+v6hHCg7IaxwK/yFtN2B0zfY4/DN/fEtcew7ZeAxFSanSdMv4f2Lz1vB8 IGjcsLeP/VOviyOSjhyx+7QF54nbfwI6lOzmFyjPh5TkcGCZR/rGa7zpfD5kPpK0CKhWXbPKFbO DlChp4ng== X-Received: by 2002:a05:6a00:3a1c:b0:83a:4846:90bf with SMTP id d2e1a72fcca58-83f05ae4d10mr7150460b3a.43.1778758860102; Thu, 14 May 2026 04:41:00 -0700 (PDT) Received: from lgs.. ([2001:250:5800:1000::f280]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-83f19c7f202sm2415974b3a.43.2026.05.14.04.40.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 May 2026 04:40:59 -0700 (PDT) From: Guangshuo Li To: "Md. Haris Iqbal" , Jack Wang , Jason Gunthorpe , Leon Romanovsky , Vaishali Thakkar , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Guangshuo Li Subject: [PATCH v3] RDMA/rtrs: Fix use-after-free in path file creation cleanup Date: Thu, 14 May 2026 19:38:34 +0800 Message-ID: <20260514113834.865530-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In the error path of rtrs_srv_create_path_files(), the sysfs root folders may already have been created and srv_path->kobj may already have been initialized. If a later step fails, the cleanup currently calls kobject_put(&srv_path->kobj) before rtrs_srv_destroy_once_sysfs_root_folders(srv_path). kobject_put() may drop the last reference to srv_path->kobj and invoke the release callback, rtrs_srv_release(), which frees srv_path. The following call to rtrs_srv_destroy_once_sysfs_root_folders(srv_path) then dereferences srv_path internally to access srv_path->srv, resulting in a use-after-free. This failure path is reached before rtrs_srv_create_path_files() returns success, so the successful-path lifetime handling is not involved. Fix this by destroying the sysfs root folders before calling kobject_put(&srv_path->kobj), so srv_path is still valid while the helper accesses it. This issue was found by a static analysis tool I am developing. Fixes: ae4c81644e91 ("RDMA/rtrs-srv: Rename rtrs_srv_sess to rtrs_srv_path") Signed-off-by: Guangshuo Li --- v3: - Clarify that the use-after-free is in the rtrs_srv_create_path_files() error path. - Explain that this path is before the function returns success, so the successful-path lifetime handling is not involved. - Drop the rtrs_srv_destroy_path_files() change. v2: - Clarify that rtrs_srv_destroy_once_sysfs_root_folders() dereferences srv_path internally. - No code changes. drivers/infiniband/ulp/rtrs/rtrs-srv-sysfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/ulp/rtrs/rtrs-srv-sysfs.c b/drivers/infinib= and/ulp/rtrs/rtrs-srv-sysfs.c index 51727c7d710c..9dd9141c86a5 100644 --- a/drivers/infiniband/ulp/rtrs/rtrs-srv-sysfs.c +++ b/drivers/infiniband/ulp/rtrs/rtrs-srv-sysfs.c @@ -295,8 +295,8 @@ int rtrs_srv_create_path_files(struct rtrs_srv_path *sr= v_path) put_kobj: kobject_del(&srv_path->kobj); destroy_root: - kobject_put(&srv_path->kobj); rtrs_srv_destroy_once_sysfs_root_folders(srv_path); + kobject_put(&srv_path->kobj); =20 return err; } --=20 2.43.0