From nobody Fri Jun 12 14:17:02 2026 Received: from mail-dl1-f68.google.com (mail-dl1-f68.google.com [74.125.82.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E507338C2B0 for ; Thu, 14 May 2026 10:07:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.68 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778753246; cv=none; b=iu1hy0WSq/fZqYJn8Dkp72CfGO3V5IoCZxrQ029vYWNudHhihovxqGd8BD0p61jzb+YZfpI3hpM5sOWGVUibgj4IO4GJiCMYO3OiYNhrB3ImndL/RPtM82B38ktR+Vnk1YfIfC/ljZPH/ViQj7gSQuOYg3yvYhLZdppDiSXxMK4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778753246; c=relaxed/simple; bh=Axmd5IPh2I0ePfoBcxce130e2QCyMyW6fCwo7DYmTgQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=D6lfWbFaKW309Sc0mGCzErkrbfBv1nJ8r90BL9Fg6AcB5PI/WejWSUCLgBLeaN/xSbcNYyYvbn0vmHYYSDfnyuqu5i8FzGrg0Lu0Qqi0JE5jrg2MrRzwXkHvSxhoeiU9eEoOqVqVbLqGmU9DaMkPtNdgEdnO/wDpCeKLLS9wE4I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AH+kc1Br; arc=none smtp.client-ip=74.125.82.68 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AH+kc1Br" Received: by mail-dl1-f68.google.com with SMTP id a92af1059eb24-12c1a170a50so10862484c88.0 for ; Thu, 14 May 2026 03:07:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778753244; x=1779358044; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lCk5lbI7sH2Lz326mmiKMLpYmZaGzeWhG5OnFEOU7xw=; b=AH+kc1Br6LiJqJSsaq044ZInB748n0z2G1afzEWvYIhXG2iCBJq9GU84wjC/wLHMKr FzeoE8tSJ9zeZsfQh497GKfR4YJcJvigH1XxxhOuw4vyskcXigkL7wgG2UfO+uViGbz7 QDiSf6WvGyVyYKnjWhmDS/fMZpq5q/oWTjdwwfm2LGY5Jfhk8xZPlyUJhQ1SF6AoBCFy wrTDE98kuQHEuF5k3KOHKmzXXn9ne1HpHc5LkDOVvxW9yHiaTNnWXevScrC5y+5MzpWS Kyo1D4GtXxS9hthRmkYSiheuheTm0YuphYJCLj0OqXOiTuJe8ZDdSk9QTsGhMYBvL2/6 CoXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778753244; x=1779358044; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=lCk5lbI7sH2Lz326mmiKMLpYmZaGzeWhG5OnFEOU7xw=; b=fzCYeMiYnZ5uziDYNwv55fHMfyT0tQvu5yem9S95ZYQkgQWuXtyT/X4/k+b7TH10V2 9Evgu1xx7aTg+0+/UDp11MDx3QkPNm8DMDBtDEr7Cmd6v24estYdHlSKyusZmsnqBReL 4A+ioQA0kiLWp6I5lUmTTJms8gzquwNS3gG2tMyMiiL2wj33fpC9A9z7Yph8aJGgDuah cQ7QOdgHOt14a8z3AIp/8qf83/wbJkeiJwRBTcp8emvXX8jo8E5HmL/U06kpV34651BC gXVvacTO5aQHC3JrfFkzy7I8TY2ywBe7tkrUHDAalV8weefOMeQAAuaxUk6OfbvAm+SF 6MNw== X-Forwarded-Encrypted: i=1; AFNElJ80q4Bf0FY7qRjU04aT7RXGzSd8K7/A6kasUALu8n9+lyYocGZnjQQGo4oZ5TBDrcjoubYzIQOaO745rPU=@vger.kernel.org X-Gm-Message-State: AOJu0YyNQVnAKZVJY5N90yIDS4ddQgM6jeiWqMCiwQQTHtOUKTWhjuh2 50nGmyqLQyrRcIuBJeI6H1tZjppi+xLtFADYHHpaKybXlNrSUUGwP/GdZZxAbsAg22g= X-Gm-Gg: Acq92OGU9c8/df/BNHm8ZoF6RnBM3xv/WOBG4kXSQZQ9X+iXpPviUpmuQECws45oZLf YseWV0BjMQDUMuvyBTxk47OmCPkfbCW0aBlwhIVYFQVuxW2CuDYX0aINxNgaV9HCNWylGkMV3tS QiXVM6rTquSbDFG49AM+y0Vy04YsICukHmaSkc6JM6HcgoBAQK0xJOiK/plvz+zU77vh6H7Ud82 C2ZaxPQV2/c1VNlLRzWGPyoXdP5bwE6BC150CZu+pPUfQ4o4txZ2cnXqW167ULndx1WQrNhLiih 57VUP9ICgYuvQ/O++19ITn79c3rSX673KDozycSdR7rgK16+9qAEtB/hjZeakcGbdC3EMtaucn0 qOYy9UY8Drjk19vcMC1biym/HdLxzoPdG57N8GQg91MOtTE/dj7q9clEUK6oscMtqjivHnWtKSX M1GOBvwiTlsYxC3JvM5K8GxNZYSlW2Nbvs7PvgenxPEosrAKItiSPBWkA= X-Received: by 2002:a05:7022:2399:b0:134:83c2:26b3 with SMTP id a92af1059eb24-1349a14eed9mr4253148c88.0.1778753243876; Thu, 14 May 2026 03:07:23 -0700 (PDT) Received: from localhost.localdomain ([76.32.119.210]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-134cbcb93f3sm3757921c88.3.2026.05.14.03.07.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 May 2026 03:07:23 -0700 (PDT) From: Hungyu Lin To: Greg Kroah-Hartman Cc: Dan Carpenter , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Hungyu Lin Subject: [PATCH v2 1/5] staging: rtl8723bs: simplify rtw_xmit_classifier control flow Date: Thu, 14 May 2026 10:07:04 +0000 Message-Id: <20260514100708.25031-2-dennylin0707@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260514100708.25031-1-dennylin0707@gmail.com> References: <20260514100708.25031-1-dennylin0707@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Simplify rtw_xmit_classifier() by removing the exit label and using direct returns for error handling. No functional change. Signed-off-by: Hungyu Lin --- drivers/staging/rtl8723bs/core/rtw_xmit.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rt= l8723bs/core/rtw_xmit.c index 458e471535ad..72e5dddfee5d 100644 --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c @@ -1874,16 +1874,13 @@ s32 rtw_xmit_classifier(struct adapter *padapter, s= truct xmit_frame *pxmitframe) struct tx_servq *ptxservq; struct pkt_attrib *pattrib =3D &pxmitframe->attrib; struct hw_xmit *phwxmits =3D padapter->xmitpriv.hwxmits; - signed int res =3D _SUCCESS; =20 psta =3D rtw_get_stainfo(&padapter->stapriv, pattrib->ra); if (pattrib->psta !=3D psta) return _FAIL; =20 - if (!psta) { - res =3D _FAIL; - goto exit; - } + if (!psta) + return _FAIL; =20 if (!(psta->state & _FW_LINKED)) return _FAIL; @@ -1897,9 +1894,7 @@ s32 rtw_xmit_classifier(struct adapter *padapter, str= uct xmit_frame *pxmitframe) ptxservq->qcnt++; phwxmits[ac_index].accnt++; =20 -exit: - - return res; + return _SUCCESS; } =20 void rtw_free_hwxmits(struct adapter *padapter) --=20 2.34.1 From nobody Fri Jun 12 14:17:02 2026 Received: from mail-dl1-f65.google.com (mail-dl1-f65.google.com [74.125.82.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B71A838D686 for ; Thu, 14 May 2026 10:07:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.65 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778753251; cv=none; b=gHebG/a8RF2T+Up0SkgMlrJbD4PjOFmMtHE1JZhas3axVqoY9Jjuml+NNuZ9h2f7VLN4pE8sVH43qpz3whv1YBIn/wRcgK+Pu2hiz4gXEKp3hta6E6YPBUzHosRbkLdspIySOTNF7C4K4cZ60JajKqqjtXCUOl4stgqvHjOBMr0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778753251; c=relaxed/simple; bh=nrczOfGVC80s+tKVDd3e9ohV6aT19hUDJHpFQ9xSAjI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Mj0R51578ya+kZjEqn1xwWC70wDCSm24ALy+gfqncSANO+aMZNT953wlbR7w8XE/wjQe6DzQkPdsjEmn3WK6agqNaCsEzYuZ3NtblpVfg0z/mqFaTnOrn3Oddyy/cX3wX7xR0n5gd57J0qN495UdXiHvjWsN+9xDD+idLUnUj3s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Ihtr31Cc; arc=none smtp.client-ip=74.125.82.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ihtr31Cc" Received: by mail-dl1-f65.google.com with SMTP id a92af1059eb24-13317450f83so533123c88.0 for ; Thu, 14 May 2026 03:07:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778753245; x=1779358045; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=YEDmPs3IEzkMNu9wS4D7y4et1HievtNnY5UColUpsPw=; b=Ihtr31CcRLFTIccWza68sTVblwevcAEHNeJDzCasbCnfeXy8vbC0m98LV1xNWO0HDZ 7aUR0FmteI5m/a3fyN0LYxO/kOyLJ8XsIoJEJTam/ZU5TDCRpsHiubPVHcBJlxJZzddY Jyowp9MHqKpDHChUuVX6vB9YnJ8H+eWTmRZlxnxgSNLarhvWK7nD1J/+da4euVkYwvPZ aGmrUlbFGFquSGhPFRFY9d9ruHfIowlOi1uL3sSDJrZUFHU54/MeI0oWJxCNI5exW3Ff 4XXdOI7m52I3Ixs0S0K3eQmhCGHm61TkIGJJKjy3fqQWZaAnIC5dC7yXBCpYpczOmJzI FgNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778753245; x=1779358045; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=YEDmPs3IEzkMNu9wS4D7y4et1HievtNnY5UColUpsPw=; b=rjTydJuzk1RkR26deBfOS++eL0Qcy9YDuG4n+k2FcdIas+U3fhxSRDMZYGwkaWGIiJ iF7o5zBfxcGGhfHeDZl9qNm+FyFm/eJFCdJC6Z1b+kzmSPMRSia1Az62I4ttQ7jCnhJp Ts8PCyGLXLQGjCDNy1MEXuq+ZighnIj9YzDKlO/d5WL55al9nNA5Wo3uvBy0YXf6F32e Mm0Jsp87goiappBjvIZnFxF/XqVB3z3vFJMiQLAMAsr0lWFDyS1MneASxY3ILJX1pmHF NscnCrXlhYJ5vssisL4yY353oc6UVI2GZuDgZLKUX8cTrg/eVAOo4vn7Iw2w4gdmf1R3 c6+w== X-Forwarded-Encrypted: i=1; AFNElJ/XP0MNaLxdo++mNKd5Vz791fzYxs3NBCvKBdt+hHsM1z9n9kAFQIV1OoS5CY5gWdG1882X/70mMfhOrdw=@vger.kernel.org X-Gm-Message-State: AOJu0YxSseKYsGI7ARBp8LRkqWmZwZmNuyBZytYAgPlSZ41ZgZhfY5jG OH0V6bEx3HLdrGHSo8ijEqkwos7cq/byTqJqNG38M6M2igpeL34yMTts X-Gm-Gg: Acq92OEFUqIzofPY9BTkfjyHoSluXLG6XzJgvcQe3hp287p3iiZO8r1AZaHLQx3tssx IbdAUhgNq+XCsED7O2/r1CREvGum0qVvUxizlSxLvcuDfx+XhyOxvYdKBe8z8brUhdxqgUfnXAH OT7jG1YDr1W3wHUWpWh+dH0HxLTHgURvEYNFIgxKrvRDEUZsspkNNhwUG0HQshyBtfYNDQfOoBn yZPvu+Su33sEq6bRFWuD8XmXh7jXnuGgeYVQfIZD57bn2qJZRVjkPus+3rPUJUe9j/fyXOuPgcj kKaDIbslHYOtXKbj4O8QUqgZJGJUEo514Kr5nKbJ5G0t/JN3AQZconiKJEep53T9i3RZ/DxZ04t FDTVo3pAub9scECJU63jTAaHcw/Cg0zt0qjYc44t8lT3+YZxx+iYng3YUQNC3OYCE+xMxLIVInZ MOs8DKODudmZHR+Yl0Fle1Hebdx2/kJi35FDE+SStPUNPxtKBraxu/uBCIJXBlXJyYTA== X-Received: by 2002:a05:7022:10b:b0:12b:f881:d8fb with SMTP id a92af1059eb24-1342ee3a2aemr4711893c88.3.1778753244970; Thu, 14 May 2026 03:07:24 -0700 (PDT) Received: from localhost.localdomain ([76.32.119.210]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-134cbcb93f3sm3757921c88.3.2026.05.14.03.07.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 May 2026 03:07:24 -0700 (PDT) From: Hungyu Lin To: Greg Kroah-Hartman Cc: Dan Carpenter , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Hungyu Lin Subject: [PATCH v2 2/5] staging: rtl8723bs: make rtw_xmit_classifier static Date: Thu, 14 May 2026 10:07:05 +0000 Message-Id: <20260514100708.25031-3-dennylin0707@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260514100708.25031-1-dennylin0707@gmail.com> References: <20260514100708.25031-1-dennylin0707@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The rtw_xmit_classifier() function is only used within rtw_xmit.c. Move it above its caller and make it static to limit its scope. Signed-off-by: Hungyu Lin --- drivers/staging/rtl8723bs/core/rtw_xmit.c | 68 ++++++++++---------- drivers/staging/rtl8723bs/include/rtw_xmit.h | 1 - 2 files changed, 34 insertions(+), 35 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rt= l8723bs/core/rtw_xmit.c index 72e5dddfee5d..b3953bdedb04 100644 --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c @@ -1821,6 +1821,40 @@ void rtw_free_xmitframe_queue(struct xmit_priv *pxmi= tpriv, struct __queue *pfram spin_unlock_bh(&pframequeue->lock); } =20 +/* + * Will enqueue pxmitframe to the proper queue, + * and indicate it to xx_pending list..... + */ +static s32 rtw_xmit_classifier(struct adapter *padapter, struct xmit_frame= *pxmitframe) +{ + u8 ac_index; + struct sta_info *psta; + struct tx_servq *ptxservq; + struct pkt_attrib *pattrib =3D &pxmitframe->attrib; + struct hw_xmit *phwxmits =3D padapter->xmitpriv.hwxmits; + + psta =3D rtw_get_stainfo(&padapter->stapriv, pattrib->ra); + if (pattrib->psta !=3D psta) + return _FAIL; + + if (!psta) + return _FAIL; + + if (!(psta->state & _FW_LINKED)) + return _FAIL; + + ptxservq =3D rtw_get_sta_pending(padapter, psta, pattrib->priority, (u8 *= )(&ac_index)); + + if (list_empty(&ptxservq->tx_pending)) + list_add_tail(&ptxservq->tx_pending, get_list_head(phwxmits[ac_index].st= a_queue)); + + list_add_tail(&pxmitframe->list, get_list_head(&ptxservq->sta_pending)); + ptxservq->qcnt++; + phwxmits[ac_index].accnt++; + + return _SUCCESS; +} + s32 rtw_xmitframe_enqueue(struct adapter *padapter, struct xmit_frame *pxm= itframe) { if (rtw_xmit_classifier(padapter, pxmitframe) =3D=3D _FAIL) @@ -1863,40 +1897,6 @@ struct tx_servq *rtw_get_sta_pending(struct adapter = *padapter, struct sta_info * return ptxservq; } =20 -/* - * Will enqueue pxmitframe to the proper queue, - * and indicate it to xx_pending list..... - */ -s32 rtw_xmit_classifier(struct adapter *padapter, struct xmit_frame *pxmit= frame) -{ - u8 ac_index; - struct sta_info *psta; - struct tx_servq *ptxservq; - struct pkt_attrib *pattrib =3D &pxmitframe->attrib; - struct hw_xmit *phwxmits =3D padapter->xmitpriv.hwxmits; - - psta =3D rtw_get_stainfo(&padapter->stapriv, pattrib->ra); - if (pattrib->psta !=3D psta) - return _FAIL; - - if (!psta) - return _FAIL; - - if (!(psta->state & _FW_LINKED)) - return _FAIL; - - ptxservq =3D rtw_get_sta_pending(padapter, psta, pattrib->priority, (u8 *= )(&ac_index)); - - if (list_empty(&ptxservq->tx_pending)) - list_add_tail(&ptxservq->tx_pending, get_list_head(phwxmits[ac_index].st= a_queue)); - - list_add_tail(&pxmitframe->list, get_list_head(&ptxservq->sta_pending)); - ptxservq->qcnt++; - phwxmits[ac_index].accnt++; - - return _SUCCESS; -} - void rtw_free_hwxmits(struct adapter *padapter) { struct xmit_priv *pxmitpriv =3D &padapter->xmitpriv; diff --git a/drivers/staging/rtl8723bs/include/rtw_xmit.h b/drivers/staging= /rtl8723bs/include/rtw_xmit.h index b0189a703d28..a2ff62182b97 100644 --- a/drivers/staging/rtl8723bs/include/rtw_xmit.h +++ b/drivers/staging/rtl8723bs/include/rtw_xmit.h @@ -440,7 +440,6 @@ extern void rtw_free_xmitframe_queue(struct xmit_priv *= pxmitpriv, struct __queue struct tx_servq *rtw_get_sta_pending(struct adapter *padapter, struct sta_= info *psta, signed int up, u8 *ac); extern s32 rtw_xmitframe_enqueue(struct adapter *padapter, struct xmit_fra= me *pxmitframe); =20 -extern s32 rtw_xmit_classifier(struct adapter *padapter, struct xmit_frame= *pxmitframe); extern u32 rtw_calculate_wlan_pkt_size_by_attribue(struct pkt_attrib *patt= rib); #define rtw_wlan_pkt_size(f) rtw_calculate_wlan_pkt_size_by_attribue(&f->a= ttrib) extern s32 rtw_xmitframe_coalesce(struct adapter *padapter, struct sk_buff= *pkt, struct xmit_frame *pxmitframe); --=20 2.34.1 From nobody Fri Jun 12 14:17:02 2026 Received: from mail-dl1-f65.google.com (mail-dl1-f65.google.com [74.125.82.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 79BE738E8A6 for ; Thu, 14 May 2026 10:07:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.65 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778753248; cv=none; b=HrGTP21oYh5eufcpz5A3usbW1jQcwPwf5rcxGS/I/akSx6zvQfSl71PXaEjI5r411S0RSD2H12oOVigoRN10Xdm/wBudRfNg1jSh6tdc/z0oSFXa4IGSIronGR651bGIPgYW4V3sdWc6Q2D33U7pj2hEjmtHt2lsjc8vS4JcAE0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778753248; c=relaxed/simple; bh=OwRd3NUTkaAoh8Y+r/wsJsf4AWa/FLJ5AAP/ykOV6ps=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=JDDVIjQiPjRqeOxTTNl3SmYUTusKRFCcXQkyNu4JC3picWZf82E+ID/S/klY/uWoIidDr/d5Hvpm8krSnKjcxtQmr1RchOtsK7wYBOJWariQcPlxP+wgsHHgwVEixCTRvAeAk1ML6Ohc3ELHLUZTznV7b2uYh98PQqwYlAHSuJQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LJ43nzKz; arc=none smtp.client-ip=74.125.82.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LJ43nzKz" Received: by mail-dl1-f65.google.com with SMTP id a92af1059eb24-1309f4ee97fso9799876c88.1 for ; Thu, 14 May 2026 03:07:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778753246; x=1779358046; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=KhH4QN2V6pideai/krprs3/7h/AE1I4RG4vdBuW1XJg=; b=LJ43nzKzpb4y4OPTKfKPaDTDBADgEAhjt7CcGW1QGhyNH8EJQSUeTeiCESi7owVDnc A1Ql1G0iLRafVc/KkEQnsmzg2vWAb1xa5mf8paXPoRNrbWa/j3OnmyAlEdL3K1ePidkw VU3KnExjhoCj+hQaqgWQekeRmcZoEmSYA9VlIZWOlh6y9keIhsSsmdDvKXH/Ho5Fixjd sOkFquyRTE84N+SAh+wUb0SWQ482CSPEzWwx43MzOzhP/4xAXWEXI5DpMECZ00h3q9qm eTpx3t6RfiGtvAE+V2rSWAf/5jsRrX4mLXMKiLCHL53LzllfO0CkNSUdRi2YjNdPtMvR 6zSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778753246; x=1779358046; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=KhH4QN2V6pideai/krprs3/7h/AE1I4RG4vdBuW1XJg=; b=N/sQvGAnqEPdFg+N+uuxM+2VLI1W+8k+LsKELB28nbPBiQ6MW4O7jKXsBMiuVrm3zR iLXrb1hNLSfWlhoV2eaLfOCU0jnBBrTVBdEG7OGXSRuLmApnirkQTUx86Scoi1+j+6zI Zwkf6hWQrfQIyxTzKej0VAKfs9iH6amZU1hp9LMViY5okFax9jT5MaDBgEnfzBE8nAH2 9tvxRD2knwwyd3yk5aP3pqdxrYfRTpNzfgm6hhnt11HK6K427ar4QYRDL0xr3yHRF5Wj XAGb4sKhbvkFaGHlCMMIZCFIHqJ+we6tmUKfDi9K3QAbCtq1qFixXmlq818GWegIVU1g sPtA== X-Forwarded-Encrypted: i=1; AFNElJ+7j7CNrescIYRnw22bdXpJq1hBbLYwnWY7Dw4DvmWdCz7jLw89pM2uSH/5/LXJNT2eS9vPgcOzH0z71CE=@vger.kernel.org X-Gm-Message-State: AOJu0Yw65lmzvLuBxYIxQfWrkE4M4p72h00XTqF+v0uH4on7anY1rjfg 8g7VykqXQQyD8ZpYb2wZlPk4deWiiu0B+OuAzwWNa2gEmXNqcDXV3kxt X-Gm-Gg: Acq92OHgOGaCfqgld9m1Pr9EIhJtuHM/FNRFviVU9WU7h0Jy2A8XW1WlKFFEUhCXnVd 7A/UvFym6KEeXpg35qTbPFtZ30r+5IhyHVvPxDsSNKv27EsomJchbBld/KP58u6sgMQClWhhc/X e1m3OtC1SAc8qievIjfgsdFhMjdHaZxtETbj7Wb+b0Ag5s3NOX5MuR/VErFcoCuHuiLXIVdIX5l vAfGol0ZkZTwhKyMczFyG83SryEY4BFBRe9RseZwwN+WOrWkUd47d7wc3Z8pTaQ9Grz/FIVQfY1 2+o6kRcwzk9WerXKe8llxV/4tcFs5J71H8I90z4IKdXOfTp/gCh2v4Ibbb28SfEjkliRHooJ+V6 NJQB4sFCOlJxcGayQBq+zPAR0oOUn+M80/FNhe5qKMDVs2kqymmDg9+AOnQ6duLuqy/DsdVkTuw CdU46Nu7Q8x6WsdhOKxH0XpmoVpHMYZu8AeUGEX0KCSgnE+0JbsL57D10= X-Received: by 2002:a05:7022:459a:b0:132:1e01:2d7d with SMTP id a92af1059eb24-1349a6f91cfmr3919417c88.5.1778753246265; Thu, 14 May 2026 03:07:26 -0700 (PDT) Received: from localhost.localdomain ([76.32.119.210]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-134cbcb93f3sm3757921c88.3.2026.05.14.03.07.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 May 2026 03:07:25 -0700 (PDT) From: Hungyu Lin To: Greg Kroah-Hartman Cc: Dan Carpenter , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Hungyu Lin Subject: [PATCH v2 3/5] staging: rtl8723bs: convert rtw_xmit_classifier to return errno Date: Thu, 14 May 2026 10:07:06 +0000 Message-Id: <20260514100708.25031-4-dennylin0707@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260514100708.25031-1-dennylin0707@gmail.com> References: <20260514100708.25031-1-dennylin0707@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Convert rtw_xmit_classifier() to return 0 on success and negative error codes on failure. Update the caller to check for non-zero return values and preserve the existing _FAIL/_SUCCESS semantics. Signed-off-by: Hungyu Lin --- drivers/staging/rtl8723bs/core/rtw_xmit.c | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rt= l8723bs/core/rtw_xmit.c index b3953bdedb04..80f3dfaf793d 100644 --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c @@ -1825,7 +1825,7 @@ void rtw_free_xmitframe_queue(struct xmit_priv *pxmit= priv, struct __queue *pfram * Will enqueue pxmitframe to the proper queue, * and indicate it to xx_pending list..... */ -static s32 rtw_xmit_classifier(struct adapter *padapter, struct xmit_frame= *pxmitframe) +static int rtw_xmit_classifier(struct adapter *padapter, struct xmit_frame= *pxmitframe) { u8 ac_index; struct sta_info *psta; @@ -1835,13 +1835,13 @@ static s32 rtw_xmit_classifier(struct adapter *pada= pter, struct xmit_frame *pxmi =20 psta =3D rtw_get_stainfo(&padapter->stapriv, pattrib->ra); if (pattrib->psta !=3D psta) - return _FAIL; + return -ENODEV; =20 if (!psta) - return _FAIL; + return -EINVAL; =20 if (!(psta->state & _FW_LINKED)) - return _FAIL; + return -ENETDOWN; =20 ptxservq =3D rtw_get_sta_pending(padapter, psta, pattrib->priority, (u8 *= )(&ac_index)); =20 @@ -1852,12 +1852,15 @@ static s32 rtw_xmit_classifier(struct adapter *pada= pter, struct xmit_frame *pxmi ptxservq->qcnt++; phwxmits[ac_index].accnt++; =20 - return _SUCCESS; + return 0; } =20 s32 rtw_xmitframe_enqueue(struct adapter *padapter, struct xmit_frame *pxm= itframe) { - if (rtw_xmit_classifier(padapter, pxmitframe) =3D=3D _FAIL) + int res; + + res =3D rtw_xmit_classifier(padapter, pxmitframe); + if (res) return _FAIL; =20 return _SUCCESS; --=20 2.34.1 From nobody Fri Jun 12 14:17:02 2026 Received: from mail-dl1-f65.google.com (mail-dl1-f65.google.com [74.125.82.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC79038F656 for ; Thu, 14 May 2026 10:07:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.65 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778753250; cv=none; b=d/zVmKrzn5kWtRKv1adarsy97g2dJSDjhioRZHB68kf0148RHg0yP+oDr2RVeAy8D3fNi0sNsVtBlBpo4hLXowNAtuJvYSjeSC+rrgFyX9VvswD2J3Y8C9C3zfKrMxEzaHf1cRg2KzZcJcsxyd3dJZcVXMOQ5icZmLvrYQ9wRaI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778753250; c=relaxed/simple; bh=Lx8tjc2hi/BxnlTzuA9QV3HwAbmze/Wwgnxtiq84N/A=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=sWmpa3JDtHS7rLV12fzurxxrQQatLmdh69X46W1FfSb4ZZ2h7m6rCMjuwmKpwndduC9HNgpYf2vLDqMfF84pIiPPZS8SXf/9RL0Ru5NnDOW02VfLFvmZ4uo5YxoTTLjeqq8XTlDt5wkVWSifqW0zgQvr5RIwKkgq5DDRS91hdgY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MdEPuxdE; arc=none smtp.client-ip=74.125.82.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MdEPuxdE" Received: by mail-dl1-f65.google.com with SMTP id a92af1059eb24-12db2e415a7so5594503c88.1 for ; Thu, 14 May 2026 03:07:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778753248; x=1779358048; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4JlJ+zwzmXqUTxE6mP3nEpdnrhD+xyjOREjmHfGZCMw=; b=MdEPuxdE9uTBw+l5I1KzXBUh05ITOm5Yx/EkyBQRfQd54Q2z63/N1xT/WWVXY01r3h N6no1KTF3Xncs/0qLwVlkdsHVKZO2C4ziAE83H18Yp+omM8Nm/vBY1JyMpqEbvkeg6/t kmxpXTH3g+7YBX9o9RFBuYwxwmDpo6iqsD4zlMHTNWYOwp7RiSDDXgGiI0iEn8OCNM5y gFc86yiKFxyWPqq1npwqZ6TJ/CoeMCn3nE1fepOt5p47dvijpUfOO0xcmvXYKgsI0yCq T2PzsTRX7h6wlbbzUCT21wxjrxLvejLQbf34wiblEpW0Mfhlb0w/N1HXy0vKuH6PtTkv z1JA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778753248; x=1779358048; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=4JlJ+zwzmXqUTxE6mP3nEpdnrhD+xyjOREjmHfGZCMw=; b=NEV3qxXMVlaRAoNLtNH6jUvb6pa0+5YB05I2cSH4JIh9oW9XG7B3xxX/fDWw7pDA+y EjKsmtf/q7fXg8sRPIKbCUQqovXiXjWB5Vwr03KW9nfmY1nsrNuSFl4rP4i1etvwQqoD Ui/buQmESaIbAtK6/tOHIpynFwoZQOMrwhs00VAlySKBhuisEq/tVmiShYkCAXKFKiEc 234RFMqedGkul4hxSuj3JgnJpPRdAdeFGpSmMaTk5KD+S4gIlLVdaPXkAZn0wkui0k/C dVwoHX1l83dOWa/TMDC3nNRg6lcSaWkpw9YgIN2uwfEZYgPhCluSroy0qQyBJtvd7PVA pGcw== X-Forwarded-Encrypted: i=1; AFNElJ8GS0Rkz9S/VASXuGLaBpIB/jNS5iuc/MJav+HL0zFnpJeiUs5RiV2LsYsmlDxd6hndJoRaLrpgE0iUcQU=@vger.kernel.org X-Gm-Message-State: AOJu0YxgRod8Ww+zR6Zdi3aqeHwmMiPprexJK/uWYb3wlByxN5TMmlqv dLEQhQZ0jGjOkRaBPEqyP5LC4R998pdhvwIUyLm+pRy3oR0LlgBegf7a X-Gm-Gg: Acq92OHnfIQTUc+L7zqAdnirzH+33cQ5kVKf+kA2B2ou3bRDH186e2G/Ow9lcC89Bzu Eubwe0Aw34fwT/24iSKalsIFlwB4T6tJr5XpbKXU0cqEsk2H265iIkWcqGhbgcng0bx7oDipKEK vDS1LMkETbAZJsHDDLMnBuDs5JreBuYGtOi66NsV5ivLIJ2VPjE2JUU07PT+5K0A1F0S1QKVIZB QkAS8eVOajHI30geFGjHW18a72KnHWIxluziVyS+Um89ETCg1cGpIFnrDoCT099Cd+TKb7Jj6F/ EGHJbp+erZBoMKK2EuXBT0LHcUJuq3x6Zhd8VwAUkYJFEn67yDnTZWbfWDv7Quwj2UZ7lPkniCB 9OYnXBlzkHi6WKZ7TYwhQWO1xCyyMiPho7EprKhEcpJw+t2Jx2Y3v0+khDWRx0bxJNsOlTaW4N6 v5vmxLPismbvRb5xh+hA26oQ+CVbmLbMjIbG5uyPfsw0yhUUyzBxivOYc= X-Received: by 2002:a05:7022:e984:b0:128:d450:bc76 with SMTP id a92af1059eb24-1349ac708damr3929784c88.26.1778753247541; Thu, 14 May 2026 03:07:27 -0700 (PDT) Received: from localhost.localdomain ([76.32.119.210]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-134cbcb93f3sm3757921c88.3.2026.05.14.03.07.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 May 2026 03:07:26 -0700 (PDT) From: Hungyu Lin To: Greg Kroah-Hartman Cc: Dan Carpenter , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Hungyu Lin Subject: [PATCH v2 4/5] staging: rtl8723bs: propagate errno through xmit enqueue path Date: Thu, 14 May 2026 10:07:07 +0000 Message-Id: <20260514100708.25031-5-dennylin0707@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260514100708.25031-1-dennylin0707@gmail.com> References: <20260514100708.25031-1-dennylin0707@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Propagate errno values from rtw_xmit_classifier() through rtw_xmitframe_enqueue(), and update the local enqueue caller to check for non-zero return values. Signed-off-by: Hungyu Lin --- drivers/staging/rtl8723bs/core/rtw_xmit.c | 6 +++--- drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c | 10 +++++----- drivers/staging/rtl8723bs/include/rtw_xmit.h | 2 +- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rt= l8723bs/core/rtw_xmit.c index 80f3dfaf793d..054cb4c9d1de 100644 --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c @@ -1855,15 +1855,15 @@ static int rtw_xmit_classifier(struct adapter *pada= pter, struct xmit_frame *pxmi return 0; } =20 -s32 rtw_xmitframe_enqueue(struct adapter *padapter, struct xmit_frame *pxm= itframe) +int rtw_xmitframe_enqueue(struct adapter *padapter, struct xmit_frame *pxm= itframe) { int res; =20 res =3D rtw_xmit_classifier(padapter, pxmitframe); if (res) - return _FAIL; + return res; =20 - return _SUCCESS; + return 0; } =20 struct tx_servq *rtw_get_sta_pending(struct adapter *padapter, struct sta_= info *psta, signed int up, u8 *ac) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c b/drivers/stagi= ng/rtl8723bs/hal/rtl8723bs_xmit.c index a7f23335cdd9..ff82b6efefc7 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c @@ -464,8 +464,8 @@ s32 rtl8723bs_mgnt_xmit( *Handle xmitframe(packet) come from rtw_xmit() * * Return: - *true dump packet directly ok - *false enqueue, temporary can't transmit packets to hardware + * true dump packet directly ok + * false enqueue, temporary can't transmit packets to hardware */ s32 rtl8723bs_hal_xmit( struct adapter *padapter, struct xmit_frame *pxmitframe @@ -491,7 +491,7 @@ s32 rtl8723bs_hal_xmit( spin_lock_bh(&pxmitpriv->lock); err =3D rtw_xmitframe_enqueue(padapter, pxmitframe); spin_unlock_bh(&pxmitpriv->lock); - if (err !=3D _SUCCESS) { + if (err) { rtw_free_xmitframe(pxmitpriv, pxmitframe); =20 pxmitpriv->tx_drop++; @@ -511,7 +511,7 @@ s32 rtl8723bs_hal_xmitframe_enqueue( s32 err; =20 err =3D rtw_xmitframe_enqueue(padapter, pxmitframe); - if (err !=3D _SUCCESS) { + if (err) { rtw_free_xmitframe(pxmitpriv, pxmitframe); =20 pxmitpriv->tx_drop++; @@ -519,7 +519,7 @@ s32 rtl8723bs_hal_xmitframe_enqueue( complete(&pxmitpriv->SdioXmitStart); } =20 - return err; + return err ? _FAIL : _SUCCESS; =20 } =20 diff --git a/drivers/staging/rtl8723bs/include/rtw_xmit.h b/drivers/staging= /rtl8723bs/include/rtw_xmit.h index a2ff62182b97..b13f16716e98 100644 --- a/drivers/staging/rtl8723bs/include/rtw_xmit.h +++ b/drivers/staging/rtl8723bs/include/rtw_xmit.h @@ -438,7 +438,7 @@ struct xmit_frame *rtw_alloc_xmitframe_once(struct xmit= _priv *pxmitpriv); extern s32 rtw_free_xmitframe(struct xmit_priv *pxmitpriv, struct xmit_fra= me *pxmitframe); extern void rtw_free_xmitframe_queue(struct xmit_priv *pxmitpriv, struct _= _queue *pframequeue); struct tx_servq *rtw_get_sta_pending(struct adapter *padapter, struct sta_= info *psta, signed int up, u8 *ac); -extern s32 rtw_xmitframe_enqueue(struct adapter *padapter, struct xmit_fra= me *pxmitframe); +int rtw_xmitframe_enqueue(struct adapter *padapter, struct xmit_frame *pxm= itframe); =20 extern u32 rtw_calculate_wlan_pkt_size_by_attribue(struct pkt_attrib *patt= rib); #define rtw_wlan_pkt_size(f) rtw_calculate_wlan_pkt_size_by_attribue(&f->a= ttrib) --=20 2.34.1 From nobody Fri Jun 12 14:17:02 2026 Received: from mail-dl1-f67.google.com (mail-dl1-f67.google.com [74.125.82.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC3E1390226 for ; Thu, 14 May 2026 10:07:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.67 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778753251; cv=none; b=MUWPRZdPH8zbdI/WYLgT3INeGLcegtEq282ETFYUht7N53RIgTZb9FzPuzzkdn4hv7UvpfHWoR49trC7VXayySHuyzuR308Z/GYTXihljSPt8pEfXxUG9FBN5AmP6jLQrqPt6A8uu/KtY63AWQHjllSOGX9EjONpnPXlyYiZ1NI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778753251; c=relaxed/simple; bh=RPY2YGdcwZmN2y65thUH+fDewRbjIejIAuxOMinGZBA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=lOv1mVGzZA2BG+uT//WteYYwulKJwMOh3ZTgIS3zNqkNC4kJqWf/mtB2v3KIigU4jkITAPBfBcMAwJrHfyEWyFwV3dK/oRCkOji4JIzMPVCPjWIu+VigwVYIybY6a5qUCy8xMPmBNhT4H4KV97bP93uMkNIENJG9K/p0PNhz8zg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=J3hkphIz; arc=none smtp.client-ip=74.125.82.67 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="J3hkphIz" Received: by mail-dl1-f67.google.com with SMTP id a92af1059eb24-1329507c387so3723054c88.1 for ; Thu, 14 May 2026 03:07:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778753249; x=1779358049; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=U/WaJCxuPkp9m47CrrlWhqVf7lEthVaN44VofO+IDbE=; b=J3hkphIztmZ3/hwtT6jI2u3EuYuwhpngld94KMAjUh8w90AYOQzRQNooFU0P6twkGI sbmdheQ8+Vq3WU4TnuLJlPFOSTRfEbx/ZodpjAipOl1A6nED/lrlyfB5HUfNvhYZprZW ReTeBKxsP/kK1aG1Xght+vi+ghm6J81b4C/9mskmObkYmRh1NoYjLFiyuxtlg401L54j fEX5N6y/+LYrNGMC/8CY0A7zqeV9IRgajiDGy1j0a/uj721aecL1xgpdExkcKlfg+N4C 5bd1TifcUGkFeLWRemagFYejkJO+wcJRfMBeSpPUwRx/8OkNdC5Hzeps1lksK5krz4Sq fhSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778753249; x=1779358049; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=U/WaJCxuPkp9m47CrrlWhqVf7lEthVaN44VofO+IDbE=; b=YCdW6boRSRL3C0YvwQk7diNlm7cYd4dL3bXzuEpiP17c5D3/jIPa1P/L5oPDR1BY/3 k9Aq4FzbpSkIKrOXATr12OHZA6o6UdSCkfhRmjuan2Wgfwlqh2jrTnnUuc5q5oYIpvou ky3eJVic2AsuQdDMy5WXy/9qmpxlUY3hMFvQEytxum5GTwE5RN64LPuC11s5vZWEl53L mIOeIJaL2kxIUkYmord8U1hjs24p9kF1JdnHouGeqJnmoURu6PO0haD7SK4Sh7DJny6o wTdLqrtspIfFcAxL4795HZNtKd9PwTKvx8Rmk/MeGAb4I4j+G7XHGit1hMn7PZ2gwyU6 pO3Q== X-Forwarded-Encrypted: i=1; AFNElJ9hcbavw0W2sC5+/Q/yR64qiY+uCuVNB2dnXEqnx6/0BpVzAvyi0+z0p2oqNNZLnNsIWquskIGrbgMtSbY=@vger.kernel.org X-Gm-Message-State: AOJu0YwYQToXbiSpIPvt/jsttKVWpyfizyr39mW3WUd0Vk9BzCPNcYuq bGKlx70CigKUyLWgx5tnBpJL0VsHardLLYqxBa4/2DEdLsp4B4TkyBBx X-Gm-Gg: Acq92OHrKpHu9rInkTZVpNSBZd0Y9IUNnu0DX6ST2+oAs04cvjE85zBdyS5JLk/fWMO w/y3KQt1g8ZdSjGmsXhy3/r5HkEr/fPSpGlGh2Mu/KnVSUplcsr+h2D5PHbeH0HFuuBM/pdd0js 6MsmxoT/5u1F6YDlrAA6vg+NtZ0HqurBlL2ZlUJ6FN9yoQwFnYx3D9+WVxvIYkgGdR6N3i9SU+6 pryyf8+fG8WJbC71hIAQOtlvio0JIIWAR6l5RC10unewTgtxx33OYF3kfKtB9Z+8EM6gCS8erWI T8bFwB+9rUMGmN5KOEYI9Q8yHcFG3tIoImpAfYfV/5IB1FmxbVuFfhXyLNFdDTuXyNmWljpIWa8 BxotuztBW5Pp9jml2Hf+xqhf4qaMe9YiQ3ji4sn5Of6eOXraxtX28P8KWC/rPTPA/r/qGcP2W6h vKfzCO3AAVB61c7LS+xuvUroxsKX67roZU5rotdmBksgjlnfX/jIX7WQY= X-Received: by 2002:a05:7022:660b:b0:12d:de3f:d840 with SMTP id a92af1059eb24-1349ac7cab6mr4335778c88.35.1778753248760; Thu, 14 May 2026 03:07:28 -0700 (PDT) Received: from localhost.localdomain ([76.32.119.210]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-134cbcb93f3sm3757921c88.3.2026.05.14.03.07.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 May 2026 03:07:28 -0700 (PDT) From: Hungyu Lin To: Greg Kroah-Hartman Cc: Dan Carpenter , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Hungyu Lin Subject: [PATCH v2 5/5] staging: rtl8723bs: propagate errno through hal xmit path Date: Thu, 14 May 2026 10:07:08 +0000 Message-Id: <20260514100708.25031-6-dennylin0707@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260514100708.25031-1-dennylin0707@gmail.com> References: <20260514100708.25031-1-dennylin0707@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Propagate errno values from rtl8723bs_hal_xmitframe_enqueue() through rtw_hal_xmitframe_enqueue() by returning the error code directly. Update rtw_hal_xmit() to explicitly map the boolean return value of rtl8723bs_hal_xmit() to _SUCCESS/_FAIL, clarifying the return semantics at the HAL boundary. None of the callers of rtw_hal_xmitframe_enqueue() check the return value, so they do not need to be updated. This change does not affect runtime behavior. Signed-off-by: Hungyu Lin --- v2: - Clarify commit message per Dan Carpenter's review drivers/staging/rtl8723bs/hal/hal_intf.c | 7 +++++-- drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c | 2 +- drivers/staging/rtl8723bs/include/hal_intf.h | 2 +- 3 files changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/hal_intf.c b/drivers/staging/rtl= 8723bs/hal/hal_intf.c index 03f23b75d532..77fa6e67530a 100644 --- a/drivers/staging/rtl8723bs/hal/hal_intf.c +++ b/drivers/staging/rtl8723bs/hal/hal_intf.c @@ -99,14 +99,17 @@ u8 rtw_hal_check_ips_status(struct adapter *padapter) return CheckIPSStatus(padapter); } =20 -s32 rtw_hal_xmitframe_enqueue(struct adapter *padapter, struct xmit_frame = *pxmitframe) +int rtw_hal_xmitframe_enqueue(struct adapter *padapter, struct xmit_frame = *pxmitframe) { return rtl8723bs_hal_xmitframe_enqueue(padapter, pxmitframe); } =20 s32 rtw_hal_xmit(struct adapter *padapter, struct xmit_frame *pxmitframe) { - return rtl8723bs_hal_xmit(padapter, pxmitframe); + if (rtl8723bs_hal_xmit(padapter, pxmitframe)) + return _FAIL; + + return _SUCCESS; } =20 /* diff --git a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c b/drivers/stagi= ng/rtl8723bs/hal/rtl8723bs_xmit.c index ff82b6efefc7..ea7c9f4ac0f4 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c @@ -519,7 +519,7 @@ s32 rtl8723bs_hal_xmitframe_enqueue( complete(&pxmitpriv->SdioXmitStart); } =20 - return err ? _FAIL : _SUCCESS; + return err; =20 } =20 diff --git a/drivers/staging/rtl8723bs/include/hal_intf.h b/drivers/staging= /rtl8723bs/include/hal_intf.h index 9b000681ff80..ee8ad26325b5 100644 --- a/drivers/staging/rtl8723bs/include/hal_intf.h +++ b/drivers/staging/rtl8723bs/include/hal_intf.h @@ -195,7 +195,7 @@ void rtw_hal_set_odm_var(struct adapter *padapter, enum= hal_odm_variable eVariab =20 u8 rtw_hal_check_ips_status(struct adapter *padapter); =20 -s32 rtw_hal_xmitframe_enqueue(struct adapter *padapter, struct xmit_frame = *pxmitframe); +int rtw_hal_xmitframe_enqueue(struct adapter *padapter, struct xmit_frame = *pxmitframe); s32 rtw_hal_xmit(struct adapter *padapter, struct xmit_frame *pxmitframe); s32 rtw_hal_mgnt_xmit(struct adapter *padapter, struct xmit_frame *pmgntfr= ame); =20 --=20 2.34.1