From nobody Fri Jun 12 15:48:12 2026 Received: from mail-dy1-f195.google.com (mail-dy1-f195.google.com [74.125.82.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A8D43C0604 for ; Thu, 14 May 2026 06:03:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.195 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778738633; cv=none; b=mCY2O8irLW8afxtTkSxZxszTIy+u3PZMK1LMFOQx10qO48MuRIm4eSgOFKZqRAJdwgRS4KGwzm1aFQuUyNqFoJeUufj0o6Vz6yLEtvLxreTn0clMG08f8YnrfMziZM/RnTelwhMkhu+ZJB5CRujaD2TOQ0cZLWHs2kPIqoR2Bk0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778738633; c=relaxed/simple; bh=Axmd5IPh2I0ePfoBcxce130e2QCyMyW6fCwo7DYmTgQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=l99YQqqzLmlfAZjCPBo1E1sB4LAZpQ3s15oDDKKxUMyY9iA1lJwDYf7RR6ydjFAJjM9BqlUYvr2fyOYpplZ3uhUoTmLIFIMJYoahcXb8QkCq1fM0y4jC2/7aEyU/yI9BviS/FCcgJFCJ0BeS+fbEQZlFeMdEoVsuZmHBw6ZknJE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=pIaiW/sp; arc=none smtp.client-ip=74.125.82.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pIaiW/sp" Received: by mail-dy1-f195.google.com with SMTP id 5a478bee46e88-30246cfd41aso2519993eec.1 for ; Wed, 13 May 2026 23:03:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778738631; x=1779343431; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lCk5lbI7sH2Lz326mmiKMLpYmZaGzeWhG5OnFEOU7xw=; b=pIaiW/spPVNRtGwiHIRCsIIfj4vz9BsEg+Rl1Y7g/7sKTQSwGs7XJu3SRHhsnD2tv5 SYKjWpm+sX1sIixcPuBtusG5V8CtNFhTs+kx0QrNgM30VrNu/0ZViVLvGcxgqTGaeu2w vO0CoF7L2t72OifNrRgITEq9DHs0r8QDxFIJi3HMUP/pOrSjkvrxSeBJh/TdWFwpQ0t1 YZiWQxcspGYbjsdAq4fNlcPRJDlVCjKg0SzuNS8Uo7t2qKNwJd9sVnJfNNVmNzHbp0I2 c6V9cvD4yE38q/RhW7ZEHpa1k3wX3Z/oaHlyS+EJUVECHJtqsTj+R7+61uUaYCpRnMfe FOXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778738631; x=1779343431; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=lCk5lbI7sH2Lz326mmiKMLpYmZaGzeWhG5OnFEOU7xw=; b=HPcQNwSHW/C0fNW5K3c0R76usr3b/YE3GeT+Fa6koxYURQTPebIXgdngOrIWnBflyH GvlD3iztlYZBjqERNfBv1ZTdWglkBnlHzP5LCnx5x1AlBBfX2nOyJ/HWEJnwRJgoYbMf GY1ioq2+yRf5IeOnWsVSF9/EhhlC5bXdFoY+1UEWzkXuumYrW1Vr670UC5Zl7abt+MZg sfbPYe0LXEvBUc21pMmMNpoN2ZuKpVtqlqL/D/6bkWSJPuRcLhcd7igaSFwrmCaqohs+ 4RoZU9u6nbp2xGIVFT0mFN38WyX94h9ibJRKTcVKcRm90Gl6e/HHgAhPg72XJ4TiUbjT FDow== X-Forwarded-Encrypted: i=1; AFNElJ+kzsboeMbBi8Tf35tBzxl441tQngoL5GBSoOqofvioXMP554oQ2nGrAxof0nwPnRljVDOacL+Pb0pU6js=@vger.kernel.org X-Gm-Message-State: AOJu0YygE/ssJStBTBlYKsZE2eZQg+5PoTq2jPWJu05Br6NP/DDoNkYm BOPnPEKG/k2NYbDCQ5oRxl2sjD0xNKkTG/FsZzhKWkQGWjBpPdM1VJPj X-Gm-Gg: Acq92OHuXR0l095DoMU1Yhnj5PqIT+CuU6YUpIol+RD7tLGl4E7xcG3kCcPW4RQ0Cp2 8JCqwkbmLsALdvKBi9x2KmKD5mboe6kw3QMJ65xHm1MZaFX/1sVzHwJIdydVlUp4xyK6F7XZv3g fu+S58X4Ajn+H1n5SN7H/IeXeHAOP9gk3QJsJVCP/YaYTqt3QJUabg4Q2FluGwGrgoEBlaYpOKx la2gsfXcS4uVb6to5nC456FIYYTFhrwyQcEfRbNiha7jzNsav5WKl4qxNygGkJn6EdPXrbYnI+l hm3X44i2uyQZbgEsnfK68aCu0Gl7v8a0C4ZfqikYCLlx5CCkcon2p1+A0kdH3X3WURAWwunKIyx 5TRjXMOdAlk4/9G+K2I915Xpkwxi6xxRliCVUbgo4N5+Jz5fK5bw4AJo6oxR7EYWkTFMSHflE86 xQ8hSN3TFVvfXHA4RSG6otHESUmAR1Og8FPTtcAzlMDQlaZZ1NggQ/vtQ= X-Received: by 2002:a05:7300:5709:b0:2ce:f3d7:221 with SMTP id 5a478bee46e88-3015593e4e3mr3965161eec.17.1778738631263; Wed, 13 May 2026 23:03:51 -0700 (PDT) Received: from localhost.localdomain ([76.32.119.210]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30296dcb6adsm2034772eec.15.2026.05.13.23.03.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 May 2026 23:03:49 -0700 (PDT) From: Hungyu Lin To: Greg Kroah-Hartman Cc: Dan Carpenter , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Hungyu Lin Subject: [PATCH 1/5] staging: rtl8723bs: simplify rtw_xmit_classifier control flow Date: Thu, 14 May 2026 06:03:19 +0000 Message-Id: <20260514060323.24895-2-dennylin0707@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260514060323.24895-1-dennylin0707@gmail.com> References: <20260514060323.24895-1-dennylin0707@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Simplify rtw_xmit_classifier() by removing the exit label and using direct returns for error handling. No functional change. Signed-off-by: Hungyu Lin --- drivers/staging/rtl8723bs/core/rtw_xmit.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rt= l8723bs/core/rtw_xmit.c index 458e471535ad..72e5dddfee5d 100644 --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c @@ -1874,16 +1874,13 @@ s32 rtw_xmit_classifier(struct adapter *padapter, s= truct xmit_frame *pxmitframe) struct tx_servq *ptxservq; struct pkt_attrib *pattrib =3D &pxmitframe->attrib; struct hw_xmit *phwxmits =3D padapter->xmitpriv.hwxmits; - signed int res =3D _SUCCESS; =20 psta =3D rtw_get_stainfo(&padapter->stapriv, pattrib->ra); if (pattrib->psta !=3D psta) return _FAIL; =20 - if (!psta) { - res =3D _FAIL; - goto exit; - } + if (!psta) + return _FAIL; =20 if (!(psta->state & _FW_LINKED)) return _FAIL; @@ -1897,9 +1894,7 @@ s32 rtw_xmit_classifier(struct adapter *padapter, str= uct xmit_frame *pxmitframe) ptxservq->qcnt++; phwxmits[ac_index].accnt++; =20 -exit: - - return res; + return _SUCCESS; } =20 void rtw_free_hwxmits(struct adapter *padapter) --=20 2.34.1 From nobody Fri Jun 12 15:48:12 2026 Received: from mail-dy1-f193.google.com (mail-dy1-f193.google.com [74.125.82.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 725713C2769 for ; Thu, 14 May 2026 06:03:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.193 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778738635; cv=none; b=uw+yjIyMBeWj0e3IDHd+9F70W7F1PGf6hbcvGE43MgFrIhgPi5dEcrlOGyGpwenK6tX7lM0ys8Z5CotsSs7N2vv/N+AcCAd64jN8UoB/biZXds00saDg/EbqFrvty5jYqh/utdqcY15xifYOSxhspQ/EoEagFJ3pHL+O3D4iJsI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778738635; c=relaxed/simple; bh=nrczOfGVC80s+tKVDd3e9ohV6aT19hUDJHpFQ9xSAjI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=XkvHTRNMAUkpheeYPoG7wX1CZxvLRWUeXR+JIv8AmseuJ4784fd33gnsT6VfudBl2hmssyhg4HhQB+/SW4avlONqqkobBrX8TVf9BgTWCvDN5yzHckGPjDD75PIVAzm3EolV05QuD/7hSyTDkcFLjJJvDoOkGuAJbUDQJSCEXgE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=APoF3WdL; arc=none smtp.client-ip=74.125.82.193 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="APoF3WdL" Received: by mail-dy1-f193.google.com with SMTP id 5a478bee46e88-2f7020a928eso10639754eec.1 for ; Wed, 13 May 2026 23:03:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778738633; x=1779343433; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=YEDmPs3IEzkMNu9wS4D7y4et1HievtNnY5UColUpsPw=; b=APoF3WdLbcUmPwiSeXM1f3frBx8P6amFCIR0jzIACOp6pdX9GerXVE9fK6VoKdKKN+ 5jXae/7S9WRfOHB7jAXo1vnbAyT7naMrjdFZ/9MJJdx9n4WAOvdzvaiNha0Fvt60VybW eZs2gRf5Ng9QUbCzkTonFx0CvnYApSwpGpK1Ii2/KDMqV+N/gD0WVEb+5i0+oYfyfFFK s+ZH1JdyLt9YBj0MsfW+CVqCoENGsD0WnDTV0uGVDFp2Gbikr7iwkOU3cEu9/jWK8OsO Jf7WkdK+/LuMTD4ZYNwFM4H1DI7KCcNAkicvpfv7XImBiI3qXbTj/DlbtnTFmoH7UEv/ m6vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778738633; x=1779343433; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=YEDmPs3IEzkMNu9wS4D7y4et1HievtNnY5UColUpsPw=; b=Nni94diAI8DtwFLVu9KoUPNClWcMQV2AdKwRAQodp0YpM9zZrAJByan11mWEuk0cIh ZpbBl30yVzUTiRbMy1k66cnuFDUbs+5DFrISx8+tkna5W2I5TsiWOMiEwDNABWkVg2/E gNF3gUiFEt1kniHLpO17inCTO5uAVMqTuNQx1+CIwljW2A6/6ilEfx5RQlQusPx6GwwF lq60k56x98zXe2VhyPJ4o4Yy2HOM7P+9uOl34KUpV4tWy714AMjXGdUH3o0i2+UOmj3O VVtjYooMMiPDcSVn4nOcOsh+cuwsF4Hu0K5D7X7UdorpcZjeUW05HGttOtlsxJ8mxddK tvWA== X-Forwarded-Encrypted: i=1; AFNElJ8xE84OcquuMqyhDMyzxVChqlyx4hvIkKh9KLv/6fX5iGEQAb6x4DNIs65nordT0vuzSaCvNdid082k0Ks=@vger.kernel.org X-Gm-Message-State: AOJu0Yy/mf2cr5reXYFir8eLwSfmKcOuFsRCbYi4O/TySwJHeWDC2rRw cvPKpJl/qbPdO7nLjTdLeuc3VNTtprbMFpP6ZjOcHUII8iasAS0Xy/4M X-Gm-Gg: Acq92OGVesxcdVuMlGuwiy5sRSxdHMwTO3UtWXr+3svIYBXF7VGm8x155/m2ZB910A/ GBvLHcHITq8eeLH0d0DLplLL8/scAxGXCBbGur/w825ccwM4V8s2JV3fVtsZT0R4IfK4kEtvr0F amig26eXCwzUGRm6l/4y+ApkUn+33eUb8df1aCa/wH4n+QBQ/BtvkbPz5tbWQq46mf2hwQsiAAv r6ZRUqdzNzjAaT6qlmDpxbrXwZpaVu/QNEXvLwdqirYYnEF+/GHx/M+QFbw0vG6IUlNxlXKiA+P YnS3obhIVG4zlPns/WTMFmQlvi+1NFxH2pavkqC/z+M6Q7gmabzBS7ZbwabVPJaeaZS6OWRhP2K E8tiubCPFZgfAcC6AMBmPWkctMBWo1YvwW8tSvfNVNHdaH+yNHCOqsjJ9vk98arTMmxGLL9JEuw di19n4MbDCgfOF2bSVvREQqzMaP4qk/aNvXAZ+0OHQkOrYgqRhrR9q3Lg= X-Received: by 2002:a05:693c:310c:b0:2f0:4268:bc42 with SMTP id 5a478bee46e88-30119f5e862mr3591064eec.25.1778738633533; Wed, 13 May 2026 23:03:53 -0700 (PDT) Received: from localhost.localdomain ([76.32.119.210]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30296dcb6adsm2034772eec.15.2026.05.13.23.03.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 May 2026 23:03:53 -0700 (PDT) From: Hungyu Lin To: Greg Kroah-Hartman Cc: Dan Carpenter , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Hungyu Lin Subject: [PATCH 2/5] staging: rtl8723bs: make rtw_xmit_classifier static Date: Thu, 14 May 2026 06:03:20 +0000 Message-Id: <20260514060323.24895-3-dennylin0707@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260514060323.24895-1-dennylin0707@gmail.com> References: <20260514060323.24895-1-dennylin0707@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The rtw_xmit_classifier() function is only used within rtw_xmit.c. Move it above its caller and make it static to limit its scope. Signed-off-by: Hungyu Lin --- drivers/staging/rtl8723bs/core/rtw_xmit.c | 68 ++++++++++---------- drivers/staging/rtl8723bs/include/rtw_xmit.h | 1 - 2 files changed, 34 insertions(+), 35 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rt= l8723bs/core/rtw_xmit.c index 72e5dddfee5d..b3953bdedb04 100644 --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c @@ -1821,6 +1821,40 @@ void rtw_free_xmitframe_queue(struct xmit_priv *pxmi= tpriv, struct __queue *pfram spin_unlock_bh(&pframequeue->lock); } =20 +/* + * Will enqueue pxmitframe to the proper queue, + * and indicate it to xx_pending list..... + */ +static s32 rtw_xmit_classifier(struct adapter *padapter, struct xmit_frame= *pxmitframe) +{ + u8 ac_index; + struct sta_info *psta; + struct tx_servq *ptxservq; + struct pkt_attrib *pattrib =3D &pxmitframe->attrib; + struct hw_xmit *phwxmits =3D padapter->xmitpriv.hwxmits; + + psta =3D rtw_get_stainfo(&padapter->stapriv, pattrib->ra); + if (pattrib->psta !=3D psta) + return _FAIL; + + if (!psta) + return _FAIL; + + if (!(psta->state & _FW_LINKED)) + return _FAIL; + + ptxservq =3D rtw_get_sta_pending(padapter, psta, pattrib->priority, (u8 *= )(&ac_index)); + + if (list_empty(&ptxservq->tx_pending)) + list_add_tail(&ptxservq->tx_pending, get_list_head(phwxmits[ac_index].st= a_queue)); + + list_add_tail(&pxmitframe->list, get_list_head(&ptxservq->sta_pending)); + ptxservq->qcnt++; + phwxmits[ac_index].accnt++; + + return _SUCCESS; +} + s32 rtw_xmitframe_enqueue(struct adapter *padapter, struct xmit_frame *pxm= itframe) { if (rtw_xmit_classifier(padapter, pxmitframe) =3D=3D _FAIL) @@ -1863,40 +1897,6 @@ struct tx_servq *rtw_get_sta_pending(struct adapter = *padapter, struct sta_info * return ptxservq; } =20 -/* - * Will enqueue pxmitframe to the proper queue, - * and indicate it to xx_pending list..... - */ -s32 rtw_xmit_classifier(struct adapter *padapter, struct xmit_frame *pxmit= frame) -{ - u8 ac_index; - struct sta_info *psta; - struct tx_servq *ptxservq; - struct pkt_attrib *pattrib =3D &pxmitframe->attrib; - struct hw_xmit *phwxmits =3D padapter->xmitpriv.hwxmits; - - psta =3D rtw_get_stainfo(&padapter->stapriv, pattrib->ra); - if (pattrib->psta !=3D psta) - return _FAIL; - - if (!psta) - return _FAIL; - - if (!(psta->state & _FW_LINKED)) - return _FAIL; - - ptxservq =3D rtw_get_sta_pending(padapter, psta, pattrib->priority, (u8 *= )(&ac_index)); - - if (list_empty(&ptxservq->tx_pending)) - list_add_tail(&ptxservq->tx_pending, get_list_head(phwxmits[ac_index].st= a_queue)); - - list_add_tail(&pxmitframe->list, get_list_head(&ptxservq->sta_pending)); - ptxservq->qcnt++; - phwxmits[ac_index].accnt++; - - return _SUCCESS; -} - void rtw_free_hwxmits(struct adapter *padapter) { struct xmit_priv *pxmitpriv =3D &padapter->xmitpriv; diff --git a/drivers/staging/rtl8723bs/include/rtw_xmit.h b/drivers/staging= /rtl8723bs/include/rtw_xmit.h index b0189a703d28..a2ff62182b97 100644 --- a/drivers/staging/rtl8723bs/include/rtw_xmit.h +++ b/drivers/staging/rtl8723bs/include/rtw_xmit.h @@ -440,7 +440,6 @@ extern void rtw_free_xmitframe_queue(struct xmit_priv *= pxmitpriv, struct __queue struct tx_servq *rtw_get_sta_pending(struct adapter *padapter, struct sta_= info *psta, signed int up, u8 *ac); extern s32 rtw_xmitframe_enqueue(struct adapter *padapter, struct xmit_fra= me *pxmitframe); =20 -extern s32 rtw_xmit_classifier(struct adapter *padapter, struct xmit_frame= *pxmitframe); extern u32 rtw_calculate_wlan_pkt_size_by_attribue(struct pkt_attrib *patt= rib); #define rtw_wlan_pkt_size(f) rtw_calculate_wlan_pkt_size_by_attribue(&f->a= ttrib) extern s32 rtw_xmitframe_coalesce(struct adapter *padapter, struct sk_buff= *pkt, struct xmit_frame *pxmitframe); --=20 2.34.1 From nobody Fri Jun 12 15:48:12 2026 Received: from mail-dy1-f195.google.com (mail-dy1-f195.google.com [74.125.82.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A53CA3AE1B9 for ; Thu, 14 May 2026 06:03:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.195 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778738636; cv=none; b=KZwL0LJ32z2mGQ2LEWfKAKrCYmmLzBCokAq/0zBHgh+haJzR09AhgN7aSeclKk09gIgqvirMFYmRpPuJY9L/k0IbabheCm0xxWVjUQRuqkIlpW0IEwuJbdoeeIfzAKbDJYn2NdGfZrfx6ukCSqTLvqybVarSKI/S5ckHr6DTPOc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778738636; c=relaxed/simple; bh=OwRd3NUTkaAoh8Y+r/wsJsf4AWa/FLJ5AAP/ykOV6ps=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=KRX6o9Tjq+WJTU4TzyzBDu0e5Pyfei3FwTLYqVwSpwBPNJoEAdS8/fFdy5jc1FcwT41zwHqBbo+AJ2MXZASxiJwmB6IfYT3sTWZqTwN/afG3KjpCD7ODi6rT9SWhEVQC2NTdNj5ozGoMCzx9jQnm1kYzndkysVSV1Vn2QgUtHIU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PhcMbTZs; arc=none smtp.client-ip=74.125.82.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PhcMbTZs" Received: by mail-dy1-f195.google.com with SMTP id 5a478bee46e88-2c15849aa2cso10259144eec.0 for ; Wed, 13 May 2026 23:03:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778738635; x=1779343435; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=KhH4QN2V6pideai/krprs3/7h/AE1I4RG4vdBuW1XJg=; b=PhcMbTZsHu3Qq16aK6EqqvIvX1xLWoyhKZg5tgOL+fm+Um64dVqoUfv/lzrEhF7avr D/cCqZAFmnECPTq9ReOZhzbt628PWvHHu3U3nvN+nApYS45ddkvIa6uBV7P4yFmyn3HX ch7qa0AXYEXknhghdpDKKYzwVKS0tnrAaknX0Z6CgQU0G39w+hLllTG7NwCzj2nRojP7 ehowSfBcbFAZmRo2jWVr2iwKnGplXMV0pe/ZLFCbaA4oQfT/9fcPMeCgUD8VFZNOnurH BeAb5z3tdbMjYcCFwLiAY1Uir+TSudRcdxlIsygqqq/M8XTHMdvY8K9z9VMJVLtJOSrt QRdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778738635; x=1779343435; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=KhH4QN2V6pideai/krprs3/7h/AE1I4RG4vdBuW1XJg=; b=rM857yeaxcrdoTO2rtcfdPtxW5gzLFAMXV8FqXac77UKCERdHeubrGIjektNEVuE2K 9Br0fdvhw/5PDfxOgOw2ok1HWhR7gNVpE612hjEVB/mK0AqHoPmxZwIYEDAk07UCcCC2 Si2Wlc6UghLQfsNIC44bQiBrSRcrvlAatcpLZXotAhtQsi6fHGJJ3yZ35Z+Smvalil89 IeAIsiPJr2CxPjPHuPkRkOfS7tCzOdtCFuLew+MGWmmYEuL0dEv3JiG2vrajLJCKtsTZ qSobr021KlirZ0mAK5/ilLeRb8aS4Iq3Eigtgd1MqX/DU7nNYHEmSk2EPtw+1hP9V4nr MO6A== X-Forwarded-Encrypted: i=1; AFNElJ+jNSmcS0baGk1tXUNgRqXRBD4g4+MHmPMJDQw/tdbAuZLVUXHCcAXxKXu8qIKUoujN+DprJ3lROhr5hWo=@vger.kernel.org X-Gm-Message-State: AOJu0YzGbUZQsP6x0zx+QOa7JAh3mwunRMg+oy86B4qP+tjnxyH4trA5 H/hbAQXJ7l3tQRkTKYuTan/tIuz46wwxn3vTaXv0f86NILf3Kb0M05cw X-Gm-Gg: Acq92OHvWiY8BKwFwMU8lSkjMfhCVa77EPSoRA3/xGzpQKo1AE76Qup6LUV3+JgqYTK 90MpXALs4q9SceJdfGwK1UEEtNG35E/te989/4iQZu1kwCVr7UcZjdmvolplk8hesUplND+h58W Q4VRo3iJdKmY57bJG4dL0XU9TbYw95JNRtxV1aDiJCKZ5xov6OaqVFXvchv+i8TsmNMLvQaBD3K 42BZTwilp/MBIqI3QzZjX6TpYpg8ZUCytVSaWTG08xH+wPRluBclAF/iTAKOX2LHTxziXy+bjvI D17iiTCF5aJR+MQ+/3wv30fN6qkEKPbUJup6RmuTu3JTpM5N0XHq0M5jIszFKPppyFat5SXv+kY QkOUvn2pdKywUK53USRXac/tgXoM1Ch7xc/BQuk3lB+edVAQlfmfFeNQV0NWdzJYOaWHQGbJAzJ Tf/rvrOO65DJAEufmpB6OPSu3S5dQ8htW99lRUCyy+KL4vHcIFbs9uqxQ= X-Received: by 2002:a05:7301:d09:b0:2e6:e916:70ff with SMTP id 5a478bee46e88-30119395696mr3467614eec.28.1778738634773; Wed, 13 May 2026 23:03:54 -0700 (PDT) Received: from localhost.localdomain ([76.32.119.210]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30296dcb6adsm2034772eec.15.2026.05.13.23.03.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 May 2026 23:03:54 -0700 (PDT) From: Hungyu Lin To: Greg Kroah-Hartman Cc: Dan Carpenter , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Hungyu Lin Subject: [PATCH 3/5] staging: rtl8723bs: convert rtw_xmit_classifier to return errno Date: Thu, 14 May 2026 06:03:21 +0000 Message-Id: <20260514060323.24895-4-dennylin0707@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260514060323.24895-1-dennylin0707@gmail.com> References: <20260514060323.24895-1-dennylin0707@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Convert rtw_xmit_classifier() to return 0 on success and negative error codes on failure. Update the caller to check for non-zero return values and preserve the existing _FAIL/_SUCCESS semantics. Signed-off-by: Hungyu Lin --- drivers/staging/rtl8723bs/core/rtw_xmit.c | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rt= l8723bs/core/rtw_xmit.c index b3953bdedb04..80f3dfaf793d 100644 --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c @@ -1825,7 +1825,7 @@ void rtw_free_xmitframe_queue(struct xmit_priv *pxmit= priv, struct __queue *pfram * Will enqueue pxmitframe to the proper queue, * and indicate it to xx_pending list..... */ -static s32 rtw_xmit_classifier(struct adapter *padapter, struct xmit_frame= *pxmitframe) +static int rtw_xmit_classifier(struct adapter *padapter, struct xmit_frame= *pxmitframe) { u8 ac_index; struct sta_info *psta; @@ -1835,13 +1835,13 @@ static s32 rtw_xmit_classifier(struct adapter *pada= pter, struct xmit_frame *pxmi =20 psta =3D rtw_get_stainfo(&padapter->stapriv, pattrib->ra); if (pattrib->psta !=3D psta) - return _FAIL; + return -ENODEV; =20 if (!psta) - return _FAIL; + return -EINVAL; =20 if (!(psta->state & _FW_LINKED)) - return _FAIL; + return -ENETDOWN; =20 ptxservq =3D rtw_get_sta_pending(padapter, psta, pattrib->priority, (u8 *= )(&ac_index)); =20 @@ -1852,12 +1852,15 @@ static s32 rtw_xmit_classifier(struct adapter *pada= pter, struct xmit_frame *pxmi ptxservq->qcnt++; phwxmits[ac_index].accnt++; =20 - return _SUCCESS; + return 0; } =20 s32 rtw_xmitframe_enqueue(struct adapter *padapter, struct xmit_frame *pxm= itframe) { - if (rtw_xmit_classifier(padapter, pxmitframe) =3D=3D _FAIL) + int res; + + res =3D rtw_xmit_classifier(padapter, pxmitframe); + if (res) return _FAIL; =20 return _SUCCESS; --=20 2.34.1 From nobody Fri Jun 12 15:48:12 2026 Received: from mail-dy1-f195.google.com (mail-dy1-f195.google.com [74.125.82.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE1AC3C343E for ; Thu, 14 May 2026 06:03:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.195 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778738638; cv=none; b=Azb0ckhCbXCgEyo6ioXsWXAJKmRh4rozDv9IZxBtQz0mPTtlOZjBHpeHzYRTStfhpn/d2yh4+fwb8NJ5GugCvUNFEmIrD2nSn1UD4AFtZ57DdtHo+5NtyQajsuaqShTfJyTy/z0yc33aSL+vY966YqtB/VveUY4Abg4c7St+6Sw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778738638; c=relaxed/simple; bh=Lx8tjc2hi/BxnlTzuA9QV3HwAbmze/Wwgnxtiq84N/A=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=jMw+PHRviaVMJ1UFB8rer64aHC9ECJ0C0jHxMUc/7cY8L3eOLPszE4Cc97nfj5UjKM/jbRzBYJRnqHLuhWFMW2zsy0CfUHjveli4Vb6+hAM8Xsi4ebUYHiHdxYGjYZsx7u+kxrelyEeuBpTJVMm6cyN3jDhpshnyvc1LzoO+jHg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=tFMuZdID; arc=none smtp.client-ip=74.125.82.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="tFMuZdID" Received: by mail-dy1-f195.google.com with SMTP id 5a478bee46e88-2c15849aa2cso10259161eec.0 for ; Wed, 13 May 2026 23:03:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778738636; x=1779343436; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4JlJ+zwzmXqUTxE6mP3nEpdnrhD+xyjOREjmHfGZCMw=; b=tFMuZdID1jdBUi+veRN1bECA09K5mUlGM4rsMX9bf3YhzCMiI/j1mhmV4B9Lav+WeP gErvBaNXFgGxcUOch3MZ3ijNpGkU1wSayRBFz6WaPHaf+lKbeyEBceRb06VPxcqJ2w9s rszfkm/myFqkHlbh3GAnlC/Yo1NxHipH01xTC/3NNC1AErgXFGyMiBZKBjftnugzuV+M bcCttKawYy7BRAGs8S+oxaI16UmUkhhNkc1zCI9K/QK3cDb/JyOZG0nBSC9AKVLTowRW LXj07526zpXhyNBtW8ij512Vwel6YKSbgiTSkOBVd5qMU9+Shw7iXZhERKrK0yt+vLFS C/rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778738636; x=1779343436; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=4JlJ+zwzmXqUTxE6mP3nEpdnrhD+xyjOREjmHfGZCMw=; b=kkv1q3zijJeImAl+JZ4k1VctiqEfPA1vvO/hjE4jjas47niWxd+cZan4RrOMNue38U +RTxXp+ksRkq2bCa5j9sbALOASl5RllWIq9ivqeWGEiWMMmG8gJxp3K1sDKn318kCglF UD0ZAQu1/d81ggdBJtxKEpcdY0au2ic8PxKDKBcvFhZ8xDIS33VubvnDkmzqyCUOHRfx qClo+vTvcxLAhoX74wDOQmQ7vC4J2TP8/XNAWwt9pHrU2H9nQLxSdMhz88cVTbcsFPxx v8vDhBPilwbal1coxY8aQNcC18l9QfqUDE/W1DMinbcFHxUFuQGOCBs8IBWVcz/7a95I Bj0Q== X-Forwarded-Encrypted: i=1; AFNElJ+DznuQmvxQ22cWqaD3nPnffadACbGZFkSK4peHbmkViXNaGLtegnzGS0UK0uozcoVtnukDMZyh7w9IgRo=@vger.kernel.org X-Gm-Message-State: AOJu0Yzj0HNhQlIuYNUOtTId1Gj7IUBn467QRV3iqx7SFVw/Uy98js7C ++0NLakIZdefDPSTkhxZBVO5jcubctw/fzilG6OWarTdy7FVfFaNMgq0dK7b/UqTUSQ= X-Gm-Gg: Acq92OHsaIUtvGHM84geLiXcl33/LI4GJ5nDQPtxmWQXEawH+2udm4c9W/MiP4cUGOe 5RQ/qrMjlWowQJeQbjsdHnsAcNUq2t/4yQmjZSYhWSqiBpDkuQmynMNQqYq6pebG39evtc4pam/ FpmqZWV/sesuZZXLY25uRXRRcpJb5mI4KAL6BdRkPZEkKOa63lhaoCg5s2q4uAMVsRL44n+zb31 X6q3Rra/z2sm5z5WMQxOQKJaAdogpx0u9i9vdjJ6wQ0IyIo+9dZ26IzybfJLIoFSct2vZnHZ11o ktudp5YLMj01s1fk9cvsQWmNw6PeCD2gwEgBUIGCJDreVhFVl2TI4u8l35pMk9AAJmw+VjpEig6 0Uy/1ZdcP4a6wVfASej2SlcBxokEZu2/t4GhUwTr/LWVpU2mZIwmL6VM5tUdQ2V3JSqq3wZ8K6D OEQjGnvU8QHfBXmp91inMCRmBkoQBz4iFt+VoJYSNzpApWILQQH/38MzWfn04bezKWBA== X-Received: by 2002:a05:7300:572a:b0:2e6:fe90:27ad with SMTP id 5a478bee46e88-30116e95830mr3777818eec.7.1778738635996; Wed, 13 May 2026 23:03:55 -0700 (PDT) Received: from localhost.localdomain ([76.32.119.210]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30296dcb6adsm2034772eec.15.2026.05.13.23.03.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 May 2026 23:03:55 -0700 (PDT) From: Hungyu Lin To: Greg Kroah-Hartman Cc: Dan Carpenter , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Hungyu Lin Subject: [PATCH 4/5] staging: rtl8723bs: propagate errno through xmit enqueue path Date: Thu, 14 May 2026 06:03:22 +0000 Message-Id: <20260514060323.24895-5-dennylin0707@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260514060323.24895-1-dennylin0707@gmail.com> References: <20260514060323.24895-1-dennylin0707@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Propagate errno values from rtw_xmit_classifier() through rtw_xmitframe_enqueue(), and update the local enqueue caller to check for non-zero return values. Signed-off-by: Hungyu Lin --- drivers/staging/rtl8723bs/core/rtw_xmit.c | 6 +++--- drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c | 10 +++++----- drivers/staging/rtl8723bs/include/rtw_xmit.h | 2 +- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rt= l8723bs/core/rtw_xmit.c index 80f3dfaf793d..054cb4c9d1de 100644 --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c @@ -1855,15 +1855,15 @@ static int rtw_xmit_classifier(struct adapter *pada= pter, struct xmit_frame *pxmi return 0; } =20 -s32 rtw_xmitframe_enqueue(struct adapter *padapter, struct xmit_frame *pxm= itframe) +int rtw_xmitframe_enqueue(struct adapter *padapter, struct xmit_frame *pxm= itframe) { int res; =20 res =3D rtw_xmit_classifier(padapter, pxmitframe); if (res) - return _FAIL; + return res; =20 - return _SUCCESS; + return 0; } =20 struct tx_servq *rtw_get_sta_pending(struct adapter *padapter, struct sta_= info *psta, signed int up, u8 *ac) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c b/drivers/stagi= ng/rtl8723bs/hal/rtl8723bs_xmit.c index a7f23335cdd9..ff82b6efefc7 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c @@ -464,8 +464,8 @@ s32 rtl8723bs_mgnt_xmit( *Handle xmitframe(packet) come from rtw_xmit() * * Return: - *true dump packet directly ok - *false enqueue, temporary can't transmit packets to hardware + * true dump packet directly ok + * false enqueue, temporary can't transmit packets to hardware */ s32 rtl8723bs_hal_xmit( struct adapter *padapter, struct xmit_frame *pxmitframe @@ -491,7 +491,7 @@ s32 rtl8723bs_hal_xmit( spin_lock_bh(&pxmitpriv->lock); err =3D rtw_xmitframe_enqueue(padapter, pxmitframe); spin_unlock_bh(&pxmitpriv->lock); - if (err !=3D _SUCCESS) { + if (err) { rtw_free_xmitframe(pxmitpriv, pxmitframe); =20 pxmitpriv->tx_drop++; @@ -511,7 +511,7 @@ s32 rtl8723bs_hal_xmitframe_enqueue( s32 err; =20 err =3D rtw_xmitframe_enqueue(padapter, pxmitframe); - if (err !=3D _SUCCESS) { + if (err) { rtw_free_xmitframe(pxmitpriv, pxmitframe); =20 pxmitpriv->tx_drop++; @@ -519,7 +519,7 @@ s32 rtl8723bs_hal_xmitframe_enqueue( complete(&pxmitpriv->SdioXmitStart); } =20 - return err; + return err ? _FAIL : _SUCCESS; =20 } =20 diff --git a/drivers/staging/rtl8723bs/include/rtw_xmit.h b/drivers/staging= /rtl8723bs/include/rtw_xmit.h index a2ff62182b97..b13f16716e98 100644 --- a/drivers/staging/rtl8723bs/include/rtw_xmit.h +++ b/drivers/staging/rtl8723bs/include/rtw_xmit.h @@ -438,7 +438,7 @@ struct xmit_frame *rtw_alloc_xmitframe_once(struct xmit= _priv *pxmitpriv); extern s32 rtw_free_xmitframe(struct xmit_priv *pxmitpriv, struct xmit_fra= me *pxmitframe); extern void rtw_free_xmitframe_queue(struct xmit_priv *pxmitpriv, struct _= _queue *pframequeue); struct tx_servq *rtw_get_sta_pending(struct adapter *padapter, struct sta_= info *psta, signed int up, u8 *ac); -extern s32 rtw_xmitframe_enqueue(struct adapter *padapter, struct xmit_fra= me *pxmitframe); +int rtw_xmitframe_enqueue(struct adapter *padapter, struct xmit_frame *pxm= itframe); =20 extern u32 rtw_calculate_wlan_pkt_size_by_attribue(struct pkt_attrib *patt= rib); #define rtw_wlan_pkt_size(f) rtw_calculate_wlan_pkt_size_by_attribue(&f->a= ttrib) --=20 2.34.1 From nobody Fri Jun 12 15:48:12 2026 Received: from mail-dl1-f68.google.com (mail-dl1-f68.google.com [74.125.82.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 363773C4B71 for ; Thu, 14 May 2026 06:03:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.68 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778738639; cv=none; b=OCO1SUyQPm/XJXWsLyRKYcWA0jjXCzjpAmZYl2qDCIWQ7HHl4q6XgMbygtDKvYNo7SYupO0h+rwISesCpQ/qdJ8Zlg+VA6WU8LlkP3icxHnVc10QwhrfpVAOTf5Wf8Mze1R17xfv/bgYtwpwuWo3AVlQGdDQjD5udW85QqFNmX8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778738639; c=relaxed/simple; bh=11dcICdL6yAMWZIt05foSVoZ8djH8Ghv+x8fPZ+bFrQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=EWk4jYmDnzXLmuOebnRW/0bGNbv7V66TtbMKRPX6J/N2EmvXU36Btw9IMlrhx/N6ng3Xa/3jdgmclvqSwqW7/139+8vY8+LDzRXQflulptK6Em1XmfsJ26SgchfTpu5smwT7QbFjF5wPNxSuAkaIybln639k5CLG4xhPLu7XxC0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=eMjDrTR4; arc=none smtp.client-ip=74.125.82.68 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eMjDrTR4" Received: by mail-dl1-f68.google.com with SMTP id a92af1059eb24-13317450f83so858712c88.0 for ; Wed, 13 May 2026 23:03:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778738637; x=1779343437; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Wt6IobLS9ikgtJxLPxmko8DdVcDAzzBqW2zVT+4q8FI=; b=eMjDrTR46QGfbuEqzTCLv+76GgKMqgg8jiyfiL46kIraCLBRnVMXvfVyWXsMtwztcj vpX1jWvyREpHWhKgGX23RjZtHTsMy8VfUMdr64tl1an/zjgwJYvIQFPzfxhv+KoKMzZW Ht4hPpOycmFT/YL0zd1L1BLvX+KgPQqK7XhlHStX8Do4x65o7Oykf3nOQN0DDqUVPvP+ szBQd07VjppwoCM5FOsU7+gNoKJPQ5Y/71flQ8rZX+YEK35JDBiCqQ40R3DMICnVM0+w wHnrJxRTb8Q0jYQfeYFQwTyi44tFRkAr3T7HMjjcP0UbiMFvT4+VqW3TQZfvRxWykBXE 7h1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778738637; x=1779343437; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Wt6IobLS9ikgtJxLPxmko8DdVcDAzzBqW2zVT+4q8FI=; b=GsM31XkExuN/84c/Zb2OuGgTqH1sl7g23+ARFeU/eXxdyoaY4oVZ5i3NkQCTLHp1Fl IGirOMICp9SY1iavEJIG3yTp4Z9kaSu6LhWeQF1t0Sh1xYrVGV8yVUZEMOZeVberMILJ cpdXop371f7rJgPbyeTTPWJz5v4TeHcgsqt8XHzRpnv/R/1wEpcpdGp99QWwE52LGagt U3aA0FpAFuDLWFu92onC1yX1/2rDkUl8un2S+8q6MNOmv7PVAFMZMhFXd64BUdBXpzzO MnnvoYM9lfpO0AXIEiTgcEJ6JDey2QsWOjPU42ptAFW3HyYtpXB+OOprN2uZ4IjfoIfx RkPA== X-Forwarded-Encrypted: i=1; AFNElJ9SpkEQb6wqutelZhkf6Q+0tyGhPTlFBSrF8nALi8B3+Ze1zcgyMDPqoEF8xxnuhCehRQFaMM2ASG27gvc=@vger.kernel.org X-Gm-Message-State: AOJu0YyHBNA61yZLQXQDBwY1oYIOfmDwIRu4QhekOGhtndQ01TFU2TxR wfY6+2KkP2aE6T7cTZpyZ1pfH+aXUCQc6facRDFn8MPLXZHeFy6CyRJ6 X-Gm-Gg: Acq92OHBZUyUOy1s4DxQwlcp+THWhsfEm8V+tq7YwTIfa0P9K/merEasz79JEzFqOn9 V9ierAZxHetYfOYkzt/rrxEmxwxQBrjGnpoM32rujZrq4+dWC2S0gxEc6eSnXo5vl6oRczrVTze yNeTsu3da9ZT8beqZo1N+vRRMTa+2lKBoxWQspDqWc06i3tOPoLOJrIfnGVq1DUSO/LqvuEFWCC GvPJ2S7N0uX7pm5YfbjGlkqFNmOYumnGgf7vvOB48YG2lo5xuAlfmWmhUzai3y6WHTClyvuHGWj TkWytnMayO8Hl1B8fv9C4oRsZBSWCUj4N7n+IfeIhcb6HtHwQ+b/ZFLs7oRf4lGVKNNB1JnXO2U XtpWE3dyyfmUPaZ+FhxqhJYPX7wnI0NUjTFRT5Acq2H/aDVGlJQCOS6oT+U3ok5/JxFbn+5yLo5 jHnK6diZChdsy2tp07+jkRerFhYRKJpeU27ndP8SZHBlqqrW6zOC0G2516DgHSDUN7TA== X-Received: by 2002:a05:7300:a986:b0:2c1:6676:5ebd with SMTP id 5a478bee46e88-3011758698cmr3924036eec.10.1778738637099; Wed, 13 May 2026 23:03:57 -0700 (PDT) Received: from localhost.localdomain ([76.32.119.210]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30296dcb6adsm2034772eec.15.2026.05.13.23.03.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 May 2026 23:03:56 -0700 (PDT) From: Hungyu Lin To: Greg Kroah-Hartman Cc: Dan Carpenter , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Hungyu Lin Subject: [PATCH 5/5] staging: rtl8723bs: propagate errno through hal xmit path Date: Thu, 14 May 2026 06:03:23 +0000 Message-Id: <20260514060323.24895-6-dennylin0707@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260514060323.24895-1-dennylin0707@gmail.com> References: <20260514060323.24895-1-dennylin0707@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Propagate errno values from rtl8723bs_hal_xmitframe_enqueue() through rtw_hal_xmitframe_enqueue() by returning the error code directly. Also update rtw_hal_xmit() to explicitly map the boolean return value of rtl8723bs_hal_xmit() to _SUCCESS/_FAIL, clarifying the return semantics at the HAL boundary. Signed-off-by: Hungyu Lin --- drivers/staging/rtl8723bs/hal/hal_intf.c | 7 +++++-- drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c | 2 +- drivers/staging/rtl8723bs/include/hal_intf.h | 2 +- 3 files changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/hal_intf.c b/drivers/staging/rtl= 8723bs/hal/hal_intf.c index 03f23b75d532..77fa6e67530a 100644 --- a/drivers/staging/rtl8723bs/hal/hal_intf.c +++ b/drivers/staging/rtl8723bs/hal/hal_intf.c @@ -99,14 +99,17 @@ u8 rtw_hal_check_ips_status(struct adapter *padapter) return CheckIPSStatus(padapter); } =20 -s32 rtw_hal_xmitframe_enqueue(struct adapter *padapter, struct xmit_frame = *pxmitframe) +int rtw_hal_xmitframe_enqueue(struct adapter *padapter, struct xmit_frame = *pxmitframe) { return rtl8723bs_hal_xmitframe_enqueue(padapter, pxmitframe); } =20 s32 rtw_hal_xmit(struct adapter *padapter, struct xmit_frame *pxmitframe) { - return rtl8723bs_hal_xmit(padapter, pxmitframe); + if (rtl8723bs_hal_xmit(padapter, pxmitframe)) + return _FAIL; + + return _SUCCESS; } =20 /* diff --git a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c b/drivers/stagi= ng/rtl8723bs/hal/rtl8723bs_xmit.c index ff82b6efefc7..ea7c9f4ac0f4 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c @@ -519,7 +519,7 @@ s32 rtl8723bs_hal_xmitframe_enqueue( complete(&pxmitpriv->SdioXmitStart); } =20 - return err ? _FAIL : _SUCCESS; + return err; =20 } =20 diff --git a/drivers/staging/rtl8723bs/include/hal_intf.h b/drivers/staging= /rtl8723bs/include/hal_intf.h index 9b000681ff80..ee8ad26325b5 100644 --- a/drivers/staging/rtl8723bs/include/hal_intf.h +++ b/drivers/staging/rtl8723bs/include/hal_intf.h @@ -195,7 +195,7 @@ void rtw_hal_set_odm_var(struct adapter *padapter, enum= hal_odm_variable eVariab =20 u8 rtw_hal_check_ips_status(struct adapter *padapter); =20 -s32 rtw_hal_xmitframe_enqueue(struct adapter *padapter, struct xmit_frame = *pxmitframe); +int rtw_hal_xmitframe_enqueue(struct adapter *padapter, struct xmit_frame = *pxmitframe); s32 rtw_hal_xmit(struct adapter *padapter, struct xmit_frame *pxmitframe); s32 rtw_hal_mgnt_xmit(struct adapter *padapter, struct xmit_frame *pmgntfr= ame); =20 --=20 2.34.1