From nobody Fri Jun 12 15:49:38 2026 Received: from m16.mail.163.com (m16.mail.163.com [220.197.31.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 38B662E54D3 for ; Thu, 14 May 2026 02:53:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=220.197.31.5 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778727243; cv=none; b=gJyfm1OEuCGhhDH5h47hSaWIkJM19fnEyO7h5QjtBY0MuPJ62sSIuyV6TvUu1dRQUh7nHf0FgUt3zP/X5EwO76OCy3R0LhCjETTeGL/L9SG5x+jGcWiN/QuLIybnBq31N3KBZrRqRZq6SFytwDcV4rVSPtV/DAqnYh3BkPRwwRk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778727243; c=relaxed/simple; bh=jtx334ikCV3W3Y93OyFfRfbue62lyvN9TdKGc7JXQ3Q=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=EBe28NH8brUHJsJuLNsxnpEUU01REyFS5cdqZLeTX/qOygWh8q7SN57DajTfqMKvXqa2I/V0776GFKmnwBd3Igk3+r5WAqjnWKVT8/65p4Un8MyTmUYUhGYE89tC/GFSgzxR+3/bTZVSOihAIHXnVZHLGeNwk6/FXB7Rvnm4xpo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com; spf=pass smtp.mailfrom=163.com; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b=UL8J9iPl; arc=none smtp.client-ip=220.197.31.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=163.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="UL8J9iPl" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:To:Subject:Date:Message-ID:MIME-Version; bh=sj 0OVl41nVZux8MonM1pdcOWpZksVKbhvt53cRYip9o=; b=UL8J9iPldTXuiIktEX oDWHPCX8JIV7rZBrvWNNy5iBOjTAxMNF9eGaLYIt9hBQPkAOhXVVOjs0AGMudcuZ RkYJefw/ilJOCsAJicBgRHx0Hxij1O8/cYCpmkQogEr4B8X4L/DpKF+UABMVvmjk SuN3BpSvRBuem1xNZR89jpibQ= Received: from neo-TianYi510Pro-15ICK.. (unknown []) by gzga-smtp-mtada-g1-1 (Coremail) with SMTP id _____wDX75EqOQVql_fuBA--.3458S2; Thu, 14 May 2026 10:53:32 +0800 (CST) From: liuqiangneo@163.com To: jgg@ziepe.ca, leon@kernel.org Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Qiang Liu Subject: [PATCH] lib/test_hmm: fix error path in dmirror_devmem_fault() Date: Thu, 14 May 2026 10:53:27 +0800 Message-ID: <20260514025328.21175-1-liuqiangneo@163.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: _____wDX75EqOQVql_fuBA--.3458S2 X-Coremail-Antispam: 1Uf129KBjvdXoWrKw4xAr18Ww4rKFWktryfXrb_yoW3XFX_uF 4Utan3uay5JFZ09r4xAws0yrZYyasFya1xurn2yrW7W34UXryYq34kWrZFyas09F48KFWa kr1Dtr13Ar1SkjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IU8Qtx3UUUUU== X-CM-SenderInfo: 5olx1xxdqj0vrr6rljoofrz/xtbC+ww1lmoFOSw5YwAA30 Content-Type: text/plain; charset="utf-8" From: Qiang Liu Handle migrate_vma_setup() failure via goto err for unified cleanup. Signed-off-by: Qiang Liu Reviewed-by: Alistair Popple --- lib/test_hmm.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/test_hmm.c b/lib/test_hmm.c index 213504915737..5430ef97bbe0 100644 --- a/lib/test_hmm.c +++ b/lib/test_hmm.c @@ -1679,8 +1679,10 @@ static vm_fault_t dmirror_devmem_fault(struct vm_fau= lt *vmf) if (order) args.flags |=3D MIGRATE_VMA_SELECT_COMPOUND; =20 - if (migrate_vma_setup(&args)) - return VM_FAULT_SIGBUS; + if (migrate_vma_setup(&args)) { + ret =3D VM_FAULT_SIGBUS; + goto err; + } =20 ret =3D dmirror_devmem_fault_alloc_and_copy(&args, dmirror); if (ret) --=20 2.43.0