From nobody Fri Jun 12 15:48:57 2026 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 979D02D3EF2 for ; Thu, 14 May 2026 01:01:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778720491; cv=none; b=g7tsW9LW+bfVxCGy11nhqmY6jSp73bzyrA2BU2zgagqHscrPNDad1fepIdm7Pzo0LnxofL/d8pZM++wGiLYZnyGPuLAtrJa88w0+n7Xw5EqAEEVPla7+EsXr91oZjkL3Y7KjrULpgDqn+rB3yzR3xJPXlFGimgr7UUm3nJDT37U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778720491; c=relaxed/simple; bh=DpZqDpgWFdqDiUupU3hy+hp66wdYNBtQrPd1t+nKiRM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Rz3yGY7yqPI99kdbQgpyVE3rQz2YbQulD+JoAPkJlJObFtBabG8y+Ql4KGrhWtG8QA5BBlfE3vszIL19bFVd/GQesXwvIaStgDGvw9WGceIJKJyXBTLrU7zJn0CQhuOJoJaLTVl1WzvOykVJPEyNh9ub67ykp5srXOTgRaXyGoE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nE8kAGLE; arc=none smtp.client-ip=209.85.216.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nE8kAGLE" Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-365e20fe3b8so4381828a91.3 for ; Wed, 13 May 2026 18:01:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778720490; x=1779325290; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=P/TJCCyg3GNNF+cgc4ppW8pNVQF/2kpZ5OGVnmEUE2Y=; b=nE8kAGLEOnpAiwsOx7rhu/Ae7K6KKRSzvz0GHMEVYNMyFMjOFhy6pyJckphG4RAK6z WIqDffZ6sUAS/UAcvoo58JZ5qWT6gsFuQ8JxBzfUqt4oWtmWSheOkZPU+tZne3CQOuBt eb5bCZA8VCywwpV3VfuHmdnCZ7LCgrAn6HanNt80uFLRAPVVhMud6uCKiH4ddQOuBeb4 1uwLq3M5Y3HjJuG1jv85f5AtvyN/lbhcHuiTjgrCK8Nvp1Mzs5680Ds4Lm40TDQ4zWRo 3NCpDzn5FCSBWKx2vsJdUiVYi3knc0HJEB9Wm+j3OOxvA7Bno3R8NGiCrEihniwUfVTr 7sZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778720490; x=1779325290; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=P/TJCCyg3GNNF+cgc4ppW8pNVQF/2kpZ5OGVnmEUE2Y=; b=U69A57yfOqOqc8StClP0rR4f9MFUqjB89BoD8xldyVH7kPwJy3hOr4aYdnfj2gqAv7 oJ6QbyDydI/bbMa1hlQoDKuoF9gf3FRf71p46TFfysONxt/fUfkDreU5V1E//DX1KdGj xuAyGyu90ID+15/A4t48F7X+jYt6m5w4qHrc29ier0DCNhIPZvdvqRUJ9m1ZlsdGnXdA v2TmLdYOtOmvnypRoMCJFzMFOt99fMAZK1ckUyzi25JxinwjY9n8P6kry9c2VynYh5Iq C1QHr2y48j8q15Gh5KyZHucaU6cUEIW3ptFe2zT65nKXvIXjoP7p4rKjm5NpubmtKu7Y N2Ig== X-Forwarded-Encrypted: i=1; AFNElJ8o5nOZtMAa1bF7ZPSwTEanJf2etiJwAtbdkWSSeV1cS6gW2yZpdI+qVcJ/rQo8asaR0cE9d8bzRZ+/CmE=@vger.kernel.org X-Gm-Message-State: AOJu0YyH+e/BHH9ga3A2hLllyv/qmAcDrUF7sEdbUvdThDwFY2ACBc7p luIA0lR9X3SAdJ+HV/q1wGKZ19CNM/qdyIaKPwfLfhHiaB+lvRV6TA3X X-Gm-Gg: Acq92OFlKmgp5s/xVwRng6EFzzsZsopu6dSErbILvXnadCudPWbpS7tbr81aJ5FEEYp h6HD1dGpFIoxk0ctHUgsVhrgzNzpRler0u0OdM9/knn/teW7Et85W3PSHiKi6p2piVvI3sGYyOx MBBFG2Sf/yNbnQXaDSkXZASgV+KXeOdMu89GSG+VGrhh5HnB5I2JaGVDwYyg8dWdq/4d+gzeav1 2Ht3nIb0BOZIJaOEIa1vW7n4gW6rrylx7SsVYcpHpG6Iq9WOZoQwQc9d/uBAHiCszszO6l5g4/d nrvD+G17bZivUgkitT5huVvoEQxR2PlBd/10nZXLklnkmicJdA/bErQ7dp/PxrwmsuijKVGMV6e c8TT2qFP0hDtYKWiaikseiOb4szS/g9aRJqYx9gzQjiLhRPODJSOuXr/fnyuUm/ITFw2WTiRuaP DpR7Rk/YgdE9FlMjwG5DYRPE9j+8FFUxBzLv56 X-Received: by 2002:a17:903:bc2:b0:2b0:c45a:bc2 with SMTP id d9443c01a7336-2bd27139901mr47310305ad.16.1778720489578; Wed, 13 May 2026 18:01:29 -0700 (PDT) Received: from [127.0.1.1] ([203.99.159.231]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2bd5d0fbc05sm4645895ad.57.2026.05.13.18.01.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 May 2026 18:01:29 -0700 (PDT) From: Javier Carrasco Date: Thu, 14 May 2026 14:01:11 +1300 Subject: [PATCH v2 1/2] iio: light: veml6030: fix channel type when pushing events Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260514-veml6030-fixes-v2-1-abdd5837be50@gmail.com> References: <20260514-veml6030-fixes-v2-0-abdd5837be50@gmail.com> In-Reply-To: <20260514-veml6030-fixes-v2-0-abdd5837be50@gmail.com> To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko , Rishi Gupta Cc: Javier Carrasco , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Jonathan Cameron , stable@vger.kernel.org X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1778720474; l=1127; i=javier.carrasco.cruz@gmail.com; s=20260111; h=from:subject:message-id; bh=DpZqDpgWFdqDiUupU3hy+hp66wdYNBtQrPd1t+nKiRM=; b=OrFqgirHI7m+cM4ZxxgUcUAQM1us2yF8oTs0fAFVY6/ocWNtSozbqMaHSve1Ak/YMHkAT7vNQ zldFm4QZ10pC8uirk0rCYe9S9qWdG1/XtG2wmY8jMPFlLrvsbw27Pxb X-Developer-Key: i=javier.carrasco.cruz@gmail.com; a=ed25519; pk=Lge8w8xidNSf/INy7JAIbAW+Hezkp3nsBh2OjKL7lLU= The events are registered for IIO_LIGHT and not for IIO_INTENSITY. Use the correct channel type. When at it, fix minor checkpatch code style warning (alignment). Cc: stable@vger.kernel.org Fixes: 7b779f573c48 ("iio: light: add driver for veml6030 ambient light sen= sor") Signed-off-by: Javier Carrasco --- drivers/iio/light/veml6030.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/iio/light/veml6030.c b/drivers/iio/light/veml6030.c index 6bcacae3863c..da8c32cabfd6 100644 --- a/drivers/iio/light/veml6030.c +++ b/drivers/iio/light/veml6030.c @@ -875,9 +875,11 @@ static irqreturn_t veml6030_event_handler(int irq, voi= d *private) else evtdir =3D IIO_EV_DIR_FALLING; =20 - iio_push_event(indio_dev, IIO_UNMOD_EVENT_CODE(IIO_INTENSITY, - 0, IIO_EV_TYPE_THRESH, evtdir), - iio_get_time_ns(indio_dev)); + iio_push_event(indio_dev, IIO_UNMOD_EVENT_CODE(IIO_LIGHT, + 0, + IIO_EV_TYPE_THRESH, + evtdir), + iio_get_time_ns(indio_dev)); =20 return IRQ_HANDLED; } --=20 2.43.0 From nobody Fri Jun 12 15:48:57 2026 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D8A9F2D23A6 for ; Thu, 14 May 2026 01:01:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778720497; cv=none; b=KNZ/NfKYWexgblCanyJyQWxuSWHGDuMLRdn5h60Epz0Nt3X+FxCPacatF3Fh0g/MjwrZ4mH+5riLwM1clIkQdgzgJqKrSKMCvqNwQL94cKFipogGqGFt/9KtqfJvCRClm6f2+8B/rNDi7P6o+5Qy+8923qMsodiKlJzqn/5UOhY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778720497; c=relaxed/simple; bh=MTc1QEwh/xTD1zWNj97mO+9s/9gbkXSTbhQYw4RZcus=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=oGzk1aMg6tF1dF5i5grTlR0oQANyUvjvJahrddtN9gL6D2MXsFHoXN5B4CxytsKXdFcTnjSlXzZ43+MnknhYliK+TqtKqtkNvzpbsB2o4W2gILRJzr3TFAB3O5yQ7zoR3MgNDE0OsoTgqNpF/aSCREDGmkQs5I1uYOD5ZqMGaGk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cD5bacM5; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cD5bacM5" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-2aaed195901so36970075ad.0 for ; Wed, 13 May 2026 18:01:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778720495; x=1779325295; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=NlC9GlamOv3YoRng/MxFIGV+3xi+5mYX5rfTEUzWfFo=; b=cD5bacM5tW7T7FKCFBkauPAdwAObB4nIXPXbaXnEnzP2WnBjdj+WYjl3BTrK7rGNRq nUbemdyT/Aprn+gnV+UfPZESRDOe2zs309N5uzmIMYWk4SvrKQAdIn7egEM+cYiF4E6E xs52CWdtrmGdzULDvcYtDZIR4qAysOQqJBgkpWTLhZ7QsrIu3HxmaJgno8UUeoWQuTvy yxdPPpy/SrV2MTmoeAeD29iH4zymwtw005drdjYnU8uWKzkKvLIn/QV3c6pd9zmaqG6M +Uol4w/yc9IPLRAMfH/iHurhFBDR4pqIGicti64D3I6hFeLS2rezmH0NRVFo+WqL/onA wjAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778720495; x=1779325295; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=NlC9GlamOv3YoRng/MxFIGV+3xi+5mYX5rfTEUzWfFo=; b=j0oBiop3NApAONJZmaCYlmDhMUkmD/Kwe2BgAISYgJ5+aTB7k0/7268Ur7GYSNJaK/ nVeF6lZjBTpVkwTe1twFiCsEjwE/86uVTYs8BNzq0p9k2nGuyIKBz5mR9gS+Ag3EbOpg 0RI/4PM5BJGiBjp8jaPsCtV38UpMpI1WEvndE/LMuKdgc19vDe53W0asBftrEizPx/lb xSNd37EuDPgCvTZiiRosq70BRHBMbOtCQJNLWdvvev8QAwYK0JM4D3sdmeCgElbkSVjG XQ3UdkifEDrrG5UUmG9+wCjdimynkLRiTxF6WHEOto8Enr3GQzRQ6QnAZWLm3dnbswtO ws7w== X-Forwarded-Encrypted: i=1; AFNElJ+WUJ9K8wfuT0WX+AhZiJSV85eeOXx1V24UE+kG9PMMNB2N+P5DQYZaCMUobWJP3LByALlAdyBtSM1AM1o=@vger.kernel.org X-Gm-Message-State: AOJu0YxaahXZOWo8p82Y2kHRsPjJcbweYyLHzS635CNcYWaJYblEERDt DQzZkatAtz+/ahYwLOMuWLpmiKmF1JgfpTf7D2/7j2Xum18EAmR20/3e X-Gm-Gg: Acq92OGvn2QfThVOaWi8dt5D9W9cqFuuTtw2Ngd09eEnGoR/4t6HxM/qDZjAQlFqfbD mQr7BgJ+niIY38xnRpt+Fy0W8I2CQBNdXLTT7SWfuumynGQ0ioYBcxcx0CA481pj/q684d4ZYkF HHgJDQoC+cr/i4RjxQzy3uPBbfp+GJcqgn0Ute//dXzke3O+YcFAkJTRdZG27d6WvFXJOdKBnan xr+dNR/iFavgQB/wSs6adqdP4cMWyPmQyAHMSuNb2Hh6x0lGGXID8szOI07Wf0fqvoVZnBnrQfQ 4g+uFl8CtAYIcLGivjAu84H26J8satSBKl8WcL5BpnlwIbuP/SWUFB0g6xb1GwuBZ1OKkyfFO/m G8DEmrdFZQgB5GIPtO8rbxLykMxuEhS+3MAY85chNmRlcgG3Xycl/54IT2kiusMWvYM8zPVbz8J aFWL8I1jjE5xPyl4qdsOutM52udBaWw7kVd4z5 X-Received: by 2002:a17:903:1aa6:b0:2bd:5ddd:17ab with SMTP id d9443c01a7336-2bd5ddd1884mr9244315ad.32.1778720494999; Wed, 13 May 2026 18:01:34 -0700 (PDT) Received: from [127.0.1.1] ([203.99.159.231]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2bd5d0fbc05sm4645895ad.57.2026.05.13.18.01.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 May 2026 18:01:34 -0700 (PDT) From: Javier Carrasco Date: Thu, 14 May 2026 14:01:12 +1300 Subject: [PATCH v2 2/2] iio: light: veml6030: remove unnecessary read of IT index Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260514-veml6030-fixes-v2-2-abdd5837be50@gmail.com> References: <20260514-veml6030-fixes-v2-0-abdd5837be50@gmail.com> In-Reply-To: <20260514-veml6030-fixes-v2-0-abdd5837be50@gmail.com> To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko , Rishi Gupta Cc: Javier Carrasco , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Jonathan Cameron X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1778720474; l=1020; i=javier.carrasco.cruz@gmail.com; s=20260111; h=from:subject:message-id; bh=MTc1QEwh/xTD1zWNj97mO+9s/9gbkXSTbhQYw4RZcus=; b=cIgSR38tOtTcNIE+Jq3s0rdZDzNSnVzCuek0LDdqvAs5JWE4OQpf+OajBwHN5S5dWMyQcpbfP TWJYH8Up7+AD/FSsvig96KJy8ZH36K8vASsbrR5F3Myv4wzYEHmbUqX X-Developer-Key: i=javier.carrasco.cruz@gmail.com; a=ed25519; pk=Lge8w8xidNSf/INy7JAIbAW+Hezkp3nsBh2OjKL7lLU= This is dead code as the IT index is not used by gts to set the new scale. In its current form, the value is read but not used afterward. Remove the dead code. Signed-off-by: Javier Carrasco --- drivers/iio/light/veml6030.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/iio/light/veml6030.c b/drivers/iio/light/veml6030.c index da8c32cabfd6..2f9a25d59b71 100644 --- a/drivers/iio/light/veml6030.c +++ b/drivers/iio/light/veml6030.c @@ -521,13 +521,9 @@ static int veml6030_write_persistence(struct iio_dev *= indio_dev, =20 static int veml6030_set_scale(struct iio_dev *indio_dev, int val, int val2) { - int ret, gain_sel, it_idx, it_sel; + int ret, gain_sel, it_sel; struct veml6030_data *data =3D iio_priv(indio_dev); =20 - ret =3D regmap_field_read(data->rf.it, &it_idx); - if (ret) - return ret; - ret =3D iio_gts_find_gain_time_sel_for_scale(&data->gts, val, val2, &gain_sel, &it_sel); if (ret) --=20 2.43.0