From nobody Fri Jun 12 13:56:41 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E4F6E24DCF6 for ; Thu, 14 May 2026 16:39:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778776800; cv=none; b=gQNxBsC4FZWnqKfEwdU7NjlSnvywz8OA35b66ehTke5f0eRUPPzmpiajmSciFNPNn04EtrW+lyDDfFHLEJWxQfX/X9VaxsZgAdrONPR3my0eFFMqrVxPyzYeV2iATTmCUKzr25XrB6HcVwi6MGmSCqGkw5mmGFkv4cs83GgklGU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778776800; c=relaxed/simple; bh=Uu8LgHeTvuBSkg46HGL1uzGanUNqMH+ybOhQ0yJ7ZcM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Ffny2J9S68z99XUgB8YdBr3qVivI7KT6b+OIcA/DMpOsTYinM4b8hE2hEwZb0bY2zRzXisxNC90Nz8rsFQrBc6YcvjCDOLDgMgL8B7DqyZKLEL99lobabLVD4b64n/e/VgJ0nEGIySVApHCB/bUHfi3s+BtaHjbOvpaGmipltFQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=u7r0o5hm; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="u7r0o5hm" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DE565C2BCB3; Thu, 14 May 2026 16:39:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778776799; bh=Uu8LgHeTvuBSkg46HGL1uzGanUNqMH+ybOhQ0yJ7ZcM=; h=From:To:Cc:Subject:Date:From; b=u7r0o5hm/RgDFmoq9cOUpZyvqIBPO1SefinkqwdT/Ih1IF5rfKCSyV74u/wc6eANU jawb81Xs1etleaKDIljvFZWkGyZkQsufDFQSbeEVi45MqjFc9qFRwTJvIyb7tEuIz5 gd1ee+4mhJ2jjQLZ1sO2GB1PeFu8k5xav/trts/t0mvNpZWCiSDl/0+V3GQpE9ovmp RaSRud4/P0LzSKpVtlimH1rfdRuzi1D4CMt9eaamEtxk9cMG4bMFlgRZg+cOpbt0fL ic9NOurZqqLudKDhx9c/fgJF7jO/qtssqX8NtrXXYTwnnkXzbat238Cfk4+DEUOtiF d0HSHXUmhD//g== From: Conor Dooley To: jassisinghbrar@gmail.com Cc: conor@kernel.org, Conor Dooley , Daire McNamara , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Valentina.FernandezAlanis@microchip.com Subject: [PATCH v1] mailbox: mpfs: fix check for syscon presence in mpfs_mbox_inbox_isr() Date: Thu, 14 May 2026 17:39:51 +0100 Message-ID: <20260514-reopen-purity-0e8914bf3c51@spud> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1275; i=conor.dooley@microchip.com; h=from:subject:message-id; bh=nZN8rv3keeoKA6RSwvYbwGD0yvX+d5JBkA0LYCAO2eM=; b=owGbwMvMwCVWscWwfUFT0iXG02pJDFmsv24k9nlEBL2e8frGnUgPfjlr9dMpRVPvJy+WimguW ffSw3lqRykLgxgXg6yYIkvi7b4WqfV/XHY497yFmcPKBDKEgYtTACbC5MjI8H7D7qnHt//P7Hsj +yPHecOZEx4yL+6tMJqu+aTxq/8tcxdGhqXctd+jE1ac2tXpUz3XJXnn5F3OswxmaLFas5f8CHi +hAkA X-Developer-Key: i=conor.dooley@microchip.com; a=openpgp; fpr=F9ECA03CF54F12CD01F1655722E2C55B37CF380C Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Conor Dooley mpfs_mbox_inbox_isr() writes to the sysreg scb syscon, not the control scb syscon, but checks for the presence of the latter. Ultimately this makes little difference because if one syscon is present, both will be. Fixes: a4123ffab9ece ("mailbox: mpfs: support new, syscon based, devicetree= configuration") Signed-off-by: Conor Dooley --- CC: Conor Dooley CC: Daire McNamara CC: Jassi Brar CC: linux-riscv@lists.infradead.org CC: linux-kernel@vger.kernel.org CC: Valentina.FernandezAlanis@microchip.com --- drivers/mailbox/mailbox-mpfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mailbox/mailbox-mpfs.c b/drivers/mailbox/mailbox-mpfs.c index d5d9effece979..ef40fe2be30d6 100644 --- a/drivers/mailbox/mailbox-mpfs.c +++ b/drivers/mailbox/mailbox-mpfs.c @@ -201,7 +201,7 @@ static irqreturn_t mpfs_mbox_inbox_isr(int irq, void *d= ata) struct mbox_chan *chan =3D data; struct mpfs_mbox *mbox =3D (struct mpfs_mbox *)chan->con_priv; =20 - if (mbox->control_scb) + if (mbox->sysreg_scb) regmap_write(mbox->sysreg_scb, MESSAGE_INT_OFFSET, 0); else writel_relaxed(0, mbox->int_reg); --=20 2.53.0